hermes-agent/tui_gateway/mcp_rpc_helpers.py
Teknium a5bd246865
Old pre-decomposition import paths are gone: plugin compat layer removed on schedule (#126164)
* refactor(plugins): remove the Sep 2026 decomposition compat layer on schedule

The PLUGIN-COMPAT layer (2776813df3 + d63e380324 + 0a5164cebe) kept pre-#102117 import paths
alive for external plugins until 2026-09-14. That window closed two weeks ago; since then the loader
has already been skipping plugins that use the old paths. This removes the layer itself:

- 328 appended `PLUGIN-COMPAT` blocks (lazy `__getattr__` pointer tables, re-exported third-party
  names, restored dead definitions) and the three re-export stub modules
  (gateway/startup_watchdog, hermes_cli/observability/relay_runtime, tools/environments/modal_utils)
- COMPAT_MANIFEST.md, compat_manifest.json, scripts/check_compat_pointers.py and its lint step
- the reporting surfaces: CLI banner notice, `hermes plugins compat`, the `hermes doctor` section,
  the post-update notice, the Desktop one-time dialog, the loader's pre-import skip and the
  `plugins.allow_deprecated_imports` escape hatch

An external plugin that still imports an old path now fails to load with its ImportError as the
reason in `hermes plugins list`, the same path as any broken plugin.

hermes_cli/plugin_compat.py stays as three inert stubs (compat_report, removal_in_effect,
summary_lines): an already-running pre-removal `hermes update` lazy-imports them after the checkout
swap (tests/compat/old_updater_surface.json).

In-tree fallout, both already dead: hermes_cli/setup.py::_check_espeak_ng (no callers; its
`shutil` came from a compat block) and gateway/config.py::SessionResetPolicy ("retained solely for
the scheduled plugin-compat window"). Two test_run_agent patches targeted the removed
`run_agent.handle_function_call` pointer; they now patch `model_tools.handle_function_call`, the
seam production reads, like every sibling test in that file.

* chore: retrigger CI (zero-job startup_failure phantom)

* test: drop resolution allowlist rows for the two deleted which() sites

hermes_cli/setup.py::_check_espeak_ng (dead) and tools/skillevaluator_scan.py::scanner_available
(a restored definition inside a PLUGIN-COMPAT block) no longer exist; the stale-row gate requires
their allowlist entries go with them.
2026-09-28 10:21:41 -07:00

54 lines
2.2 KiB
Python

"""Shared helpers for the per-profile MCP lifecycle RPCs (mcp.servers.*).
Published onto ``tui_gateway.server`` as ``_mcp_summarize_server`` so the rebound handler
bodies in methods_tools resolve it.
"""
from __future__ import annotations
from typing import Any, Dict, Mapping
def server_configs_with_sources(config_servers: Mapping[str, dict]) -> tuple[Dict[str, dict], Dict[str, str | None]]:
servers = {name: dict(cfg) for name, cfg in config_servers.items() if isinstance(cfg, dict)}
plugins: Dict[str, str | None] = {name: None for name in servers}
try:
from hermes_cli.plugins import discover_plugins, get_plugin_manager
from tools.mcp_tool_config import _filter_suspicious_mcp_servers
discover_plugins()
manager = get_plugin_manager()
portable = _filter_suspicious_mcp_servers(manager.get_portable_mcp_servers())
owners = manager.get_portable_mcp_server_plugins()
for name, cfg in portable.items():
if name not in servers:
servers[name] = dict(cfg)
plugins[name] = owners.get(name)
except Exception:
pass
return servers, plugins
def summarize_server(name: str, cfg: dict, plugin: str | None = None) -> Dict[str, Any]:
from hermes_cli.mcp_config import _oauth_tokens_present
from tools.mcp_tool_common import mcp_server_enabled
cfg = cfg if isinstance(cfg, dict) else {}
transport = "http" if cfg.get("url") else ("stdio" if cfg.get("command") else "unknown")
auth = cfg.get("auth")
headers = cfg.get("headers") or {}
if not auth and isinstance(headers, dict) and any(str(key).lower() == "authorization" for key in headers):
auth = "header"
return {
"name": name,
"transport": transport,
"url": cfg.get("url"),
"command": cfg.get("command"),
"args": list(cfg.get("args") or []),
"env": sorted(str(k) for k in (cfg.get("env") or {})),
"auth": auth,
"oauth_tokens_present": _oauth_tokens_present(name) if auth == "oauth" else None,
"enabled": mcp_server_enabled(cfg),
"tools": cfg.get("tools"),
"source": "plugin" if plugin is not None else "config",
"plugin": plugin}