Brooklyn Nicholson
591e3a7ce1
fix(tui_gateway): broadcast approval.cancelled when reap/teardown drop pending prompts
...
The WS-orphan reap interrupts the turn (deny-resolving the pending approval
queue) and teardown pops it via unregister_gateway_notify — both silently.
A reconnecting client's parked prompt card then answers resolved: 0 (or a
bare 4001 on approval.pending), so the prompt looked lost rather than
cancelled and the user had no signal the command would never run (#106678 ).
- session_lifecycle: _announce_cancelled_gateway_approvals broadcasts the
dropped entries (session ids, reason, request ids/count) before the
deny-resolve drains the queue, from both _interrupt_session_turn and
_teardown_session. Fail-open: a missing key, empty queue, or broadcast
failure never blocks the deny-resolve or teardown.
- _interrupt_session_turn gains orphan= so the reaper labels its cancels
ws_orphan_reap explicitly (never request_id prefix sniffing).
- contracts: ApprovalCancelledPayload event model + regenerated TS/OpenRPC.
- desktop: gateway-event lifecycle consumes approval.cancelled and clears
the parked prompt cards by request id (mismatch is a no-op, so a newer
prompt survives); the turn's BLOCKED tool result is the in-transcript
signal, same as the timeout path.
Supersedes #106693 (KoNit-K) and #126455 (Finn763); design credit to both.
Co-authored-by: KoNit-K <[email protected] >
Fixes #106678
2026-09-29 21:42:20 -05:00
..
contracts
fix(tui_gateway): broadcast approval.cancelled when reap/teardown drop pending prompts
2026-09-29 21:42:20 -05:00
__init__.py
feat: new tui based on ink
2026-04-02 19:07:53 -05:00
_env.py
refactor(tui_gateway): split _apply_model_switch into phase helpers, compact controller/browser/relay/watcher/billing helpers
2026-09-02 22:47:13 -07:00
_stdin_recovery.py
refactor(tui_gateway): AST-neutral layout compaction of group H modules
2026-09-02 23:04:39 -07:00
agent_callbacks.py
fix(tui-gateway): probe the preview.act bridge so an absent renderer fails fast
2026-09-29 12:25:29 -05:00
AGENTS.md
Old pre-decomposition import paths are gone: plugin compat layer removed on schedule ( #126164 )
2026-09-28 10:21:41 -07:00
billing_view.py
Free tier: separate 'account exists' from 'runs this chat', and stop the mint from writing active_provider ( #127486 )
2026-09-29 07:44:13 +00:00
change_watcher.py
fix(tui-gateway): keep activity heartbeats out of the sessions digest
2026-09-28 15:43:06 -05:00
compute_host.py
fix(tui_gateway): a queued model switch crosses the compute-host boundary
2026-09-28 21:12:23 -05:00
compute_host_bridge.py
Clarify: one question shape and one result shape on every surface (skip, cancel, timeout and undelivered are told apart) ( #127760 )
2026-09-29 18:33:44 +05:30
connector_payload.py
feat(connectors): the backend API for the desktop Connectors page; connect an app without a chat session ( #115191 )
2026-09-22 13:57:51 +05:30
entry.py
feat(telemetry): v5 signals — tool_unavailable, provider_setup, feature_adoption, feature_disabled
2026-09-28 12:43:03 -07:00
event_publisher.py
refactor(tui_gateway): collapse billing/publisher/method_ctx defensive layers in group H
2026-09-02 23:41:16 -07:00
event_replay.py
fix(tui-gateway): keep replay seq monotonic across ring eviction
2026-09-29 15:22:03 -05:00
git_probe.py
review-fix(comments): restore lost #NNNN rationale comments across non-test source (mechanical sweep, condensed, code unchanged)
2026-09-03 09:44:26 -07:00
host_supervisor.py
fix(tui): the compute host keeps Hermes' full environment again
2026-09-29 02:06:58 +05:30
hosted_room_driver.py
Old pre-decomposition import paths are gone: plugin compat layer removed on schedule ( #126164 )
2026-09-28 10:21:41 -07:00
hosted_room_member_activity.py
feat(tui_gateway): real JSON-RPC server→client requests replace the *.request / *.respond notification pair
2026-09-14 06:02:05 -07:00
hosted_room_peer_http.py
refactor(tui_gateway): hosted-room X1 — inline one-site wrappers, drop dead PeerRunsHTTPError attrs, compact lease/cancel plumbing
2026-09-03 03:59:09 -07:00
hosted_room_peer_transport.py
feat(plugins): on_room_member_activity hook projects Group Chat member runtime events to plugins
2026-09-11 19:04:58 -07:00
hosted_room_server_rpc.py
feat(plugins): on_room_member_activity hook projects Group Chat member runtime events to plugins
2026-09-11 19:04:58 -07:00
hosted_room_service.py
Old pre-decomposition import paths are gone: plugin compat layer removed on schedule ( #126164 )
2026-09-28 10:21:41 -07:00
launch_profile_policy.py
feat(gateway): stop, start and restart one profile under the host multiplexer
2026-09-23 08:25:28 -07:00
loop_noise.py
refactor(tui_gateway): table-drive billing error kinds, share pet selection, compact group H docstrings
2026-09-02 23:25:59 -07:00
mcp_oauth_sessions.py
feat(connectors): one backend-owned connection operation, with a setup card on Desktop, TUI and CLI ( #111008 )
2026-09-21 10:04:32 +05:30
mcp_rpc_helpers.py
Old pre-decomposition import paths are gone: plugin compat layer removed on schedule ( #126164 )
2026-09-28 10:21:41 -07:00
method_ctx.py
feat(connectors): the backend API for the desktop Connectors page; connect an app without a chat session ( #115191 )
2026-09-22 13:57:51 +05:30
methods_bot_relay.py
fix(bot-mode): every transport into a live Bot Chat waits on the owner's receipt through one primitive
2026-09-20 13:54:22 -07:00
methods_browser.py
simplify(compat): tools/browser_tool + browser_supervisor — drop 114 re-exports + 6 legacy aliases + PEP 562 requests/call_llm hook, repoint 21 non-test callers; siblings read sibling names directly
2026-09-03 14:16:54 -07:00
methods_browser_control.py
Old pre-decomposition import paths are gone: plugin compat layer removed on schedule ( #126164 )
2026-09-28 10:21:41 -07:00
methods_complete.py
serve: retire desktop-owned local backends on code skew; guard every model-mutating path ( #99859 )
2026-09-29 20:57:23 -05:00
methods_complete_helpers.py
fix: bound the LSP document cache, delta baselines, TUI fuzzy cache and the tool-call logger ( #62950 )
2026-09-19 01:55:38 -07:00
methods_config.py
fix(tui-gateway): blame the pinned provider when runtime_check fails
2026-09-29 19:30:28 -05:00
methods_config_set.py
feat(fast): /fast ultrafast for GPT-6 Astra, priced at the served tier
2026-09-29 23:54:34 +05:30
methods_connectors.py
feat: setup agent can search the catalog and install plugins and skills through the approval card
2026-09-23 08:04:33 +05:30
methods_connectors_account.py
feat(connectors): the backend API for the desktop Connectors page; connect an app without a chat session ( #115191 )
2026-09-22 13:57:51 +05:30
methods_display.py
feat(bot_desktop): Bot Screen, computer_use and the browser run inside the terminal backend ( #121169 )
2026-09-28 03:34:07 -07:00
methods_display_watch.py
fix(agent): name the running Bot Screen in the model context
2026-09-29 18:49:11 -05:00
methods_free_tier.py
fix(free-tier): review round 2 — route-gate the allowance verdict, keep policy/billing 403s, pool the provision RPC, guard the retry race
2026-09-15 20:44:42 +05:30
methods_groups.py
fix(tui_gateway): serve fails closed when hosting a second profile home; profile RPCs bind the full runtime scope
2026-09-15 03:46:29 -07:00
methods_i18n.py
feat(i18n): pluggable, layered language packs across core, Desktop and TUI ( #126296 )
2026-09-28 14:16:18 -07:00
methods_images.py
fix(security): route remote-party-supplied URL fetches through the SSRF guard
2026-09-18 10:22:14 -07:00
methods_onboarding.py
refactor(onboarding): remove the intro cinematic, the guided-onboarding tests, and their comments ( #126139 )
2026-09-28 08:33:43 +00:00
methods_profiles.py
fix(profiles): copy launch ${VAR} refs into new profiles, not their values
2026-09-29 18:50:36 -05:00
methods_projects.py
feat(telemetry): v5 signals — tool_unavailable, provider_setup, feature_adoption, feature_disabled
2026-09-28 12:43:03 -07:00
methods_prompt.py
fix(tui_gateway): address the rotated tip when reading the transcript ( #123545 )
2026-09-29 19:42:46 -05:00
methods_session.py
fix(gateway): materialize session row on resume for minted-but-never-persisted keys
2026-09-29 21:33:22 -05:00
methods_session_control.py
refactor: share CLI goal commands across interactive surfaces
2026-09-07 00:51:41 -07:00
methods_session_foreign.py
fix(tui_gateway): foreign-profile RPCs open state.db read-only
2026-09-14 05:28:46 -07:00
methods_session_model_guard.py
fix: session.create refuses a model its provider cannot serve
2026-09-19 12:12:05 -07:00
methods_shared_metrics.py
fix(telemetry): switching Desktop collection off drops the backend onboarding latches
2026-09-28 12:43:03 -07:00
methods_slash.py
feat(fast): /fast ultrafast for GPT-6 Astra, priced at the served tier
2026-09-29 23:54:34 +05:30
methods_subagents.py
fix(tui-gateway): report recently failed async delegations in subagent.list
2026-09-26 20:40:40 -05:00
methods_tools.py
fix(skills-guard): detect bare-~ destructive rm and inline-shell auto-exec DSL
2026-09-29 20:57:45 -05:00
methods_vault.py
refactor(vault): trim the malformed-state coverage and drop the load_config shape guard
2026-09-20 10:21:52 -07:00
methods_voice.py
fix(desktop): refuse window-owned pane requests at once when no window shows the session
2026-09-28 21:04:47 -04:00
model_switch.py
feat(telemetry): v5 engagement rollup, turns-before-switch, per-conversation sessions, relay source platform
2026-09-28 12:43:03 -07:00
onboarding_personalization.py
refactor(onboarding): remove the intro cinematic, the guided-onboarding tests, and their comments ( #126139 )
2026-09-28 08:33:43 +00:00
plugin_inject.py
fix(plugins): route inject_message to the TUI session_key queue
2026-09-24 10:56:54 -05:00
profile_roster_cache.py
fix(tui-gateway): an empty -wal sidecar created by our own read-only open does not count as a store change
2026-09-20 18:45:07 -07:00
project_tree.py
fix(projects): gate branch switching on non-git folder lanes ( #61362 )
2026-09-25 17:19:54 -05:00
prompt_attachments.py
feat(tui): add attachments.storage config for workspace attachment staging
2026-09-27 19:07:07 -05:00
prompt_turn.py
fix(tui_gateway): address the rotated tip when reading the transcript ( #123545 )
2026-09-29 19:42:46 -05:00
render.py
refactor(tui): render/slash_fuzzy/turn_marker/synthetic_turn/slash_worker — shared import bridge, tier table, marker update helper
2026-09-02 22:39:38 -07:00
rpc_dispatch.py
fix(desktop): refuse window-owned pane requests at once when no window shows the session
2026-09-28 21:04:47 -04:00
server.py
fix(gateway): materialize session row on resume for minted-but-never-persisted keys
2026-09-29 21:33:22 -05:00
server_requests.py
Clarify: one question shape and one result shape on every surface (skip, cancel, timeout and undelivered are told apart) ( #127760 )
2026-09-29 18:33:44 +05:30
session_auto_continue.py
fix(tui_gateway): re-resolve the queued row across an in-place compaction ( #123675 )
2026-09-29 19:42:46 -05:00
session_compression.py
Compaction follows compression.threshold again: no default 256K token cap ( #117915 , #125235 ) ( #126064 )
2026-09-28 07:29:40 +00:00
session_history.py
fix(tui_gateway): project verified native image turns as display refs
2026-09-29 19:14:53 -05:00
session_lifecycle.py
fix(tui_gateway): broadcast approval.cancelled when reap/teardown drop pending prompts
2026-09-29 21:42:20 -05:00
session_notifications.py
fix(desktop): HUD note fires again when tool search defers the desktop tools
2026-09-29 16:40:36 +05:30
session_reaper.py
fix(tui-gateway): reap stale deferred active-session leases ( #62823 zombie slot)
2026-09-25 16:48:03 -04:00
session_transports.py
fix(desktop): refuse window-owned pane requests at once when no window shows the session
2026-09-28 21:04:47 -04:00
session_workdir.py
fix(tui_gateway): harden the off-turn session-key fixes from a parallel review ( #123545 )
2026-09-29 19:42:46 -05:00
slash_fuzzy.py
refactor(tui): compact module/function docstrings and comments (WHY preserved)
2026-09-03 00:03:43 -07:00
slash_worker.py
feat(telemetry): add shared_metrics.slash_command RPC; gateway stops counting slash.exec
2026-09-28 12:43:03 -07:00
synthetic_turn.py
refactor(tui): compact module/function docstrings and comments (WHY preserved)
2026-09-03 00:03:43 -07:00
tool_progress.py
Hiding reasoning no longer hides tool rows, and tool_progress: off no longer hides reasoning (salvage #125948 ) ( #126479 )
2026-09-28 14:18:37 +00:00
transport.py
fix(tui): socket-close only on fanout overflow; plain WSTransport.close() back to main
2026-09-25 16:44:57 +05:30
turn_marker.py
fix(tui_gateway): record a turn marker's writer and defer to it while alive ( #94778 )
2026-09-26 17:01:44 -05:00
user_messages.py
fix(auth): detect the lock holder for real and route permanent lock failures
2026-09-29 18:47:44 -05:00
ws.py
fix(tui-gateway): answer gateway.ping while a WS handler blocks dispatch
2026-09-28 18:58:29 -04:00