searxng-mcp-go/internal/searxng/searcher_internal_test.go
xlion-bot-renovate[bot] 6e4c553a9e
chore(deps): update dependency go to v1.27.1 (#588)
* chore(deps): update dependency go to v1.27.1

* Fixed all lints; just verify passes.

Co-authored-by: xlionjuan <[email protected]>

* Fixed `.golangci.yml` paths→path; `just verify` passes.

Co-authored-by: xlionjuan <[email protected]>

* Parallelized golden & error-path tests; verify passes.

Co-authored-by: xlionjuan <[email protected]>

* Verify passes; HTTPClient/Logger nil set; exhaustruct covers Config.

Co-authored-by: xlionjuan <[email protected]>

---------

Co-authored-by: xlion-bot-renovate[bot] <218815870+xlion-bot-renovate[bot]@users.noreply.github.com>
Co-authored-by: opencode-agent[bot] <opencode-agent[bot]@users.noreply.github.com>
Co-authored-by: xlionjuan <[email protected]>
2026-09-06 23:14:09 +08:00

537 lines
14 KiB
Go

package searxng
import (
"bytes"
"context"
"errors"
"log/slog"
"net/http"
"strings"
"testing"
"time"
"searxng-mcp-go/internal/testhelper"
)
// --- isEmptyResponse tests ---
func TestIsEmptyResponse(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{}
t.Run("all empty", func(t *testing.T) {
t.Parallel()
if !s.isEmptyResponse(&SearchResponse{}) {
t.Fatal("isEmptyResponse() = false, want true for empty response")
}
})
t.Run("with results", func(t *testing.T) {
t.Parallel()
if s.isEmptyResponse(&SearchResponse{
Results: []SearchResult{{Title: "A"}},
}) {
t.Fatal("isEmptyResponse() = true, want false for response with results")
}
})
t.Run("with answers", func(t *testing.T) {
t.Parallel()
if s.isEmptyResponse(&SearchResponse{
Answers: []Answer{{Answer: "test"}},
}) {
t.Fatal("isEmptyResponse() = true, want false for response with answers")
}
})
t.Run("with infoboxes", func(t *testing.T) {
t.Parallel()
if s.isEmptyResponse(&SearchResponse{
Infoboxes: []Infobox{{Infobox: "test"}},
}) {
t.Fatal("isEmptyResponse() = true, want false for response with infoboxes")
}
})
t.Run("with suggestions", func(t *testing.T) {
t.Parallel()
if s.isEmptyResponse(&SearchResponse{
Suggestions: []string{"test"},
}) {
t.Fatal("isEmptyResponse() = true, want false for response with suggestions")
}
})
t.Run("nil slices count as empty", func(t *testing.T) {
t.Parallel()
if !s.isEmptyResponse(&SearchResponse{
Results: nil,
}) {
t.Fatal("isEmptyResponse() = false, want true for nil Results")
}
})
}
// --- Close tests ---
func TestClose_Searcher(t *testing.T) {
t.Parallel()
t.Run("close with transport", func(t *testing.T) {
t.Parallel()
searcher, err := NewSearXNGSearcher(&Config{
SearXNGURL: "https://127.0.0.1:9999",
Timeout: time.Second,
}, false)
if err != nil {
t.Fatalf("NewSearXNGSearcher() error = %v", err)
}
err = searcher.Close()
if err != nil {
t.Fatalf("Close() error = %v", err)
}
})
t.Run("close with custom client", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{
client: &http.Client{},
}
err := s.Close()
if err != nil {
t.Fatalf("Close() error = %v, want nil for custom client without transport", err)
}
})
t.Run("close with nil client", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{client: nil}
err := s.Close()
if err != nil {
t.Fatalf("Close() error = %v, want nil for nil client", err)
}
})
t.Run("repeated close does not panic", func(t *testing.T) {
t.Parallel()
s, err := NewSearXNGSearcher(&Config{
SearXNGURL: "https://127.0.0.1:9999",
Timeout: time.Second,
}, false)
if err != nil {
t.Fatalf("NewSearXNGSearcher() error = %v", err)
}
err = s.Close()
if err != nil {
t.Fatalf("first Close() error = %v, want nil", err)
}
err = s.Close()
if err != nil {
t.Fatalf("second Close() error = %v, want nil", err)
}
})
}
//nolint:gocognit,gocyclo // subtests cover three separate lifecycle scenarios
func TestClose_SearcherLifecycle(t *testing.T) {
t.Parallel()
t.Run("close before search returns context canceled", func(t *testing.T) {
t.Parallel()
s := newTestSearcher(t, testhelper.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
<-req.Context().Done()
return nil, req.Context().Err()
}), 0)
// Close the searcher first — searcherCtx is canceled
err := s.Close()
if err != nil {
t.Fatalf("Close() error = %v, want nil", err)
}
// AfterFunc fires cancel on the search context (searcherCtx is already done)
_, err = s.Search(t.Context(), &SearchArgs{Query: "test"})
if err == nil {
t.Fatal("Search() error = nil after Close, want error")
}
if !errors.Is(err, context.Canceled) {
t.Fatalf("Search() error = %v, want context.Canceled in chain", err)
}
})
t.Run("close during request cancels in-flight search", func(t *testing.T) {
t.Parallel()
enteredTransport := make(chan struct{})
s := newTestSearcher(t, testhelper.RoundTripperFunc(func(req *http.Request) (*http.Response, error) {
close(enteredTransport)
<-req.Context().Done()
return nil, req.Context().Err()
}), 0)
errCh := make(chan error, 1)
go func() {
_, err := s.Search(t.Context(), &SearchArgs{Query: "test"})
errCh <- err
}()
<-enteredTransport
err := s.Close()
if err != nil {
t.Fatalf("Close() error = %v, want nil", err)
}
select {
case err = <-errCh:
if err == nil {
t.Fatal("Search() error = nil after Close during request, want error")
}
if !errors.Is(err, context.Canceled) {
t.Fatalf("Search() error = %v, want context.Canceled in chain", err)
}
case <-time.After(5 * time.Second):
t.Fatal("Search() did not return within timeout")
}
})
t.Run("close during retry backoff cancels waiting search", func(t *testing.T) {
t.Parallel()
retryWaitStarted := make(chan struct{})
// Use a retry delay (30s) much longer than the test-select timeout (5s)
// so the test can only pass if cancellation interrupts the backoff
// promptly — the normal retry delay alone would exceed the timeout.
retryDelay := 30 * time.Second
s := newTestSearcher(t, testhelper.RoundTripperFunc(func(_ *http.Request) (*http.Response, error) {
return nil, errRetryTestConnectionReset
}), 1)
s.retryStrategy = newExponentialBackoffStrategy(1, retryDelay, retryDelay)
s.retryWaitHook = func() { close(retryWaitStarted) }
errCh := make(chan error, 1)
go func() {
_, err := s.Search(t.Context(), &SearchArgs{Query: "test"})
errCh <- err
}()
// Wait until the search goroutine has entered retryWait.
// At this point ShouldRetry has already returned true and the
// retryWait select is waiting on ctx.Done() or the timer.
<-retryWaitStarted
searchStart := time.Now()
err := s.Close()
if err != nil {
t.Fatalf("Close() error = %v, want nil", err)
}
select {
case err = <-errCh:
if elapsed := time.Since(searchStart); elapsed >= retryDelay {
t.Fatalf("Search() returned %v after Close, want <%v (backoff cancellation not prompt)", elapsed, retryDelay)
}
if err == nil {
t.Fatal("Search() error = nil after Close during backoff, want error")
}
if !errors.Is(err, context.Canceled) {
t.Fatalf("Search() error = %v, want context.Canceled in chain", err)
}
case <-time.After(5 * time.Second):
t.Fatal("Search() did not return within timeout — 30s retry delay exceeded test timeout, cancellation likely failed")
}
})
}
func TestSearch_NilArgs(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{}
_, err := s.Search(t.Context(), nil)
requireValidationError(t, err, "args")
}
// --- log debug methods (coverage-only, verify no panic) ---
func TestLogDebugMethods(t *testing.T) {
t.Parallel()
t.Run("debug=false does nothing", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{debug: false}
//nolint:errcheck // test request with valid URL/method; error impossible
req, _ := http.NewRequestWithContext(t.Context(), http.MethodPost, "https://example.com", strings.NewReader("body"))
// Should not panic
s.logDebugRequest(req, "test body")
s.logDebugResponse(&http.Response{StatusCode: http.StatusOK}, nil)
s.logDebugRetry(0, 2, time.Millisecond, nil)
})
t.Run("debug=true with valid data", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{debug: true}
//nolint:errcheck // test request with valid URL/method; error impossible
req, _ := http.NewRequestWithContext(t.Context(), http.MethodPost, "https://example.com", strings.NewReader("body"))
req.Header.Set("Content-Type", "application/json")
req.Header.Set("Accept", "text/plain")
// Should not panic
s.logDebugRequest(req, "test body")
s.logDebugResponse(&http.Response{
StatusCode: http.StatusOK,
Header: http.Header{"Content-Type": []string{"application/json"}},
}, nil)
s.logDebugRetry(0, 5, 100*time.Millisecond, errRetryTestConnectionReset)
})
t.Run("debug=true with GET request without body preview", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{debug: true}
//nolint:errcheck // test request with valid URL/method; error impossible
req, _ := http.NewRequestWithContext(t.Context(), http.MethodGet, "https://example.com?q=test", http.NoBody)
req.Header.Set("Accept", "text/html")
// Should not panic
s.logDebugRequest(req, "")
})
t.Run("debug=true with long body truncated", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{debug: true}
//nolint:errcheck // test request with valid URL/method; error impossible
req, _ := http.NewRequestWithContext(t.Context(), http.MethodPost, "https://example.com", http.NoBody)
longBody := strings.Repeat("x", DebugBodyPreviewBytes+100)
s.logDebugRequest(req, longBody)
})
t.Run("logDebugResponse with error skips logging", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{debug: true}
// Should not panic; error means no logging
s.logDebugResponse(nil, errRetryTestConnectionReset)
})
t.Run("logDebugResponse with nil response skips logging", func(t *testing.T) {
t.Parallel()
s := &SearXNGSearcher{debug: true}
// Should not panic
s.logDebugResponse(nil, nil)
})
}
func TestSearch_EmptyResultsAfterRetryExhaustion(t *testing.T) {
t.Parallel()
t.Run("exhausted retries return wrapped empty-results error", func(t *testing.T) {
t.Parallel()
callCount := 0
s := newTestSearcher(t, testhelper.RoundTripperFunc(func(_ *http.Request) (*http.Response, error) {
callCount++
return makeJSONResponse(minimalJSONBody), nil
}), 2)
result, err := s.Search(t.Context(), &SearchArgs{Query: "my-secret-password"})
if err == nil {
t.Fatal("Search() error = nil, want empty-results error")
}
if !errors.Is(err, errSearchEmptyResults) {
t.Fatalf("Search() error = %v, want errSearchEmptyResults in chain", err)
}
if result != nil {
t.Fatalf("Search() result = %#v, want nil", result)
}
if callCount != 3 {
t.Fatalf("callCount = %d, want 3", callCount)
}
if strings.Contains(err.Error(), "my-secret-password") {
t.Fatalf("Search() error = %q, must not contain raw query", err)
}
})
}
func TestAllowGETFallbackLogsWarnings(t *testing.T) {
t.Parallel()
t.Run("startup warning", func(t *testing.T) {
t.Parallel()
var buf bytes.Buffer
logger := slog.New(slog.NewTextHandler(&buf, nil))
searcher, err := NewSearXNGSearcher(&Config{
SearXNGURL: "https://search.example.com",
AllowGETFallback: true,
Logger: logger,
}, false)
if err != nil {
t.Fatalf("NewSearXNGSearcher() error = %v, want nil", err)
}
_ = searcher.Close() //nolint:errcheck // test cleanup; error is non-actionable
logOutput := buf.String()
if !strings.Contains(logOutput, "GET fallback is enabled") {
t.Fatalf("log output = %q, want startup warning", logOutput)
}
})
t.Run("per-use warning", func(t *testing.T) {
t.Parallel()
var buf bytes.Buffer
logger := slog.New(slog.NewTextHandler(&buf, nil))
origResp := &http.Response{
StatusCode: http.StatusMethodNotAllowed,
Header: http.Header{"Content-Type": []string{"text/html"}},
Body: http.NoBody,
}
postReq, err := http.NewRequestWithContext(
t.Context(),
http.MethodPost,
"https://search.example.com/search",
strings.NewReader("q=test&format=json"),
)
if err != nil {
t.Fatalf("NewRequestWithContext() error = %v, want nil", err)
}
s := &SearXNGSearcher{
client: &http.Client{
Transport: testhelper.RoundTripperFunc(func(_ *http.Request) (*http.Response, error) {
return makeJSONResponse(minimalJSONBody), nil
}),
},
logger: logger,
allowGETFallback: true,
}
resp, err := s.executeGETfallback(t.Context(), origResp, postReq, "q=test&format=json")
if err != nil {
t.Fatalf("executeGETfallback() error = %v, want nil", err)
}
closeBody(resp)
logOutput := buf.String()
if !strings.Contains(logOutput, "GET fallback used after POST search was rejected") {
t.Fatalf("log output = %q, want per-use warning", logOutput)
}
if strings.Contains(logOutput, "q=test") {
t.Fatalf("log output leaked query: %q", logOutput)
}
})
}
// TestNewSearXNGSearcher_ZeroTimeout verifies that a zero Config.Timeout in a
// struct literal creates a searcher whose HTTP client uses DefaultTimeout.
func TestNewSearXNGSearcher_ZeroTimeout(t *testing.T) {
t.Parallel()
cfg := &Config{
SearXNGURL: "https://search.example.com",
Timeout: 0, // zero struct literal: should normalize to DefaultTimeout
}
s, err := NewSearXNGSearcher(cfg, false)
if err != nil {
t.Fatalf("NewSearXNGSearcher() error = %v, want nil", err)
}
defer s.Close() //nolint:errcheck // test cleanup
if s.client.Timeout != DefaultTimeout {
t.Fatalf("client.Timeout = %v, want %v (zero should normalize to default)", s.client.Timeout, DefaultTimeout)
}
}
// TestNewSearXNGSearcher_PositiveTimeout verifies that a positive Config.Timeout
// creates a searcher whose HTTP client uses the configured value.
func TestNewSearXNGSearcher_PositiveTimeout(t *testing.T) {
t.Parallel()
cfg := &Config{
SearXNGURL: "https://search.example.com",
Timeout: 15 * time.Second,
}
s, err := NewSearXNGSearcher(cfg, false)
if err != nil {
t.Fatalf("NewSearXNGSearcher() error = %v, want nil", err)
}
defer s.Close() //nolint:errcheck // test cleanup
if s.client.Timeout != 15*time.Second {
t.Fatalf("client.Timeout = %v, want 15s", s.client.Timeout)
}
}
// TestNewSearXNGSearcher_CustomClientIgnoringTimeout verifies that when
// HTTPClient is set, the Config.Timeout field is not applied to the client
// (the caller-provided client controls its own HTTP timing).
func TestNewSearXNGSearcher_CustomClientIgnoringTimeout(t *testing.T) {
t.Parallel()
customTimeout := 42 * time.Second
cfg := &Config{
SearXNGURL: "https://search.example.com",
Timeout: 5 * time.Second, // should be ignored
HTTPClient: &http.Client{Timeout: customTimeout},
}
s, err := NewSearXNGSearcher(cfg, false)
if err != nil {
t.Fatalf("NewSearXNGSearcher() error = %v, want nil", err)
}
defer s.Close() //nolint:errcheck // test cleanup
if s.client.Timeout != customTimeout {
t.Fatalf("client.Timeout = %v, want %v (custom client timeout must be preserved)", s.client.Timeout, customTimeout)
}
}