mirror of
https://github.com/xlionjuan/hermes-subagent-output-guide.git
synced 2026-11-16 22:37:50 +00:00
143 lines
5.6 KiB
Python
143 lines
5.6 KiB
Python
"""Tests for pre_llm_call output (_on_pre_llm_call)."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from tests.helpers import make_child
|
|
|
|
|
|
class TestPreLlmCall:
|
|
def test_returns_guidance_when_child_and_first_turn(self, plugin):
|
|
"""When the session IS a child AND first turn: returns guidance string."""
|
|
make_child(plugin, "child-1")
|
|
result = plugin._on_pre_llm_call(
|
|
session_id="child-1",
|
|
is_first_turn=True,
|
|
)
|
|
assert result is not None and len(result) > 0
|
|
|
|
def test_returns_none_when_child_but_not_first_turn(self, plugin):
|
|
"""When the session IS a child but NOT first turn: returns None."""
|
|
make_child(plugin, "child-1")
|
|
assert (
|
|
plugin._on_pre_llm_call(
|
|
session_id="child-1",
|
|
is_first_turn=False,
|
|
)
|
|
is None
|
|
)
|
|
|
|
def test_returns_none_when_not_a_child_first_turn(self, plugin):
|
|
"""When the session is NOT a child: returns None (even if first turn)."""
|
|
assert (
|
|
plugin._on_pre_llm_call(
|
|
session_id="unknown-session",
|
|
is_first_turn=True,
|
|
)
|
|
is None
|
|
)
|
|
|
|
def test_returns_none_for_empty_session_id(self, plugin):
|
|
"""An empty session_id always returns None."""
|
|
make_child(plugin, "child-1")
|
|
assert (
|
|
plugin._on_pre_llm_call(
|
|
session_id="",
|
|
is_first_turn=True,
|
|
)
|
|
is None
|
|
)
|
|
|
|
def test_guidance_mentions_report_location(self, plugin):
|
|
"""The returned guidance mentions /tmp/ and text report concepts."""
|
|
make_child(plugin, "child-1")
|
|
result = plugin._on_pre_llm_call(
|
|
session_id="child-1",
|
|
is_first_turn=True,
|
|
)
|
|
assert "/tmp/" in result # nosec B108
|
|
assert "text report" in result.lower()
|
|
|
|
def test_guidance_has_boundary_markers(self, plugin):
|
|
"""The guidance has both <subagent-output-guide> and </subagent-output-guide> markers."""
|
|
make_child(plugin, "child-1")
|
|
result = plugin._on_pre_llm_call(
|
|
session_id="child-1",
|
|
is_first_turn=True,
|
|
)
|
|
assert "<subagent-output-guide>" in result
|
|
assert "</subagent-output-guide>" in result
|
|
assert result.index("<subagent-output-guide>") < result.index("</subagent-output-guide>")
|
|
|
|
def test_guidance_not_returned_for_different_child(self, plugin):
|
|
"""Guidance is only returned for the registered child, not other sessions."""
|
|
make_child(plugin, "child-1")
|
|
assert (
|
|
plugin._on_pre_llm_call(
|
|
session_id="child-2",
|
|
is_first_turn=True,
|
|
)
|
|
is None
|
|
)
|
|
|
|
def test_additional_kwargs_ignored(self, plugin):
|
|
"""Extra keyword arguments are accepted and don't affect logic."""
|
|
make_child(plugin, "child-1")
|
|
result = plugin._on_pre_llm_call(
|
|
session_id="child-1",
|
|
is_first_turn=True,
|
|
extra_param="should be ignored",
|
|
)
|
|
assert result is not None and len(result) > 0
|
|
|
|
def test_full_flow(self, plugin):
|
|
"""Integration: subagent_start + pre_llm_call chain works end-to-end."""
|
|
# Simulate delegation: spawn child, then child's first turn
|
|
child_id = "integration-test-session"
|
|
plugin._on_subagent_start(child_session_id=child_id, child_role="researcher")
|
|
result = plugin._on_pre_llm_call(
|
|
session_id=child_id,
|
|
is_first_turn=True,
|
|
)
|
|
assert result is not None
|
|
assert "<subagent-output-guide>" in result
|
|
assert "/tmp/" in result # nosec B108
|
|
assert (
|
|
plugin._on_pre_llm_call(
|
|
session_id=child_id,
|
|
is_first_turn=False,
|
|
)
|
|
is None
|
|
)
|
|
|
|
def test_cleanup_prevents_future_injection(self, plugin):
|
|
"""After session cleanup, first-turn guidance is no longer injected."""
|
|
child_id = "cleanup-test"
|
|
plugin._on_subagent_start(child_session_id=child_id)
|
|
# First turn: guidance should be returned
|
|
assert plugin._on_pre_llm_call(session_id=child_id, is_first_turn=True) is not None
|
|
# Session ends
|
|
plugin._on_session_end(session_id=child_id)
|
|
# Even if treated as first turn again, no guidance for an unknown session
|
|
assert plugin._on_pre_llm_call(session_id=child_id, is_first_turn=True) is None
|
|
|
|
def test_guidance_contains_semantic_phrases(self, plugin):
|
|
"""The guidance text asserts key policy semantics."""
|
|
make_child(plugin, "child-1")
|
|
result = plugin._on_pre_llm_call(session_id="child-1", is_first_turn=True)
|
|
assert result is not None
|
|
msg = result.lower()
|
|
# Applies only to text reports, not project files or other artifacts
|
|
assert "applies only to text reports" in msg
|
|
assert "does not apply to source code" in msg
|
|
# Explicit delivery instructions take priority
|
|
assert "follow any explicit delivery instructions" in msg
|
|
# Concise reports can stay in the response
|
|
assert "for a concise report, respond directly" in msg
|
|
# Long reports are proactively moved out of the final response
|
|
assert "proactively save the detailed report" in msg
|
|
assert "placing most of it in the final response" in msg
|
|
# Unspecified report path → /tmp/
|
|
assert "/tmp/" in msg # nosec B108
|
|
# The final response preserves useful context and the absolute path
|
|
assert "key findings, decisions, or next steps" in msg
|
|
assert "absolute path" in msg
|