hermes-agent/tests/tui_gateway/test_profiles_configure_model_guard.py
ethernet 612d542281 Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	.gitignore
#	Dockerfile
#	agent/onboarding.py
#	apps/desktop/electron/main.ts
#	apps/desktop/electron/pool-stop.ts
#	apps/desktop/src/components/model-picker.test.tsx
#	apps/desktop/src/store/updates.ts
#	apps/desktop/vite.config.ts
#	datagen-config-examples/run_browser_tasks.sh
#	docs/rca-ssl-cacert-post-git-pull.md
#	gateway/run.py
#	hermes_cli/backup.py
#	hermes_cli/credential_lifecycle.py
#	hermes_cli/dashboard_procs.py
#	hermes_cli/doctor_state.py
#	hermes_cli/env_loader.py
#	hermes_cli/gateway_windows.py
#	hermes_cli/local_runtime/endpoint.py
#	hermes_cli/psutil_android.py
#	hermes_cli/update_cmd.py
#	hermes_cli/update_cmd_windows.py
#	hermes_cli/web_routers/local_models.py
#	hermes_cli/web_server_config.py
#	hermes_cli/web_server_cron.py
#	plugins/memory/hindsight/__init__.py
#	plugins/memory/holographic/__init__.py
#	plugins/memory/honcho/cli.py
#	plugins/memory/mem0/__init__.py
#	plugins/platforms/google_chat/oauth.py
#	plugins/platforms/photon/adapter.py
#	scripts/ci/list_os_marked_tests.py
#	scripts/run_tests.sh
#	tests/agent/test_compression_stall_fallback.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/gateway/test_google_chat_oauth_dependencies.py
#	tests/hermes_cli/conftest.py
#	tests/hermes_cli/test_cli_init.py
#	tests/hermes_cli/test_gateway_migrate_multiplex.py
#	tests/hermes_cli/test_psutil_android_extract.py
#	tests/hermes_cli/test_relaunch.py
#	tests/hermes_cli/test_update_check.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_worktree_gc.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_retry_policy.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_autostash_conflict_recovery.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_commit_pin_rollback.py
#	tests/scripts/install/test_install_diverged_update.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_macos_launcher.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_ps1_ascii_only.py
#	tests/scripts/install/test_install_ps1_browser_install.py
#	tests/scripts/install/test_install_ps1_managed_node_swap.py
#	tests/scripts/install/test_install_ps1_native_stderr_eap.py
#	tests/scripts/install/test_install_ps1_node_path_for_npm.py
#	tests/scripts/install/test_install_ps1_python_fallback_venv.py
#	tests/scripts/install/test_install_ps1_resolver_strictmode.py
#	tests/scripts/install/test_install_ps1_uv_install_fallback.py
#	tests/scripts/install/test_install_ps1_uv_powershell_host.py
#	tests/scripts/install/test_install_ps1_venv_process_tree.py
#	tests/scripts/install/test_install_ps1_venv_recreate_safety.py
#	tests/scripts/install/test_install_ps1_venv_rename_abort.py
#	tests/scripts/install/test_install_ps1_venv_transaction_boundary.py
#	tests/scripts/install/test_install_ps1_web_server_syntax_probe.py
#	tests/scripts/install/test_install_scripts_computer_use.py
#	tests/scripts/install/test_install_sh_acp_launcher.py
#	tests/scripts/install/test_install_sh_bootstrap_marker.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_install_method_stamp.py
#	tests/scripts/install/test_install_sh_node_deps_failure.py
#	tests/scripts/install/test_install_sh_node_deps_workspaces.py
#	tests/scripts/install/test_install_sh_node_global_prefix.py
#	tests/scripts/install/test_install_sh_node_npm_check.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_node_probe.py
#	tests/scripts/install/test_install_sh_node_tarball_without_xz.py
#	tests/scripts/install/test_install_sh_pythonpath_sanitization.py
#	tests/scripts/install/test_install_sh_reuse_supported_python.py
#	tests/scripts/install/test_install_sh_root_fhs_uv_python_path.py
#	tests/scripts/install/test_install_sh_setup_wizard_tty_probe.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_termux_network_prereqs.py
#	tests/scripts/install/test_install_sh_termux_python_bounds.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_project_metadata.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_tts_pythonpath_fallback.py
#	tests/tui_gateway/test_hosted_room_driver_runtime.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	tools/lazy_deps.py
#	tools/voice_mode.py
#	uv.lock
#	website/docs/developer-guide/macos-bundle-updates.md
#	website/docs/developer-guide/pm-audit-status.md
#	website/docs/developer-guide/shared-bundle-builds.md
#	website/docs/developer-guide/source-update-completion.md
#	website/docs/developer-guide/stable-releases.md
2026-09-14 15:38:34 -04:00

118 lines
4.2 KiB
Python

"""profiles.configure honours the model selection guard (#95293 remainder).
The Bots-mode editor writes a profile's default model through
``profiles.configure`` — a surface that historically bypassed the
data-policy / expensive-model selection guard every other model-switch path
enforces (``config.set model`` answers ``confirm_required`` and waits for a
``confirm_expensive_model`` resend). A guarded pick made from the Bots
surface was therefore applied silently, with no confirm flow anywhere.
These tests pin the same handshake contract on ``profiles.configure``:
* a guarded model WITHOUT ``confirm_expensive_model`` answers
``confirm_required`` + ``confirm_message`` and writes NOTHING;
* the confirmed resend (``confirm_expensive_model: true``) writes;
* unguarded models keep writing exactly as before.
"""
from __future__ import annotations
from pathlib import Path
from types import SimpleNamespace
import pytest
import hermes_yaml as yaml
import hermes_cli.model_selection_guards as guards
import tui_gateway.server as srv
GUARDED_MODEL = "muse-spark-1.2-contributor"
GUARD_MESSAGE = "CONTRIBUTOR TIER: this model may train on your data."
@pytest.fixture
def home(tmp_path, monkeypatch):
hermes_home = tmp_path / ".hermes"
hermes_home.mkdir()
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
# The profile write now validates through ``switch_model`` (catalog + credentials); these
# tests pin the guard handshake, so echo the pick back as an accepted route.
from hermes_cli.model_switch import ModelSwitchResult
monkeypatch.setattr(
"hermes_cli.model_switch.switch_model",
lambda *, raw_input, explicit_provider, **_kw: ModelSwitchResult(
success=True, new_model=raw_input, target_provider=explicit_provider))
return hermes_home
@pytest.fixture
def contributor_guard(monkeypatch):
"""Fire the selection guard for GUARDED_MODEL only, like the real
data-policy guard fires for ``-contributor`` ids."""
def fake_combined_selection_warning(model_name, **_kwargs):
if model_name == GUARDED_MODEL:
return SimpleNamespace(message=GUARD_MESSAGE, kind="data_policy")
return None
monkeypatch.setattr(guards, "combined_selection_warning", fake_combined_selection_warning)
def _configure(params):
return srv._methods["profiles.configure"]("configure", {"name": "default", **params})["result"]
def _profile_model(home: Path):
cfg_path = home / "config.yaml"
if not cfg_path.is_file():
return None
cfg = yaml.safe_load(cfg_path.read_text()) or {}
model_cfg = cfg.get("model") or {}
return model_cfg.get("default")
def test_guarded_model_answers_confirm_required_and_writes_nothing(home, contributor_guard):
result = _configure({"model": GUARDED_MODEL, "provider": "opencode-go"})
assert result.get("confirm_required") is True
assert GUARD_MESSAGE in (result.get("confirm_message") or "")
# The model section is PENDING confirmation, not failed — it must not
# poison ``ok`` (the Bots editor toasts "Some sections failed" on False).
assert result["applied"].get("model") is not False
assert _profile_model(home) != GUARDED_MODEL
def test_confirmed_resend_writes_the_guarded_model(home, contributor_guard):
result = _configure(
{
"model": GUARDED_MODEL,
"provider": "opencode-go",
"confirm_expensive_model": True,
}
)
assert not result.get("confirm_required")
assert result["applied"].get("model") is True
assert _profile_model(home) == GUARDED_MODEL
def test_unguarded_model_still_writes_without_confirmation(home, contributor_guard):
result = _configure({"model": "hermes-4.5-405b", "provider": "nous"})
assert not result.get("confirm_required")
assert result["applied"].get("model") is True
assert _profile_model(home) == "hermes-4.5-405b"
def test_other_sections_still_apply_while_model_awaits_confirmation(home, contributor_guard):
result = _configure(
{
"model": GUARDED_MODEL,
"provider": "opencode-go",
"soul": "# SOUL\nBe kind.",
}
)
assert result.get("confirm_required") is True
assert result["applied"].get("soul") is True
assert _profile_model(home) != GUARDED_MODEL