hermes-agent/tests/tui_gateway/test_profile_db_readonly.py
yoniebans a30ccdbeab fix(tui_gateway): keep opportunistic writes off read-only foreign handles
Two write paths were still reachable through the now read-only foreign-profile
handle (reported by @ehz0ah on #110718): the repo-root backfill in
_discover_repos_payload raised and was swallowed per RPC, silently dropping the
persistence; the Bot Chat unarchive in session.list's exact-title lookup failed
the RPC with error 5006. Backfill now skips on read-only handles (that
profile's own gateway backfills on its refreshes); the unarchive escalates to a
short-lived registry writer for the rare recoverable-archive case.

Reported-by: ehz0ah
2026-09-14 05:28:46 -07:00

90 lines
4 KiB
Python

"""Foreign-profile _profile_db handles must not write-lock another profile's live store.
A named-profile backend serving RPCs about a different profile (desktop app-global remote
mode, profile switcher) used to acquire() a WRITER on that profile's state.db per RPC and
close it in the handler's finally. Reads never need that lock, and the writer's close
participated in the deleted-WAL incident class. Read paths now open read-only, mirroring
hermes_cli.web_routers.profiles._read_profile_db; the few RPCs that genuinely write
(move-cwd, delete, set_hidden, foreign import) opt in with writer=True, and the two
opportunistic writes reachable from read RPCs (repo-root backfill, Bot Chat unarchive)
either skip or escalate to a short-lived writer instead of writing on the reader.
"""
from __future__ import annotations
from pathlib import Path
import tui_gateway.server as server
from hermes_state import SessionDB
def _seed_store(home: Path) -> Path:
home.mkdir(parents=True, exist_ok=True)
db = SessionDB(db_path=home / "state.db")
db.create_session(session_id="seed", source="cli", model="m")
db.close()
return home
def _bind_foreign(monkeypatch, tmp_path: Path) -> None:
foreign = _seed_store(tmp_path / "profiles" / "code")
monkeypatch.setattr(server, "_profile_home", lambda name: foreign if (name or "").strip() == "code" else None)
def test_foreign_profile_db_is_read_only(monkeypatch, tmp_path):
_bind_foreign(monkeypatch, tmp_path)
with server._profile_db({"profile": "code"}) as db:
assert db is not None
assert db.read_only is True
assert db.get_session("seed") is not None
def test_foreign_profile_db_writer_opt_in(monkeypatch, tmp_path):
_bind_foreign(monkeypatch, tmp_path)
with server._profile_db({"profile": "code"}, writer=True) as db:
assert db is not None
assert db.read_only is False
assert db.set_session_title("seed", "renamed") is True
def test_discover_repos_payload_skips_backfill_on_read_only(monkeypatch, tmp_path):
"""The repo-root backfill UPDATE must not be attempted (and swallowed) on a reader."""
_bind_foreign(monkeypatch, tmp_path)
with server._profile_db({"profile": "code"}) as db:
calls = []
monkeypatch.setattr(type(db), "backfill_repo_roots", lambda self, m: calls.append(m), raising=False)
server._discover_repos_payload(db, backfill=True, include_cached=False)
assert calls == []
# Same call on a writable handle still backfills.
with server._profile_db({"profile": "code"}, writer=True) as db:
calls = []
monkeypatch.setattr(type(db), "backfill_repo_roots", lambda self, m: calls.append(m), raising=False)
server._discover_repos_payload(db, backfill=True, include_cached=False)
assert len(calls) == 1
def test_bot_chat_unarchive_escalates_to_writer(monkeypatch, tmp_path):
"""An archived-by-accident Bot Chat found via an exact-title lookup on a READ-ONLY foreign
handle is still resurrected: the write goes through a short-lived registry writer."""
from tools.bot_mode_probe import BOT_CHAT_TITLE
foreign = tmp_path / "profiles" / "code"
foreign.mkdir(parents=True, exist_ok=True)
db = SessionDB(db_path=foreign / "state.db")
db.create_session(session_id="bot", source="cli", model="m")
db.set_session_title("bot", BOT_CHAT_TITLE)
db.end_session("bot", "ws_orphan_reap")
db.set_session_archived("bot", True)
db.close()
monkeypatch.setattr(server, "_profile_home", lambda name: foreign if (name or "").strip() == "code" else None)
with server._profile_db({"profile": "code"}) as ro_db:
assert ro_db.read_only is True
resp = server._session_list_by_title("rid", ro_db, BOT_CHAT_TITLE)
assert resp["result"]["sessions"], "archived Bot Chat was not resurrected through the writer escalation"
check = SessionDB(db_path=foreign / "state.db", read_only=True)
try:
assert not check.get_session("bot").get("archived")
finally:
check.close()