hermes-agent/tests/tui_gateway/test_config_profile_scope.py
ethernet 9f837d298b Merge remote-tracking branch 'origin/main' into ethie/pm-clean
Conflicts resolved toward the PM model: main's lazy_deps/update_cmd_deps/npm
stamp machinery stays deleted (PM + scripts/build/node-deps.mjs own it), the
systemd ExecStop stop-mark rides the installation launcher, legacy
linux_only/macos_only/windows_only markers are rewritten to platforms(), and
finalize_update_receipt carries pending manual-serve obligations forward
again (lost when the ContextVar receipt rewrite crossed c0aa3ce354).

Test harness: the real-home I/O guard exempts /proc/<pid>/fd metadata reads
(deleted-WAL holder scans) and run_tests.sh drops ~/.hermes PATH entries so
shutil.which() cannot trip the tripwire.
2026-09-20 10:07:50 -04:00

202 lines
7.1 KiB
Python

"""config.get / config.set must honor params.profile (issue #95760).
A single dashboard backend in desktop app-global remote mode serves every
profile. projects.* RPCs already bind params.profile via @_profile_scoped;
config.get / config.set did not, so reads and persistent writes used the
launch profile's config.yaml for every focused profile.
"""
from __future__ import annotations
from pathlib import Path
import hermes_yaml as yaml
import tui_gateway.server as server
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
LAUNCH_CWD = "/workspace/default"
WORKER_CWD = "/workspace/code"
LAUNCH_ROOTS = ["/workspace/default"]
WORKER_ROOTS = ["/workspace/code"]
def _write_cfg(home: Path, cwd: str, roots: list[str]) -> None:
home.mkdir(parents=True, exist_ok=True)
(home / "config.yaml").write_text(
yaml.safe_dump(
{
"terminal": {"cwd": cwd},
"desktop": {"repo_scan_roots": list(roots)},
"display": {"busy_input_mode": "queue"},
}
),
encoding="utf-8",
)
def _homes(tmp_path: Path) -> tuple[Path, Path]:
launch = tmp_path / "launch"
worker = tmp_path / "profiles" / "code"
_write_cfg(launch, LAUNCH_CWD, LAUNCH_ROOTS)
_write_cfg(worker, WORKER_CWD, WORKER_ROOTS)
return launch, worker
def _reset_cfg_cache() -> None:
server._cfg_cache = None
server._cfg_sig = None
server._cfg_path = None
def _bind_homes(monkeypatch, launch: Path, worker: Path) -> None:
monkeypatch.setattr(server, "_hermes_home", launch)
monkeypatch.setenv("HERMES_HOME", str(launch))
monkeypatch.setattr(
server,
"_profile_home",
lambda name: worker if (name or "").strip() == "code" else None,
)
_reset_cfg_cache()
def _get(params: dict) -> dict:
return server._methods["config.get"]("rid-get", params)
def _set(params: dict) -> dict:
return server._methods["config.set"]("rid-set", params)
def _read_yaml(home: Path) -> dict:
return yaml.safe_load((home / "config.yaml").read_text(encoding="utf-8")) or {}
def test_config_get_full_reads_params_profile_yaml_not_launch(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
_bind_homes(monkeypatch, launch, worker)
launch_resp = _get({"key": "full"})
assert launch_resp["result"]["config"]["terminal"]["cwd"] == LAUNCH_CWD
assert launch_resp["result"]["config"]["desktop"]["repo_scan_roots"] == LAUNCH_ROOTS
_reset_cfg_cache()
worker_resp = _get({"key": "full", "profile": "code"})
assert worker_resp["result"]["config"]["terminal"]["cwd"] == WORKER_CWD
assert worker_resp["result"]["config"]["desktop"]["repo_scan_roots"] == WORKER_ROOTS
# Launch file must be untouched by the focused-profile read.
assert _read_yaml(launch)["terminal"]["cwd"] == LAUNCH_CWD
def test_config_set_persistent_write_lands_on_params_profile_yaml(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
_bind_homes(monkeypatch, launch, worker)
resp = _set({"key": "busy", "value": "steer", "profile": "code"})
assert resp["result"]["value"] == "steer"
worker_cfg = _read_yaml(worker)
launch_cfg = _read_yaml(launch)
assert worker_cfg["display"]["busy_input_mode"] == "steer"
assert launch_cfg["display"]["busy_input_mode"] == "queue"
assert launch_cfg["terminal"]["cwd"] == LAUNCH_CWD
assert worker_cfg["terminal"]["cwd"] == WORKER_CWD
def test_config_set_without_profile_still_writes_launch_home(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
_bind_homes(monkeypatch, launch, worker)
resp = _set({"key": "busy", "value": "interrupt"})
assert resp["result"]["value"] == "interrupt"
assert _read_yaml(launch)["display"]["busy_input_mode"] == "interrupt"
assert _read_yaml(worker)["display"]["busy_input_mode"] == "queue"
def test_launch_cwd_reads_launch_config_during_foreign_profile_scope(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
launch_cwd = tmp_path / "launch-workspace"
worker_cwd = tmp_path / "worker-workspace"
launch_cwd.mkdir()
worker_cwd.mkdir()
_write_cfg(launch, str(launch_cwd), LAUNCH_ROOTS)
_write_cfg(worker, str(worker_cwd), WORKER_ROOTS)
_bind_homes(monkeypatch, launch, worker)
token = set_hermes_home_override(str(worker))
try:
assert server._launch_configured_cwd() == str(launch_cwd)
finally:
reset_hermes_home_override(token)
def test_profile_cwd_write_does_not_retarget_launch_session(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
launch_cwd = tmp_path / "launch-workspace"
worker_cwd = tmp_path / "worker-workspace"
launch_cwd.mkdir()
worker_cwd.mkdir()
_write_cfg(launch, ".", LAUNCH_ROOTS)
_write_cfg(worker, str(worker_cwd), WORKER_ROOTS)
_bind_homes(monkeypatch, launch, worker)
monkeypatch.setenv("TERMINAL_CWD", str(launch_cwd))
monkeypatch.setattr(server, "_schedule_agent_build", lambda _sid: None)
monkeypatch.setattr(server, "_schedule_session_cap_enforcement", lambda: None)
response = _set(
{"key": "terminal.cwd", "value": str(worker_cwd), "profile": "code"}
)
assert response["result"]["cwd"] == str(worker_cwd)
assert _read_yaml(worker)["terminal"]["cwd"] == str(worker_cwd)
assert server.os.environ["TERMINAL_CWD"] == str(launch_cwd)
created = server._methods["session.create"]("rid-create", {"cols": 80})
sid = created["result"]["session_id"]
try:
assert created["result"]["info"]["cwd"] == str(launch_cwd)
assert server._sessions[sid]["profile_home"] is None
finally:
server._sessions.pop(sid, None)
def test_session_bound_profile_cwd_write_does_not_retarget_launch_process(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
launch_cwd = tmp_path / "launch-workspace"
worker_cwd = tmp_path / "worker-workspace"
launch_cwd.mkdir()
worker_cwd.mkdir()
_bind_homes(monkeypatch, launch, worker)
monkeypatch.setenv("TERMINAL_CWD", str(launch_cwd))
monkeypatch.setitem(
server._sessions,
"worker-session",
{"agent": None, "profile_home": str(worker), "session_key": "worker-session"},
)
response = _set(
{"session_id": "worker-session", "key": "terminal.cwd", "value": str(worker_cwd)}
)
assert response["result"]["cwd"] == str(worker_cwd)
assert _read_yaml(worker)["terminal"]["cwd"] == str(worker_cwd)
assert server.os.environ["TERMINAL_CWD"] == str(launch_cwd)
def test_launch_profile_cwd_write_updates_non_local_terminal_task(tmp_path, monkeypatch):
launch, worker = _homes(tmp_path)
old_cwd = tmp_path / "old-workspace"
new_cwd = tmp_path / "new-workspace"
old_cwd.mkdir()
new_cwd.mkdir()
_bind_homes(monkeypatch, launch, worker)
monkeypatch.setenv("TERMINAL_ENV", "docker")
monkeypatch.setenv("TERMINAL_CWD", str(old_cwd))
response = _set({"key": "terminal.cwd", "value": str(new_cwd)})
assert response["result"]["cwd"] == str(new_cwd)
assert _read_yaml(launch)["terminal"]["cwd"] == str(new_cwd)
assert server.os.environ["TERMINAL_CWD"] == str(new_cwd)
assert server._terminal_task_cwd(None) == str(new_cwd)