hermes-agent/tests/tools/test_skillevaluator_scan.py
ethernet 890bbbda1f Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts
#	apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts
#	apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts
#	apps/desktop/e2e/bot-mode-roster-localized.spec.ts
#	apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts
#	apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts
#	apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts
#	apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts
#	apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts
#	apps/desktop/e2e/bot-roster-user-sections.spec.ts
#	apps/desktop/e2e/bot-routines-pane-narrow.spec.ts
#	apps/desktop/e2e/bot-row-open-recent-session.spec.ts
#	apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts
#	apps/desktop/e2e/group-composer-auto-grow.spec.ts
#	apps/desktop/e2e/group-create-gate-remote-roster.spec.ts
#	apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts
#	apps/desktop/e2e/hosted-room-backend-continuity.spec.ts
#	apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts
#	apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts
#	apps/desktop/e2e/worktree-branch-status.spec.ts
#	apps/desktop/electron/backend-probes.test.ts
#	apps/desktop/electron/connection-apply.test.ts
#	apps/desktop/electron/desktop-electron-pin.test.ts
#	apps/desktop/electron/desktop-uninstall.test.ts
#	apps/desktop/electron/gateway-file-download-transport.test.ts
#	apps/desktop/electron/gateway-stop-before-update.test.ts
#	apps/desktop/electron/github-api-auth.test.ts
#	apps/desktop/electron/registry-primary-profile-scope.test.ts
#	apps/desktop/electron/update-api-check.test.ts
#	apps/desktop/electron/update-handoff-marker.test.ts
#	apps/desktop/electron/venv-blocker-scan.test.ts
#	apps/desktop/scripts/after-extract.test.mjs
#	apps/desktop/scripts/local-pack-publish.test.mjs
#	apps/desktop/scripts/tasks-scroll.test.mjs
#	apps/desktop/src/app/settings/model-settings.test.tsx
#	apps/desktop/src/app/updates-overlay.blockers.test.tsx
#	apps/desktop/src/components/desktop-install-overlay.test.tsx
#	apps/desktop/src/lib/update-copy.test.ts
#	scripts/ci/check_os_marker_fakes.py
#	tests-js/desktop-mac-usage-descriptions.test.ts
#	tests-js/node-engine-alignment.test.ts
#	tests/agent/lsp/test_install_and_lint_fixes.py
#	tests/agent/test_command_token_source.py
#	tests/agent/test_compression_boundary_hook.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/agent/test_custom_provider_ca_probes.py
#	tests/agent/test_endpoint_blackhole.py
#	tests/agent/test_estimator_parity.py
#	tests/agent/test_in_place_compaction.py
#	tests/agent/test_moa_loop_mode.py
#	tests/agent/test_model_metadata.py
#	tests/agent/test_skill_session_platform_gate.py
#	tests/agent/test_skill_utils.py
#	tests/agent/test_ssl_ca_guard.py
#	tests/computer_use/test_doctor.py
#	tests/cron/test_codex_execution_paths.py
#	tests/cron/test_cron_bot_chat_delivery.py
#	tests/cron/test_cron_script.py
#	tests/cron/test_media_delivery_parity.py
#	tests/cron/test_misfire_catchup.py
#	tests/cron/test_parallel_pool.py
#	tests/cron/test_recurring_eagain_redispatch.py
#	tests/gateway/test_choice_picker.py
#	tests/gateway/test_control_socket_windows_live.py
#	tests/gateway/test_dingtalk.py
#	tests/gateway/test_feishu.py
#	tests/gateway/test_feishu_onboard.py
#	tests/gateway/test_gateway_shutdown.py
#	tests/gateway/test_matrix.py
#	tests/gateway/test_model_command_custom_providers.py
#	tests/gateway/test_reasoning_command.py
#	tests/gateway/test_runtime_footer.py
#	tests/gateway/test_session.py
#	tests/gateway/test_session_hygiene.py
#	tests/gateway/test_status.py
#	tests/gateway/test_teams.py
#	tests/gateway/test_turn_lease.py
#	tests/gateway/test_whatsapp_connect.py
#	tests/hermes_cli/test_approvals_command.py
#	tests/hermes_cli/test_auth_store_lock_concurrent.py
#	tests/hermes_cli/test_backup.py
#	tests/hermes_cli/test_banner_git_state.py
#	tests/hermes_cli/test_certifi_repair.py
#	tests/hermes_cli/test_cmd_update.py
#	tests/hermes_cli/test_compat_manifest_targets.py
#	tests/hermes_cli/test_computer_use_cli.py
#	tests/hermes_cli/test_cpr_local_leak.py
#	tests/hermes_cli/test_dashboard_auth_gate.py
#	tests/hermes_cli/test_dashboard_procs_kill_grace.py
#	tests/hermes_cli/test_desktop_lifecycle_windows_live.py
#	tests/hermes_cli/test_doctor.py
#	tests/hermes_cli/test_doctor_command_install.py
#	tests/hermes_cli/test_fleet_config_migration_windows_live.py
#	tests/hermes_cli/test_gateway.py
#	tests/hermes_cli/test_gateway_platform_gating.py
#	tests/hermes_cli/test_gateway_restart_loop.py
#	tests/hermes_cli/test_gateway_task_probe.py
#	tests/hermes_cli/test_gateway_wsl.py
#	tests/hermes_cli/test_gui_command.py
#	tests/hermes_cli/test_install_cua_driver.py
#	tests/hermes_cli/test_kanban_db.py
#	tests/hermes_cli/test_lazy_command_exports.py
#	tests/hermes_cli/test_lazy_refresh_venv_repair.py
#	tests/hermes_cli/test_linux_desktop_entry.py
#	tests/hermes_cli/test_local_runtime.py
#	tests/hermes_cli/test_local_runtime_updates.py
#	tests/hermes_cli/test_managed_uv.py
#	tests/hermes_cli/test_mcp_reload_confirm_gate.py
#	tests/hermes_cli/test_nous_subscription.py
#	tests/hermes_cli/test_npm_engine.py
#	tests/hermes_cli/test_personality_none.py
#	tests/hermes_cli/test_pet_toggle.py
#	tests/hermes_cli/test_plan_reconciliation_windows_live.py
#	tests/hermes_cli/test_plugin_event_bus.py
#	tests/hermes_cli/test_plugin_manifest_v2.py
#	tests/hermes_cli/test_plugin_packs.py
#	tests/hermes_cli/test_plugins_cmd.py
#	tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py
#	tests/hermes_cli/test_process_identity.py
#	tests/hermes_cli/test_profiles.py
#	tests/hermes_cli/test_profiles_sidebar_cache.py
#	tests/hermes_cli/test_pty_bridge.py
#	tests/hermes_cli/test_resolve_turn_limit.py
#	tests/hermes_cli/test_serve_runtime_inventory.py
#	tests/hermes_cli/test_session_vacuum_config.py
#	tests/hermes_cli/test_set_config_value.py
#	tests/hermes_cli/test_signal_handler_kanban_worker.py
#	tests/hermes_cli/test_slash_confirm_windows.py
#	tests/hermes_cli/test_stale_pid_guard.py
#	tests/hermes_cli/test_startup_fast_guards.py
#	tests/hermes_cli/test_status.py
#	tests/hermes_cli/test_telegram_managed_bot.py
#	tests/hermes_cli/test_tools_config.py
#	tests/hermes_cli/test_update_apply_shallow_count.py
#	tests/hermes_cli/test_update_autostash.py
#	tests/hermes_cli/test_update_concurrent_quarantine.py
#	tests/hermes_cli/test_update_fetch_failure_classifier.py
#	tests/hermes_cli/test_update_fleet_probe_resume_token.py
#	tests/hermes_cli/test_update_handoff_backend_reap.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_update_head_moved_gate.py
#	tests/hermes_cli/test_update_host_obligation.py
#	tests/hermes_cli/test_update_import_guard.py
#	tests/hermes_cli/test_update_interrupted_recovery.py
#	tests/hermes_cli/test_update_inventory.py
#	tests/hermes_cli/test_update_launchd_unloaded_gateway.py
#	tests/hermes_cli/test_update_missing_configured_deps.py
#	tests/hermes_cli/test_update_modified_notice.py
#	tests/hermes_cli/test_update_multiplex_migration_hook.py
#	tests/hermes_cli/test_update_no_gateway_restart.py
#	tests/hermes_cli/test_update_orphan_backend_reap.py
#	tests/hermes_cli/test_update_parked_branch_guard.py
#	tests/hermes_cli/test_update_post_pull_syntax_guard.py
#	tests/hermes_cli/test_update_receipt.py
#	tests/hermes_cli/test_update_self_lock.py
#	tests/hermes_cli/test_update_shim_fail_closed.py
#	tests/hermes_cli/test_update_shim_self_lock.py
#	tests/hermes_cli/test_update_sqlite_remediation.py
#	tests/hermes_cli/test_update_stale_dashboard.py
#	tests/hermes_cli/test_update_stale_virtualenv.py
#	tests/hermes_cli/test_update_venv_health.py
#	tests/hermes_cli/test_update_venv_ownership_preflight.py
#	tests/hermes_cli/test_update_wedged_gateway.py
#	tests/hermes_cli/test_update_yes_flag.py
#	tests/hermes_cli/test_update_zip_two_phase.py
#	tests/hermes_cli/test_urllib_security.py
#	tests/hermes_cli/test_ux_messages_auth_config.py
#	tests/hermes_cli/test_ux_messages_startup.py
#	tests/hermes_cli/test_venv_holder_classifier.py
#	tests/hermes_cli/test_verify_console_scripts.py
#	tests/hermes_cli/test_verify_core_dependencies.py
#	tests/hermes_cli/test_web_server.py
#	tests/hermes_cli/test_web_server_console_ws.py
#	tests/hermes_cli/test_web_server_ws_ping.py
#	tests/hermes_cli/test_web_ui_build.py
#	tests/hermes_state/test_fts_rebuild_admission.py
#	tests/hermes_state/test_hermes_state.py
#	tests/plugins/memory/test_memory_lazy_install.py
#	tests/plugins/test_google_meet_plugin.py
#	tests/plugins/test_langfuse_plugin.py
#	tests/plugins/test_security_guidance_plugin.py
#	tests/plugins/test_transform_llm_output_hook.py
#	tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_contributor_map.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/skills/test_competitor_news_monitor_skill.py
#	tests/skills/test_document_to_action_items_skill.py
#	tests/skills/test_google_workspace_setup.py
#	tests/skills/test_google_workspace_setup_deps.py
#	tests/skills/test_grounded_citations_skill.py
#	tests/skills/test_ip_as_logo_skill.py
#	tests/skills/test_live_dashboard_skill.py
#	tests/skills/test_mcp_oauth_remote_gateway_skill.py
#	tests/skills/test_office_document_skills.py
#	tests/skills/test_openclaw_migration.py
#	tests/skills/test_product_price_monitor_skill.py
#	tests/skills/test_scrollcraft_skill.py
#	tests/skills/test_setup_wizard_generator_skill.py
#	tests/skills/test_weekly_review_planning_skill.py
#	tests/test_engines_satisfiable.py
#	tests/test_fast_safe_load.py
#	tests/test_hermes_bootstrap.py
#	tests/test_hermes_constants.py
#	tests/test_hermes_logging.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_model_tools_async_bridge.py
#	tests/test_packaging_build_guard.py
#	tests/test_packaging_metadata.py
#	tests/test_yaml_indent_consistency.py
#	tests/tools/test_approval_timeout_overflow.py
#	tests/tools/test_base_environment.py
#	tests/tools/test_bot_mode_dm.py
#	tests/tools/test_browser_chromium_check.py
#	tests/tools/test_browser_hardening.py
#	tests/tools/test_browser_homebrew_paths.py
#	tests/tools/test_browser_npx_warmup.py
#	tests/tools/test_browser_orphan_reaper.py
#	tests/tools/test_browser_real_profile.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_code_execution.py
#	tests/tools/test_code_execution_modes.py
#	tests/tools/test_code_execution_windows_env.py
#	tests/tools/test_computer_use.py
#	tests/tools/test_delegate_liveness_timeout.py
#	tests/tools/test_execute_code_approval_cluster.py
#	tests/tools/test_execution_flag_detection.py
#	tests/tools/test_fal_common.py
#	tests/tools/test_file_operations.py
#	tests/tools/test_file_tools.py
#	tests/tools/test_file_tools_cwd_resolution.py
#	tests/tools/test_file_tools_live.py
#	tests/tools/test_lazy_deps.py
#	tests/tools/test_lazy_deps_durable_target.py
#	tests/tools/test_lazy_deps_managed.py
#	tests/tools/test_local_env_blocklist.py
#	tests/tools/test_local_tempdir.py
#	tests/tools/test_macos_protected_search.py
#	tests/tools/test_mcp_npx_cached_bin.py
#	tests/tools/test_oneshot_completion_linger.py
#	tests/tools/test_process_registry.py
#	tests/tools/test_read_file_schema_gating.py
#	tests/tools/test_skill_improvements.py
#	tests/tools/test_skills_sync.py
#	tests/tools/test_termux_api_detection.py
#	tests/tools/test_tirith_security.py
#	tests/tools/test_transcription_tools.py
#	tests/tools/test_tts_streaming.py
#	tests/tools/test_wake_word.py
#	tests/tui_gateway/test_compute_host_borrowed_lease.py
#	tests/tui_gateway/test_compute_host_turn_protocol.py
#	tests/tui_gateway/test_isolated_orphan_activity.py
#	tests/tui_gateway/test_protocol.py
#	tests/tui_gateway/test_slash_worker_profile_home.py
#	tests/tui_gateway/test_subprocess_encoding.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	ui-tui/src/__tests__/terminalParity.test.ts
#	ui-tui/src/__tests__/termuxComposerLayout.test.ts
#	ui-tui/src/__tests__/textInputFastEcho.test.ts
2026-09-23 07:02:44 -04:00

234 lines
9.4 KiB
Python

"""Tests for the advisory SkillEvaluator Tier 1 install scan.
The adapter (tools/skillevaluator_scan.py) must:
- classify secrets-class vs advisory findings correctly,
- degrade to an unavailable (no-op) report on every failure mode,
- never raise out of the install path helper.
"""
import json
import subprocess
import sys
from pathlib import Path
from unittest import mock
sys.path.insert(0, str(Path(__file__).resolve().parents[2]))
from tools.skillevaluator_scan import ( # noqa: E402
Tier1Report,
_parse_report,
format_tier1_report,
run_tier1_scan,
tier1_advisory_enabled,
)
def _report_json(findings):
return {
"overall_passed": not findings,
"results": [
{"validator": "PII Scan", "passed": not findings, "findings": findings},
{"validator": "Unicode Smuggling Detection", "passed": True, "findings": []},
],
}
def _finding(check, severity="high", message="msg", file="SKILL.md", line=3):
return {
"check_name": check,
"severity": severity,
"message": message,
"file_path": file,
"line_number": line,
"suggestion": "fix it",
}
class TestParseReport:
def test_clean_report(self):
report = _parse_report(_report_json([]))
assert report.available
assert report.passed
assert report.findings == []
def test_pii_email_is_advisory_not_secrets(self):
report = _parse_report(_report_json([
_finding("emails", message="Non-placeholder email address: [email protected]"),
]))
assert len(report.findings) == 1
assert report.advisory_findings == report.findings
assert report.secrets_findings == []
def test_database_credentials_is_secrets_class(self):
report = _parse_report(_report_json([
_finding("database_credentials", severity="critical"),
]))
assert len(report.secrets_findings) == 1
assert report.advisory_findings == []
def test_malformed_findings_skipped(self):
raw = _report_json([_finding("emails")])
raw["results"][0]["findings"].append("not-a-dict")
report = _parse_report(raw)
assert len(report.findings) == 1
def test_incomplete_check_excluded_from_verdict(self):
"""A fail-with-zero-findings incomplete validator (e.g. SkillSpector
consistency-check trip) must not fail the advisory verdict."""
raw = _report_json([])
raw["results"].append({
"validator": "Security Scan",
"passed": False,
"status": "incomplete",
"findings": [],
})
report = _parse_report(raw)
assert report.passed
assert report.findings == []
assert report.incomplete_checks == ["Security Scan"]
def test_incomplete_check_findings_preserved(self):
"""Partial evidence from an incomplete validator is kept as findings
(Nir Paz review) — only the validator's pass/fail verdict is excluded."""
raw = _report_json([])
raw["results"].append({
"validator": "Security Scan",
"passed": False,
"status": "incomplete",
"findings": [_finding("hardcoded_secrets", severity="critical")],
})
report = _parse_report(raw)
assert len(report.findings) == 1
assert report.findings[0].is_secrets_class
assert report.incomplete_checks == ["Security Scan"]
# findings present -> report is not clean, even though the only
# failing validator was incomplete
assert not report.passed
class TestRunTier1Scan:
def test_scanner_missing_degrades(self, tmp_path):
with mock.patch("tools.skillevaluator_scan.shutil.which", return_value=None):
report = run_tier1_scan(tmp_path)
assert not report.available
assert report.findings == []
def test_scanner_timeout_degrades(self, tmp_path):
with mock.patch("tools.skillevaluator_scan.shutil.which", return_value="/usr/bin/skillevaluator"), \
mock.patch("tools.skillevaluator_scan.subprocess.run",
side_effect=subprocess.TimeoutExpired(cmd="x", timeout=1)):
report = run_tier1_scan(tmp_path)
assert not report.available
def test_scanner_launch_failure_degrades(self, tmp_path):
with mock.patch("tools.skillevaluator_scan.shutil.which", return_value="/usr/bin/skillevaluator"), \
mock.patch("tools.skillevaluator_scan.subprocess.run", side_effect=OSError("boom")):
report = run_tier1_scan(tmp_path)
assert not report.available
def test_no_json_report_degrades(self, tmp_path):
with mock.patch("tools.skillevaluator_scan.shutil.which", return_value="/usr/bin/skillevaluator"), \
mock.patch("tools.skillevaluator_scan.subprocess.run",
return_value=subprocess.CompletedProcess([], 1, "", "")):
report = run_tier1_scan(tmp_path)
assert not report.available
def test_real_report_parsed(self, tmp_path):
"""subprocess.run mocked to drop a real-shaped report into outdir."""
payload = _report_json([_finding("emails")])
def fake_run(cmd, **kwargs):
outdir = Path(cmd[cmd.index("-o") + 1])
(outdir / "skillevaluator-output-1.json").write_text(json.dumps(payload))
return subprocess.CompletedProcess(cmd, 1, "", "")
with mock.patch("tools.skillevaluator_scan.shutil.which", return_value="/usr/bin/skillevaluator"), \
mock.patch("tools.skillevaluator_scan.subprocess.run", side_effect=fake_run):
report = run_tier1_scan(tmp_path)
assert report.available
assert not report.passed
assert len(report.findings) == 1
assert report.findings[0].check == "emails"
class TestFormatReport:
def test_unavailable_is_empty(self):
assert format_tier1_report(Tier1Report(available=False)) == ""
def test_findings_show_location_and_secrets_tag(self):
report = _parse_report(_report_json([
_finding("database_credentials", severity="critical",
message="Database connection string with credentials"),
_finding("emails", message="Non-placeholder email address: [email protected]", line=8),
]))
text = format_tier1_report(report)
assert "[SECRETS]" in text
assert "SKILL.md:3" in text
assert "SKILL.md:8" in text
def test_incomplete_checks_noted(self):
raw = _report_json([])
raw["results"].append({
"validator": "Security Scan",
"passed": False,
"status": "incomplete",
"findings": [],
})
text = format_tier1_report(_parse_report(raw))
assert "Security Scan" in text
def test_limit_truncates(self):
findings = [_finding("emails", message=f"m{i}", line=i) for i in range(1, 15)]
report = _parse_report(_report_json(findings))
text = format_tier1_report(report, limit=5)
assert "9 more" in text
class TestConfigGate:
def test_disabled_via_config(self):
with mock.patch("hermes_cli.config.load_config",
return_value={"skills": {"tier1_advisory": False}}):
assert not tier1_advisory_enabled()
def test_string_false_disabled(self):
with mock.patch("hermes_cli.config.load_config",
return_value={"skills": {"tier1_advisory": "false"}}):
assert not tier1_advisory_enabled()
def test_config_error_defaults_enabled(self):
with mock.patch("hermes_cli.config.load_config", side_effect=RuntimeError):
assert tier1_advisory_enabled()
class TestInstallPathHelper:
"""_print_tier1_advisory must never raise and never block."""
def test_helper_never_raises_on_scanner_error(self, tmp_path):
from hermes_cli.skills_hub import _print_tier1_advisory
console = mock.MagicMock()
with mock.patch("tools.skillevaluator_scan.run_tier1_scan",
side_effect=RuntimeError("boom")):
_print_tier1_advisory(tmp_path, console) # must not raise
def test_helper_silent_when_unavailable(self, tmp_path):
from hermes_cli.skills_hub import _print_tier1_advisory
console = mock.MagicMock()
with mock.patch("tools.skillevaluator_scan.run_tier1_scan",
return_value=Tier1Report(available=False)):
_print_tier1_advisory(tmp_path, console)
console.print.assert_not_called()
def test_helper_silent_when_disabled(self, tmp_path):
from hermes_cli.skills_hub import _print_tier1_advisory
console = mock.MagicMock()
with mock.patch("tools.skillevaluator_scan.tier1_advisory_enabled",
return_value=False), \
mock.patch("tools.skillevaluator_scan.run_tier1_scan") as scan:
_print_tier1_advisory(tmp_path, console)
scan.assert_not_called()
console.print.assert_not_called()
def test_helper_prints_findings_and_continues(self, tmp_path):
from hermes_cli.skills_hub import _print_tier1_advisory
console = mock.MagicMock()
report = _parse_report(_report_json([
_finding("emails", message="Non-placeholder email: [email protected]"),
]))
with mock.patch("tools.skillevaluator_scan.run_tier1_scan",
return_value=report):
_print_tier1_advisory(tmp_path, console)
assert console.print.called