mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
417 lines
15 KiB
Python
417 lines
15 KiB
Python
"""Tests for tools/self_repo_guard.py — the running-source-checkout git guard."""
|
|
|
|
import subprocess
|
|
|
|
import pytest
|
|
|
|
from tools.self_repo_guard import (
|
|
detect_self_repo_git_mutation,
|
|
)
|
|
|
|
|
|
@pytest.fixture
|
|
def repo(tmp_path):
|
|
root = tmp_path / "hermes-agent"
|
|
root.mkdir()
|
|
subprocess.run(["git", "init", "-q", str(root)], check=True)
|
|
(root / "agent").mkdir()
|
|
return root.resolve()
|
|
|
|
|
|
def _detect(command, cwd, root):
|
|
return detect_self_repo_git_mutation(command, str(cwd), source_root=root)
|
|
|
|
|
|
class TestBlocksMutationsInSourceRepo:
|
|
@pytest.mark.parametrize(
|
|
"sub",
|
|
[
|
|
"checkout pr-51020",
|
|
"switch main",
|
|
"bisect start",
|
|
"bisect good HEAD~10",
|
|
"reset --hard origin/main",
|
|
"reset --har origin/main",
|
|
"rebase origin/main",
|
|
"merge origin/main",
|
|
"pull",
|
|
"restore .",
|
|
"stash",
|
|
"stash pop",
|
|
"clean -fd",
|
|
"cherry-pick abc123",
|
|
"revert HEAD",
|
|
],
|
|
)
|
|
def test_cwd_inside_repo(self, repo, sub):
|
|
hit, msg = _detect(f"git {sub}", repo, repo)
|
|
assert hit is True
|
|
assert str(repo) in msg
|
|
|
|
def test_cwd_in_repo_subdirectory(self, repo):
|
|
hit, _ = _detect("git checkout main", repo / "agent", repo)
|
|
assert hit is True
|
|
|
|
def test_dash_c_targeting_repo_from_outside(self, repo, tmp_path):
|
|
hit, _ = _detect(f"git -C {repo.as_posix()} checkout pr-51020", tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_cd_into_repo_then_checkout(self, repo, tmp_path):
|
|
hit, _ = _detect(f"cd {repo.as_posix()} && git checkout pr-51020", tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_relative_cd_into_repo(self, repo):
|
|
hit, _ = _detect("cd hermes-agent && git pull", repo.parent, repo)
|
|
assert hit is True
|
|
|
|
def test_mutation_after_safe_command(self, repo):
|
|
hit, _ = _detect("git status; git reset --hard HEAD~1", repo, repo)
|
|
assert hit is True
|
|
|
|
def test_wrapped_in_sudo_env(self, repo):
|
|
hit, _ = _detect("sudo env GIT_PAGER=cat git checkout main", repo, repo)
|
|
assert hit is True
|
|
|
|
@pytest.mark.parametrize(
|
|
"command",
|
|
[
|
|
"sudo -u root git checkout main",
|
|
"env -u GIT_PAGER git switch main",
|
|
"/usr/bin/git checkout main",
|
|
"sh -c 'git checkout main'",
|
|
"bash -lc 'git switch main'",
|
|
"bash -o pipefail -c 'git checkout main'",
|
|
"bash +O extglob -c 'git checkout main'",
|
|
"zsh -yc 'git checkout main'",
|
|
"dash -Vc 'git checkout main'",
|
|
"ksh -Gc 'git checkout main'",
|
|
],
|
|
)
|
|
def test_wrappers_and_nested_shells(self, repo, command):
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is True
|
|
|
|
@pytest.mark.parametrize(
|
|
"command",
|
|
[
|
|
"gh pr checkout 51020",
|
|
"hub pr checkout 51020",
|
|
],
|
|
)
|
|
def test_pr_checkout_clients(self, repo, command):
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is True
|
|
|
|
def test_explicit_work_tree_targeting_repo(self, repo, tmp_path):
|
|
command = f"git --git-dir={(repo / '.git').as_posix()} --work-tree={repo.as_posix()} checkout main"
|
|
hit, _ = _detect(command, tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_git_environment_targeting_repo(self, repo, tmp_path):
|
|
command = f"GIT_DIR={(repo / '.git').as_posix()} GIT_WORK_TREE={repo.as_posix()} git checkout main"
|
|
hit, _ = _detect(command, tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_inline_git_alias(self, repo):
|
|
hit, _ = _detect("git -c alias.co=checkout co main", repo, repo)
|
|
assert hit is True
|
|
|
|
def test_configured_git_alias(self, repo):
|
|
subprocess.run(
|
|
["git", "-C", str(repo), "config", "alias.co", "checkout"],
|
|
check=True,
|
|
)
|
|
hit, _ = _detect("git co main", repo, repo)
|
|
assert hit is True
|
|
|
|
def test_mutation_in_command_substitution(self, repo):
|
|
hit, _ = _detect('echo "$(git checkout main)"', repo, repo)
|
|
assert hit is True
|
|
|
|
@pytest.mark.parametrize(
|
|
"command",
|
|
[
|
|
'echo "$(echo ready && git checkout main)"',
|
|
"echo `git checkout main`",
|
|
'echo "`git checkout main`"',
|
|
],
|
|
)
|
|
def test_nested_command_lists(self, repo, command):
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is True
|
|
|
|
def test_shell_heredoc_is_executed(self, repo):
|
|
command = "bash <<'EOF'\ngit checkout main\nEOF\n"
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is True
|
|
|
|
@pytest.mark.parametrize(
|
|
"command",
|
|
[
|
|
"cat <<'EOF' | bash\ngit checkout main\nEOF\n",
|
|
"cat <<EOF | sudo bash -s\ngit reset --hard\nEOF\n",
|
|
"cat <<'EOF' |& tee log | { echo; bash; }\ngit checkout main\nEOF\n",
|
|
"cat <<'EOF' | (bash) # note\ngit checkout main\nEOF\n",
|
|
# `|` at end of line: the body follows, the consumer comes after the terminator.
|
|
"cat <<'EOF' |\ngit checkout main\nEOF\nbash\n",
|
|
# Backslash-newline is removed before the shell reads the line.
|
|
"cat <<'EOF' | \\\nbash\ngit checkout main\nEOF\n",
|
|
"bash \\\n<<'EOF'\ngit checkout main\nEOF\n",
|
|
"(cat <<'EOF'; echo) | bash\ngit checkout main\nEOF\n",
|
|
],
|
|
)
|
|
def test_heredoc_piped_to_bare_shell_is_executed(self, repo, command):
|
|
"""A heredoc body reaching a bare shell anywhere down its pipeline is a script
|
|
(GitHub issue 112441): the guard scans it like a `bash <<EOF` body."""
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is True
|
|
|
|
@pytest.mark.parametrize(
|
|
("command", "expected"),
|
|
[
|
|
# `2>&1` is an fd redirect, not a `&` list operator ending the pipeline before bash.
|
|
("cat <<'EOF' 2>&1 | bash\ngit checkout main\nEOF\n", True),
|
|
("cat <<'EOF' &>/dev/null | bash\ngit checkout main\nEOF\n", True),
|
|
# The fd number of a redirect is not a script operand: bash is still bare.
|
|
("cat <<'EOF' | bash 2>/dev/null\ngit checkout main\nEOF\n", True),
|
|
("cat <<'EOF' | bash 2>&1\ngit checkout main\nEOF\n", True),
|
|
("cat <<'EOF' | bash >/dev/null\ngit checkout main\nEOF\n", True),
|
|
# A real script operand keeps the body as data; a plain redirect is a file write.
|
|
("cat <<'EOF' | bash run.sh 2>/dev/null\ngit checkout main\nEOF\n", False),
|
|
("cat <<'EOF' > notes.md\ngit checkout main\nEOF\n", False),
|
|
],
|
|
)
|
|
def test_fd_redirects_around_heredoc_pipe(self, repo, command, expected):
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is expected
|
|
|
|
def test_tilde_dash_c_path(self, repo, monkeypatch, tmp_path):
|
|
monkeypatch.setenv("HOME", str(repo.parent))
|
|
monkeypatch.setenv("USERPROFILE", str(repo.parent))
|
|
hit, _ = _detect("git -C ~/hermes-agent checkout main", tmp_path, repo)
|
|
assert hit is True
|
|
|
|
|
|
class TestAllowsSafeCommands:
|
|
@pytest.mark.parametrize(
|
|
"cmd",
|
|
[
|
|
"git status",
|
|
"git log --oneline -5",
|
|
"git diff main...HEAD",
|
|
"git branch --show-current",
|
|
"git stash list",
|
|
"git stash show -p",
|
|
"git stash create",
|
|
"git stash store abc123",
|
|
"git stash drop",
|
|
"git stash clear",
|
|
"git reset --soft HEAD~1",
|
|
"git reset --mixed HEAD~1",
|
|
"git restore --staged pyproject.toml",
|
|
"git clean --dry-run -fd",
|
|
"git clean -nd",
|
|
"git commit -m 'msg'",
|
|
"git add -A",
|
|
"git fetch origin main",
|
|
"git worktree add /tmp/wt feature-branch",
|
|
"git push fork feature-branch",
|
|
"ls -la",
|
|
"grep -rn checkout tools/",
|
|
],
|
|
)
|
|
def test_read_only_and_dev_loop_in_repo(self, repo, cmd):
|
|
hit, _ = _detect(cmd, repo, repo)
|
|
assert hit is False
|
|
|
|
def test_mutation_in_other_repo(self, repo, tmp_path):
|
|
other = tmp_path / "other-project"
|
|
other.mkdir()
|
|
hit, _ = _detect("git checkout main", other, repo)
|
|
assert hit is False
|
|
|
|
def test_dash_c_redirects_out_of_repo(self, repo, tmp_path):
|
|
hit, _ = _detect(f"git -C {tmp_path.as_posix()} checkout main", repo, repo)
|
|
assert hit is False
|
|
|
|
def test_cd_out_of_repo_then_checkout(self, repo, tmp_path):
|
|
hit, _ = _detect(f"cd {tmp_path.as_posix()} && git checkout main", repo, repo)
|
|
assert hit is False
|
|
|
|
def test_mentioning_repo_path_without_targeting_it(self, repo, tmp_path):
|
|
hit, _ = _detect(f"echo {repo.as_posix()} && git checkout main", tmp_path, repo)
|
|
assert hit is False
|
|
|
|
def test_checkout_as_grep_pattern_not_git(self, repo):
|
|
hit, _ = _detect("grep checkout file.txt", repo, repo)
|
|
assert hit is False
|
|
|
|
def test_pr_checkout_words_in_other_gh_command_are_safe(self, repo):
|
|
hit, _ = _detect("gh api /repos/example/pr/checkout", repo, repo)
|
|
assert hit is False
|
|
|
|
@pytest.mark.parametrize(
|
|
"command",
|
|
[
|
|
'echo "safe | git checkout main"',
|
|
"echo '$(git checkout main)'",
|
|
"printf '%s\\n' 'git checkout main'",
|
|
],
|
|
)
|
|
def test_quoted_git_text_is_not_executed(self, repo, command):
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is False
|
|
|
|
@pytest.mark.parametrize(
|
|
"command",
|
|
[
|
|
"cat > script.sh <<'EOF'\ngit checkout main\nEOF\n",
|
|
"python - <<'PY'\nprint('git checkout main')\nPY\n",
|
|
# Downstream consumers that never execute the body, or a shell running a visible
|
|
# script (already scanned as its own command).
|
|
"cat <<'EOF' | grep '| bash'\ngit checkout main\nEOF\n",
|
|
"cat <<'EOF' | bash -c 'echo hi'\ngit checkout main\nEOF\n",
|
|
"cat <<'EOF' | bash run.sh\ngit checkout main\nEOF\n",
|
|
"cat <<'EOF' | python3\ngit checkout main\nEOF\n",
|
|
# `&&` / `;` / a bare newline end the pipeline: that shell never sees the body.
|
|
"cat <<'EOF' && bash\ngit checkout main\nEOF\n",
|
|
"(cat <<'EOF'); bash\ngit checkout main\nEOF\n",
|
|
"cat <<'EOF' | grep x\ngit checkout main\nEOF\nbash\n",
|
|
],
|
|
)
|
|
def test_data_heredoc_is_not_executed_as_shell(self, repo, command):
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is False
|
|
|
|
def test_subshell_cd_does_not_leak(self, repo):
|
|
command = f"(cd {repo.as_posix()} && git status); git checkout main"
|
|
hit, _ = _detect(command, repo.parent, repo)
|
|
assert hit is False
|
|
|
|
def test_pipeline_cd_does_not_leak(self, repo):
|
|
command = f"cd {repo.as_posix()} | cat; git checkout main"
|
|
hit, _ = _detect(command, repo.parent, repo)
|
|
assert hit is False
|
|
|
|
def test_successful_cd_or_branch_does_not_run(self, repo):
|
|
command = f"cd {repo.as_posix()} || git checkout main"
|
|
hit, _ = _detect(command, repo.parent, repo)
|
|
assert hit is False
|
|
|
|
def test_empty_command(self, repo):
|
|
hit, _ = _detect("", repo, repo)
|
|
assert hit is False
|
|
|
|
def test_packaged_install_is_inert(self, monkeypatch, tmp_path):
|
|
import tools.self_repo_guard as mod
|
|
|
|
monkeypatch.setattr(mod, "get_running_source_root", lambda: None)
|
|
hit, msg = mod.detect_self_repo_git_mutation("git checkout main", str(tmp_path))
|
|
assert hit is False
|
|
assert msg is None
|
|
|
|
|
|
class TestWorktreeTargetingSourceRoot:
|
|
@pytest.mark.parametrize(
|
|
"sub",
|
|
[
|
|
"remove .",
|
|
"remove -f .",
|
|
"remove --force .",
|
|
"remove -- .",
|
|
"move . {other}",
|
|
"move -f . {other}",
|
|
],
|
|
)
|
|
def test_blocks_relative_target_from_inside(self, repo, tmp_path, sub):
|
|
command = f"git worktree {sub.format(other=tmp_path / 'moved')}"
|
|
hit, msg = _detect(command, repo, repo)
|
|
assert hit is True
|
|
assert str(repo) in msg
|
|
|
|
@pytest.mark.parametrize("action", ["remove", "remove -f", "remove --force"])
|
|
def test_blocks_absolute_target_from_outside(self, repo, tmp_path, action):
|
|
hit, _ = _detect(f"git worktree {action} {repo.as_posix()}", tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_blocks_move_of_root_from_outside(self, repo, tmp_path):
|
|
command = f"git worktree move {repo.as_posix()} {tmp_path / 'moved'}"
|
|
hit, _ = _detect(command, tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_blocks_dash_c_worktree_remove(self, repo, tmp_path):
|
|
hit, _ = _detect(f"git -C {tmp_path.as_posix()} worktree remove {repo.as_posix()}", tmp_path, repo)
|
|
assert hit is True
|
|
|
|
def test_blocks_parent_relative_target_from_subdirectory(self, repo):
|
|
hit, _ = _detect("git worktree remove ..", repo / "agent", repo)
|
|
assert hit is True
|
|
|
|
def test_blocks_sibling_relative_target(self, repo):
|
|
hit, _ = _detect(f"git worktree remove ../{repo.name}", repo, repo)
|
|
assert hit is True
|
|
|
|
@pytest.mark.parametrize(
|
|
"sub",
|
|
[
|
|
"add {other}",
|
|
"add -b feature {other}",
|
|
"list",
|
|
"list --porcelain",
|
|
"prune",
|
|
"lock {other}",
|
|
"unlock {other}",
|
|
"remove {other}",
|
|
"move {other} {other}-dest",
|
|
],
|
|
)
|
|
def test_allows_other_worktrees_and_add(self, repo, tmp_path, sub):
|
|
command = f"git worktree {sub.format(other=tmp_path / 'other-wt')}"
|
|
hit, _ = _detect(command, repo, repo)
|
|
assert hit is False
|
|
|
|
@pytest.mark.parametrize("sub", ["", "remove", "move", "-f"])
|
|
def test_incomplete_worktree_command_is_not_blocked(self, repo, sub):
|
|
hit, _ = _detect(f"git worktree {sub}".strip(), repo, repo)
|
|
assert hit is False
|
|
|
|
|
|
class TestSourceRootResolution:
|
|
|
|
def test_worktree_git_file_counts(self, tmp_path, monkeypatch):
|
|
import tools.self_repo_guard as mod
|
|
|
|
root = tmp_path / "wt"
|
|
root.mkdir()
|
|
(root / ".git").write_text("gitdir: /somewhere/.git/worktrees/wt\n")
|
|
(root / "tools").mkdir()
|
|
fake_file = root / "tools" / "self_repo_guard.py"
|
|
fake_file.write_text("")
|
|
monkeypatch.setattr(mod, "__file__", str(fake_file))
|
|
assert mod.get_running_source_root() == root.resolve()
|
|
|
|
|
|
class TestUnparseableCommands:
|
|
def test_unbalanced_quotes_fall_back(self, repo):
|
|
hit, _ = _detect('git checkout "unterminated', repo, repo)
|
|
assert hit is True
|
|
|
|
def test_subshell_syntax_does_not_crash(self, repo):
|
|
hit, _ = _detect("VAL=$(git rev-parse HEAD) git checkout main", repo, repo)
|
|
assert hit is True
|
|
|
|
|
|
class TestBlockMessageGuidance:
|
|
"""The block message must steer agents to a disk-backed scratch clone,
|
|
not a bare "temporary clone" (agents defaulted to /tmp, which is tmpfs
|
|
on most distros — parallel salvage clones running npm ci filled a 32GB
|
|
tmpfs to 97% in one campaign)."""
|
|
|
|
|
|
|
|
def test_scratch_hint_honors_hermes_home(self, repo, monkeypatch, tmp_path):
|
|
home = tmp_path / "custom" / "hermes-home"
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
hit, msg = _detect("git rebase origin/main", repo, repo)
|
|
assert hit is True
|
|
assert str(home / "scratch") in msg
|