mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
176 lines
6.4 KiB
Python
176 lines
6.4 KiB
Python
"""``npx -y <pkg>`` should spawn the cached binary, not a resident `npm exec`.
|
|
|
|
`npx` resolves the package and then FORKS, staying alive as the real server's
|
|
parent for the whole process lifetime while doing no work. Measured on a
|
|
4-agent host that is ~48 MB of private memory per MCP server — and it buys
|
|
nothing, because Hermes already wraps the child in its own parent-death
|
|
watchdog, so npx's supervision is a second parent nobody reads.
|
|
|
|
Removing it must stay conservative: a cache miss, a version-pinned spec, or an
|
|
ambiguous ``bin`` map all fall back to plain `npx` so a cold machine still
|
|
installs normally.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import json
|
|
import os
|
|
|
|
import pytest
|
|
|
|
from tools.mcp_tool_config import _npx_cached_bin
|
|
|
|
|
|
def _cache(tmp_path, *, package, deps=None, bin_field, make_bin=True, entry="abc123"):
|
|
"""Build a fake npx cache entry the way npm lays one out."""
|
|
root = tmp_path / ".npm" / "_npx" / entry
|
|
(root / "node_modules" / package).mkdir(parents=True)
|
|
(root / "package.json").write_text(
|
|
json.dumps({"dependencies": deps if deps is not None else {package: "^1.0.0"}}),
|
|
encoding="utf-8",
|
|
)
|
|
(root / "node_modules" / package / "package.json").write_text(
|
|
json.dumps({"name": package, "bin": bin_field}), encoding="utf-8"
|
|
)
|
|
bindir = root / "node_modules" / ".bin"
|
|
bindir.mkdir(parents=True, exist_ok=True)
|
|
name = bin_field if isinstance(bin_field, str) else list(bin_field)[0]
|
|
target = bindir / (os.path.basename(package) if isinstance(bin_field, str) else name)
|
|
if os.name == "nt":
|
|
target = target.with_suffix(".cmd")
|
|
if make_bin:
|
|
target.write_text("#!/usr/bin/env node\n", encoding="utf-8")
|
|
target.chmod(0o755)
|
|
return target
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _isolate_cache(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("npm_config_cache", str(tmp_path / ".npm"))
|
|
yield
|
|
|
|
|
|
def test_cached_package_resolves_to_its_binary(tmp_path):
|
|
target = _cache(tmp_path, package="mcp-linear", bin_field={"mcp-linear": "dist/index.js"})
|
|
|
|
got = _npx_cached_bin(["-y", "mcp-linear"])
|
|
|
|
assert got == (str(target), [])
|
|
|
|
|
|
def test_scoped_package_and_trailing_args_survive(tmp_path):
|
|
target = _cache(
|
|
tmp_path,
|
|
package="@tacticlaunch/mcp-linear",
|
|
bin_field={"mcp-linear": "dist/index.js"},
|
|
)
|
|
|
|
got = _npx_cached_bin(["-y", "@tacticlaunch/mcp-linear", "--port", "7"])
|
|
|
|
assert got == (str(target), ["--port", "7"])
|
|
|
|
|
|
def test_uncached_package_falls_back_to_npx(tmp_path):
|
|
_cache(tmp_path, package="something-else", bin_field={"something-else": "i.js"})
|
|
|
|
assert _npx_cached_bin(["-y", "mcp-linear"]) is None
|
|
|
|
|
|
def test_version_pinned_spec_is_left_to_npx(tmp_path):
|
|
_cache(tmp_path, package="mcp-linear", bin_field={"mcp-linear": "dist/index.js"})
|
|
|
|
# The user pinned a build; npx owns that resolution and the cache key for
|
|
# a different version would not match this entry.
|
|
assert _npx_cached_bin(["-y", "[email protected]"]) is None
|
|
|
|
|
|
def test_ambiguous_bin_map_is_left_to_npx(tmp_path):
|
|
_cache(
|
|
tmp_path,
|
|
package="multi",
|
|
bin_field={"one": "a.js", "two": "b.js"},
|
|
)
|
|
|
|
# Which bin npx would choose is not ours to guess.
|
|
assert _npx_cached_bin(["-y", "multi"]) is None
|
|
|
|
|
|
def test_missing_or_non_executable_binary_falls_back(tmp_path):
|
|
_cache(
|
|
tmp_path,
|
|
package="mcp-linear",
|
|
bin_field={"mcp-linear": "dist/index.js"},
|
|
make_bin=False,
|
|
)
|
|
|
|
assert _npx_cached_bin(["-y", "mcp-linear"]) is None
|
|
|
|
|
|
def test_no_cache_directory_at_all(tmp_path, monkeypatch):
|
|
monkeypatch.setenv("npm_config_cache", str(tmp_path / "nope"))
|
|
|
|
assert _npx_cached_bin(["-y", "mcp-linear"]) is None
|
|
|
|
|
|
def test_corrupt_cache_manifest_is_skipped(tmp_path):
|
|
root = tmp_path / ".npm" / "_npx" / "broken"
|
|
root.mkdir(parents=True)
|
|
(root / "package.json").write_text("{ not json", encoding="utf-8")
|
|
|
|
assert _npx_cached_bin(["-y", "mcp-linear"]) is None
|
|
|
|
|
|
@pytest.mark.parametrize("args", [[], ["-y"], ["--yes"], ["-p", "x"], None, "notalist"])
|
|
def test_unusable_args_are_ignored(args):
|
|
assert _npx_cached_bin(args) is None
|
|
|
|
|
|
@pytest.mark.parametrize("rejected", [False, True])
|
|
def test_preflight_checks_original_package_before_cache_access(tmp_path, monkeypatch, rejected):
|
|
import asyncio
|
|
from tools import mcp_tool
|
|
|
|
target = _cache(tmp_path, package="mcp-linear", bin_field={"mcp-linear": "i.js"})
|
|
args = ["-y", "mcp-linear", "--port", "7"]
|
|
seen = []
|
|
|
|
def check(command, arguments):
|
|
seen.append((command, list(arguments)))
|
|
return "malicious package" if rejected else None
|
|
|
|
monkeypatch.setattr("tools.osv_check.check_package_for_malware", check)
|
|
if rejected:
|
|
monkeypatch.setattr(mcp_tool, "_npx_cached_bin", lambda *a: pytest.fail("cache read before refusal"))
|
|
with pytest.raises(ValueError, match="malicious package"):
|
|
asyncio.run(mcp_tool._preflight_stdio_command("server", "npx", args))
|
|
else:
|
|
assert asyncio.run(mcp_tool._preflight_stdio_command("server", "npx", args)) == (str(target), ["--port", "7"])
|
|
assert seen == [("npx", ["-y", "mcp-linear", "--port", "7"])]
|
|
|
|
|
|
def test_windows_selects_launchers_never_the_sh_script():
|
|
"""On Windows the extensionless sh script must never be chosen.
|
|
|
|
npm lays down three siblings per bin — `<name>`, `<name>.cmd`,
|
|
`<name>.ps1` — and spawning the sh one from a Windows process fails, while
|
|
`os.access(X_OK)` there is effectively an existence check and cannot tell
|
|
them apart. Tested through the injectable helper rather than by patching
|
|
`os.name`, which breaks path handling process-wide (it took pytest's own
|
|
traceback formatting down when I tried).
|
|
"""
|
|
from tools.mcp_tool_config import _npx_bin_candidates
|
|
|
|
win = _npx_bin_candidates("/c/bin", "mcp-linear", windows=True)
|
|
assert win == [os.path.join("/c/bin", "mcp-linear.cmd"), os.path.join("/c/bin", "mcp-linear.exe")]
|
|
assert not any(c.endswith("mcp-linear") for c in win), "sh script must not be a candidate"
|
|
|
|
assert _npx_bin_candidates("/bin", "mcp-linear", windows=False) == [os.path.join("/bin", "mcp-linear")]
|
|
|
|
|
|
|
|
|
|
def test_flag_after_the_spec_is_left_to_npx(tmp_path):
|
|
"""`npx pkg -y` would forward -y to the server; that shape stays with npx."""
|
|
_cache(tmp_path, package="mcp-linear", bin_field={"mcp-linear": "i.js"})
|
|
|
|
assert _npx_cached_bin(["mcp-linear", "-y"]) is None
|