mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
# Conflicts: # AGENTS.md # acp_adapter/edit_approval.py # acp_adapter/server.py # agent/agent_init.py # agent/anthropic_adapter.py # agent/anthropic_credentials.py # agent/auxiliary_client.py # agent/azure_identity_adapter.py # agent/bedrock_adapter.py # agent/browser_registry.py # agent/chat_completion_helpers.py # agent/coding_context.py # agent/context_references.py # agent/conversation_loop.py # agent/copilot_acp_client.py # agent/credits_tracker.py # agent/curator.py # agent/curator_backup.py # agent/deadline.py # agent/display.py # agent/errors.py # agent/estop.py # agent/i18n.py # agent/image_gen_registry.py # agent/image_routing.py # agent/learning_graph.py # agent/learning_mutations.py # agent/lsp/servers.py # agent/model_metadata.py # agent/models_dev.py # agent/monitoring/gateway_health_export.py # agent/monitoring/otlp_exporter.py # agent/pet/store.py # agent/process_bootstrap.py # agent/prompt_builder.py # agent/proxy_sources/iron_proxy.py # agent/secret_sources/_cache.py # agent/secret_sources/bitwarden.py # agent/secret_sources/registry.py # agent/shell_hooks.py # agent/skill_bundles.py # agent/skill_commands.py # agent/skill_utils.py # agent/ssl_guard.py # agent/ssl_verify.py # agent/system_prompt.py # agent/terminal_env_registry.py # agent/trace_upload.py # agent/transcription_registry.py # agent/tts_registry.py # agent/verify/environment.py # agent/vertex_adapter.py # agent/video_gen_registry.py # agent/web_search_registry.py # cli.py # cron/jobs.py # cron/scheduler.py # gateway/agent_cache_pressure.py # gateway/cgroup_cleanup.py # gateway/channel_directory.py # gateway/config.py # gateway/control_socket.py # gateway/dead_targets.py # gateway/drain_control.py # gateway/hooks.py # gateway/kanban_watchers.py # gateway/lifecycle_ledger.py # gateway/mirror.py # gateway/pairing.py # gateway/platform_registry.py # gateway/platforms/helpers.py # gateway/platforms/weixin.py # gateway/readiness.py # gateway/restart_loop_guard.py # gateway/rich_sent_store.py # gateway/run.py # gateway/session.py # gateway/shutdown_flush.py # gateway/shutdown_forensics.py # gateway/slash_commands.py # gateway/status.py # gateway/sticker_cache.py # gateway/whatsapp_identity.py # hermes_bootstrap.py # hermes_cli/_early_recovery.py # hermes_cli/_install_repair.py # hermes_cli/_startup_fast.py # hermes_cli/_subprocess_compat.py # hermes_cli/agent_plugins.py # hermes_cli/auth.py # hermes_cli/backup.py # hermes_cli/banner.py # hermes_cli/browser_connect.py # hermes_cli/build_info.py # hermes_cli/cli_agent_setup_mixin.py # hermes_cli/cli_commands_mixin.py # hermes_cli/codex_models.py # hermes_cli/config.py # hermes_cli/config_defaults.py # hermes_cli/config_migrations.py # hermes_cli/container_boot.py # hermes_cli/dashboard_auth/registry.py # hermes_cli/debug.py # hermes_cli/dep_ensure.py # hermes_cli/doctor.py # hermes_cli/doctor_live.py # hermes_cli/dump.py # hermes_cli/env_loader.py # hermes_cli/foreign_sessions.py # hermes_cli/gateway.py # hermes_cli/gateway_windows.py # hermes_cli/gui_uninstall.py # hermes_cli/image_provenance.py # hermes_cli/install_identity.py # hermes_cli/kanban.py # hermes_cli/kanban_db.py # hermes_cli/linux_desktop_entry.py # hermes_cli/local_runtime/binaries.py # hermes_cli/local_runtime/endpoint.py # hermes_cli/local_runtime/growth.py # hermes_cli/local_runtime/supervisor.py # hermes_cli/logs.py # hermes_cli/macos_tcc_anchor.py # hermes_cli/main.py # hermes_cli/memory_setup.py # hermes_cli/model_catalog.py # hermes_cli/models.py # hermes_cli/nous_subscription.py # hermes_cli/npm_engine.py # hermes_cli/plugin_index.py # hermes_cli/plugins.py # hermes_cli/plugins_cmd.py # hermes_cli/profile_distribution.py # hermes_cli/profiles.py # hermes_cli/prompt_size.py # hermes_cli/psutil_android.py # hermes_cli/runtime_repair.py # hermes_cli/security_advisories.py # hermes_cli/security_audit.py # hermes_cli/security_audit_startup.py # hermes_cli/service_manager.py # hermes_cli/session_export_md.py # hermes_cli/setup.py # hermes_cli/skills_hub.py # hermes_cli/slack_cli.py # hermes_cli/status.py # hermes_cli/subcommands/gateway.py # hermes_cli/subcommands/uninstall.py # hermes_cli/tools_config.py # hermes_cli/uninstall.py # hermes_cli/update_cmd.py # hermes_cli/update_contract.py # hermes_cli/update_inventory.py # hermes_cli/update_lock.py # hermes_cli/update_receipt.py # hermes_cli/urllib_security.py # hermes_cli/web_routers/local_models.py # hermes_cli/web_routers/profiles.py # hermes_cli/web_routers/skills.py # hermes_cli/web_server.py # hermes_constants.py # hermes_state.py # plugins/disk-cleanup/__init__.py # plugins/disk-cleanup/disk_cleanup.py # plugins/google_meet/node/registry.py # plugins/google_meet/node/server.py # plugins/google_meet/process_manager.py # plugins/google_meet/realtime/openai_client.py # plugins/hermes-achievements/dashboard/plugin_api.py # plugins/memory/hindsight/__init__.py # plugins/memory/honcho/__init__.py # plugins/memory/honcho/cli.py # plugins/memory/honcho/client.py # plugins/memory/honcho/oauth.py # plugins/memory/honcho/session.py # plugins/memory/mem0/__init__.py # plugins/memory/mem0/_setup.py # plugins/memory/openviking/__init__.py # plugins/memory/retaindb/__init__.py # plugins/memory/supermemory/__init__.py # plugins/platforms/a2a/protocol.py # plugins/platforms/dingtalk/adapter.py # plugins/platforms/discord/adapter.py # plugins/platforms/feishu/adapter.py # plugins/platforms/google_chat/adapter.py # plugins/platforms/matrix/adapter.py # plugins/platforms/photon/adapter.py # plugins/platforms/photon/auth.py # plugins/platforms/photon/cli.py # plugins/platforms/slack/adapter.py # plugins/platforms/teams/adapter.py # plugins/platforms/telegram/adapter.py # plugins/platforms/wecom/callback_adapter.py # plugins/platforms/whatsapp/adapter.py # plugins/teams_pipeline/store.py # plugins/video_gen/fal/__init__.py # plugins/web/ddgs/provider.py # plugins/web/exa/provider.py # plugins/web/firecrawl/provider.py # plugins/web/parallel/provider.py # tests/agent/test_ssl_ca_guard.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_cmd_update_apt.py # tests/hermes_cli/test_dashboard_unified_launch.py # tests/hermes_cli/test_dep_ensure.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_live.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_kanban_boards.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_memory_setup_provider_arg.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_pip_install_detection.py # tests/hermes_cli/test_profile_export_credentials.py # tests/hermes_cli/test_psutil_android_extract.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_tui_npm_install.py # tests/hermes_cli/test_update_fleet_restart_pending.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_ui_build.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/tools/test_browser_chromium_autoinstall.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_lightpanda.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_open_timeout.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_suspect_recycle.py # tests/tools/test_find_shell.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_macos_protected_search.py # tests/tui_gateway/test_compute_host.py # tools/approval.py # tools/blueprints.py # tools/bot_mode_dm.py # tools/bot_mode_probe.py # tools/bot_relay.py # tools/browser_tool.py # tools/browser_use_cli.py # tools/checkpoint_manager.py # tools/code_execution_tool.py # tools/code_kernel.py # tools/computer_use/cua_backend.py # tools/cronjob_tools.py # tools/discord_tool.py # tools/environments/base.py # tools/environments/daytona.py # tools/environments/local.py # tools/environments/modal.py # tools/environments/vercel_sandbox.py # tools/fal_common.py # tools/file_operations.py # tools/lazy_deps.py # tools/mcp_tool.py # tools/neutts_synth.py # tools/process_registry.py # tools/read_extract.py # tools/registry.py # tools/skill_ledger.py # tools/skill_linter.py # tools/skill_manager_tool.py # tools/skill_usage.py # tools/skills_ast_audit.py # tools/skills_guard.py # tools/skills_hub.py # tools/skills_sync.py # tools/skills_sync_client.py # tools/skills_tool.py # tools/terminal_scope.py # tools/terminal_tool.py # tools/tirith_security.py # tools/transcription_tools.py # tools/tts_tool.py # tools/vision_tools.py # tools/voice_mode.py # tools/wake_word.py # tools/web_result_cache.py # tools/website_policy.py # tools/working_diff.py # tools/write_approval.py # tui_gateway/entry.py # tui_gateway/methods_tools.py # tui_gateway/server.py
168 lines
6.1 KiB
Python
168 lines
6.1 KiB
Python
"""Tests for LocalEnvironment recovery when ``self.cwd`` is deleted.
|
|
|
|
When a tool call inside the persistent terminal session ``rm -rf``'s its own
|
|
working directory, the next ``subprocess.Popen(..., cwd=self.cwd)`` would
|
|
otherwise raise ``FileNotFoundError`` before bash starts, wedging every
|
|
subsequent terminal/file-tool call until the gateway restarts.
|
|
|
|
Regression coverage for https://github.com/NousResearch/hermes-agent/issues/17558.
|
|
"""
|
|
import pytest
|
|
|
|
import os
|
|
import shutil
|
|
import tempfile
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
from tools.environments.local import (
|
|
LocalEnvironment,
|
|
_resolve_safe_cwd,
|
|
)
|
|
|
|
|
|
class TestResolveSafeCwd:
|
|
"""Pure-function unit tests for the recovery helper."""
|
|
|
|
def test_returns_cwd_when_directory_exists(self, tmp_path):
|
|
path = str(tmp_path)
|
|
assert _resolve_safe_cwd(path) == path
|
|
|
|
|
|
@pytest.mark.platforms("linux")
|
|
def test_returns_root_when_only_root_exists(self, monkeypatch):
|
|
"""If every ancestor except the filesystem root is gone, the root
|
|
itself is still a valid recovery target — don't skip it just because
|
|
``os.path.dirname('/') == '/'`` is the loop's exit condition."""
|
|
sep = os.path.sep
|
|
monkeypatch.setattr(os.path, "isdir", lambda p: p == sep)
|
|
assert _resolve_safe_cwd("/no/such/deep/dir") == sep
|
|
|
|
|
|
def _make_fake_popen(captured: dict, fds: list):
|
|
"""Build a fake ``Popen`` whose ``stdout`` exposes a real OS file
|
|
descriptor so ``BaseEnvironment._wait_for_process`` can call
|
|
``select.select([fd], ...)`` and ``os.read(fd, ...)`` against it without
|
|
tripping ``TypeError: fileno() returned a non-integer`` from a MagicMock
|
|
``fileno()`` (or worse, accidentally reading from the test runner's own
|
|
stdout).
|
|
|
|
The pipe's write end is closed immediately so the drain loop sees EOF on
|
|
the first iteration. Every fd handed out is appended to ``fds`` so the
|
|
caller can clean up after the test.
|
|
"""
|
|
def fake_popen(cmd, **kwargs):
|
|
captured["cwd"] = kwargs.get("cwd")
|
|
captured["env"] = kwargs.get("env", {})
|
|
read_fd, write_fd = os.pipe()
|
|
os.close(write_fd)
|
|
stdout = os.fdopen(read_fd, "rb", buffering=0)
|
|
fds.append(stdout)
|
|
proc = MagicMock()
|
|
proc.poll.return_value = 0
|
|
proc.returncode = 0
|
|
proc.stdout = stdout
|
|
proc.stdin = MagicMock()
|
|
return proc
|
|
return fake_popen
|
|
|
|
|
|
def _close_fds(fds):
|
|
for f in fds:
|
|
try:
|
|
f.close()
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
class TestRunBashCwdRecovery:
|
|
"""End-to-end recovery: deleted ``self.cwd`` must not crash Popen."""
|
|
|
|
def test_recovers_when_cwd_deleted_after_init(self, tmp_path, caplog):
|
|
"""Reproduces the wedge from #17558: cwd was valid when the
|
|
snapshot was taken, but a subsequent command deleted it before the
|
|
next ``Popen``."""
|
|
wedged = tmp_path / "wedge-repro"
|
|
wedged.mkdir()
|
|
|
|
with patch.object(LocalEnvironment, "init_session", autospec=True, return_value=None):
|
|
env = LocalEnvironment(cwd=str(wedged), timeout=10)
|
|
|
|
# The previous tool call deleted the working directory.
|
|
shutil.rmtree(wedged)
|
|
assert env.cwd == str(wedged) and not os.path.isdir(env.cwd)
|
|
|
|
captured = {}
|
|
fds: list = []
|
|
try:
|
|
with patch("tools.environments.local._find_bash", return_value="/bin/bash"), \
|
|
patch("subprocess.Popen", side_effect=_make_fake_popen(captured, fds)), \
|
|
caplog.at_level("WARNING", logger="tools.environments.local"):
|
|
env.execute("echo hello")
|
|
finally:
|
|
_close_fds(fds)
|
|
|
|
# Popen must have been handed a real, existing directory.
|
|
assert captured["cwd"] == str(tmp_path)
|
|
assert os.path.isdir(captured["cwd"])
|
|
|
|
# ``self.cwd`` is updated so the next call doesn't re-warn.
|
|
assert env.cwd == str(tmp_path)
|
|
|
|
# The warning surfaces the wedge so it isn't silently masked.
|
|
assert any("missing on disk" in rec.message for rec in caplog.records)
|
|
|
|
def test_no_warning_when_cwd_still_exists(self, tmp_path, caplog):
|
|
with patch.object(LocalEnvironment, "init_session", autospec=True, return_value=None):
|
|
env = LocalEnvironment(cwd=str(tmp_path), timeout=10)
|
|
|
|
captured = {}
|
|
fds: list = []
|
|
try:
|
|
with patch("tools.environments.local._find_bash", return_value="/bin/bash"), \
|
|
patch("subprocess.Popen", side_effect=_make_fake_popen(captured, fds)), \
|
|
caplog.at_level("WARNING", logger="tools.environments.local"):
|
|
env.execute("echo hello")
|
|
finally:
|
|
_close_fds(fds)
|
|
|
|
assert captured["cwd"] == str(tmp_path)
|
|
assert env.cwd == str(tmp_path)
|
|
assert not any("missing on disk" in rec.message for rec in caplog.records)
|
|
|
|
|
|
class TestUpdateCwdRejectsMissingPaths:
|
|
"""``_update_cwd`` must not propagate a deleted path back into ``self.cwd``."""
|
|
|
|
def test_skips_assignment_when_marker_path_missing(self, tmp_path):
|
|
original = tmp_path / "starting"
|
|
original.mkdir()
|
|
|
|
with patch.object(LocalEnvironment, "init_session", autospec=True, return_value=None):
|
|
env = LocalEnvironment(cwd=str(original), timeout=10)
|
|
|
|
# Simulate the stale-marker case: the prior command emitted a cwd
|
|
# marker for a directory that has since been deleted.
|
|
deleted = tmp_path / "wedge-repro"
|
|
marker = env._cwd_marker
|
|
|
|
env._update_cwd(
|
|
{"output": f"x\n{marker}{deleted}{marker}\n", "returncode": 0}
|
|
)
|
|
|
|
assert env.cwd == str(original)
|
|
|
|
def test_accepts_assignment_when_marker_path_exists(self, tmp_path):
|
|
original = tmp_path / "starting"
|
|
original.mkdir()
|
|
new_dir = tmp_path / "next"
|
|
new_dir.mkdir()
|
|
|
|
with patch.object(LocalEnvironment, "init_session", autospec=True, return_value=None):
|
|
env = LocalEnvironment(cwd=str(original), timeout=10)
|
|
marker = env._cwd_marker
|
|
|
|
env._update_cwd(
|
|
{"output": f"x\n{marker}{new_dir}{marker}\n", "returncode": 0}
|
|
)
|
|
|
|
assert env.cwd == str(new_dir)
|