mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
The OS lanes are marker-driven: list_os_marked_tests.py picks the files
a lane imports from their platforms() specs and the lane selects with
-m platforms. A test gated with skipif(sys.platform != "win32") is
therefore never imported on the Windows lane and skipped everywhere else
— it runs on no host. skipif(sys.platform == "win32") tests were merely
invisible to the lane bookkeeping, but the rule the tree now follows is
one host marker, never a bare skipif.
Mechanical mapping, semantics preserved: skip-on-Windows → "posix",
skip-off-Windows → "windows", skip-off-Linux → "linux", skip-on-macOS →
"not macos". The former skip reasons stay as trailing comments. A
non-host condition (os.geteuid() == 0) stays a separate skipif beside
the marker, spelled getattr(os, "geteuid", ...) so the decorator still
imports on Windows.
Where the conversion would stack two platforms() marks on one test (the
conftest rejects that at collection) the narrower mark wins:
- test_update_wedged_gateway: the class is already platforms("linux");
its per-test "needs UNIX sockets" marks were redundant and are gone.
- test_process_registry.TestSystemdCgroupIsolation: the class-level
skip-on-Windows moves onto the 11 methods that had no host mark; the
11 platforms("linux") methods keep theirs.
- test_file_ops_single_roundtrip: the two fifo tests drop their
platforms("linux") in favour of the module's "posix" (mkfifo exists on
macOS; both tests already skip when it does not).
- test_linux_desktop_entry / test_gateway_job_teardown_live: duplicate
or wider marks removed.
74 lines
2.6 KiB
Python
74 lines
2.6 KiB
Python
"""Regression tests for inaccessible-cwd fallback (#65583).
|
|
|
|
``/root`` leaking into a non-root gateway/cron process's terminal cwd used to
|
|
kill every command with ``PermissionError: [Errno 13] Permission denied:
|
|
'/root'`` — ``os.path.isdir('/root')`` is True for a non-root user (stat only
|
|
needs search permission on ``/``), so the old existence-only check in
|
|
``_resolve_safe_cwd`` happily returned a directory ``subprocess.Popen`` could
|
|
not enter. The fix checks X_OK and falls back to the nearest usable ancestor.
|
|
"""
|
|
|
|
import os
|
|
import sys
|
|
import tempfile
|
|
|
|
import pytest
|
|
|
|
from tools.environments.local import LocalEnvironment, _cwd_usable, _resolve_safe_cwd
|
|
|
|
|
|
@pytest.fixture
|
|
def denied_dir(tmp_path):
|
|
"""A directory that exists but cannot be entered (simulates /root)."""
|
|
d = tmp_path / "rootlike"
|
|
d.mkdir()
|
|
d.chmod(0)
|
|
yield d
|
|
d.chmod(0o755) # so pytest can clean up
|
|
|
|
|
|
needs_non_root = pytest.mark.skipif(
|
|
getattr(os, "geteuid", lambda: 1)() == 0, reason="chmod-based access denial needs non-root"
|
|
)
|
|
|
|
|
|
@pytest.mark.platforms("posix") # chmod-based access denial needs POSIX
|
|
@needs_non_root
|
|
class TestInaccessibleCwdFallback:
|
|
def test_cwd_usable_rejects_unenterable_directory(self, denied_dir):
|
|
assert os.path.isdir(denied_dir) # the trap: stat succeeds
|
|
assert _cwd_usable(str(denied_dir)) is False
|
|
|
|
|
|
def test_resolve_safe_cwd_climbs_past_denied_ancestor(self, denied_dir, tmp_path):
|
|
missing_child = str(denied_dir / "sub" / "dir")
|
|
resolved = _resolve_safe_cwd(missing_child)
|
|
assert os.access(resolved, os.X_OK)
|
|
assert resolved == str(tmp_path)
|
|
|
|
def test_local_environment_survives_denied_cwd(self, denied_dir):
|
|
"""The #65583 shape: env constructed with an unenterable cwd must
|
|
still execute commands instead of raising PermissionError."""
|
|
env = LocalEnvironment(cwd=str(denied_dir), timeout=30)
|
|
try:
|
|
handle = env._run_bash("echo ALIVE")
|
|
out = handle.stdout.read() if handle.stdout else b""
|
|
rc = handle.wait(timeout=15)
|
|
assert rc == 0
|
|
assert b"ALIVE" in (out if isinstance(out, bytes) else out.encode())
|
|
finally:
|
|
try:
|
|
env.cleanup()
|
|
except Exception:
|
|
pass
|
|
|
|
|
|
class TestUsableCwdBehaviorUnchanged:
|
|
def test_existing_accessible_cwd_returned_verbatim(self, tmp_path):
|
|
assert _resolve_safe_cwd(str(tmp_path)) == str(tmp_path)
|
|
|
|
|
|
def test_hopeless_path_falls_back_to_tempdir(self):
|
|
# A path whose every component is missing outside any real tree.
|
|
resolved = _resolve_safe_cwd("")
|
|
assert resolved == tempfile.gettempdir()
|