hermes-agent/tests/tools/test_kanban_persisted_identity.py
teknium1 9267706d6e fix(kanban): board identity follows the bound profile override, not the launch env
One resolver, hermes_cli.profiles.current_profile_name(): the HERMES_HOME override
(a multiplexed cron tick or routed gateway turn) names the profile first; the
dispatcher's HERMES_PROFILE pin is consulted only when no override is bound; the
process home last. #112888 added the HERMES_HOME-derived fallback but kept the env
pin FIRST, so under a multiplexer whose launch process carries a HERMES_PROFILE the
served profile's writes were still re-labelled with the host's name. The same
resolver replaces the per-module copies in hermes_cli/kanban.py, kanban_specify.py,
cron/lifecycle_guard.py and the kanban notify-target default.

Tests trimmed to two invariants (A->B->A under the override; control pin + generic
absence).

Closes #119859
Supersedes #112888
2026-09-23 08:09:47 -07:00

101 lines
4.1 KiB
Python

"""Board identity follows the profile a kanban call runs FOR, never the generic ``"worker"``.
``kanban_comment`` / ``kanban_create`` used to read ``os.environ["HERMES_PROFILE"]`` and fall back to
``"worker"``. A multiplexed per-profile cron tick binds the profile as a ``HERMES_HOME`` override and
never mirrors it into ``os.environ``, so every card comment a served profile's turn wrote was
authored ``"worker"`` (#119859). ``hermes_cli.profiles.current_profile_name`` is the one resolver:
the bound override first, the dispatcher's ``HERMES_PROFILE`` pin only outside an override, the
process home last. Identity never comes from tool args (#19713).
"""
from __future__ import annotations
import json
import pytest
from hermes_constants import reset_hermes_home_override, set_hermes_home_override
@pytest.fixture
def board_env(tmp_path, monkeypatch):
"""A root-profile board with two served profiles beside it and no env pin at all."""
root = tmp_path / "hroot"
for name in ("alpha", "beta"):
(root / "profiles" / name).mkdir(parents=True)
monkeypatch.setenv("HERMES_HOME", str(root))
for var in ("HERMES_PROFILE", "HERMES_PROFILE_NAME", "HERMES_SESSION_ID", "HERMES_KANBAN_DB",
"HERMES_KANBAN_HOME", "HERMES_KANBAN_BOARD", "HERMES_KANBAN_WORKSPACES_ROOT"):
monkeypatch.delenv(var, raising=False)
from hermes_cli import kanban_db as kb
from hermes_cli import kanban_db_connect as kbc
kb._INITIALIZED_PATHS.clear()
kb.init_db()
conn = kbc.connect()
try:
tid = kb.create_task(conn, title="identity-test", assignee="alpha")
kb.claim_task(conn, tid)
finally:
conn.close()
monkeypatch.setenv("HERMES_KANBAN_TASK", tid)
return root, tid
def _last_comment_author(tid: str) -> str:
from hermes_cli import kanban_db as kb
from hermes_cli import kanban_db_connect as kbc
conn = kbc.connect()
try:
return kb.list_comments(conn, tid)[-1].author
finally:
conn.close()
def _created_by(tid: str) -> str:
from hermes_cli import kanban_db as kb
from hermes_cli import kanban_db_connect as kbc
conn = kbc.connect()
try:
return kb.get_task(conn, tid).created_by
finally:
conn.close()
def test_a_served_profiles_tick_authors_board_records_as_that_profile(board_env, monkeypatch):
"""A→B→A under the home override with ``HERMES_PROFILE`` unset (the multiplexed tick shape):
comment author and ``created_by`` are the ticking profile's, never ``"worker"``. A launch-side
``HERMES_PROFILE`` pin does not re-label a served profile's writes."""
from tools import kanban_tools as kt
root, tid = board_env
monkeypatch.setenv("HERMES_PROFILE", "launch-host") # the launch process's own pin
for name in ("alpha", "beta", "alpha"):
token = set_hermes_home_override(root / "profiles" / name)
try:
out = json.loads(kt._handle_comment({"task_id": tid, "body": f"from {name}"}))
assert out["ok"], out
assert _last_comment_author(tid) == name
child = json.loads(kt._handle_create(
{"title": f"{name} child", "assignee": "peer", "parents": [tid]}))
assert child["ok"], child
assert _created_by(child["task_id"]) == name
finally:
reset_hermes_home_override(token)
def test_a_dispatched_worker_keeps_its_pinned_identity_and_an_unnamed_caller_stays_generic(
board_env, monkeypatch):
"""Control: no override → the dispatcher's ``HERMES_PROFILE`` pin wins over the process home;
absence: nothing names a profile and the home is not a profile → ``"worker"``."""
from tools import kanban_tools as kt
root, tid = board_env
monkeypatch.setenv("HERMES_PROFILE", "pinned-bot")
assert json.loads(kt._handle_comment({"task_id": tid, "body": "from env"}))["ok"]
assert _last_comment_author(tid) == "pinned-bot"
monkeypatch.delenv("HERMES_PROFILE")
import hermes_cli.profiles as profiles
monkeypatch.setattr(profiles, "get_active_profile_name", lambda: "")
assert json.loads(kt._handle_comment({"task_id": tid, "body": "anon"}))["ok"]
assert _last_comment_author(tid) == "worker"