hermes-agent/tests/tools/test_cronjob_run_background.py
ethernet 890bbbda1f Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts
#	apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts
#	apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts
#	apps/desktop/e2e/bot-mode-roster-localized.spec.ts
#	apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts
#	apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts
#	apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts
#	apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts
#	apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts
#	apps/desktop/e2e/bot-roster-user-sections.spec.ts
#	apps/desktop/e2e/bot-routines-pane-narrow.spec.ts
#	apps/desktop/e2e/bot-row-open-recent-session.spec.ts
#	apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts
#	apps/desktop/e2e/group-composer-auto-grow.spec.ts
#	apps/desktop/e2e/group-create-gate-remote-roster.spec.ts
#	apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts
#	apps/desktop/e2e/hosted-room-backend-continuity.spec.ts
#	apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts
#	apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts
#	apps/desktop/e2e/worktree-branch-status.spec.ts
#	apps/desktop/electron/backend-probes.test.ts
#	apps/desktop/electron/connection-apply.test.ts
#	apps/desktop/electron/desktop-electron-pin.test.ts
#	apps/desktop/electron/desktop-uninstall.test.ts
#	apps/desktop/electron/gateway-file-download-transport.test.ts
#	apps/desktop/electron/gateway-stop-before-update.test.ts
#	apps/desktop/electron/github-api-auth.test.ts
#	apps/desktop/electron/registry-primary-profile-scope.test.ts
#	apps/desktop/electron/update-api-check.test.ts
#	apps/desktop/electron/update-handoff-marker.test.ts
#	apps/desktop/electron/venv-blocker-scan.test.ts
#	apps/desktop/scripts/after-extract.test.mjs
#	apps/desktop/scripts/local-pack-publish.test.mjs
#	apps/desktop/scripts/tasks-scroll.test.mjs
#	apps/desktop/src/app/settings/model-settings.test.tsx
#	apps/desktop/src/app/updates-overlay.blockers.test.tsx
#	apps/desktop/src/components/desktop-install-overlay.test.tsx
#	apps/desktop/src/lib/update-copy.test.ts
#	scripts/ci/check_os_marker_fakes.py
#	tests-js/desktop-mac-usage-descriptions.test.ts
#	tests-js/node-engine-alignment.test.ts
#	tests/agent/lsp/test_install_and_lint_fixes.py
#	tests/agent/test_command_token_source.py
#	tests/agent/test_compression_boundary_hook.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/agent/test_custom_provider_ca_probes.py
#	tests/agent/test_endpoint_blackhole.py
#	tests/agent/test_estimator_parity.py
#	tests/agent/test_in_place_compaction.py
#	tests/agent/test_moa_loop_mode.py
#	tests/agent/test_model_metadata.py
#	tests/agent/test_skill_session_platform_gate.py
#	tests/agent/test_skill_utils.py
#	tests/agent/test_ssl_ca_guard.py
#	tests/computer_use/test_doctor.py
#	tests/cron/test_codex_execution_paths.py
#	tests/cron/test_cron_bot_chat_delivery.py
#	tests/cron/test_cron_script.py
#	tests/cron/test_media_delivery_parity.py
#	tests/cron/test_misfire_catchup.py
#	tests/cron/test_parallel_pool.py
#	tests/cron/test_recurring_eagain_redispatch.py
#	tests/gateway/test_choice_picker.py
#	tests/gateway/test_control_socket_windows_live.py
#	tests/gateway/test_dingtalk.py
#	tests/gateway/test_feishu.py
#	tests/gateway/test_feishu_onboard.py
#	tests/gateway/test_gateway_shutdown.py
#	tests/gateway/test_matrix.py
#	tests/gateway/test_model_command_custom_providers.py
#	tests/gateway/test_reasoning_command.py
#	tests/gateway/test_runtime_footer.py
#	tests/gateway/test_session.py
#	tests/gateway/test_session_hygiene.py
#	tests/gateway/test_status.py
#	tests/gateway/test_teams.py
#	tests/gateway/test_turn_lease.py
#	tests/gateway/test_whatsapp_connect.py
#	tests/hermes_cli/test_approvals_command.py
#	tests/hermes_cli/test_auth_store_lock_concurrent.py
#	tests/hermes_cli/test_backup.py
#	tests/hermes_cli/test_banner_git_state.py
#	tests/hermes_cli/test_certifi_repair.py
#	tests/hermes_cli/test_cmd_update.py
#	tests/hermes_cli/test_compat_manifest_targets.py
#	tests/hermes_cli/test_computer_use_cli.py
#	tests/hermes_cli/test_cpr_local_leak.py
#	tests/hermes_cli/test_dashboard_auth_gate.py
#	tests/hermes_cli/test_dashboard_procs_kill_grace.py
#	tests/hermes_cli/test_desktop_lifecycle_windows_live.py
#	tests/hermes_cli/test_doctor.py
#	tests/hermes_cli/test_doctor_command_install.py
#	tests/hermes_cli/test_fleet_config_migration_windows_live.py
#	tests/hermes_cli/test_gateway.py
#	tests/hermes_cli/test_gateway_platform_gating.py
#	tests/hermes_cli/test_gateway_restart_loop.py
#	tests/hermes_cli/test_gateway_task_probe.py
#	tests/hermes_cli/test_gateway_wsl.py
#	tests/hermes_cli/test_gui_command.py
#	tests/hermes_cli/test_install_cua_driver.py
#	tests/hermes_cli/test_kanban_db.py
#	tests/hermes_cli/test_lazy_command_exports.py
#	tests/hermes_cli/test_lazy_refresh_venv_repair.py
#	tests/hermes_cli/test_linux_desktop_entry.py
#	tests/hermes_cli/test_local_runtime.py
#	tests/hermes_cli/test_local_runtime_updates.py
#	tests/hermes_cli/test_managed_uv.py
#	tests/hermes_cli/test_mcp_reload_confirm_gate.py
#	tests/hermes_cli/test_nous_subscription.py
#	tests/hermes_cli/test_npm_engine.py
#	tests/hermes_cli/test_personality_none.py
#	tests/hermes_cli/test_pet_toggle.py
#	tests/hermes_cli/test_plan_reconciliation_windows_live.py
#	tests/hermes_cli/test_plugin_event_bus.py
#	tests/hermes_cli/test_plugin_manifest_v2.py
#	tests/hermes_cli/test_plugin_packs.py
#	tests/hermes_cli/test_plugins_cmd.py
#	tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py
#	tests/hermes_cli/test_process_identity.py
#	tests/hermes_cli/test_profiles.py
#	tests/hermes_cli/test_profiles_sidebar_cache.py
#	tests/hermes_cli/test_pty_bridge.py
#	tests/hermes_cli/test_resolve_turn_limit.py
#	tests/hermes_cli/test_serve_runtime_inventory.py
#	tests/hermes_cli/test_session_vacuum_config.py
#	tests/hermes_cli/test_set_config_value.py
#	tests/hermes_cli/test_signal_handler_kanban_worker.py
#	tests/hermes_cli/test_slash_confirm_windows.py
#	tests/hermes_cli/test_stale_pid_guard.py
#	tests/hermes_cli/test_startup_fast_guards.py
#	tests/hermes_cli/test_status.py
#	tests/hermes_cli/test_telegram_managed_bot.py
#	tests/hermes_cli/test_tools_config.py
#	tests/hermes_cli/test_update_apply_shallow_count.py
#	tests/hermes_cli/test_update_autostash.py
#	tests/hermes_cli/test_update_concurrent_quarantine.py
#	tests/hermes_cli/test_update_fetch_failure_classifier.py
#	tests/hermes_cli/test_update_fleet_probe_resume_token.py
#	tests/hermes_cli/test_update_handoff_backend_reap.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_update_head_moved_gate.py
#	tests/hermes_cli/test_update_host_obligation.py
#	tests/hermes_cli/test_update_import_guard.py
#	tests/hermes_cli/test_update_interrupted_recovery.py
#	tests/hermes_cli/test_update_inventory.py
#	tests/hermes_cli/test_update_launchd_unloaded_gateway.py
#	tests/hermes_cli/test_update_missing_configured_deps.py
#	tests/hermes_cli/test_update_modified_notice.py
#	tests/hermes_cli/test_update_multiplex_migration_hook.py
#	tests/hermes_cli/test_update_no_gateway_restart.py
#	tests/hermes_cli/test_update_orphan_backend_reap.py
#	tests/hermes_cli/test_update_parked_branch_guard.py
#	tests/hermes_cli/test_update_post_pull_syntax_guard.py
#	tests/hermes_cli/test_update_receipt.py
#	tests/hermes_cli/test_update_self_lock.py
#	tests/hermes_cli/test_update_shim_fail_closed.py
#	tests/hermes_cli/test_update_shim_self_lock.py
#	tests/hermes_cli/test_update_sqlite_remediation.py
#	tests/hermes_cli/test_update_stale_dashboard.py
#	tests/hermes_cli/test_update_stale_virtualenv.py
#	tests/hermes_cli/test_update_venv_health.py
#	tests/hermes_cli/test_update_venv_ownership_preflight.py
#	tests/hermes_cli/test_update_wedged_gateway.py
#	tests/hermes_cli/test_update_yes_flag.py
#	tests/hermes_cli/test_update_zip_two_phase.py
#	tests/hermes_cli/test_urllib_security.py
#	tests/hermes_cli/test_ux_messages_auth_config.py
#	tests/hermes_cli/test_ux_messages_startup.py
#	tests/hermes_cli/test_venv_holder_classifier.py
#	tests/hermes_cli/test_verify_console_scripts.py
#	tests/hermes_cli/test_verify_core_dependencies.py
#	tests/hermes_cli/test_web_server.py
#	tests/hermes_cli/test_web_server_console_ws.py
#	tests/hermes_cli/test_web_server_ws_ping.py
#	tests/hermes_cli/test_web_ui_build.py
#	tests/hermes_state/test_fts_rebuild_admission.py
#	tests/hermes_state/test_hermes_state.py
#	tests/plugins/memory/test_memory_lazy_install.py
#	tests/plugins/test_google_meet_plugin.py
#	tests/plugins/test_langfuse_plugin.py
#	tests/plugins/test_security_guidance_plugin.py
#	tests/plugins/test_transform_llm_output_hook.py
#	tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_contributor_map.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/skills/test_competitor_news_monitor_skill.py
#	tests/skills/test_document_to_action_items_skill.py
#	tests/skills/test_google_workspace_setup.py
#	tests/skills/test_google_workspace_setup_deps.py
#	tests/skills/test_grounded_citations_skill.py
#	tests/skills/test_ip_as_logo_skill.py
#	tests/skills/test_live_dashboard_skill.py
#	tests/skills/test_mcp_oauth_remote_gateway_skill.py
#	tests/skills/test_office_document_skills.py
#	tests/skills/test_openclaw_migration.py
#	tests/skills/test_product_price_monitor_skill.py
#	tests/skills/test_scrollcraft_skill.py
#	tests/skills/test_setup_wizard_generator_skill.py
#	tests/skills/test_weekly_review_planning_skill.py
#	tests/test_engines_satisfiable.py
#	tests/test_fast_safe_load.py
#	tests/test_hermes_bootstrap.py
#	tests/test_hermes_constants.py
#	tests/test_hermes_logging.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_model_tools_async_bridge.py
#	tests/test_packaging_build_guard.py
#	tests/test_packaging_metadata.py
#	tests/test_yaml_indent_consistency.py
#	tests/tools/test_approval_timeout_overflow.py
#	tests/tools/test_base_environment.py
#	tests/tools/test_bot_mode_dm.py
#	tests/tools/test_browser_chromium_check.py
#	tests/tools/test_browser_hardening.py
#	tests/tools/test_browser_homebrew_paths.py
#	tests/tools/test_browser_npx_warmup.py
#	tests/tools/test_browser_orphan_reaper.py
#	tests/tools/test_browser_real_profile.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_code_execution.py
#	tests/tools/test_code_execution_modes.py
#	tests/tools/test_code_execution_windows_env.py
#	tests/tools/test_computer_use.py
#	tests/tools/test_delegate_liveness_timeout.py
#	tests/tools/test_execute_code_approval_cluster.py
#	tests/tools/test_execution_flag_detection.py
#	tests/tools/test_fal_common.py
#	tests/tools/test_file_operations.py
#	tests/tools/test_file_tools.py
#	tests/tools/test_file_tools_cwd_resolution.py
#	tests/tools/test_file_tools_live.py
#	tests/tools/test_lazy_deps.py
#	tests/tools/test_lazy_deps_durable_target.py
#	tests/tools/test_lazy_deps_managed.py
#	tests/tools/test_local_env_blocklist.py
#	tests/tools/test_local_tempdir.py
#	tests/tools/test_macos_protected_search.py
#	tests/tools/test_mcp_npx_cached_bin.py
#	tests/tools/test_oneshot_completion_linger.py
#	tests/tools/test_process_registry.py
#	tests/tools/test_read_file_schema_gating.py
#	tests/tools/test_skill_improvements.py
#	tests/tools/test_skills_sync.py
#	tests/tools/test_termux_api_detection.py
#	tests/tools/test_tirith_security.py
#	tests/tools/test_transcription_tools.py
#	tests/tools/test_tts_streaming.py
#	tests/tools/test_wake_word.py
#	tests/tui_gateway/test_compute_host_borrowed_lease.py
#	tests/tui_gateway/test_compute_host_turn_protocol.py
#	tests/tui_gateway/test_isolated_orphan_activity.py
#	tests/tui_gateway/test_protocol.py
#	tests/tui_gateway/test_slash_worker_profile_home.py
#	tests/tui_gateway/test_subprocess_encoding.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	ui-tui/src/__tests__/terminalParity.test.ts
#	ui-tui/src/__tests__/termuxComposerLayout.test.ts
#	ui-tui/src/__tests__/textInputFastEcho.test.ts
2026-09-23 07:02:44 -04:00

287 lines
13 KiB
Python

"""Tests for cronjob action='run' background dispatch.
A manual `cronjob(action='run')` used to execute the job synchronously on the
calling agent's tool thread — a full agent run (minutes to hours) inside ONE
tool call, uninterruptible and serial. It now dispatches through the async
delegation registry (same rail as delegate_task background mode): the tool
returns immediately with a handle and the run's outcome re-enters the
conversation as a type='async_delegation' completion event.
Sync fallbacks preserved:
- no routable session (direct Python callers, `hermes cron run`)
- async delivery unsupported (one-shot runners, cron child sessions)
- dispatch pool at capacity (claim already taken — must not strand it)
"""
import json
import threading
from unittest.mock import patch
from tools.cronjob_tools import (
_try_dispatch_background_run,
cronjob,
)
_JOB = {"id": "job-bg-1", "name": "bg run", "prompt": "hi",
"schedule": {"kind": "cron", "expr": "0 9 * * *"}}
def _job(job_id):
"""Per-test job dict with a UNIQUE id.
Background workers outlive their test (daemon executor) and hold the id
in the scheduler's shared running set until the run finishes; reusing one
id across tests makes the in-flight dedupe guard see a phantom
'already running' from a previous test's straggler worker.
"""
return {"id": job_id, "name": f"bg run {job_id}", "prompt": "hi",
"schedule": {"kind": "cron", "expr": "0 9 * * *"}}
def _bound_session_key(key="agent:main:telegram:dm:123"):
"""Context manager binding the approval session key contextvar."""
import contextlib
from tools.approval_context import _approval_session_key
@contextlib.contextmanager
def _cm():
token = _approval_session_key.set(key)
try:
yield
finally:
_approval_session_key.reset(token)
return _cm()
class TestBackgroundDispatch:
def test_dispatches_and_returns_handle_immediately(self):
"""With a routable session, run claims sync then dispatches async."""
run_started = threading.Event()
run_release = threading.Event()
def slow_run_one_job(job, **kw):
run_started.set()
assert run_release.wait(timeout=5.0)
return True
with _bound_session_key():
with patch("tools.cronjob_tools.claim_job_for_fire", side_effect=lambda jid, **kw: {**_job(jid), "fire_claim": {"by": "bg-owner"}}), \
patch("cron.scheduler.run_one_job", side_effect=slow_run_one_job), \
patch("tools.cronjob_tools.get_job",
return_value={"last_status": "ok", "last_error": None}):
res = _try_dispatch_background_run(_job('job-bg-01'))
try:
# Returned BEFORE the job finished — that's the whole point.
assert res is not None
assert res["claimed"] is True
assert res["dispatched"] is True
assert res["delegation_id"]
# The job actually starts on the daemon executor.
assert run_started.wait(timeout=5.0), "job never started in background"
finally:
run_release.set()
def test_completion_event_reaches_shared_queue(self):
"""The finished run pushes a type='async_delegation' event carrying
the job outcome onto process_registry.completion_queue."""
import time
from tools.process_registry import process_registry
# The runner executes on a daemon thread — the patches must stay
# active until the completion event lands, so poll INSIDE the blocks.
with _bound_session_key("agent:main:telegram:dm:777"):
with patch("tools.cronjob_tools.claim_job_for_fire", side_effect=lambda jid, **kw: {**_job(jid), "fire_claim": {"by": "bg-owner"}}), \
patch("cron.scheduler.run_one_job", return_value=True), \
patch("tools.cronjob_tools.get_job",
return_value={"last_status": "ok", "last_error": None,
"next_run_at": "2026-08-07T09:00:00"}):
res = _try_dispatch_background_run(_job('job-bg-02'))
assert res["dispatched"] is True
found = None
for _ in range(100):
try:
evt = process_registry.completion_queue.get_nowait()
except Exception:
time.sleep(0.05)
continue
if (evt.get("type") == "async_delegation"
and evt.get("delegation_id") == res["delegation_id"]):
found = evt
break
process_registry.completion_queue.put(evt)
time.sleep(0.05)
assert found is not None, "completion event never reached the queue"
assert found["session_key"] == "agent:main:telegram:dm:777"
assert found["status"] == "completed"
assert "bg run" in (found.get("summary") or "")
def test_failed_run_reports_error_status_in_event(self):
import time
from tools.process_registry import process_registry
with _bound_session_key("agent:main:telegram:dm:778"):
with patch("tools.cronjob_tools.claim_job_for_fire", side_effect=lambda jid, **kw: {**_job(jid), "fire_claim": {"by": "bg-owner"}}), \
patch("cron.scheduler.run_one_job", return_value=True), \
patch("tools.cronjob_tools.get_job",
return_value={"last_status": "error",
"last_error": "provider exploded"}):
res = _try_dispatch_background_run(_job('job-bg-03'))
assert res["dispatched"] is True
found = None
for _ in range(100):
try:
evt = process_registry.completion_queue.get_nowait()
except Exception:
time.sleep(0.05)
continue
if evt.get("delegation_id") == res["delegation_id"]:
found = evt
break
process_registry.completion_queue.put(evt)
time.sleep(0.05)
assert found is not None
assert found["status"] == "error"
assert "provider exploded" in (found.get("error") or "")
def test_claim_lost_reports_immediately_without_dispatch(self):
"""Paused/already-firing jobs report in the tool response, not as a
delayed completion event."""
with _bound_session_key():
with patch("tools.cronjob_tools.claim_job_for_fire", return_value=False), \
patch("tools.cronjob_tools.get_job",
return_value={**_JOB, "enabled": False}), \
patch("tools.async_delegation.dispatch_async_delegation") as m_disp:
res = _try_dispatch_background_run(_job('job-bg-04'))
assert res["claimed"] is False
assert "paused/disabled" in res["error"]
m_disp.assert_not_called()
class TestSyncFallbacks:
def test_no_session_key_falls_back_to_sync(self):
"""Direct Python callers (no agent session) keep the sync path."""
res = _try_dispatch_background_run(_job('job-bg-05'))
assert res is None
def test_async_delivery_unsupported_falls_back_to_sync(self):
"""One-shot runtimes (hermes -z, cron child, Kanban) keep sync."""
with _bound_session_key():
with patch("gateway.session_context.async_delivery_supported",
return_value=False):
res = _try_dispatch_background_run(_job('job-bg-06'))
assert res is None
def test_pool_at_capacity_runs_inline(self):
"""A rejected dispatch must not strand the already-taken claim."""
with _bound_session_key():
with patch("tools.cronjob_tools.claim_job_for_fire", side_effect=lambda jid, **kw: {**_job(jid), "fire_claim": {"by": "bg-owner"}}), \
patch("tools.async_delegation.dispatch_async_delegation",
return_value={"status": "rejected", "error": "capacity"}), \
patch("cron.scheduler.run_one_job", return_value=True) as m_run, \
patch("tools.cronjob_tools.get_job",
return_value={"last_status": "ok", "last_error": None}):
res = _try_dispatch_background_run(_job('job-bg-07'))
assert res["dispatched"] is False
assert res["success"] is True
m_run.assert_called_once() # ran inline on this thread
class TestInFlightDedupe:
"""Manual runs must not double-fire a job that is already mid-run
(salvaged from #53395 by @izumi0uu): the fire claim's 300s TTL is
routinely outlived by real jobs, so the claim alone can't prevent it."""
def test_run_claimed_job_skips_when_already_running(self):
"""The authoritative guard: _run_claimed_job refuses to fire a job
whose id is already registered in the scheduler running set."""
from cron import scheduler as sched
from tools.cronjob_tools import _run_claimed_job
assert sched.try_register_running_job("job-bg-08") # simulate ticker mid-run
try:
with patch("cron.scheduler.run_one_job") as m_run:
res = _run_claimed_job(_job('job-bg-08'))
assert res["success"] is False
assert "already running" in res["error"]
m_run.assert_not_called()
finally:
sched.release_running_job("job-bg-08")
def test_run_claimed_job_registers_and_releases(self):
"""A normal run holds the registration for run_one_job's duration and
releases it after — visible to get_running_job_ids mid-run."""
from cron import scheduler as sched
from tools.cronjob_tools import _run_claimed_job
seen_during_run = {}
def probe_run(job, **kw):
seen_during_run["registered"] = "job-bg-09" in sched.get_running_job_ids()
return True
with patch("cron.scheduler.run_one_job", side_effect=probe_run), \
patch("tools.cronjob_tools.get_job",
return_value={"last_status": "ok", "last_error": None}):
res = _run_claimed_job(_job('job-bg-09'))
assert res["success"] is True
assert seen_during_run["registered"] is True
assert "job-bg-09" not in sched.get_running_job_ids() # released after
def test_run_claimed_job_reports_exact_unknown_execution_not_stale_success(self):
from tools.cronjob_tools import _run_claimed_job
def probe_run(job, **_kwargs):
job["execution_id"] = "exec-unknown"
return True
with patch("cron.scheduler.run_one_job", side_effect=probe_run), \
patch("cron.executions.get_execution", return_value={
"id": "exec-unknown",
"status": "unknown",
"error": "worker owner exited",
}), \
patch("tools.cronjob_tools.get_job", return_value={
"last_status": "ok",
"last_error": None,
}):
res = _run_claimed_job(_job("job-bg-unknown"))
assert res["success"] is False
assert res["error"] == "worker owner exited"
def test_background_dispatch_reports_running_job_immediately(self):
"""The dispatch path pre-checks the running set so a mid-run job
reports in the tool response, not as a delayed completion event."""
from cron import scheduler as sched
assert sched.try_register_running_job("job-bg-10")
try:
with _bound_session_key():
with patch("tools.cronjob_tools.claim_job_for_fire") as m_claim, \
patch("tools.async_delegation.dispatch_async_delegation") as m_disp:
res = _try_dispatch_background_run(_job('job-bg-10'))
assert res["claimed"] is False
assert "already running" in res["error"]
m_claim.assert_not_called() # no claim consumed for a skipped run
m_disp.assert_not_called()
finally:
sched.release_running_job("job-bg-10")
class TestCronjobRunToolIntegration:
def test_run_action_returns_background_note(self):
"""cronjob(action='run') surfaces the handle + do-not-wait note."""
with _bound_session_key():
with patch("tools.cronjob_tools.resolve_job_ref", return_value=_job('job-bg-12')), \
patch("tools.cronjob_tools.claim_job_for_fire", side_effect=lambda jid, **kw: {**_job(jid), "fire_claim": {"by": "bg-owner"}}), \
patch("cron.scheduler.run_one_job", return_value=True), \
patch("tools.cronjob_tools.get_job",
return_value={"id": "job-bg-12", "name": "bg run",
"last_status": "ok", "last_error": None}):
out = json.loads(cronjob(action="run", job_id="job-bg-12"))
assert out["success"] is True
assert out["job"]["executed"] is True
assert out["job"]["execution_mode"] == "background"
assert out["job"]["delegation_id"]