hermes-agent/tests/tools/test_bot_live_owner_delivery.py
ethernet 890bbbda1f Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts
#	apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts
#	apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts
#	apps/desktop/e2e/bot-mode-roster-localized.spec.ts
#	apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts
#	apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts
#	apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts
#	apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts
#	apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts
#	apps/desktop/e2e/bot-roster-user-sections.spec.ts
#	apps/desktop/e2e/bot-routines-pane-narrow.spec.ts
#	apps/desktop/e2e/bot-row-open-recent-session.spec.ts
#	apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts
#	apps/desktop/e2e/group-composer-auto-grow.spec.ts
#	apps/desktop/e2e/group-create-gate-remote-roster.spec.ts
#	apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts
#	apps/desktop/e2e/hosted-room-backend-continuity.spec.ts
#	apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts
#	apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts
#	apps/desktop/e2e/worktree-branch-status.spec.ts
#	apps/desktop/electron/backend-probes.test.ts
#	apps/desktop/electron/connection-apply.test.ts
#	apps/desktop/electron/desktop-electron-pin.test.ts
#	apps/desktop/electron/desktop-uninstall.test.ts
#	apps/desktop/electron/gateway-file-download-transport.test.ts
#	apps/desktop/electron/gateway-stop-before-update.test.ts
#	apps/desktop/electron/github-api-auth.test.ts
#	apps/desktop/electron/registry-primary-profile-scope.test.ts
#	apps/desktop/electron/update-api-check.test.ts
#	apps/desktop/electron/update-handoff-marker.test.ts
#	apps/desktop/electron/venv-blocker-scan.test.ts
#	apps/desktop/scripts/after-extract.test.mjs
#	apps/desktop/scripts/local-pack-publish.test.mjs
#	apps/desktop/scripts/tasks-scroll.test.mjs
#	apps/desktop/src/app/settings/model-settings.test.tsx
#	apps/desktop/src/app/updates-overlay.blockers.test.tsx
#	apps/desktop/src/components/desktop-install-overlay.test.tsx
#	apps/desktop/src/lib/update-copy.test.ts
#	scripts/ci/check_os_marker_fakes.py
#	tests-js/desktop-mac-usage-descriptions.test.ts
#	tests-js/node-engine-alignment.test.ts
#	tests/agent/lsp/test_install_and_lint_fixes.py
#	tests/agent/test_command_token_source.py
#	tests/agent/test_compression_boundary_hook.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/agent/test_custom_provider_ca_probes.py
#	tests/agent/test_endpoint_blackhole.py
#	tests/agent/test_estimator_parity.py
#	tests/agent/test_in_place_compaction.py
#	tests/agent/test_moa_loop_mode.py
#	tests/agent/test_model_metadata.py
#	tests/agent/test_skill_session_platform_gate.py
#	tests/agent/test_skill_utils.py
#	tests/agent/test_ssl_ca_guard.py
#	tests/computer_use/test_doctor.py
#	tests/cron/test_codex_execution_paths.py
#	tests/cron/test_cron_bot_chat_delivery.py
#	tests/cron/test_cron_script.py
#	tests/cron/test_media_delivery_parity.py
#	tests/cron/test_misfire_catchup.py
#	tests/cron/test_parallel_pool.py
#	tests/cron/test_recurring_eagain_redispatch.py
#	tests/gateway/test_choice_picker.py
#	tests/gateway/test_control_socket_windows_live.py
#	tests/gateway/test_dingtalk.py
#	tests/gateway/test_feishu.py
#	tests/gateway/test_feishu_onboard.py
#	tests/gateway/test_gateway_shutdown.py
#	tests/gateway/test_matrix.py
#	tests/gateway/test_model_command_custom_providers.py
#	tests/gateway/test_reasoning_command.py
#	tests/gateway/test_runtime_footer.py
#	tests/gateway/test_session.py
#	tests/gateway/test_session_hygiene.py
#	tests/gateway/test_status.py
#	tests/gateway/test_teams.py
#	tests/gateway/test_turn_lease.py
#	tests/gateway/test_whatsapp_connect.py
#	tests/hermes_cli/test_approvals_command.py
#	tests/hermes_cli/test_auth_store_lock_concurrent.py
#	tests/hermes_cli/test_backup.py
#	tests/hermes_cli/test_banner_git_state.py
#	tests/hermes_cli/test_certifi_repair.py
#	tests/hermes_cli/test_cmd_update.py
#	tests/hermes_cli/test_compat_manifest_targets.py
#	tests/hermes_cli/test_computer_use_cli.py
#	tests/hermes_cli/test_cpr_local_leak.py
#	tests/hermes_cli/test_dashboard_auth_gate.py
#	tests/hermes_cli/test_dashboard_procs_kill_grace.py
#	tests/hermes_cli/test_desktop_lifecycle_windows_live.py
#	tests/hermes_cli/test_doctor.py
#	tests/hermes_cli/test_doctor_command_install.py
#	tests/hermes_cli/test_fleet_config_migration_windows_live.py
#	tests/hermes_cli/test_gateway.py
#	tests/hermes_cli/test_gateway_platform_gating.py
#	tests/hermes_cli/test_gateway_restart_loop.py
#	tests/hermes_cli/test_gateway_task_probe.py
#	tests/hermes_cli/test_gateway_wsl.py
#	tests/hermes_cli/test_gui_command.py
#	tests/hermes_cli/test_install_cua_driver.py
#	tests/hermes_cli/test_kanban_db.py
#	tests/hermes_cli/test_lazy_command_exports.py
#	tests/hermes_cli/test_lazy_refresh_venv_repair.py
#	tests/hermes_cli/test_linux_desktop_entry.py
#	tests/hermes_cli/test_local_runtime.py
#	tests/hermes_cli/test_local_runtime_updates.py
#	tests/hermes_cli/test_managed_uv.py
#	tests/hermes_cli/test_mcp_reload_confirm_gate.py
#	tests/hermes_cli/test_nous_subscription.py
#	tests/hermes_cli/test_npm_engine.py
#	tests/hermes_cli/test_personality_none.py
#	tests/hermes_cli/test_pet_toggle.py
#	tests/hermes_cli/test_plan_reconciliation_windows_live.py
#	tests/hermes_cli/test_plugin_event_bus.py
#	tests/hermes_cli/test_plugin_manifest_v2.py
#	tests/hermes_cli/test_plugin_packs.py
#	tests/hermes_cli/test_plugins_cmd.py
#	tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py
#	tests/hermes_cli/test_process_identity.py
#	tests/hermes_cli/test_profiles.py
#	tests/hermes_cli/test_profiles_sidebar_cache.py
#	tests/hermes_cli/test_pty_bridge.py
#	tests/hermes_cli/test_resolve_turn_limit.py
#	tests/hermes_cli/test_serve_runtime_inventory.py
#	tests/hermes_cli/test_session_vacuum_config.py
#	tests/hermes_cli/test_set_config_value.py
#	tests/hermes_cli/test_signal_handler_kanban_worker.py
#	tests/hermes_cli/test_slash_confirm_windows.py
#	tests/hermes_cli/test_stale_pid_guard.py
#	tests/hermes_cli/test_startup_fast_guards.py
#	tests/hermes_cli/test_status.py
#	tests/hermes_cli/test_telegram_managed_bot.py
#	tests/hermes_cli/test_tools_config.py
#	tests/hermes_cli/test_update_apply_shallow_count.py
#	tests/hermes_cli/test_update_autostash.py
#	tests/hermes_cli/test_update_concurrent_quarantine.py
#	tests/hermes_cli/test_update_fetch_failure_classifier.py
#	tests/hermes_cli/test_update_fleet_probe_resume_token.py
#	tests/hermes_cli/test_update_handoff_backend_reap.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_update_head_moved_gate.py
#	tests/hermes_cli/test_update_host_obligation.py
#	tests/hermes_cli/test_update_import_guard.py
#	tests/hermes_cli/test_update_interrupted_recovery.py
#	tests/hermes_cli/test_update_inventory.py
#	tests/hermes_cli/test_update_launchd_unloaded_gateway.py
#	tests/hermes_cli/test_update_missing_configured_deps.py
#	tests/hermes_cli/test_update_modified_notice.py
#	tests/hermes_cli/test_update_multiplex_migration_hook.py
#	tests/hermes_cli/test_update_no_gateway_restart.py
#	tests/hermes_cli/test_update_orphan_backend_reap.py
#	tests/hermes_cli/test_update_parked_branch_guard.py
#	tests/hermes_cli/test_update_post_pull_syntax_guard.py
#	tests/hermes_cli/test_update_receipt.py
#	tests/hermes_cli/test_update_self_lock.py
#	tests/hermes_cli/test_update_shim_fail_closed.py
#	tests/hermes_cli/test_update_shim_self_lock.py
#	tests/hermes_cli/test_update_sqlite_remediation.py
#	tests/hermes_cli/test_update_stale_dashboard.py
#	tests/hermes_cli/test_update_stale_virtualenv.py
#	tests/hermes_cli/test_update_venv_health.py
#	tests/hermes_cli/test_update_venv_ownership_preflight.py
#	tests/hermes_cli/test_update_wedged_gateway.py
#	tests/hermes_cli/test_update_yes_flag.py
#	tests/hermes_cli/test_update_zip_two_phase.py
#	tests/hermes_cli/test_urllib_security.py
#	tests/hermes_cli/test_ux_messages_auth_config.py
#	tests/hermes_cli/test_ux_messages_startup.py
#	tests/hermes_cli/test_venv_holder_classifier.py
#	tests/hermes_cli/test_verify_console_scripts.py
#	tests/hermes_cli/test_verify_core_dependencies.py
#	tests/hermes_cli/test_web_server.py
#	tests/hermes_cli/test_web_server_console_ws.py
#	tests/hermes_cli/test_web_server_ws_ping.py
#	tests/hermes_cli/test_web_ui_build.py
#	tests/hermes_state/test_fts_rebuild_admission.py
#	tests/hermes_state/test_hermes_state.py
#	tests/plugins/memory/test_memory_lazy_install.py
#	tests/plugins/test_google_meet_plugin.py
#	tests/plugins/test_langfuse_plugin.py
#	tests/plugins/test_security_guidance_plugin.py
#	tests/plugins/test_transform_llm_output_hook.py
#	tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_contributor_map.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/skills/test_competitor_news_monitor_skill.py
#	tests/skills/test_document_to_action_items_skill.py
#	tests/skills/test_google_workspace_setup.py
#	tests/skills/test_google_workspace_setup_deps.py
#	tests/skills/test_grounded_citations_skill.py
#	tests/skills/test_ip_as_logo_skill.py
#	tests/skills/test_live_dashboard_skill.py
#	tests/skills/test_mcp_oauth_remote_gateway_skill.py
#	tests/skills/test_office_document_skills.py
#	tests/skills/test_openclaw_migration.py
#	tests/skills/test_product_price_monitor_skill.py
#	tests/skills/test_scrollcraft_skill.py
#	tests/skills/test_setup_wizard_generator_skill.py
#	tests/skills/test_weekly_review_planning_skill.py
#	tests/test_engines_satisfiable.py
#	tests/test_fast_safe_load.py
#	tests/test_hermes_bootstrap.py
#	tests/test_hermes_constants.py
#	tests/test_hermes_logging.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_model_tools_async_bridge.py
#	tests/test_packaging_build_guard.py
#	tests/test_packaging_metadata.py
#	tests/test_yaml_indent_consistency.py
#	tests/tools/test_approval_timeout_overflow.py
#	tests/tools/test_base_environment.py
#	tests/tools/test_bot_mode_dm.py
#	tests/tools/test_browser_chromium_check.py
#	tests/tools/test_browser_hardening.py
#	tests/tools/test_browser_homebrew_paths.py
#	tests/tools/test_browser_npx_warmup.py
#	tests/tools/test_browser_orphan_reaper.py
#	tests/tools/test_browser_real_profile.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_code_execution.py
#	tests/tools/test_code_execution_modes.py
#	tests/tools/test_code_execution_windows_env.py
#	tests/tools/test_computer_use.py
#	tests/tools/test_delegate_liveness_timeout.py
#	tests/tools/test_execute_code_approval_cluster.py
#	tests/tools/test_execution_flag_detection.py
#	tests/tools/test_fal_common.py
#	tests/tools/test_file_operations.py
#	tests/tools/test_file_tools.py
#	tests/tools/test_file_tools_cwd_resolution.py
#	tests/tools/test_file_tools_live.py
#	tests/tools/test_lazy_deps.py
#	tests/tools/test_lazy_deps_durable_target.py
#	tests/tools/test_lazy_deps_managed.py
#	tests/tools/test_local_env_blocklist.py
#	tests/tools/test_local_tempdir.py
#	tests/tools/test_macos_protected_search.py
#	tests/tools/test_mcp_npx_cached_bin.py
#	tests/tools/test_oneshot_completion_linger.py
#	tests/tools/test_process_registry.py
#	tests/tools/test_read_file_schema_gating.py
#	tests/tools/test_skill_improvements.py
#	tests/tools/test_skills_sync.py
#	tests/tools/test_termux_api_detection.py
#	tests/tools/test_tirith_security.py
#	tests/tools/test_transcription_tools.py
#	tests/tools/test_tts_streaming.py
#	tests/tools/test_wake_word.py
#	tests/tui_gateway/test_compute_host_borrowed_lease.py
#	tests/tui_gateway/test_compute_host_turn_protocol.py
#	tests/tui_gateway/test_isolated_orphan_activity.py
#	tests/tui_gateway/test_protocol.py
#	tests/tui_gateway/test_slash_worker_profile_home.py
#	tests/tui_gateway/test_subprocess_encoding.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	ui-tui/src/__tests__/terminalParity.test.ts
#	ui-tui/src/__tests__/termuxComposerLayout.test.ts
#	ui-tui/src/__tests__/textInputFastEcho.test.ts
2026-09-23 07:02:44 -04:00

277 lines
16 KiB
Python

"""Durable mailbox invariants, using real disk and exec boundaries."""
import json
import os
import subprocess
import sys
import pytest
@pytest.mark.parametrize("terminal_status", ["settled", "failed", "cancelled"])
def test_delivery_is_idempotent_fenced_and_permanent(tmp_path, terminal_status):
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat",
lease_id="lease", live_session_id="live")
delivery_id = "a" * 32
queued = mailbox.deliver_to_live_owner(tmp_path, owner, "héllo 世界", delivery_id=delivery_id)
assert queued["status"] == "queued"
path = tmp_path / "runtime" / mailbox.DELIVERY_DIR_NAME / f"{delivery_id}.json"
raw = path.read_bytes()
assert not raw.startswith(b"\xef\xbb\xbf")
path.write_bytes(b"\xef\xbb\xbf" + raw)
assert mailbox.deliver_to_live_owner(tmp_path, owner, "héllo 世界", delivery_id=delivery_id) == queued
with pytest.raises(ValueError):
mailbox.deliver_to_live_owner(tmp_path, owner, "different", delivery_id=delivery_id)
assert mailbox.claim_pending_delivery(tmp_path, dict(owner, lease_id="other")) is None
assert mailbox.claim_pending_delivery(tmp_path, dict(owner, live_session_id="other")) is None
script = (
"import json,sys; from tools.bot_live_delivery import claim_pending_delivery; "
"print(json.dumps(claim_pending_delivery(sys.argv[1],json.loads(sys.argv[2]))))"
)
children = [subprocess.Popen([sys.executable, "-c", script, str(tmp_path), json.dumps(owner)],
stdin=subprocess.DEVNULL, stdout=subprocess.PIPE,
stderr=subprocess.PIPE, text=True) for _ in range(2)]
results = []
for child in children:
out, err = child.communicate(timeout=30)
assert child.returncode == 0, err
results.append(json.loads(out))
claims = [r for r in results if r is not None]
assert len(claims) == 1 and claims[0]["message"] == "héllo 世界"
assert mailbox.read_delivery_result(tmp_path, delivery_id)["status"] == "claimed"
assert mailbox.claim_pending_delivery(tmp_path, owner) is None
path.write_bytes(b"\xef\xbb\xbf" + path.read_bytes())
receipt = mailbox.complete_delivery(tmp_path, delivery_id, status=terminal_status, reply="réponse 世界")
assert not path.read_bytes().startswith(b"\xef\xbb\xbf")
path.write_bytes(b"\xef\xbb\xbf" + path.read_bytes())
assert mailbox.read_delivery_result(tmp_path, delivery_id) == receipt
assert mailbox.complete_delivery(tmp_path, delivery_id, status=terminal_status, reply="réponse 世界") == receipt
with pytest.raises(ValueError):
mailbox.complete_delivery(tmp_path, delivery_id, status=terminal_status, reply="rewrite")
assert mailbox.deliver_to_live_owner(tmp_path, owner, "héllo 世界", delivery_id=delivery_id) == receipt
assert mailbox.claim_pending_delivery(tmp_path, owner) is None
if os.name != "nt":
for path in (tmp_path / "runtime" / mailbox.DELIVERY_DIR_NAME).iterdir():
assert path.stat().st_mode & 0o077 == 0
@pytest.mark.parametrize("intent_state", ["new", "existing", "raced"])
def test_live_dm_bom_readers_preserve_pinned_intent(tmp_path, monkeypatch, intent_state):
from pathlib import Path
from hermes_cli.active_sessions import try_acquire_active_session
from hermes_state import SessionDB
from tools import bot_live_delivery as mailbox, bot_mode_dm
db = SessionDB(db_path=tmp_path / "state.db")
db.create_session(session_id="chat", source="cli")
db.set_session_title("chat", "Bot Chat")
lease, refusal = try_acquire_active_session(
session_id="chat", surface="desktop", config={}, registry_home=tmp_path,
metadata=dict(live_session_id="live", bot_live_delivery_consumer=True))
assert refusal is None and lease is not None
try:
owner = mailbox.find_canonical_live_owner(tmp_path)
assert owner is not None
payload = tmp_path / "message.txt"
payload.write_bytes("héllo 世界".encode("utf-8-sig"))
intent_path = Path(str(payload) + ".live.json")
author = {"id": "bot:coder", "name": "Renée", "is_bot": True}
intent = dict(owner=owner, message="pinned 世界", delivery_id="d" * 32, author=author)
encoded = json.dumps(intent, ensure_ascii=False).encode("utf-8-sig")
if intent_state == "existing":
intent_path.write_bytes(encoded)
elif intent_state == "raced":
real_open = os.open
def competing_intent(path, flags, *args, **kwargs):
if Path(path) == intent_path:
intent_path.write_bytes(encoded)
return real_open(path, flags, *args, **kwargs)
monkeypatch.setattr(os, "open", competing_intent)
record = bot_mode_dm._admit_live_dm(tmp_path, str(payload), author)
assert record is not None
assert record["message"] == ("héllo 世界" if intent_state == "new" else "pinned 世界")
assert record["owner"] == owner and record["author"] == author
if intent_state == "new":
assert not intent_path.read_bytes().startswith(b"\xef\xbb\xbf")
intent_path.write_bytes(b"\xef\xbb\xbf" + intent_path.read_bytes())
payload.write_text("must not replace pinned payload", encoding="utf-8")
assert bot_mode_dm._admit_live_dm(None, str(payload)) == record
claim = mailbox.claim_pending_delivery(tmp_path, owner)
assert claim is not None and claim["delivery_id"] == record["delivery_id"]
assert mailbox.claim_pending_delivery(tmp_path, owner) is None
intent_path.write_bytes(b"\xef\xbb\xbf{broken")
assert bot_mode_dm._run_delivery([], str(payload), stdin_file=False, profile_home=tmp_path) == 1
assert payload.exists() # Ambiguous admission must retain its evidence, not retry a transport.
finally:
lease.release()
db.close()
def test_fifo_survives_clock_rollback(tmp_path, monkeypatch):
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat",
lease_id="lease", live_session_id="live")
for timestamp, message in ((100, "first"), (90, "second")):
monkeypatch.setattr(mailbox.time, "time_ns", lambda: timestamp)
mailbox.deliver_to_live_owner(tmp_path, owner, message)
assert mailbox.claim_pending_delivery(tmp_path, owner)["message"] == "first"
assert mailbox.claim_pending_delivery(tmp_path, owner)["message"] == "second"
@pytest.mark.parametrize("capable", [True, False])
def test_only_canonical_capable_owner_receives_across_compression(tmp_path, capable):
from hermes_state import SessionDB
from hermes_cli.active_sessions import try_acquire_active_session, transfer_active_session
from tools import bot_live_delivery as mailbox
db = SessionDB(db_path=tmp_path / "state.db")
db.create_session(session_id="chat", source="cli")
db.set_session_title("chat", "Bot Chat")
meta = dict(live_session_id="live", bot_live_delivery_consumer=capable)
lease, refusal = try_acquire_active_session(session_id="chat", surface="desktop", config={},
registry_home=tmp_path, metadata=meta)
assert refusal is None
try:
owner = mailbox.find_canonical_live_owner(tmp_path)
if not capable:
assert owner is None
return
assert owner["lease_id"] == lease.lease_id
queued = mailbox.deliver_to_live_owner(tmp_path, owner, "before compression")
db.end_session("chat", "compression")
db.create_session(session_id="tip", source="cli", parent_session_id="chat")
assert transfer_active_session(lease, session_id="tip", metadata=meta)
current = mailbox.find_canonical_live_owner(tmp_path)
assert current["session_id"] == "tip"
claim = mailbox.claim_pending_delivery(tmp_path, current)
assert claim["delivery_id"] == queued["delivery_id"]
assert claim["session_id"] == "chat"
assert mailbox.claim_pending_delivery(tmp_path, current) is None
finally:
lease.release()
db.close()
def test_delivery_keeps_the_sender_and_refuses_a_different_one_under_the_same_id(tmp_path):
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat", lease_id="lease", live_session_id="live")
author = {"id": "bot:coder", "name": "coder", "is_bot": True}
queued = mailbox.deliver_to_live_owner(tmp_path, owner, "héllo 世界", delivery_id="b" * 32, author=author)
assert queued["author"] == author
assert mailbox.deliver_to_live_owner(tmp_path, owner, "héllo 世界", delivery_id="b" * 32, author=author) == queued
with pytest.raises(ValueError):
mailbox.deliver_to_live_owner(tmp_path, owner, "héllo 世界", delivery_id="b" * 32, author={**author, "id": "bot:other"})
assert "author" not in mailbox.deliver_to_live_owner(tmp_path, owner, "no sender", delivery_id="c" * 32)
@pytest.mark.platforms("posix")
@pytest.mark.skipif(getattr(os, "geteuid", lambda: 1)() == 0, reason='needs POSIX file permissions for an unreadable ticket')
def test_unreadable_ticket_does_not_wedge_bulk_scans(tmp_path, caplog):
import logging
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat",
lease_id="lease", live_session_id="live")
queued = mailbox.deliver_to_live_owner(tmp_path, owner, "readable", delivery_id="d" * 32)
root = tmp_path / "runtime" / mailbox.DELIVERY_DIR_NAME
# A real admission that later turns unreadable: its sequence must survive the skip.
hidden = mailbox.deliver_to_live_owner(tmp_path, owner, "hidden", delivery_id="e" * 32)
(root / f"{'e' * 32}.json").chmod(0)
corrupt = root / f"{'1' * 32}.json"
corrupt.write_text("{not json", encoding="utf-8")
(root / f"{'2' * 32}.json").write_bytes(b"\xff\xfe\x00garbage") # invalid UTF-8, not just bad JSON
with caplog.at_level(logging.WARNING, logger="tools.bot_live_delivery"):
# Sender side: admission of a fresh id must survive the sequence sweep.
admitted = mailbox.deliver_to_live_owner(tmp_path, owner, "second", delivery_id="f" * 32)
# Receiver side: every readable queued ticket must still be claimed, in order.
assert mailbox.claim_pending_delivery(tmp_path, owner)["delivery_id"] == queued["delivery_id"]
assert mailbox.claim_pending_delivery(tmp_path, owner)["delivery_id"] == admitted["delivery_id"]
for _ in range(10): # the idle poller rescans twice a second
assert mailbox.claim_pending_delivery(tmp_path, owner) is None
assert admitted["status"] == "queued"
assert admitted["sequence"] > hidden["sequence"] > queued["sequence"]
denied = [record for record in caplog.records
if record.message.startswith(f"bot_live_delivery: skipping unreadable ticket {'e' * 32}.json")
and "Permission denied" in record.message]
assert len(denied) == 1, "one persistent bad ticket must warn once per process, not per scan"
@pytest.mark.platforms("posix")
@pytest.mark.skipif(getattr(os, "geteuid", lambda: 1)() == 0, reason='needs POSIX file permissions for an unreadable ticket')
def test_unreadable_ticket_keeps_exact_id_reads_fail_closed(tmp_path):
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat",
lease_id="lease", live_session_id="live")
unreadable = tmp_path / "runtime" / mailbox.DELIVERY_DIR_NAME / f"{'e' * 32}.json"
unreadable.parent.mkdir(parents=True, exist_ok=True)
unreadable.write_text('{"status": "queued"}', encoding="utf-8")
unreadable.chmod(0)
# Uninspectable is not absent: an exact-id retry must fail closed instead of
# minting a fresh receipt that overwrites the possibly-live one (#109820).
with pytest.raises(PermissionError):
mailbox.deliver_to_live_owner(tmp_path, owner, "same id", delivery_id="e" * 32)
with pytest.raises(PermissionError):
mailbox.read_delivery_result(tmp_path, "e" * 32)
def test_non_dict_ticket_is_skipped_by_scans_and_fails_exact_id_reads_closed(tmp_path, caplog):
import logging
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat",
lease_id="lease", live_session_id="live")
queued = mailbox.deliver_to_live_owner(tmp_path, owner, "readable", delivery_id="d" * 32)
bad = tmp_path / "runtime" / mailbox.DELIVERY_DIR_NAME / f"{'e' * 32}.json"
bad.write_text('"oops"', encoding="utf-8") # parses, but is not a record
with caplog.at_level(logging.WARNING, logger="tools.bot_live_delivery"):
admitted = mailbox.deliver_to_live_owner(tmp_path, owner, "second", delivery_id="f" * 32)
assert mailbox.claim_pending_delivery(tmp_path, owner)["delivery_id"] == queued["delivery_id"]
assert mailbox.claim_pending_delivery(tmp_path, owner)["delivery_id"] == admitted["delivery_id"]
assert mailbox.claim_pending_delivery(tmp_path, owner) is None
assert sum(r.message.startswith(f"bot_live_delivery: skipping unreadable ticket {'e' * 32}.json")
for r in caplog.records) == 1
# Malformed is not absent: exact-id reads fail closed rather than overwrite the receipt.
with pytest.raises(ValueError):
mailbox.deliver_to_live_owner(tmp_path, owner, "same id", delivery_id="e" * 32)
with pytest.raises(ValueError):
mailbox.read_delivery_result(tmp_path, "e" * 32)
assert bad.read_text(encoding="utf-8") == '"oops"'
def test_schema_damaged_ticket_does_not_wedge_bulk_scans(tmp_path, caplog):
"""Valid JSON that lost a field must degrade like corrupt JSON: skipped, warned once, never raised."""
import logging
from tools import bot_live_delivery as mailbox
owner = dict(profile_home=str(tmp_path.resolve()), session_id="chat",
lease_id="lease", live_session_id="live")
queued = mailbox.deliver_to_live_owner(tmp_path, owner, "healthy", delivery_id="d" * 32)
root = tmp_path / "runtime" / mailbox.DELIVERY_DIR_NAME
damaged = {
root / f"{'a' * 32}.json": "{}",
root / f"{'b' * 32}.json": json.dumps(dict(
delivery_id="b" * 32, id="b" * 32, status="queued", created_at=1,
sequence=1, owner=None, message="owner lost")),
root / f"{'c' * 32}.json": json.dumps(dict(
delivery_id="c" * 32, id="c" * 32, status="queued", created_at=2,
sequence="old", owner=owner, message="sequence lost", **owner)),
root / f"{'e' * 32}.json": json.dumps(dict(
delivery_id="../wrong", id="../wrong", status="queued", created_at=3,
sequence=3, owner=owner, message="id lost", **owner)),
root / f"{'1' * 32}.json": json.dumps(dict(
delivery_id="1" * 32, id="1" * 32, status=[], created_at=4,
sequence=4, owner=owner, message="status lost", **owner)),
}
for path, contents in damaged.items():
path.write_text(contents, encoding="utf-8")
with caplog.at_level(logging.WARNING, logger="tools.bot_live_delivery"):
admitted = mailbox.deliver_to_live_owner(tmp_path, owner, "also healthy", delivery_id="f" * 32)
assert mailbox.claim_pending_delivery(tmp_path, owner)["delivery_id"] == queued["delivery_id"]
assert mailbox.claim_pending_delivery(tmp_path, owner)["delivery_id"] == admitted["delivery_id"]
for _ in range(3):
assert mailbox.claim_pending_delivery(tmp_path, owner) is None
assert admitted["sequence"] == queued["sequence"] + 1
assert {path: path.read_text(encoding="utf-8") for path in damaged} == damaged
skipped = [r.message for r in caplog.records if r.message.startswith("bot_live_delivery: skipping unreadable ticket")]
assert len(skipped) == len(damaged), "each damaged ticket warns once per process, not per scan"