hermes-agent/tests/scripts/install/test_install_ps1_iex_failure.py
ethernet bcabc5b881 fix(install): keep the PowerShell session open when an iex install fails
The documented one-liner, iex (irm .../install.ps1), runs the installer
inside the user's own session. Fail ended with exit 1, so any failed
stage closed the user's PowerShell window.

Fail now throws. The two entry points own reporting and the exit code:
-Stage prints the reason, emits the -Json frame and exits 1, as before;
the full install exits 1 only when it runs from a script file, and under
iex it prints the reason, sets LASTEXITCODE=1 and returns. A scriptblock
literal's File tells the two apart: $MyInvocation.MyCommand.Path names the
caller's script under iex.
2026-09-24 11:31:08 -04:00

52 lines
2.2 KiB
Python

"""A failed install run through `iex (irm ...)` must not end the caller's session.
`iex` runs the installer text inside the user's PowerShell session, so an
`exit` on failure closed their window. A script file run keeps its exit code.
"""
import os
from pathlib import Path
import shutil
import subprocess
import pytest
pytestmark = pytest.mark.platforms("windows")
INSTALLER = Path(__file__).resolve().parents[3] / "scripts" / "install.ps1"
REFUSAL = "exists and is not a Hermes git checkout"
def _failing_install_env(tmp_path):
"""An occupied non-checkout makes the repository stage Fail before any
network or git call; a present pinned-git slot satisfies prerequisites."""
home = tmp_path / "home"
(home / "hermes-agent").mkdir(parents=True)
(home / "hermes-agent" / "user-file").write_text("preserve me", encoding="utf-8")
tools = tmp_path / "tools"
for arch in ("x64", "arm64"):
git = tools / f"git-2.53.0+3-win32-{arch}" / "cmd" / "git.exe"
git.parent.mkdir(parents=True)
git.write_bytes(b"")
return dict(os.environ, HERMES_HOME=str(home), HERMES_RUNTIME_DIR=str(tools))
def _powershell():
powershell = shutil.which("powershell")
assert powershell
return powershell
def test_failed_iex_install_reports_and_returns_to_the_callers_session(tmp_path):
command = (f"iex (Get-Content -Raw -LiteralPath '{INSTALLER}'); "
"Write-Output \"session alive: $LASTEXITCODE\"")
result = subprocess.run([_powershell(), "-NoProfile", "-ExecutionPolicy", "Bypass", "-Command", command],
env=_failing_install_env(tmp_path), capture_output=True, text=True, timeout=60)
assert REFUSAL in result.stdout
assert "session alive: 1" in result.stdout, result.stdout + result.stderr
assert (tmp_path / "home" / "hermes-agent" / "user-file").read_text(encoding="utf-8") == "preserve me"
def test_failed_file_install_still_exits_nonzero(tmp_path):
result = subprocess.run([_powershell(), "-NoProfile", "-ExecutionPolicy", "Bypass", "-File", str(INSTALLER)],
env=_failing_install_env(tmp_path), capture_output=True, text=True, timeout=60)
assert REFUSAL in result.stdout
assert result.returncode == 1