mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
`hermes sessions archive --older-than N` (SessionDB.archive_sessions) selected every ENDED row matching the filters, which includes the compression ancestors of a long conversation: they are ended (`end_reason='compression'`) and old by construction. `set_session_archived` then flipped `archived` across the whole lineage — including the OPEN, actively written, lease-holding live tip — and the default `archived=exclude` listing (Desktop sidebar, `hermes sessions list`, /resume) lost the chat while messages kept flowing. A lineage is now matched through its tip only: `_prune_filter_where` gains `lineage_tips_only`, which `archive_sessions` always sets and the CLI sets in archive mode so the dry-run preview and the confirmation count show exactly the rows the archive will touch. An idle, ended tip still archives its whole chain (the lineage stays one unit — the listed row is the root, projected to the tip, so sparing only the tip would leave the chat hidden anyway). Prune is unchanged. Docs: the bulk-archive section says how compacted conversations are matched. Direction from #115500 by @whyyagswhy (automatic archives must not hide the open live tip); the mechanism differs because the listing keys on the root. Co-authored-by: whyyagswhy <[email protected]>
99 lines
4.1 KiB
Python
99 lines
4.1 KiB
Python
import time
|
|
|
|
import pytest
|
|
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
@pytest.fixture
|
|
def db(tmp_path):
|
|
database = SessionDB(tmp_path / "state.db")
|
|
try:
|
|
yield database
|
|
finally:
|
|
database.close()
|
|
|
|
|
|
def _compression_pair(db: SessionDB):
|
|
base = time.time() - 100
|
|
db.create_session("root", source="cli")
|
|
db.create_session("tip", source="cli", parent_session_id="root")
|
|
db._conn.execute(
|
|
"UPDATE sessions SET started_at = ?, ended_at = ?, end_reason = 'compression', message_count = 1 WHERE id = 'root'",
|
|
(base, base + 10),
|
|
)
|
|
db._conn.execute(
|
|
"UPDATE sessions SET started_at = ?, message_count = 1 WHERE id = 'tip'",
|
|
(base + 20,),
|
|
)
|
|
db._conn.commit()
|
|
|
|
|
|
def test_archiving_compression_tip_archives_projected_root(db):
|
|
_compression_pair(db)
|
|
|
|
assert db.set_session_archived("tip", True) is True
|
|
|
|
assert db.get_session("root")["archived"] == 1
|
|
assert db.get_session("tip")["archived"] == 1
|
|
assert [s["id"] for s in db.list_sessions_rich(order_by_last_active=True)] == []
|
|
assert [s["id"] for s in db.list_sessions_rich(order_by_last_active=True, archived_only=True)] == ["tip"]
|
|
|
|
|
|
def test_unarchiving_compression_tip_unarchives_projected_root(db):
|
|
_compression_pair(db)
|
|
db.set_session_archived("tip", True)
|
|
|
|
assert db.set_session_archived("tip", False) is True
|
|
|
|
assert db.get_session("root")["archived"] == 0
|
|
assert db.get_session("tip")["archived"] == 0
|
|
assert [s["id"] for s in db.list_sessions_rich(order_by_last_active=True)] == ["tip"]
|
|
|
|
|
|
def test_archived_only_view_includes_hidden_archived_sessions(db):
|
|
"""The archived-only view is the recovery surface: a session that is both
|
|
archived and hidden (Bot Mode marks its sessions hidden) must appear
|
|
there, otherwise it is unreachable from every UI list (#90946)."""
|
|
db.create_session("plain", source="cli")
|
|
db.create_session("both", source="cli")
|
|
assert db.set_session_hidden("both", True) is True
|
|
assert db.set_session_archived("both", True) is True
|
|
|
|
# Default list: hidden rows stay excluded (unchanged behaviour)...
|
|
assert [s["id"] for s in db.list_sessions_rich(order_by_last_active=True)] == ["plain"]
|
|
# ...and the archived-only view must surface the archived+hidden row.
|
|
assert [s["id"] for s in db.list_sessions_rich(order_by_last_active=True, archived_only=True)] == ["both"]
|
|
|
|
|
|
def _stale_lineage(db: SessionDB, prefix: str) -> tuple[str, str]:
|
|
"""root(compression, 40 days old) -> tip; the tip's state is the caller's."""
|
|
root, tip = f"{prefix}-root", f"{prefix}-tip"
|
|
db.create_session(root, source="feishu")
|
|
db.create_session(tip, source="feishu", parent_session_id=root)
|
|
base = time.time() - 40 * 86400
|
|
db._conn.execute(
|
|
"UPDATE sessions SET started_at = ?, ended_at = ?, end_reason = 'compression', last_activity_at = ? WHERE id = ?",
|
|
(base, base + 10, base + 10, root))
|
|
db._conn.commit()
|
|
return root, tip
|
|
|
|
|
|
def test_bulk_archive_matches_a_lineage_through_its_tip_only(db):
|
|
"""#115489: `hermes sessions archive --older-than` must never hide an OPEN, active continuation
|
|
because its compression ancestor is old — the lineage is archived through its tip, and an idle
|
|
ended tip still takes its whole chain with it."""
|
|
live_root, live_tip = _stale_lineage(db, "live")
|
|
db.append_message(live_tip, "user", "still chatting")
|
|
stale_root, stale_tip = _stale_lineage(db, "stale")
|
|
stale = time.time() - 35 * 86400
|
|
db._conn.execute("UPDATE sessions SET started_at = ?, ended_at = ?, end_reason = 'cli_close', last_activity_at = ? "
|
|
"WHERE id = ?", (stale, stale + 10, stale + 10, stale_tip))
|
|
db._conn.commit()
|
|
|
|
assert [r["id"] for r in db.list_prune_candidates(older_than_days=30, archived=False, lineage_tips_only=True)] == [stale_tip]
|
|
assert db.archive_sessions(older_than_days=30) == 1
|
|
|
|
assert {s: db.get_session(s)["archived"] for s in (live_root, live_tip)} == {live_root: 0, live_tip: 0}
|
|
assert {s: db.get_session(s)["archived"] for s in (stale_root, stale_tip)} == {stale_root: 1, stale_tip: 1}
|
|
assert [s["id"] for s in db.list_sessions_rich(order_by_last_active=True)] == [live_tip]
|