hermes-agent/tests/hermes_state/test_prune_activity_recency.py
kshitijk4poor f1ad1934a4 fix(sessions): pinned-skip note counts pinned rows, not spared ancestors
_note_pinned_skipped diffed count_prune_matches(include_pinned=True/False)
with whole_lineages on for prune. Excluding a pinned tip turns it into an
unmatched continuation, so its unpinned compression ancestors drop out of
the "without" count too and the note reported them as pinned (chain
a -> a-2 -> a-3 with only a-3 pinned said "3 pinned sessions").

Count plain filter matches for the note; the delete itself is unchanged.
count_prune_matches has no other caller that needs whole_lineages, so the
keyword goes back to base's signature.
2026-09-27 00:43:39 +05:30

88 lines
4.4 KiB
Python

import time
from contextlib import closing
import pytest
from hermes_cli.sessions_cmd import _note_pinned_skipped
from hermes_state import SessionDB
def test_prune_sessions_respects_touch_session_activity(tmp_path):
with closing(SessionDB(tmp_path / "state.db")) as db:
now = time.time()
old_time = now - 100 * 86400 # 100 days ago
recent_time = now - 2 * 86400 # 2 days ago
# Session with older messages and started_at, but recent heartbeat / activity
db.create_session("active_by_heartbeat", source="cli")
db.append_message("active_by_heartbeat", "user", "hello", timestamp=old_time)
db.end_session("active_by_heartbeat", "done")
db._conn.execute(
"UPDATE sessions SET started_at = ?, ended_at = ? WHERE id = ?",
(old_time, old_time, "active_by_heartbeat"),
)
db._conn.commit()
db.touch_session_activity("active_by_heartbeat", ts=recent_time)
# Truly old session
db.create_session("truly_old", source="cli")
db.append_message("truly_old", "user", "old message", timestamp=old_time)
db.end_session("truly_old", "done")
db._conn.execute(
"UPDATE sessions SET started_at = ?, ended_at = ? WHERE id = ?",
(old_time, old_time, "truly_old"),
)
db._conn.commit()
# Check dry-run candidates
candidates = db.list_prune_candidates(older_than_days=10)
candidate_ids = [c["id"] for c in candidates]
assert "active_by_heartbeat" not in candidate_ids
assert "truly_old" in candidate_ids
candidate_map = {c["id"]: c for c in db.list_prune_candidates(older_than_days=None)}
assert candidate_map["active_by_heartbeat"]["last_active"] == pytest.approx(recent_time, abs=1.0)
# Pruning sessions older than 10 days should spare active_by_heartbeat
pruned = db.prune_sessions(older_than_days=10)
assert pruned == 1
assert db.get_session("truly_old") is None
assert db.get_session("active_by_heartbeat") is not None
def test_prune_keeps_the_compressed_segments_of_a_chat_still_in_use(tmp_path, capsys):
"""A rotated conversation ages as one: its old compressed-away segments stay while a later segment
is still in use, and go together once the whole chat is idle. The CLI/dashboard preview lists what prune deletes."""
with closing(SessionDB(tmp_path / "state.db")) as db:
old = time.time() - 120 * 86400
def rotate(parent, child, at):
db.publish_compression_child(parent_session_id=parent, child_session_id=child, source="cli",
messages=[{"role": "user", "content": "[summary]", "timestamp": at}],
require_compression_lease=False)
db._conn.execute("UPDATE sessions SET ended_at = ? WHERE id = ?", (at, parent))
db._conn.execute("UPDATE sessions SET started_at = ? WHERE id = ?", (at, child))
db._conn.commit()
for chat in ("live", "idle"):
db.create_session(chat, source="cli")
db.append_message(chat, "user", f"{chat} early detail", timestamp=old)
db._conn.execute("UPDATE sessions SET started_at = ? WHERE id = ?", (old, chat))
db._conn.commit()
rotate(chat, f"{chat}-2", old + 60)
rotate(f"{chat}-2", f"{chat}-3", old + 120)
db.append_message("live-3", "user", "still talking today")
db.end_session("idle-3", "done")
db._conn.execute("UPDATE sessions SET ended_at = ? WHERE id = 'idle-3'", (old + 180,))
db._conn.commit()
idle = {"idle", "idle-2", "idle-3"}
# The CLI pinned-skip note counts pinned rows, not the unpinned ancestors a pinned tip spares.
db._conn.execute("UPDATE sessions SET pinned = 1 WHERE id = 'idle-3'")
db._conn.commit()
_note_pinned_skipped(db, {"older_than_days": 90, "lineage_tips_only": False}, "prune")
assert "Note: 1 pinned session also match" in capsys.readouterr().out
db._conn.execute("UPDATE sessions SET pinned = 0 WHERE id = 'idle-3'")
db._conn.commit()
assert {c["id"] for c in db.list_prune_candidates(older_than_days=90, whole_lineages=True)} == idle
assert db.prune_sessions(older_than_days=90) == len(idle)
assert db.get_compression_lineage("live-3") == ["live", "live-2", "live-3"]
assert not any(db.get_session(sid) for sid in idle)