mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
296 lines
11 KiB
Python
296 lines
11 KiB
Python
"""An existing database's journal mode must not be rewritten silently (#89293).
|
|
|
|
``PRAGMA journal_mode`` is a property of the FILE. Switching an existing
|
|
database to WAL rewrites its header and outlives the process that did it.
|
|
|
|
``apply_wal_with_fallback`` already treats on-disk WAL as authoritative and
|
|
refuses to live-downgrade it. The mirror case had no protection at all: an
|
|
on-disk DELETE database was flipped to WAL by the *default* configured value,
|
|
with no log line -- so an operator who set DELETE on the file (the documented
|
|
mitigation for the SQLite 3.50.4 WAL-reset bug) had no way to learn their
|
|
choice had been overwritten, or that ``database.journal_mode`` is the lever
|
|
that makes it stick.
|
|
|
|
#89293 is the field report: after upgrading past the vulnerable SQLite,
|
|
``is_sqlite_wal_reset_vulnerable()`` stopped short-circuiting to DELETE and
|
|
4 of 5 databases silently returned to WAL.
|
|
|
|
This is a LOG-ONLY change. Half of these tests exist to prove that: the return
|
|
value, the resulting header, and the never-live-downgrade rule are all pinned
|
|
unchanged, and the brand-new-database case must stay silent or the warning
|
|
would fire on every fresh install.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sqlite3
|
|
|
|
import pytest
|
|
|
|
import hermes_state_wal
|
|
import hermes_yaml as yaml
|
|
|
|
|
|
def _write_config(monkeypatch: pytest.MonkeyPatch, tmp_path, config: object) -> None:
|
|
home = tmp_path / "hermes-home"
|
|
home.mkdir(exist_ok=True)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
(home / "config.yaml").write_text(yaml.safe_dump(config), encoding="utf-8")
|
|
|
|
|
|
def _configure_mode(monkeypatch: pytest.MonkeyPatch, tmp_path, mode: object) -> None:
|
|
_write_config(monkeypatch, tmp_path, {"database": {"journal_mode": mode}})
|
|
|
|
|
|
def _disable_vulnerable_gate(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: False,
|
|
)
|
|
|
|
|
|
def _make_delete_db_with_content(path) -> None:
|
|
"""Create a real, non-empty database left in journal_mode=DELETE."""
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
assert conn.execute("PRAGMA journal_mode=DELETE").fetchone()[0].lower() == "delete"
|
|
conn.execute("CREATE TABLE t (x)")
|
|
conn.execute("INSERT INTO t VALUES (1)")
|
|
conn.commit()
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_dedup():
|
|
"""Order-independence: the warning is deduped per process per db_label."""
|
|
|
|
hermes_state_wal._journal_upgrade_warned_paths.clear()
|
|
yield
|
|
hermes_state_wal._journal_upgrade_warned_paths.clear()
|
|
|
|
|
|
|
|
|
|
class TestTheWarningFires:
|
|
|
|
def test_an_existing_delete_database_warns_when_flipped(
|
|
self, monkeypatch, tmp_path, caplog
|
|
):
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
path = tmp_path / "existing-delete.db"
|
|
_make_delete_db_with_content(path)
|
|
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="state.db") == "wal"
|
|
finally:
|
|
conn.close()
|
|
|
|
blob = "\n".join(r.getMessage() for r in caplog.records)
|
|
assert "state.db" in blob
|
|
assert "delete" in blob.lower()
|
|
|
|
|
|
def test_the_flip_still_happens(self, monkeypatch, tmp_path):
|
|
"""Log-only: WAL is still applied, and it still persists.
|
|
|
|
Staying on DELETE is itself treated as a defect elsewhere in the tree
|
|
(managed_uv repairs it on update, citing ~2600x slower appends), so
|
|
this must warn about the change without preventing it.
|
|
"""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
path = tmp_path / "existing-delete.db"
|
|
_make_delete_db_with_content(path)
|
|
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
assert apply_wal_with_fallback(conn, db_label="state.db") == "wal"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
finally:
|
|
conn.close()
|
|
|
|
def test_it_fires_once_per_process_per_database(
|
|
self, monkeypatch, tmp_path, caplog
|
|
):
|
|
"""kanban opens a connection per operation; undeduped this is a flood."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
for name in ("a", "b"):
|
|
path = tmp_path / f"{name}.db"
|
|
_make_delete_db_with_content(path)
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
apply_wal_with_fallback(conn, db_label="same-label.db")
|
|
finally:
|
|
conn.close()
|
|
|
|
hits = [r for r in caplog.records if "same-label.db" in r.getMessage()]
|
|
assert len(hits) == 1, f"expected one deduped warning, got {len(hits)}"
|
|
|
|
def test_a_second_database_gets_its_own_warning(
|
|
self, monkeypatch, tmp_path, caplog
|
|
):
|
|
"""#89293 saw four databases flip. Dedup is per label, not global."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
for label in ("state.db", "kanban.db"):
|
|
path = tmp_path / f"{label}"
|
|
_make_delete_db_with_content(path)
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
apply_wal_with_fallback(conn, db_label=label)
|
|
finally:
|
|
conn.close()
|
|
|
|
blob = "\n".join(r.getMessage() for r in caplog.records)
|
|
assert "state.db" in blob and "kanban.db" in blob
|
|
|
|
|
|
class TestTheWarningStaysQuiet:
|
|
"""Every one of these would be a false positive shipped to every user."""
|
|
|
|
def test_a_brand_new_database_is_silent(self, monkeypatch, tmp_path, caplog):
|
|
"""The load-bearing guard.
|
|
|
|
A fresh file reports journal_mode=delete (SQLite's default) and is
|
|
about to be switched to WAL, which looks identical to the reported
|
|
bug from `current_mode` alone. Only page_count tells them apart, and
|
|
every opener applies WAL before creating any schema -- so without
|
|
this guard the warning fires on every first run of every install.
|
|
"""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
|
|
conn = sqlite3.connect(str(tmp_path / "fresh.db"))
|
|
try:
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="fresh.db") == "wal"
|
|
finally:
|
|
conn.close()
|
|
|
|
assert not [r for r in caplog.records if "fresh.db" in r.getMessage()]
|
|
|
|
def test_an_existing_wal_database_is_silent(self, monkeypatch, tmp_path, caplog):
|
|
"""No flip happens: the probe returns early. Nothing to report."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
path = tmp_path / "already-wal.db"
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
conn.execute("PRAGMA journal_mode=WAL")
|
|
conn.execute("CREATE TABLE t (x)")
|
|
conn.commit()
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="already-wal.db") == "wal"
|
|
finally:
|
|
conn.close()
|
|
|
|
assert not [r for r in caplog.records if "already-wal.db" in r.getMessage()]
|
|
|
|
def test_configured_delete_is_silent(self, monkeypatch, tmp_path, caplog):
|
|
"""The operator used the durable lever. There is nothing to tell them."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
path = tmp_path / "configured-delete.db"
|
|
_make_delete_db_with_content(path)
|
|
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="configured-delete.db") == "delete"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "delete"
|
|
finally:
|
|
conn.close()
|
|
|
|
assert not [
|
|
r for r in caplog.records if "configured-delete.db" in r.getMessage()
|
|
]
|
|
|
|
def test_the_wal_reset_vulnerable_path_is_silent(
|
|
self, monkeypatch, tmp_path, caplog
|
|
):
|
|
"""That branch returns before any flip, so it must not warn.
|
|
|
|
It is also the branch that KEPT #89293's databases on DELETE before
|
|
the SQLite upgrade -- warning here would blame the guard that was
|
|
doing its job.
|
|
"""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: True,
|
|
)
|
|
path = tmp_path / "vulnerable.db"
|
|
_make_delete_db_with_content(path)
|
|
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
with caplog.at_level("WARNING", logger="hermes_state"):
|
|
apply_wal_with_fallback(conn, db_label="vulnerable.db")
|
|
finally:
|
|
conn.close()
|
|
|
|
assert not [
|
|
r
|
|
for r in caplog.records
|
|
if "database.journal_mode" in r.getMessage()
|
|
]
|
|
|
|
|
|
class TestTheExistingContractIsUnchanged:
|
|
"""Behaviour preservation for the rules this change sits next to."""
|
|
|
|
def test_on_disk_wal_is_still_never_live_downgraded(self, monkeypatch, tmp_path):
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
path = tmp_path / "existing-wal.db"
|
|
conn = sqlite3.connect(str(path))
|
|
try:
|
|
assert conn.execute("PRAGMA journal_mode=WAL").fetchone()[0].lower() == "wal"
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: True,
|
|
)
|
|
assert apply_wal_with_fallback(conn, db_label="existing-wal.db") == "wal"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
finally:
|
|
conn.close()
|
|
|
|
def test_default_config_still_yields_wal_on_a_fresh_database(
|
|
self, monkeypatch, tmp_path
|
|
):
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
conn = sqlite3.connect(str(tmp_path / "default.db"))
|
|
try:
|
|
assert apply_wal_with_fallback(conn, db_label="default.db") == "wal"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
finally:
|
|
conn.close()
|