mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
372 lines
14 KiB
Python
372 lines
14 KiB
Python
"""Behavioral coverage for #68545's centralized journal-mode setting."""
|
|
|
|
from __future__ import annotations
|
|
|
|
import sqlite3
|
|
|
|
import pytest
|
|
|
|
import hermes_state_wal
|
|
import hermes_yaml as yaml
|
|
|
|
|
|
def _write_config(monkeypatch: pytest.MonkeyPatch, tmp_path, config: object) -> None:
|
|
home = tmp_path / "hermes-home"
|
|
home.mkdir(exist_ok=True)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
(home / "config.yaml").write_text(
|
|
yaml.safe_dump(config),
|
|
encoding="utf-8",
|
|
)
|
|
|
|
|
|
def _configure_mode(monkeypatch: pytest.MonkeyPatch, tmp_path, mode: object) -> None:
|
|
_write_config(monkeypatch, tmp_path, {"database": {"journal_mode": mode}})
|
|
|
|
|
|
def _disable_vulnerable_gate(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: False,
|
|
)
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _reset_configured_delete_override_warned_paths():
|
|
"""Reset the configured-delete-override warned-paths set so the
|
|
once-per-process-per-db_label dedup doesn't leak between tests."""
|
|
|
|
hermes_state_wal._delete_overridden_warned_paths.clear()
|
|
yield
|
|
hermes_state_wal._delete_overridden_warned_paths.clear()
|
|
|
|
|
|
def test_wal_probe_unknown_never_emits_set_pragma(monkeypatch, tmp_path, caplog):
|
|
"""Probe failure (None) on the configured-WAL path must not reach any journal-mode
|
|
pragma: the file may be held by a sibling whose -wal/-shm sidecars WAL-init would
|
|
unlink. The DELETE branch already refused; this binds the WAL branch to the same rule,
|
|
and ``require_wal=True`` must raise instead of reporting an unverified "wal"."""
|
|
import logging
|
|
|
|
from hermes_state_wal import WalUnsupportedError, apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
hermes_state_wal._wal_probe_unknown_paths.clear()
|
|
|
|
class _SpyConnection(sqlite3.Connection):
|
|
def __init__(self, *args, **kwargs):
|
|
super().__init__(*args, **kwargs)
|
|
self.pragmas: list[str] = []
|
|
|
|
def execute(self, sql, *args, **kwargs): # type: ignore[override]
|
|
if str(sql).lstrip().lower().startswith("pragma"):
|
|
self.pragmas.append(str(sql))
|
|
return super().execute(sql, *args, **kwargs)
|
|
|
|
db_path = tmp_path / "probe-unknown.db"
|
|
sibling = sqlite3.connect(str(db_path))
|
|
try:
|
|
assert sibling.execute("PRAGMA journal_mode=WAL").fetchone()[0].lower() == "wal"
|
|
monkeypatch.setattr("hermes_state_wal._on_disk_journal_mode", lambda _conn: None)
|
|
conn = sqlite3.connect(str(db_path), factory=_SpyConnection)
|
|
try:
|
|
with caplog.at_level(logging.WARNING, logger="hermes_state_wal"):
|
|
assert apply_wal_with_fallback(conn, db_label="probe-unknown.db") == "wal"
|
|
assert conn.pragmas == [] # nothing touched while ownership is unproven
|
|
assert sibling.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
assert any("could not verify the on-disk journal mode" in r.getMessage() for r in caplog.records)
|
|
with pytest.raises(WalUnsupportedError, match="could not verify the on-disk journal mode"):
|
|
apply_wal_with_fallback(conn, db_label="probe-unknown.db", require_wal=True)
|
|
assert conn.pragmas == []
|
|
finally:
|
|
conn.close()
|
|
finally:
|
|
sibling.close()
|
|
|
|
|
|
|
|
|
|
def test_resolve_journal_mode_uses_real_database_config(monkeypatch, tmp_path):
|
|
from hermes_state_wal import resolve_journal_mode
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "DELETE")
|
|
assert resolve_journal_mode() == "delete"
|
|
|
|
|
|
def test_new_nonsecret_hermes_env_override_is_not_exposed(monkeypatch, tmp_path):
|
|
from hermes_state_wal import resolve_journal_mode
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
monkeypatch.setenv("HERMES_JOURNAL_MODE", "delete")
|
|
assert resolve_journal_mode() == "wal"
|
|
|
|
|
|
@pytest.mark.parametrize("value", ["bogus", "truncate", None, 42, {"bad": "shape"}])
|
|
def test_invalid_config_value_falls_back_to_wal(monkeypatch, tmp_path, value):
|
|
from hermes_state_wal import resolve_journal_mode
|
|
|
|
_configure_mode(monkeypatch, tmp_path, value)
|
|
assert resolve_journal_mode() == "wal"
|
|
|
|
|
|
@pytest.mark.parametrize("database", [[], "delete", 42, None])
|
|
def test_malformed_database_section_falls_back_to_wal(
|
|
monkeypatch, tmp_path, database
|
|
):
|
|
from hermes_state_wal import resolve_journal_mode
|
|
|
|
_write_config(monkeypatch, tmp_path, {"database": database})
|
|
assert resolve_journal_mode() == "wal"
|
|
|
|
|
|
def test_apply_wal_with_fallback_honors_delete_config(monkeypatch, tmp_path):
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
conn = sqlite3.connect(tmp_path / "configured.db")
|
|
try:
|
|
assert apply_wal_with_fallback(conn, db_label="configured.db") == "delete"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "delete"
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_apply_wal_with_fallback_defaults_to_wal(monkeypatch, tmp_path):
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "wal")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
conn = sqlite3.connect(tmp_path / "default.db")
|
|
try:
|
|
assert apply_wal_with_fallback(conn, db_label="default.db") == "wal"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_configured_delete_validates_vulnerable_sqlite_result(monkeypatch, tmp_path):
|
|
"""The safety gate must not report DELETE when SQLite returns MEMORY."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: True,
|
|
)
|
|
conn = sqlite3.connect(":memory:")
|
|
try:
|
|
with pytest.raises(sqlite3.OperationalError, match="configured.*delete"):
|
|
apply_wal_with_fallback(conn, db_label="memory-configured.db")
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "memory"
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_configured_delete_never_live_downgrades_existing_wal(monkeypatch, tmp_path, caplog):
|
|
"""Keeping WAL is correct, but the operator must be told their configured
|
|
delete had no effect (otherwise the DB silently stays WAL and the protection
|
|
they configured never applies)."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
db_path = tmp_path / "existing-wal.db"
|
|
conn = sqlite3.connect(db_path)
|
|
try:
|
|
assert conn.execute("PRAGMA journal_mode=WAL").fetchone()[0].lower() == "wal"
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: True,
|
|
)
|
|
with caplog.at_level("ERROR", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="existing-wal.db") == "wal"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
assert any(
|
|
"database.journal_mode=delete is configured" in r.message
|
|
and "on-disk" in r.message
|
|
for r in caplog.records
|
|
), "expected a warning that configured delete was overridden by on-disk WAL"
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_configured_delete_overridden_warns_on_non_vulnerable_runtime_too(monkeypatch, tmp_path, caplog):
|
|
"""When the SQLite runtime is NOT WAL-reset-vulnerable (e.g. after a
|
|
3.51.3+ upgrade), the on-disk WAL + configured-delete case reaches the
|
|
read-only probe path instead of the vulnerability path. That path used to
|
|
return WAL with no signal at all; it must emit the same override warning."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
db_path = tmp_path / "existing-wal.db"
|
|
conn = sqlite3.connect(db_path)
|
|
try:
|
|
assert conn.execute("PRAGMA journal_mode=WAL").fetchone()[0].lower() == "wal"
|
|
with caplog.at_level("ERROR", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="existing-wal.db") == "wal"
|
|
assert apply_wal_with_fallback(conn, db_label="existing-wal.db") == "wal"
|
|
assert conn.execute("PRAGMA journal_mode").fetchone()[0].lower() == "wal"
|
|
warnings = [
|
|
r for r in caplog.records
|
|
if "database.journal_mode=delete is configured" in r.message
|
|
]
|
|
assert len(warnings) == 1, (
|
|
"probe path must warn when configured delete is overridden by on-disk WAL, "
|
|
"and dedup to one per process per db_label"
|
|
)
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_configured_delete_overridden_warning_fires_once_per_db(monkeypatch, tmp_path, caplog):
|
|
"""The override warning is deduped per process per db_label (same discipline
|
|
as the WAL-fallback warning), so repeated connections don't flood the log."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
monkeypatch.setattr(
|
|
"hermes_state_wal.is_sqlite_wal_reset_vulnerable",
|
|
lambda **kwargs: True,
|
|
)
|
|
db_path = tmp_path / "existing-wal.db"
|
|
conn = sqlite3.connect(db_path)
|
|
try:
|
|
conn.execute("PRAGMA journal_mode=WAL").fetchone()
|
|
with caplog.at_level("ERROR", logger="hermes_state"):
|
|
assert apply_wal_with_fallback(conn, db_label="once.db") == "wal"
|
|
assert apply_wal_with_fallback(conn, db_label="once.db") == "wal"
|
|
assert apply_wal_with_fallback(conn, db_label="once.db") == "wal"
|
|
warnings = [
|
|
r for r in caplog.records
|
|
if "database.journal_mode=delete is configured" in r.message
|
|
]
|
|
assert len(warnings) == 1, "override warning must fire once per process per db_label"
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_configured_delete_with_require_wal_and_existing_wal_returns_wal(monkeypatch, tmp_path, caplog):
|
|
"""Pin the require_wal=True + configured=delete + on-disk WAL edge case: the
|
|
existing-WAL probe branch returns "wal" unconditionally (require_wal only
|
|
governs the WAL-refusal fallback paths), so the override warning fires and no
|
|
WalUnsupportedError is raised."""
|
|
from hermes_state_wal import apply_wal_with_fallback
|
|
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
db_path = tmp_path / "existing-wal.db"
|
|
conn = sqlite3.connect(db_path)
|
|
try:
|
|
assert conn.execute("PRAGMA journal_mode=WAL").fetchone()[0].lower() == "wal"
|
|
with caplog.at_level("ERROR", logger="hermes_state"):
|
|
result = apply_wal_with_fallback(
|
|
conn, db_label="existing-wal.db", require_wal=True
|
|
)
|
|
assert result == "wal"
|
|
assert any(
|
|
"database.journal_mode=delete is configured" in r.message
|
|
for r in caplog.records
|
|
)
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_real_db_openers_honor_configured_delete(monkeypatch, tmp_path):
|
|
"""All helper-routed file-backed openers must behaviorally use DELETE."""
|
|
_configure_mode(monkeypatch, tmp_path, "delete")
|
|
_disable_vulnerable_gate(monkeypatch)
|
|
|
|
from agent import verification_evidence
|
|
from cron import executions
|
|
from gateway import delivery_ledger
|
|
from gateway.platforms.api_server import ResponseStore
|
|
from hermes_cli import projects_db
|
|
from hermes_cli import kanban_db_connect as kbc
|
|
from hermes_state import SessionDB
|
|
from plugins.memory.holographic.store import MemoryStore
|
|
from plugins.platforms.discord.recovery import DiscordRecoveryStore
|
|
from tools import async_delegation
|
|
|
|
observed: dict[str, str] = {}
|
|
|
|
for name, connect in (
|
|
("async_delegation", async_delegation._connect),
|
|
("delivery_ledger", delivery_ledger._connect),
|
|
("verification_evidence", verification_evidence._connect),
|
|
):
|
|
conn = connect()
|
|
try:
|
|
observed[name] = conn.execute("PRAGMA journal_mode").fetchone()[0].lower()
|
|
finally:
|
|
conn.close()
|
|
|
|
monkeypatch.setattr(executions, "EXECUTIONS_FILE", tmp_path / "cron" / "executions.db")
|
|
executions.EXECUTIONS_FILE.parent.mkdir(parents=True, exist_ok=True)
|
|
cron_conn = executions._connect()
|
|
try:
|
|
executions._initialize_schema(cron_conn)
|
|
observed["cron_executions"] = cron_conn.execute(
|
|
"PRAGMA journal_mode"
|
|
).fetchone()[0].lower()
|
|
finally:
|
|
cron_conn.close()
|
|
|
|
discord = DiscordRecoveryStore(hermes_home=tmp_path)
|
|
observed["discord_recovery"] = discord.call(
|
|
lambda conn: conn.execute("PRAGMA journal_mode").fetchone()[0].lower()
|
|
)
|
|
|
|
session_db = SessionDB(db_path=tmp_path / "state.db")
|
|
try:
|
|
observed["session_db"] = session_db._conn.execute(
|
|
"PRAGMA journal_mode"
|
|
).fetchone()[0].lower()
|
|
finally:
|
|
session_db.close()
|
|
|
|
kanban_conn = kbc.connect(db_path=tmp_path / "kanban.db")
|
|
try:
|
|
observed["kanban"] = kanban_conn.execute(
|
|
"PRAGMA journal_mode"
|
|
).fetchone()[0].lower()
|
|
finally:
|
|
kanban_conn.close()
|
|
|
|
projects_conn = projects_db.connect(db_path=tmp_path / "projects.db")
|
|
try:
|
|
observed["projects"] = projects_conn.execute(
|
|
"PRAGMA journal_mode"
|
|
).fetchone()[0].lower()
|
|
finally:
|
|
projects_conn.close()
|
|
|
|
holographic = MemoryStore(db_path=tmp_path / "memory_store.db")
|
|
try:
|
|
observed["holographic"] = holographic._conn.execute(
|
|
"PRAGMA journal_mode"
|
|
).fetchone()[0].lower()
|
|
finally:
|
|
holographic.close()
|
|
|
|
response_store = ResponseStore(db_path=str(tmp_path / "response_store.db"))
|
|
try:
|
|
observed["response_store"] = response_store._conn.execute(
|
|
"PRAGMA journal_mode"
|
|
).fetchone()[0].lower()
|
|
finally:
|
|
response_store.close()
|
|
|
|
assert observed == {
|
|
"async_delegation": "delete",
|
|
"delivery_ledger": "delete",
|
|
"verification_evidence": "delete",
|
|
"cron_executions": "delete",
|
|
"discord_recovery": "delete",
|
|
"session_db": "delete",
|
|
"kanban": "delete",
|
|
"projects": "delete",
|
|
"holographic": "delete",
|
|
"response_store": "delete",
|
|
}
|