hermes-agent/tests/hermes_state/test_guest_durability_barriers.py
teknium1 d10bb2ab6f test: make tests/ mirror the source tree; drop issue numbers from filenames
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.

Parallel directories for one source package, folded into the mirror:
  tests/acp        -> tests/acp_adapter   (its __init__/conftest move with it)
  tests/cli        -> tests/hermes_cli    (prompt_toolkit fixture merged into
                                           hermes_cli/conftest.py)
  tests/run_agent  -> tests/agent         (backoff fixture becomes
                                           agent/conftest.py)
  tests/relay      -> tests/gateway/relay
  tests/state      -> tests/hermes_state

246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.

Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.

Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).

Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
2026-09-13 09:18:02 -07:00

68 lines
2.3 KiB
Python

"""Guest ledger connections must inherit the configured database.synchronous.
apply_durability_barriers() is the guest-connection entry point (secondary
state.db users that must NOT touch journal mode). The configured
``database.synchronous`` level normally rides on apply_database_pragmas()
during the owner's journal-mode setup — a path guests deliberately skip — so
the guest entry point applies it directly.
"""
import sqlite3
import pytest
import hermes_state
from hermes_state_repair import apply_durability_barriers
def _config(monkeypatch, database_section):
import hermes_cli.config as config_mod
cfg = {"database": database_section}
monkeypatch.setattr(config_mod, "load_config_readonly", lambda *a, **k: cfg)
return cfg
def test_guest_barriers_apply_configured_synchronous(monkeypatch, tmp_path):
_config(monkeypatch, {"synchronous": "FULL"})
conn = sqlite3.connect(tmp_path / "state.db")
try:
conn.execute("PRAGMA journal_mode=DELETE")
conn.execute("PRAGMA synchronous=1")
apply_durability_barriers(conn)
assert conn.execute("PRAGMA synchronous").fetchone()[0] == 2
# And the journal mode was NOT touched — that is the whole contract.
assert (
str(conn.execute("PRAGMA journal_mode").fetchone()[0]).lower()
== "delete"
)
finally:
conn.close()
def test_guest_barriers_leave_synchronous_alone_when_unset(monkeypatch, tmp_path):
_config(monkeypatch, {})
conn = sqlite3.connect(tmp_path / "state.db")
try:
conn.execute("PRAGMA journal_mode=DELETE")
conn.execute("PRAGMA synchronous=1")
apply_durability_barriers(conn)
assert conn.execute("PRAGMA synchronous").fetchone()[0] == 1
finally:
conn.close()
def test_guest_barriers_survive_config_failure(monkeypatch, tmp_path):
import hermes_cli.config as config_mod
def _boom(*a, **k):
raise RuntimeError("config unavailable")
monkeypatch.setattr(config_mod, "load_config_readonly", _boom)
conn = sqlite3.connect(tmp_path / "state.db")
try:
conn.execute("PRAGMA journal_mode=DELETE")
# Must not raise; best-effort like every other pragma path.
apply_durability_barriers(conn)
finally:
conn.close()