hermes-agent/tests/hermes_state/test_fts_fresh_bootstrap_admission.py
teknium1 d10bb2ab6f test: make tests/ mirror the source tree; drop issue numbers from filenames
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.

Parallel directories for one source package, folded into the mirror:
  tests/acp        -> tests/acp_adapter   (its __init__/conftest move with it)
  tests/cli        -> tests/hermes_cli    (prompt_toolkit fixture merged into
                                           hermes_cli/conftest.py)
  tests/run_agent  -> tests/agent         (backoff fixture becomes
                                           agent/conftest.py)
  tests/relay      -> tests/gateway/relay
  tests/state      -> tests/hermes_state

246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.

Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.

Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).

Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
2026-09-13 09:18:02 -07:00

77 lines
2.4 KiB
Python

"""Fresh state.db FTS bootstrap must honor cross-process rebuild admission."""
import sqlite3
import subprocess
import sys
from pathlib import Path
import hermes_state_common
from hermes_state import SessionDB
_HOLD_ADMISSION_SCRIPT = """
import sys
import time
from pathlib import Path
from hermes_state_common import fts_rebuild_admission
with fts_rebuild_admission(Path(sys.argv[1]), timeout_seconds=0) as acquired:
assert acquired
print("locked", flush=True)
time.sleep(30)
"""
def _trigram_supported() -> bool:
conn = sqlite3.connect(":memory:")
try:
conn.execute("CREATE VIRTUAL TABLE trigram_probe USING fts5(content, tokenize='trigram')")
except sqlite3.OperationalError:
return False
finally:
conn.close()
return True
def test_fresh_fts_bootstrap_does_not_publish_schema_without_admission(tmp_path, monkeypatch):
"""A fresh opener that loses admission leaves no partially initialized FTS surface."""
db_path = tmp_path / "state.db"
proc = subprocess.Popen(
[sys.executable, "-c", _HOLD_ADMISSION_SCRIPT, str(db_path)],
cwd=Path(__file__).resolve().parents[2],
stdout=subprocess.PIPE,
text=True,
)
try:
assert proc.stdout is not None
assert proc.stdout.readline().strip() == "locked"
monkeypatch.setattr(hermes_state_common, "_FTS_REBUILD_LOCK_TIMEOUT_SECONDS", 0.1)
deferred = SessionDB(db_path=db_path)
try:
assert deferred._fts_stale is True
assert deferred._fts_enabled is False
assert deferred._conn.execute(
"SELECT 1 FROM sqlite_master WHERE name = 'messages_fts'"
).fetchone() is None
finally:
deferred.close()
finally:
proc.kill()
proc.wait(timeout=10)
recovered = SessionDB(db_path=db_path)
try:
assert recovered._fts_stale is False
assert recovered._fts_enabled is True
if _trigram_supported():
assert recovered._trigram_available is True
assert recovered._conn.execute(
"SELECT 1 FROM sqlite_master WHERE name = 'messages_fts_trigram'"
).fetchone() is not None
recovered.create_session("s1", source="test")
recovered.append_message("s1", "user", "fresh bootstrap recovered")
assert recovered.search_messages("recovered")
finally:
recovered.close()