mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
Four origin/main merges brought back `linux_only` / `macos_only` / `windows_only` marks in 41 test files, along with the pre-platforms() versions of scripts/ci/list_os_marked_tests.py and check_os_marker_fakes.py. Because the legacy names are no longer registered, pytest treated them as unknown marks — a warning — so every Windows- or macOS-only test RAN on Linux (test_local_runtime_recovery.py tripped the live-system kill guard). Rewrite the marks, restore the platforms()-aware CI scripts (keeping main's os.walk fix for vanishing __pycache__ dirs), drop the stale _BASELINE entries, and make the conftest reject the retired marks outright so the next merge cannot resurrect them silently.
127 lines
4.6 KiB
Python
127 lines
4.6 KiB
Python
"""Regression for #105670: a halted split-brain/replaced handle must not run ANY checkpoint.
|
|
|
|
After ``DeletedWalGenerationError`` / ``StateDbReplacedError`` the handle is quarantined
|
|
(sticky flags). The close() path and the periodic _try_wal_checkpoint() must skip entirely
|
|
for quarantined handles so no stale-generation frames are checkpointed into the main DB.
|
|
Additionally, _disable_close_time_checkpoint() must run on first halt (3.12+) so SQLite's
|
|
internal last-connection checkpoint is also disabled.
|
|
|
|
Without the guards: a live split-brain writer halts correctly, but the shutdown checkpoint
|
|
converts the contained split-brain into page corruption in the main DB — exactly the #105670
|
|
incident's close-time damage.
|
|
"""
|
|
|
|
import sys
|
|
from pathlib import Path
|
|
from unittest.mock import ANY, patch
|
|
|
|
import pytest
|
|
|
|
import hermes_state
|
|
import hermes_state_wal
|
|
from hermes_state import DeletedWalGenerationError, SessionDB
|
|
|
|
|
|
@pytest.fixture
|
|
def force_wal(monkeypatch):
|
|
"""Pin WAL so this host's vulnerable SQLite still matches production topology."""
|
|
monkeypatch.setattr(
|
|
hermes_state_wal,
|
|
"is_sqlite_wal_reset_vulnerable",
|
|
lambda version_info=None: False,
|
|
)
|
|
monkeypatch.setattr(hermes_state_wal, "resolve_journal_mode", lambda: "wal")
|
|
|
|
|
|
def _make_db(path: Path, session_id: str, content: str) -> SessionDB:
|
|
db = SessionDB(db_path=path)
|
|
db.create_session(session_id, "cli")
|
|
db.append_message(session_id, role="user", content=content)
|
|
return db
|
|
|
|
|
|
def _require_wal(db: SessionDB) -> Path:
|
|
if not db._wal_active:
|
|
db.close()
|
|
pytest.skip("WAL not active on this filesystem")
|
|
wal = Path(str(db.db_path) + "-wal")
|
|
if not wal.exists():
|
|
db.close()
|
|
pytest.skip("WAL sidecar missing after first write")
|
|
return wal
|
|
|
|
|
|
def _unlink_sidecars(db_path: Path) -> None:
|
|
import os
|
|
|
|
for suffix in ("-wal", "-shm"):
|
|
sidecar = Path(str(db_path) + suffix)
|
|
if sidecar.exists():
|
|
os.unlink(sidecar)
|
|
|
|
|
|
@pytest.mark.platforms("linux") # deleted-WAL write halt uses Linux unlink semantics
|
|
def test_close_after_halt_runs_no_checkpoint(tmp_path, force_wal):
|
|
"""A writer halted by DeletedWalGenerationError must not checkpoint (periodic, VACUUM or close) nor run FTS repair."""
|
|
path = tmp_path / "state.db"
|
|
db = _make_db(path, "s", "before")
|
|
_require_wal(db)
|
|
_unlink_sidecars(path)
|
|
|
|
with pytest.raises(DeletedWalGenerationError):
|
|
db.append_message("s", role="user", content="after-unlink")
|
|
assert db._db_wal_generation_lost is True
|
|
|
|
# Neither the periodic checkpoint, the stale-FTS retry, VACUUM, nor close() may touch the file now.
|
|
with patch.object(db._conn, "execute", wraps=db._conn.execute) as mock_execute:
|
|
db._try_wal_checkpoint()
|
|
db._fts_stale = True
|
|
assert db.retry_deferred_fts_recovery() is False
|
|
with pytest.raises(DeletedWalGenerationError):
|
|
db.vacuum()
|
|
assert not [c for c in mock_execute.call_args_list if "vacuum" in str(c).lower()], "VACUUM ran on a quarantined handle"
|
|
db.close()
|
|
# No checkpoint call should have been made.
|
|
checkpoint_calls = [
|
|
call
|
|
for call in mock_execute.call_args_list
|
|
if "wal_checkpoint" in str(call).lower()
|
|
]
|
|
assert not checkpoint_calls, (
|
|
f"close() ran {len(checkpoint_calls)} checkpoint call(s) on a quarantined handle"
|
|
)
|
|
|
|
|
|
@pytest.mark.platforms("linux") # deleted-WAL write halt uses Linux unlink semantics
|
|
def test_halt_disables_close_time_checkpoint(tmp_path, force_wal):
|
|
"""On 3.12+ the halt must also call _disable_close_time_checkpoint()."""
|
|
import sqlite3
|
|
|
|
flag = getattr(sqlite3, "SQLITE_DBCONFIG_NO_CKPT_ON_CLOSE", None)
|
|
if flag is None:
|
|
pytest.skip("Python 3.12+ SQLITE_DBCONFIG_NO_CKPT_ON_CLOSE not available")
|
|
|
|
path = tmp_path / "state.db"
|
|
db = _make_db(path, "s", "before")
|
|
_require_wal(db)
|
|
|
|
setconfig = getattr(db._conn, "setconfig", None)
|
|
if setconfig is None:
|
|
pytest.skip("Connection.setconfig not available")
|
|
|
|
_unlink_sidecars(path)
|
|
|
|
with patch.object(db._conn, "setconfig", wraps=setconfig) as mock_setconfig:
|
|
with pytest.raises(DeletedWalGenerationError):
|
|
db.append_message("s", role="user", content="after-unlink")
|
|
|
|
# _disable_close_time_checkpoint() must have been called during the halt.
|
|
disable_calls = [
|
|
call
|
|
for call in mock_setconfig.call_args_list
|
|
if call[0][0] == flag and call[0][1] is True
|
|
]
|
|
assert disable_calls, (
|
|
"halt did not call setconfig(SQLITE_DBCONFIG_NO_CKPT_ON_CLOSE, True)"
|
|
)
|
|
db.close()
|