mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
The full_uninstall=True case ran the real macOS full-wipe sweep:
remove_dashboard_launchd_jobs() (launchctl bootout + plist unlink in
~/Library/LaunchAgents), rmtree of ~/Library/Caches/{Hermes,...}, and
uninstall_gui() against /Applications/Hermes.app; on Windows it would
have reached the registry/env/launcher/portable-tooling helpers.
conftest keeps HOME intact and HomeIOGuard only covers ~/.hermes, so
nothing stopped it.
Stub every step that reaches outside tmp_path (launchd jobs, macOS
cache dirs, packaged app paths, _is_windows) and make any stray
shutil.rmtree outside tmp_path or subprocess.run fail loudly. Run the
real uninstall_gui() with desktop_userdata_dir() pointed at a tmp dir
and assert connections.json survives keep-data and is gone after a full
uninstall, instead of spying on the remove_userdata kwarg. Drop the
unused HERMES_HOME / get_project_root / get_hermes_home stubs.
Also fix the sibling full-wipe test's uninstall_gui stub, which now
raised TypeError on remove_userdata= (swallowed by the except).
Co-authored-by: Yuan Li <[email protected]>
129 lines
6.1 KiB
Python
129 lines
6.1 KiB
Python
"""Full-uninstall macOS sweep: dashboard/serve launchd jobs and Electron/setup
|
|
caches that live OUTSIDE HERMES_HOME and survive the home rmtree (#62209)."""
|
|
from __future__ import annotations
|
|
|
|
import plistlib
|
|
import subprocess
|
|
import sys
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from hermes_cli import uninstall
|
|
|
|
|
|
@pytest.mark.skipif(sys.platform != "darwin", reason="macOS-only sweep")
|
|
def test_remove_dashboard_launchd_jobs_boots_out_and_deletes_matching_plists(
|
|
monkeypatch, tmp_path, capsys):
|
|
agents_dir = tmp_path / "LaunchAgents"
|
|
daemons_dir = tmp_path / "LaunchDaemons"
|
|
agents_dir.mkdir()
|
|
daemons_dir.mkdir()
|
|
|
|
def job(label, args, directory):
|
|
path = directory / f"{label}.plist"
|
|
path.write_bytes(plistlib.dumps({
|
|
"Label": label,
|
|
"ProgramArguments": args,
|
|
}))
|
|
return path
|
|
|
|
dashboard = job("com.user.hermes-dashboard",
|
|
["/Users/u/.hermes/hermes-agent/venv/bin/hermes", "dashboard", "--port", "9200"],
|
|
agents_dir)
|
|
serve = job("com.user.hermes-serve", ["hermes", "serve"], agents_dir)
|
|
unrelated = job("com.user.keep", ["/usr/bin/say", "hello"], agents_dir)
|
|
daemon = job("io.nousresearch.hermes-agent.dashboard", ["hermes_cli.main", "dashboard"],
|
|
daemons_dir)
|
|
|
|
booted = []
|
|
monkeypatch.setattr(uninstall.subprocess, "run", lambda cmd, **kw: booted.append(cmd))
|
|
monkeypatch.setattr("hermes_cli.main_dashboard._launchd_plist_dirs",
|
|
lambda: [("agent", agents_dir), ("daemon", daemons_dir)])
|
|
|
|
removed = uninstall.remove_dashboard_launchd_jobs()
|
|
|
|
assert sorted(removed) == sorted([dashboard, serve, daemon])
|
|
assert not dashboard.exists() and not serve.exists() and not daemon.exists()
|
|
assert unrelated.exists() # non-Hermes job is never touched
|
|
domains = {tuple(cmd[2].rsplit("/", 1)) for cmd in booted}
|
|
assert ("com.user.hermes-dashboard", "gui/501") in domains or \
|
|
{d for d, _ in domains} >= {"gui/501", "user/501"} or booted # bootout attempted per domain
|
|
assert all(cmd[:2] == ["launchctl", "bootout"] for cmd in booted)
|
|
|
|
|
|
def test_remove_dashboard_launchd_jobs_skips_malformed_plists(monkeypatch, tmp_path):
|
|
if sys.platform != "darwin":
|
|
pytest.skip("macOS-only sweep")
|
|
agents_dir = tmp_path / "LaunchAgents"
|
|
agents_dir.mkdir()
|
|
(agents_dir / "broken.plist").write_text("<plist><dict>&", encoding="utf-8")
|
|
(agents_dir / "not-a-dict.plist").write_bytes(plistlib.dumps(["nope"]))
|
|
monkeypatch.setattr("hermes_cli.main_dashboard._launchd_plist_dirs",
|
|
lambda: [("agent", agents_dir), ("daemon", tmp_path / "LaunchDaemons")])
|
|
monkeypatch.setattr(uninstall.subprocess, "run", lambda cmd, **kw: None)
|
|
assert uninstall.remove_dashboard_launchd_jobs() == []
|
|
assert (agents_dir / "broken.plist").exists() # skipped, not aborted
|
|
|
|
|
|
@pytest.mark.skipif(sys.platform != "darwin", reason="macOS-only sweep")
|
|
def test_full_uninstall_sweeps_macos_caches_and_dashboard_launchd(monkeypatch, tmp_path):
|
|
"""The full-wipe step must reach the caches + launchd sweep, keep-data must not."""
|
|
project_root = tmp_path / "hermes-agent"
|
|
hermes_home = tmp_path / ".hermes"
|
|
project_root.mkdir()
|
|
# A .git dir marks the tree as a removable git checkout — without it the
|
|
# install-kind gate refuses before the sweep runs.
|
|
(project_root / ".git").mkdir()
|
|
hermes_home.mkdir()
|
|
|
|
removed_caches, removed_jobs = [], []
|
|
cache_dirs = [tmp_path / "caches" / name for name in
|
|
("Hermes", "com.nousresearch.hermes", "hermes-setup",
|
|
"com.nousresearch.hermes.setup")]
|
|
for d in cache_dirs:
|
|
d.mkdir(parents=True)
|
|
(d / "Cache").write_text("x", encoding="utf-8")
|
|
|
|
monkeypatch.setattr(uninstall, "get_project_root", lambda: project_root)
|
|
monkeypatch.setattr(uninstall, "_is_default_hermes_home", lambda home: False)
|
|
monkeypatch.setattr(uninstall, "_discover_named_profiles", lambda: [])
|
|
monkeypatch.setattr(uninstall, "_refuse_if_steward_owned", lambda: None)
|
|
monkeypatch.setattr(uninstall, "uninstall_gateway_service", lambda: True)
|
|
monkeypatch.setattr(uninstall, "remove_path_from_shell_configs", lambda: [])
|
|
monkeypatch.setattr(uninstall, "remove_wrapper_script", lambda: [])
|
|
monkeypatch.setattr(uninstall, "remove_node_symlinks", lambda home: [])
|
|
monkeypatch.setattr(uninstall, "remove_legacy_runtime_trees", lambda home: [])
|
|
monkeypatch.setattr(uninstall, "_rmtree_step",
|
|
lambda path, **kw: None if path in (project_root, hermes_home)
|
|
else (_ for _ in ()).throw(AssertionError(f"unexpected rmtree {path}")))
|
|
monkeypatch.setattr("hermes_cli.gui_uninstall.uninstall_gui", lambda home, **kw: True)
|
|
monkeypatch.setattr(uninstall, "_macos_cache_leftover_dirs", lambda: cache_dirs)
|
|
monkeypatch.setattr(uninstall, "_rmtree_if_exists",
|
|
lambda p: removed_caches.append(p) or True)
|
|
monkeypatch.setattr(uninstall, "remove_dashboard_launchd_jobs",
|
|
lambda: removed_jobs.append("jobs") or [])
|
|
|
|
uninstall.run_uninstall(_args(hermes_home, project_root, full=True, yes=True))
|
|
|
|
assert removed_caches == cache_dirs # Electron + setup caches swept in the full wipe
|
|
assert removed_jobs # dashboard/serve launchd jobs booted out + deleted
|
|
|
|
removed_caches.clear(), removed_jobs.clear()
|
|
uninstall.run_uninstall(_args(hermes_home, project_root, full=False, yes=True))
|
|
assert removed_caches == [] # keep-data never touches caches outside the home
|
|
assert not removed_jobs
|
|
|
|
|
|
def _args(hermes_home, project_root, *, full, yes):
|
|
from types import SimpleNamespace
|
|
import hermes_constants
|
|
monkey = {"HERMES_HOME": str(hermes_home)}
|
|
real_get = hermes_constants.get_hermes_home
|
|
hermes_constants.get_hermes_home = (lambda: Path(monkey["HERMES_HOME"]))
|
|
try:
|
|
# run_uninstall reads HERMES_HOME via the module-level import in uninstall.py
|
|
uninstall.get_hermes_home = lambda: Path(monkey["HERMES_HOME"])
|
|
return SimpleNamespace(dry_run=False, yes=yes, full=full, data=False, gui=False)
|
|
finally:
|
|
hermes_constants.get_hermes_home = real_get
|