mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
Activation reaches plugin discovery before the application dependencies exist. Give PM its own locked Python project and runtime so it can install or repair the application without importing that dependency tree. Keep PM outside the application workspace. A shared uv workspace resolves the application graph and cannot provide this isolation. Route mutations through an isolated worker and preserve transaction callbacks, cancellation, custom package registrations, and correlated receipts. Use the same runtime builder for source installs and packaged payloads. Keep offline wheelhouse support in that builder. Nix builds the independent PM lock as a separate derivation. Refuse lazy-disabled bootstrap before installing tools or dependencies. Move first-party YAML readers and writers to ruamel. Keep the application lock's transitive PyYAML requirements for third-party packages. Verification: - Focused canonical Python suite: 177 passed, 1 host-gated skip. - Electron backend probes: 12 passed. Electron typecheck passed. - Both uv locks, scoped lint, Bash syntax, and whitespace checks passed. - Cold activation, corrupt-app repair, offline staging, and relocation ran. - Built and exercised the Nix PM runtime and standalone YAML merge script. Six broader caller test files retain the same 24 failing test IDs as an archive of HEAD. The existing real-home guard blocks those tests before they can exercise the affected paths. No full-suite pass is claimed. Native Windows signing and full Bionic package execution remain unverified.
119 lines
4.5 KiB
Python
119 lines
4.5 KiB
Python
"""Tests that ``model_catalog.excluded_providers`` hides providers from the
|
|
interactive ``hermes model`` CLI picker.
|
|
|
|
The CLI picker (``hermes_cli.main.select_provider_and_model``) builds its
|
|
provider menu from ``CANONICAL_PROVIDERS`` via ``group_providers`` — a
|
|
separate code path from ``list_authenticated_providers``. These tests
|
|
verify the exclusion config is honored there too, matching the
|
|
gateway/TUI picker behavior.
|
|
"""
|
|
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture
|
|
def config_home(tmp_path, monkeypatch):
|
|
"""Isolated HERMES_HOME with a minimal config."""
|
|
home = tmp_path / "hermes"
|
|
home.mkdir()
|
|
config_yaml = home / "config.yaml"
|
|
config_yaml.write_text("model: old-model\ncustom_providers: []\n")
|
|
env_file = home / ".env"
|
|
env_file.write_text("")
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.delenv("HERMES_MODEL", raising=False)
|
|
monkeypatch.delenv("LLM_MODEL", raising=False)
|
|
monkeypatch.delenv("HERMES_INFERENCE_PROVIDER", raising=False)
|
|
monkeypatch.delenv("OPENAI_BASE_URL", raising=False)
|
|
monkeypatch.delenv("OPENAI_API_KEY", raising=False)
|
|
return home
|
|
|
|
|
|
def _write_config(home, **top_level):
|
|
import hermes_yaml as yaml
|
|
cfg = {"model": "old-model", "custom_providers": []}
|
|
cfg.update(top_level)
|
|
(home / "config.yaml").write_text(yaml.safe_dump(cfg))
|
|
|
|
|
|
def _capture_provider_labels(config_home):
|
|
"""Drive ``select_provider_and_model`` and return the provider-menu labels
|
|
shown to the user (the first ``_prompt_provider_choice`` call). Cancels
|
|
immediately after capturing."""
|
|
from hermes_cli.main import select_provider_and_model
|
|
|
|
captured: dict = {}
|
|
|
|
def _capture_and_cancel(labels, default=0, title=None):
|
|
# Only capture the top-level provider menu (the first call).
|
|
if "labels" not in captured:
|
|
captured["labels"] = list(labels)
|
|
return None # cancel
|
|
|
|
with patch("hermes_cli.main._prompt_provider_choice",
|
|
side_effect=_capture_and_cancel), \
|
|
patch("builtins.print"):
|
|
select_provider_and_model()
|
|
|
|
return captured.get("labels", [])
|
|
|
|
|
|
def test_cli_picker_hides_excluded_provider(config_home):
|
|
"""``excluded_providers: [openrouter]`` must remove the OpenRouter row
|
|
from the ``hermes model`` provider menu."""
|
|
_write_config(config_home, **{"model_catalog": {"excluded_providers": ["openrouter"]}})
|
|
|
|
labels = _capture_provider_labels(config_home)
|
|
assert labels, "provider menu was empty"
|
|
assert not any("OpenRouter" in lbl for lbl in labels), (
|
|
f"OpenRouter should be hidden by excluded_providers, got: {labels}"
|
|
)
|
|
|
|
|
|
def test_cli_picker_hides_excluded_provider_by_alias(config_home):
|
|
"""Exclusion by an alias (not the canonical slug) must also hide the
|
|
provider, matching ``list_authenticated_providers``' matching against
|
|
hermes_id / alias names."""
|
|
# 'openai' is an alias-style hermes id; ensure excluding it hides the
|
|
# canonical openai provider row if present. Use the canonical slug's
|
|
# alias from _PROVIDER_ALIASES to stay robust to renames.
|
|
from hermes_cli.models import _PROVIDER_ALIASES, CANONICAL_PROVIDERS
|
|
|
|
# Find a canonical provider that has at least one alias and is a leaf
|
|
# row (not folded into a multi-member group) so its label appears
|
|
# directly. Pick the first such provider.
|
|
target_slug = None
|
|
target_alias = None
|
|
for alias, canon in _PROVIDER_ALIASES.items():
|
|
if canon and any(p.slug == canon for p in CANONICAL_PROVIDERS):
|
|
target_slug = canon
|
|
target_alias = alias
|
|
break
|
|
if target_slug is None:
|
|
pytest.skip("no aliased canonical provider available to test")
|
|
|
|
from hermes_cli.models import _PROVIDER_LABELS
|
|
target_label_fragment = _PROVIDER_LABELS.get(target_slug, target_slug)
|
|
|
|
# Baseline: the provider appears without exclusion.
|
|
_write_config(config_home)
|
|
baseline = _capture_provider_labels(config_home)
|
|
assert any(target_label_fragment in lbl for lbl in baseline), (
|
|
f"sanity: {target_slug} ({target_label_fragment!r}) should appear by "
|
|
f"default; labels={baseline}"
|
|
)
|
|
|
|
# Excluding by alias hides it.
|
|
_write_config(
|
|
config_home,
|
|
**{"model_catalog": {"excluded_providers": [target_alias]}},
|
|
)
|
|
excluded_labels = _capture_provider_labels(config_home)
|
|
assert not any(target_label_fragment in lbl for lbl in excluded_labels), (
|
|
f"excluding alias {target_alias!r} should hide {target_slug}; "
|
|
f"labels={excluded_labels}"
|
|
)
|
|
|
|
|