mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 03:54:08 +00:00
`named_profile_has_identity` now gates listing/serving/resolution, so a `profiles/<name>` dir created with a bare mkdir is no longer a profile. Production always publishes identity files (`create_profile` seeds config.yaml/.env before the rename), so these fixtures were relying on a contract that never existed in real installs. Each now writes a minimal `config.yaml` marker next to the mkdir (config.yaml rather than SOUL.md or auth.json so tests that own those files stay neutral). Where a file had a shared fixture/helper it is fixed once. Files: tests/gateway/test_multiplex_lifecycle.py tests/gateway/test_multiplex_session_db_profile_scope.py tests/gateway/test_status_command.py tests/hermes_cli/test_apply_profile_override.py tests/hermes_cli/test_dashboard_admin_endpoints.py tests/hermes_cli/test_gateway_multiplex_served_record.py tests/hermes_cli/test_kanban_per_profile_cap.py tests/hermes_cli/test_kanban_review_surfaces.py tests/hermes_cli/test_pooled_served_profile_backend_unscoped.py tests/hermes_cli/test_profiles.py tests/hermes_cli/test_web_oauth_dispatch.py tests/hermes_cli/test_web_profile_soul_writes.py tests/hermes_cli/test_web_profiles_off_loop.py tests/hermes_cli/test_webhook_cli.py tests/tools/test_kanban_tools.py tests/tools/test_local_env_blocklist.py tests/tui_gateway/test_groups_methods.py tests/tui_gateway/test_groups_replication_methods.py tests/tui_gateway/test_hosted_room_settled_retry.py Contract rewrite (old contract asserted a bare dir IS a profile): tests/gateway/test_multiplex_session_db_profile_scope.py:: test_profile_home_is_not_memoized_before_the_profile_exists — after the runtime mkdir the test now asserts `_profile_home_for_key` still returns None (a bare dir is not a profile) and only resolves once the identity marker exists; the not-memoized-miss invariant is kept.
106 lines
4 KiB
Python
106 lines
4 KiB
Python
"""Regression tests for #21582 — per-profile concurrency cap in dispatcher.
|
|
|
|
When ``kanban.max_in_progress_per_profile`` is set, no single profile
|
|
gets more than N workers running at once even if the global
|
|
``max_in_progress`` cap would allow it. Prevents one profile's local
|
|
model / API quota / browser pool from being overwhelmed by a fan-out.
|
|
"""
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import sys
|
|
import tempfile
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture()
|
|
def isolated_kanban_home_with_profiles(monkeypatch):
|
|
"""Spin up a fresh HERMES_HOME with kanban DB + alpha/beta profiles."""
|
|
test_home = tempfile.mkdtemp(prefix="kanban_per_profile_cap_test_")
|
|
for prof in ("alpha", "beta", "default"):
|
|
os.makedirs(os.path.join(test_home, "profiles", prof), exist_ok=True)
|
|
with open(os.path.join(test_home, "profiles", prof, "config.yaml"), "w") as fh:
|
|
fh.write("{}\n") # identity marker: a bare dir is not a profile
|
|
monkeypatch.setenv("HERMES_HOME", test_home)
|
|
for mod in list(sys.modules.keys()):
|
|
if mod.startswith("hermes_cli") or mod.startswith("hermes_state") or mod == "hermes_constants":
|
|
del sys.modules[mod]
|
|
from hermes_cli import kanban_db
|
|
yield kanban_db
|
|
|
|
|
|
def _fake_spawn(*args, **kwargs):
|
|
return 12345
|
|
|
|
|
|
|
|
|
|
def test_cap_2_balances_two_profiles(isolated_kanban_home_with_profiles):
|
|
"""With cap=2: 2 alpha + 2 beta dispatched; remaining 3 alpha + 1 beta
|
|
deferred to skipped_per_profile_capped."""
|
|
kb = isolated_kanban_home_with_profiles
|
|
from hermes_cli import kanban_db_connect as kbc
|
|
from hermes_cli import kanban_db_dispatch as kbd
|
|
with kbc.connect_closing() as conn:
|
|
kb.create_board(slug="default", name="Test")
|
|
for i in range(5):
|
|
kb.create_task(conn, title=f"a{i}", assignee="alpha")
|
|
for i in range(3):
|
|
kb.create_task(conn, title=f"b{i}", assignee="beta")
|
|
with kbc.connect_closing() as conn:
|
|
res = kbd.dispatch_once(
|
|
conn, spawn_fn=_fake_spawn, dry_run=True,
|
|
max_in_progress_per_profile=2,
|
|
)
|
|
spawn_assignees = [s[1] for s in res.spawned]
|
|
capped_assignees = [c[1] for c in res.skipped_per_profile_capped]
|
|
assert spawn_assignees.count("alpha") == 2
|
|
assert spawn_assignees.count("beta") == 2
|
|
assert capped_assignees.count("alpha") == 3
|
|
assert capped_assignees.count("beta") == 1
|
|
|
|
|
|
|
|
|
|
def test_capped_tasks_dispatched_on_subsequent_tick(isolated_kanban_home_with_profiles):
|
|
"""A task deferred this tick because its profile was at cap should be
|
|
eligible for dispatch on the next tick (after running tasks complete).
|
|
This verifies the cap is per-tick state, not a permanent block."""
|
|
kb = isolated_kanban_home_with_profiles
|
|
from hermes_cli import kanban_db_connect as kbc
|
|
from hermes_cli import kanban_db_dispatch as kbd
|
|
with kbc.connect_closing() as conn:
|
|
kb.create_board(slug="default", name="Test")
|
|
ids = [kb.create_task(conn, title=f"a{i}", assignee="alpha") for i in range(3)]
|
|
|
|
# First tick: cap=1, only 1 alpha dispatched
|
|
with kbc.connect_closing() as conn:
|
|
res1 = kbd.dispatch_once(
|
|
conn, spawn_fn=_fake_spawn, dry_run=False,
|
|
max_in_progress_per_profile=1,
|
|
)
|
|
assert len(res1.spawned) == 1
|
|
assert len(res1.skipped_per_profile_capped) == 2
|
|
|
|
# Simulate the running task completing — set it back to done so the
|
|
# 'running' count drops
|
|
spawned_id = res1.spawned[0][0]
|
|
with kbc.connect_closing() as conn:
|
|
with kb.write_txn(conn):
|
|
conn.execute(
|
|
"UPDATE tasks SET status = 'done', claim_lock = NULL WHERE id = ?",
|
|
(spawned_id,),
|
|
)
|
|
|
|
# Second tick: 1 more alpha should now dispatch
|
|
with kbc.connect_closing() as conn:
|
|
res2 = kbd.dispatch_once(
|
|
conn, spawn_fn=_fake_spawn, dry_run=False,
|
|
max_in_progress_per_profile=1,
|
|
)
|
|
assert len(res2.spawned) == 1
|
|
assert len(res2.skipped_per_profile_capped) == 1
|
|
assert res2.spawned[0][0] != spawned_id # different task this time
|
|
|
|
|