hermes-agent/tests/hermes_cli/test_home_init_soul_symlink.py
teknium1 69b63e7407 fix(config,update): replace an unwritable SOUL.md symlink; say when the pre-update snapshot failed
Two follow-ups on the salvaged commits:

- `_ensure_default_soul_md`: widen the cyclic-only (ELOOP) branch to any symlink the seed
  cannot write through — a link dangling into a missing directory raises ENOENT on the same
  write and bricked home init the same way (HomeInitializationError -> exit 75 -> supervisor
  relaunch storm). Shape: write through the link first (a working link stays operator
  wiring), and only on OSError seed the default in place of the link via mkstemp + replace.
  Tests trimmed to two invariants (cyclic/dangling replaced; resolving link preserved).
- `_run_pre_update_backup`: the quick snapshot stays best-effort by design (8ed599dc05:
  "a broken backup never blocks the update"), but a failure was swallowed at DEBUG level, so
  the user only learned from the receipt afterwards that no recovery point existed. Print a
  stdout warning with the reason and continue; together with the receipt skip/fail split the
  receipt now says "failed" only when a snapshot was requested and not produced.
- docs: updating.md describes the warning and the receipt split.
2026-09-18 10:15:11 -07:00

45 lines
1.7 KiB
Python

"""Home initialization must survive a SOUL.md symlink the seed cannot write through.
A cyclic ``SOUL.md -> SOUL.md`` link (ELOOP) or a link dangling into a missing directory
(ENOENT) made the first-run seed raise OSError, which ``initialize_home`` turned into
``HomeInitializationError`` on every gateway spawn (launchd exit-75 relaunch storm). The seed
now replaces such a link with the default identity file; a link that resolves is operator
wiring and stays a link.
"""
import pytest
from hermes_cli.config import DEFAULT_SOUL_MD, _ensure_default_soul_md
from hermes_cli.config_home import initialize_home
_SUBDIRS = ("cron", "sessions", "logs", "memories")
@pytest.mark.parametrize("target", ["SOUL.md", "missing-dir/SOUL.md"], ids=["cyclic", "dangling"])
def test_initialize_home_replaces_unwritable_soul_symlink(tmp_path, target):
home = tmp_path / ".hermes"
home.mkdir()
soul = home / "SOUL.md"
soul.symlink_to(home / target)
initialize_home(home, _SUBDIRS, set())
assert not soul.is_symlink()
assert soul.read_text(encoding="utf-8") == DEFAULT_SOUL_MD
assert not [p for p in home.iterdir() if p.name.startswith(".SOUL.md.")]
def test_soul_symlink_to_customized_file_is_left_alone(tmp_path):
"""Control: a resolving link survives and its content is untouched."""
home = tmp_path / ".hermes"
home.mkdir()
target = tmp_path / "shared-identity.md"
target.write_text("custom identity\n", encoding="utf-8")
soul = home / "SOUL.md"
soul.symlink_to(target)
_ensure_default_soul_md(home)
initialize_home(home, _SUBDIRS, set())
assert soul.is_symlink()
assert soul.read_text(encoding="utf-8") == "custom identity\n"