hermes-agent/tests/hermes_cli/test_doctor_ipv6_probe.py
teknium1 72360ae1d2 fix(doctor): detect a dead IPv6 route and name network.force_ipv4
#114265 secondary finding 1: ``network.force_ipv4`` was undiscoverable (default
off, mentioned only by a rotating tip), so an advertised-but-blackholed IPv6
prefix cost the reporter weeks. ``hermes doctor`` now runs an ``IPv6 route``
probe in the API Connectivity section: one 2 s IPv6 TCP connect to a known
dual-stack host. A timeout is the dead-route signature and is reported as a
warning plus a summary issue naming ``network.force_ipv4: true``; no AAAA /
no IPv6 route at all is healthy (fails fast, no stall) and ``force_ipv4``
already set skips the probe. Two invariant tests over a mocked connect seam.

Docs: doctor reference and the network config section describe the check.
2026-09-18 09:56:28 -07:00

48 lines
1.9 KiB
Python

"""``hermes doctor`` dead-IPv6 probe (#114265 secondary finding 1).
An advertised-but-blackholed IPv6 route stalls every serial connect for the full timeout;
the racer hides most of it, but nothing told the user that ``network.force_ipv4`` exists.
The probe connects to one known AAAA host over IPv6 with a short timeout and, on a
timeout, names the remedy. No IPv6 route at all is healthy (skip), as is an explicit
``force_ipv4: true``.
"""
from __future__ import annotations
import socket
from hermes_cli import doctor_connectivity as dc
_AAAA = [(socket.AF_INET6, socket.SOCK_STREAM, 6, "", ("2001:db8::1", 443, 0, 0))]
def _run(monkeypatch, connect, *, config=None, addrinfo=_AAAA):
monkeypatch.setattr(dc, "_load_network_config", lambda: config or {})
monkeypatch.setattr(dc.socket, "getaddrinfo", lambda *_a, **_k: addrinfo)
monkeypatch.setattr(dc, "_tcp_connect", connect)
return dc._probe_ipv6_path()
def test_dead_ipv6_route_warns_and_names_force_ipv4(monkeypatch):
def timed_out(_sockaddr, _timeout):
raise TimeoutError("timed out")
result = _run(monkeypatch, timed_out)
(glyph, _label, detail), = result.lines
assert "⚠" in glyph and "network.force_ipv4" in detail
assert result.issues and "network.force_ipv4" in result.issues[0]
def test_healthy_or_absent_ipv6_never_warns(monkeypatch):
def reachable(_sockaddr, _timeout):
return None
def no_route(_sockaddr, _timeout):
raise OSError(101, "Network is unreachable")
assert _run(monkeypatch, reachable).issues == []
assert _run(monkeypatch, no_route).issues == []
assert "✓" in _run(monkeypatch, reachable).lines[0][0]
# force_ipv4 already set, or no AAAA record: nothing to probe, nothing to say.
assert _run(monkeypatch, reachable, config={"force_ipv4": True}).lines == []
assert _run(monkeypatch, reachable, addrinfo=[]).lines == []