hermes-agent/tests/hermes_cli/test_config_migration_45_connections.py
ethernet f3b1399211 fix: round-5 CI backlog after the 779-commit main merge
Merge fallout (my resolution errors, all caught by CI):
- hermes_cli/backup.py + gateway.py: `theirs` on those hunks re-imported clusters HEAD had
  already moved to backup_restore.py / kept in the facade. backup.py loses the 349-line
  duplicate (main's #110179 fix is ported into backup_restore._import_db_member); the
  systemd service-unit cluster returns to gateway.py (PM's _prepare_service_launcher /
  _pm_managed_node_dirs / _systemd_command have no home in main's extraction) with main's
  utf-8-sig read. gateway_service_unit.py is dropped.
- gateway/run.py: main's plugin-update chore is not profile-scoped (the housekeeping
  ordering test pins the scope/drain sequence).
- pyproject + 30 test files: `import yaml` -> `import hermes_yaml as yaml` (pm-clean has no
  pyyaml); gateway/config._bundled_platform_manifest_name reads through hermes_yaml.
- tests re-seamed onto pm-clean's shape: residency admission (installed_engine),
  supervisor child env (binary is a constructor argument), update import guard
  (update_cmd_deps is gone; our probe already scrubs PYTHONPATH — both #115032 invariants
  pass), shallow-count git responses (stash path asks `status --porcelain -z`); dropped
  tests for retired code (_run_node_bootstrap/_ensure_tui_node, Windows resume demotion).
- tests/tools/test_local_env_blocklist.py: restore the two helpers the suite-reduction
  commit dropped and the blocklist import.

Real fixes:
- pm: classify_uv_failure/ResolutionConflict move beside the uv runner (pm.environment,
  stdlib-only). pm.workspace imports tomllib at module level and cannot load on the 3.10
  bootstrap python that streams uv output in the Docker arm64 image.
- tools/browser_tool.warm_agent_browser_npx_cache: back as a permanent definition — it is on
  the frozen old-updater surface, and the revert-scheduled compat pointer does not count.
- hermes_cli/memory_setup: the dashboard's pip row uses pm.environments.
  running_from_selected_environment for installed vs restart_required.
- scripts/windows-build-deps.ps1: export DISTUTILS_USE_SDK/MSSdk so setuptools trusts the
  primed MSVC environment instead of asking vswhere (`env -i` test runner on win32-arm64
  compiling ruamel-yaml-clib); run_tests.sh forwards them.
- tests/pm/test_windows_build_deps.py: start the protocol test from a parent env without the
  toolchain variables the runner job already exports.
- tests/conftest.py scrubs HERMES_BUNDLED_PLUGINS (Nix-wrapped hermes on the dev host);
  tests/home_io_guard.py treats sys.path site-packages under the real home as the
  interpreter's installation (PM-activated developer shell).
- tests-js: four `curly` lint errors from main's new scripts.
2026-09-21 02:47:48 -04:00

160 lines
6.3 KiB
Python

"""Migration 44→45: saved ``platform_toolsets`` lists gain the ``connections`` toolset.
``hermes tools`` persists an explicit per-platform toolset list, and absence from
that list reads as "unchecked" — so a toolset that ships after the list was saved
stays off for picker users while composite (``[hermes-cli]``) users inherit it.
The 44→45 step turns ``connections`` on for stale lists, preserves an explicit
decline, and leaves composites/empty lists alone.
"""
import os
from unittest.mock import patch
import pytest
import hermes_yaml as yaml
class TestConnectionsToolsetMigration:
"""Behaviour contract for ``_migrate_to_45`` driven through ``run_migrations``."""
@staticmethod
def _run_ladder(tmp_path, current_ver=44):
from hermes_cli.config_migrations import run_migrations
results = {"env_added": [], "config_added": [], "warnings": []}
with patch.dict(os.environ, {"HERMES_HOME": str(tmp_path)}):
run_migrations(current_ver, results, quiet=True)
return results
@staticmethod
def _write_config(tmp_path, config):
(tmp_path / "config.yaml").write_text(
yaml.safe_dump(config), encoding="utf-8"
)
@staticmethod
def _read_config(tmp_path):
return yaml.safe_load((tmp_path / "config.yaml").read_text(encoding="utf-8"))
def test_stale_list_gains_connections_for_every_platform(self, tmp_path):
"""A list saved before the toolset shipped is offered it (and records the offer)."""
platforms = {
"cli": ["file", "terminal", "web"],
"telegram": ["file", "web"],
}
self._write_config(
tmp_path,
{
"_config_version": 44,
"platform_toolsets": platforms,
"known_builtin_toolsets": {
"cli": ["browser", "file", "memory", "skills", "terminal", "todo", "web"]
},
},
)
results = self._run_ladder(tmp_path)
raw = self._read_config(tmp_path)
assert "connections" in raw["platform_toolsets"]["cli"]
assert "connections" in raw["platform_toolsets"]["telegram"]
# The offer is recorded so a later uncheck is a recorded decline, not another migration.
assert "connections" in raw["known_builtin_toolsets"]["cli"]
added = [entry for entry in results["config_added"] if "connections" in entry.lower()]
assert len(added) == 1, results["config_added"]
@pytest.mark.parametrize(
"platform_toolsets, known",
[
pytest.param( # (a) the user saw the checkbox and left it off
{"cli": ["file", "terminal", "web"]},
{"cli": ["browser", "connections", "file", "web"]},
id="declined",
),
pytest.param( # (b) composite list already inherits every core tool
{"cli": ["hermes-cli"]},
{},
id="composite",
),
pytest.param( # (c) empty picker selection — no configurable key to extend
{"cli": []},
{},
id="empty",
),
],
)
def test_declines_composites_and_empty_lists_are_untouched(
self, tmp_path, platform_toolsets, known
):
self._write_config(
tmp_path,
{
"_config_version": 44,
"platform_toolsets": platform_toolsets,
"known_builtin_toolsets": known,
},
)
results = self._run_ladder(tmp_path)
raw = self._read_config(tmp_path)
assert raw["platform_toolsets"] == platform_toolsets
assert results["config_added"] == []
@pytest.mark.parametrize("disabled", [["browser", "connections", "web"], '["connections"]'], ids=["list", "json-string"])
def test_global_disable_is_not_overridden_or_claimed(self, tmp_path, disabled):
"""Blank Slate and `hermes tools --disable` write agent.disabled_toolsets, which the resolver
subtracts last; appending to the platform list would print an enable that never takes effect."""
platform_toolsets = {"cli": ["file", "skills", "terminal", "vision"]}
self._write_config(
tmp_path,
{
"_config_version": 44,
"platform_toolsets": platform_toolsets,
"agent": {"disabled_toolsets": disabled},
},
)
results = self._run_ladder(tmp_path)
raw = self._read_config(tmp_path)
assert raw["platform_toolsets"] == platform_toolsets
assert raw["agent"]["disabled_toolsets"] == disabled
assert results["config_added"] == []
def test_rerun_adds_nothing_and_keeps_one_connections(self, tmp_path):
"""Running the step twice is a no-op; the toolset appears exactly once."""
self._write_config(
tmp_path,
{
"_config_version": 44,
"platform_toolsets": {"cli": ["file", "terminal", "web"]},
"known_builtin_toolsets": {"cli": ["file", "terminal", "web"]},
},
)
self._run_ladder(tmp_path)
after_first = self._read_config(tmp_path)["platform_toolsets"]["cli"]
second = self._run_ladder(tmp_path)
after_second = self._read_config(tmp_path)["platform_toolsets"]["cli"]
# Running the step again rewrites nothing and never appends a duplicate.
assert second["config_added"] == []
assert after_second == after_first
assert after_second.count("connections") <= 1
def test_full_migration_stamps_the_current_version(self, tmp_path):
"""A pre-45 config that takes this step ends at DEFAULT_CONFIG's version, never one short."""
from hermes_cli.config import migrate_config
from hermes_cli.config_defaults import DEFAULT_CONFIG
self._write_config(
tmp_path,
{"_config_version": 42, "platform_toolsets": {"cli": ["file", "terminal"]}},
)
with patch.dict(os.environ, {"HERMES_HOME": str(tmp_path)}):
migrate_config(interactive=False, quiet=True)
raw = self._read_config(tmp_path)
assert "connections" in raw["platform_toolsets"]["cli"]
assert raw["_config_version"] == DEFAULT_CONFIG["_config_version"]