hermes-agent/tests/hermes_cli/test_cli_goal_parked_resume.py
teknium1 d10bb2ab6f test: make tests/ mirror the source tree; drop issue numbers from filenames
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.

Parallel directories for one source package, folded into the mirror:
  tests/acp        -> tests/acp_adapter   (its __init__/conftest move with it)
  tests/cli        -> tests/hermes_cli    (prompt_toolkit fixture merged into
                                           hermes_cli/conftest.py)
  tests/run_agent  -> tests/agent         (backoff fixture becomes
                                           agent/conftest.py)
  tests/relay      -> tests/gateway/relay
  tests/state      -> tests/hermes_state

246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.

Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.

Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).

Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
2026-09-13 09:18:02 -07:00

58 lines
1.9 KiB
Python

"""A parked /goal resumes from the idle hook once its barrier lifts, without waiting for another turn."""
import queue
import time
from unittest.mock import patch
import pytest
from hermes_cli import goals
from hermes_cli.cli_loops_mixin import CLILoopsMixin
@pytest.fixture
def hermes_home(tmp_path, monkeypatch):
from pathlib import Path
home = tmp_path / ".hermes"; home.mkdir()
monkeypatch.setattr(Path, "home", lambda: tmp_path)
monkeypatch.setenv("HERMES_HOME", str(home))
goals._DB_CACHE.clear()
yield home
goals._DB_CACHE.clear()
class _Cli(CLILoopsMixin):
def __init__(self, mgr):
self._pending_input = queue.Queue()
self._mgr = mgr
def _get_goal_manager(self):
return self._mgr
def test_idle_hook_queues_the_continuation_when_a_timed_barrier_has_elapsed(hermes_home):
mgr = goals.GoalManager(session_id="resume-idle")
mgr.set("finish the thing")
mgr.wait_for_seconds(1, reason="cooldown")
cli = _Cli(mgr)
with patch("cli._cprint"), patch("cli._DIM", ""), patch("cli._RST", ""):
cli._maybe_resume_parked_goal()
assert cli._pending_input.empty() # still parked
mgr.state.waiting_until = time.time() - 1
mgr._save()
cli._last_goal_barrier_check = 0.0
cli._maybe_resume_parked_goal()
assert not cli._pending_input.empty() # continuation queued
assert "finish the thing" in cli._pending_input.get()
assert mgr.state.waiting_until == 0.0 # barrier cleared
def test_idle_hook_is_a_no_op_for_an_unparked_or_inactive_goal(hermes_home):
mgr = goals.GoalManager(session_id="resume-noop")
mgr.set("g")
cli = _Cli(mgr)
cli._maybe_resume_parked_goal()
assert cli._pending_input.empty()
mgr.clear()
cli._last_goal_barrier_check = 0.0
cli._maybe_resume_parked_goal()
assert cli._pending_input.empty()