mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
Change-detectors, tautologies, source-reading tests, redundant duplicates, mock-echo tests and dead/unrunnable tests. Per-test rationale in the lane ledger (category + reason for every removal).
137 lines
5 KiB
Python
137 lines
5 KiB
Python
"""Tests for WhatsApp reply_prefix config.yaml support.
|
|
|
|
Covers:
|
|
- config.yaml whatsapp.reply_prefix bridging into PlatformConfig.extra
|
|
- WhatsAppAdapter reading reply_prefix from config.extra
|
|
- Bridge subprocess receiving WHATSAPP_REPLY_PREFIX env var
|
|
- config.yaml whatsapp.send_read_receipts bridging into PlatformConfig.extra
|
|
- WhatsAppAdapter parsing send_read_receipts as a boolean
|
|
- Config version covers all ENV_VARS_BY_VERSION keys (regression guard)
|
|
"""
|
|
|
|
from types import SimpleNamespace
|
|
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform, PlatformConfig
|
|
|
|
|
|
class _AsyncResponseContext:
|
|
def __init__(self, response):
|
|
self.response = response
|
|
|
|
async def __aenter__(self):
|
|
return self.response
|
|
|
|
async def __aexit__(self, exc_type, exc, tb):
|
|
return False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Config bridging from config.yaml
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestConfigYamlBridging:
|
|
"""Test that whatsapp.reply_prefix in config.yaml flows into PlatformConfig."""
|
|
|
|
def test_reply_prefix_bridged_from_yaml(self, tmp_path):
|
|
"""whatsapp.reply_prefix in config.yaml sets PlatformConfig.extra."""
|
|
config_yaml = tmp_path / "config.yaml"
|
|
config_yaml.write_text('whatsapp:\n reply_prefix: "Custom Bot"\n')
|
|
|
|
with patch("gateway.config.get_hermes_home", return_value=tmp_path):
|
|
from gateway.config import load_gateway_config
|
|
# Need to also patch WHATSAPP_ENABLED so the platform exists
|
|
with patch.dict("os.environ", {"WHATSAPP_ENABLED": "true"}, clear=False):
|
|
config = load_gateway_config()
|
|
|
|
wa_config = config.platforms.get(Platform.WHATSAPP)
|
|
assert wa_config is not None
|
|
assert wa_config.extra.get("reply_prefix") == "Custom Bot"
|
|
|
|
def test_empty_reply_prefix_bridged(self, tmp_path):
|
|
"""Empty string reply_prefix disables the header."""
|
|
config_yaml = tmp_path / "config.yaml"
|
|
config_yaml.write_text('whatsapp:\n reply_prefix: ""\n')
|
|
|
|
with patch("gateway.config.get_hermes_home", return_value=tmp_path):
|
|
from gateway.config import load_gateway_config
|
|
with patch.dict("os.environ", {"WHATSAPP_ENABLED": "true"}, clear=False):
|
|
config = load_gateway_config()
|
|
|
|
wa_config = config.platforms.get(Platform.WHATSAPP)
|
|
assert wa_config is not None
|
|
assert wa_config.extra.get("reply_prefix") == ""
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# WhatsAppAdapter __init__
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
|
|
|
|
class TestBridgeEnvironment:
|
|
@pytest.mark.parametrize(
|
|
("configured", "explicit_env", "expected"),
|
|
[
|
|
("Custom Bot\\n", None, "Custom Bot\\n"),
|
|
("", None, ""),
|
|
("Config Bot\\n", "Env Bot\\n", "Env Bot\\n"),
|
|
],
|
|
)
|
|
def test_reply_prefix_reaches_bridge_with_existing_precedence(
|
|
self, monkeypatch, configured, explicit_env, expected
|
|
):
|
|
from plugins.platforms.whatsapp.adapter import WhatsAppAdapter
|
|
|
|
monkeypatch.delenv("WHATSAPP_REPLY_PREFIX", raising=False)
|
|
if explicit_env is not None:
|
|
monkeypatch.setenv("WHATSAPP_REPLY_PREFIX", explicit_env)
|
|
|
|
adapter = WhatsAppAdapter(
|
|
PlatformConfig(enabled=True, extra={"reply_prefix": configured})
|
|
)
|
|
|
|
assert adapter._bridge_env()["WHATSAPP_REPLY_PREFIX"] == expected
|
|
|
|
|
|
class TestReadReceiptPolicyOrdering:
|
|
@pytest.mark.asyncio
|
|
async def test_accepted_receipt_key_is_sent_to_bridge(self):
|
|
from plugins.platforms.whatsapp.adapter import WhatsAppAdapter
|
|
|
|
adapter = WhatsAppAdapter(
|
|
PlatformConfig(enabled=True, extra={"send_read_receipts": True})
|
|
)
|
|
response = SimpleNamespace(status=200)
|
|
session = MagicMock()
|
|
session.post.return_value = _AsyncResponseContext(response)
|
|
adapter._http_session = session
|
|
key = {
|
|
"id": "incoming-1",
|
|
"remoteJid": "[email protected]",
|
|
"participant": "[email protected]",
|
|
"fromMe": False,
|
|
}
|
|
|
|
await adapter._send_read_receipt({"readReceiptKey": key})
|
|
|
|
assert session.post.call_args.kwargs["json"] == {"key": key}
|
|
assert session.post.call_args.args[0].endswith("/read")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Config version regression guard
|
|
# ---------------------------------------------------------------------------
|
|
|
|
|
|
class TestConfigVersionCoverage:
|
|
"""Ensure _config_version covers all ENV_VARS_BY_VERSION keys."""
|
|
|
|
def test_default_config_version_covers_env_var_versions(self):
|
|
"""_config_version must be >= the highest ENV_VARS_BY_VERSION key."""
|
|
from hermes_cli.config import DEFAULT_CONFIG, ENV_VARS_BY_VERSION
|
|
assert DEFAULT_CONFIG["_config_version"] >= max(ENV_VARS_BY_VERSION)
|