mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
346 lines
14 KiB
Python
346 lines
14 KiB
Python
"""Tests for WhatsApp message formatting and chunking.
|
|
|
|
Covers:
|
|
- format_message(): markdown → WhatsApp syntax conversion
|
|
- send(): message chunking for long responses
|
|
- MAX_MESSAGE_LENGTH: practical UX limit
|
|
"""
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock
|
|
|
|
import pytest
|
|
|
|
from gateway.config import Platform
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _whatsapp_open_optin(monkeypatch):
|
|
"""Opt into WhatsApp allow-all so ``dm_policy: open`` dispatch tests run.
|
|
|
|
The adapter fails closed on ``open`` without an allow-all opt-in
|
|
(SECURITY.md 2.6); these formatting/dispatch-mechanics tests set
|
|
``_dm_policy = "open"`` as a stand-in for "process this DM".
|
|
"""
|
|
monkeypatch.setenv("WHATSAPP_ALLOW_ALL_USERS", "true")
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# Helpers
|
|
# ---------------------------------------------------------------------------
|
|
|
|
def _make_adapter():
|
|
"""Create a WhatsAppAdapter with test attributes (bypass __init__)."""
|
|
from plugins.platforms.whatsapp.adapter import WhatsAppAdapter
|
|
|
|
adapter = WhatsAppAdapter.__new__(WhatsAppAdapter)
|
|
adapter.platform = Platform.WHATSAPP
|
|
adapter.config = MagicMock()
|
|
adapter.config.extra = {}
|
|
adapter._bridge_port = 3000
|
|
adapter._bridge_script = "/tmp/test-bridge.js"
|
|
adapter._session_path = MagicMock()
|
|
adapter._bridge_log_fh = None
|
|
adapter._bridge_log = None
|
|
adapter._bridge_process = None
|
|
adapter._reply_prefix = None
|
|
adapter._running = True
|
|
adapter._message_handler = None
|
|
adapter._fatal_error_code = None
|
|
adapter._fatal_error_message = None
|
|
adapter._fatal_error_retryable = True
|
|
adapter._fatal_error_handler = None
|
|
adapter._active_sessions = {}
|
|
adapter._pending_messages = {}
|
|
adapter._background_tasks = set()
|
|
adapter._auto_tts_disabled_chats = set()
|
|
adapter._message_queue = asyncio.Queue()
|
|
adapter._http_session = MagicMock()
|
|
adapter._mention_patterns = []
|
|
adapter._dm_policy = "open"
|
|
adapter._allow_from = set()
|
|
adapter._group_policy = "open"
|
|
adapter._group_allow_from = set()
|
|
return adapter
|
|
|
|
class _AsyncCM:
|
|
"""Minimal async context manager returning a fixed value."""
|
|
|
|
def __init__(self, value):
|
|
self.value = value
|
|
|
|
async def __aenter__(self):
|
|
return self.value
|
|
|
|
async def __aexit__(self, *exc):
|
|
return False
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# format_message tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestFormatMessage:
|
|
"""WhatsApp markdown conversion."""
|
|
|
|
def test_strikethrough(self):
|
|
adapter = _make_adapter()
|
|
assert adapter.format_message("~~deleted~~") == "~deleted~"
|
|
|
|
def test_headers_converted_to_bold(self):
|
|
adapter = _make_adapter()
|
|
assert adapter.format_message("# Title") == "*Title*"
|
|
assert adapter.format_message("## Subtitle") == "*Subtitle*"
|
|
assert adapter.format_message("### Deep") == "*Deep*"
|
|
|
|
def test_bold_header_does_not_double_wrap(self):
|
|
""""# **Title**" must become *Title*, not **Title** (WhatsApp would
|
|
render the doubled asterisks literally)."""
|
|
adapter = _make_adapter()
|
|
assert adapter.format_message("# **Title**") == "*Title*"
|
|
assert adapter.format_message("## __Strong__") == "*Strong*"
|
|
|
|
def test_already_whatsapp_italic(self):
|
|
"""Markdown *italic* converts to WhatsApp _italic_ (PR #58704)."""
|
|
adapter = _make_adapter()
|
|
assert adapter.format_message("*italic*") == "_italic_"
|
|
# Already-WhatsApp _italic_ passes through unchanged
|
|
assert adapter.format_message("_italic_") == "_italic_"
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# MAX_MESSAGE_LENGTH tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestMessageLimits:
|
|
"""WhatsApp message length limits."""
|
|
|
|
def test_chunk_limit_reserves_default_self_chat_prefix(self, monkeypatch):
|
|
adapter = _make_adapter()
|
|
monkeypatch.delenv("WHATSAPP_REPLY_PREFIX", raising=False)
|
|
monkeypatch.setenv("WHATSAPP_MODE", "self-chat")
|
|
|
|
assert adapter._outgoing_chunk_limit() == (
|
|
adapter.MAX_MESSAGE_LENGTH - len(adapter.DEFAULT_REPLY_PREFIX)
|
|
)
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# send() chunking tests
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestSendChunking:
|
|
"""WhatsApp send() splits long messages into chunks."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_short_message_single_send(self):
|
|
adapter = _make_adapter()
|
|
resp = MagicMock(status=200)
|
|
resp.json = AsyncMock(return_value={"messageId": "msg1"})
|
|
adapter._http_session.post = MagicMock(return_value=_AsyncCM(resp))
|
|
|
|
result = await adapter.send("chat1", "short message")
|
|
assert result.success
|
|
# Only one call to bridge /send
|
|
assert adapter._http_session.post.call_count == 1
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_long_message_chunked(self):
|
|
adapter = _make_adapter()
|
|
resp = MagicMock(status=200)
|
|
resp.json = AsyncMock(return_value={"messageId": "msg1"})
|
|
adapter._http_session.post = MagicMock(return_value=_AsyncCM(resp))
|
|
|
|
# Create a message longer than MAX_MESSAGE_LENGTH (4096)
|
|
long_msg = "a " * 3000 # ~6000 chars
|
|
|
|
result = await adapter.send("chat1", long_msg)
|
|
assert result.success
|
|
# Should have made multiple calls
|
|
assert adapter._http_session.post.call_count > 1
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_chunks_leave_room_for_bridge_prefix(self, monkeypatch):
|
|
adapter = _make_adapter()
|
|
monkeypatch.delenv("WHATSAPP_REPLY_PREFIX", raising=False)
|
|
monkeypatch.setenv("WHATSAPP_MODE", "self-chat")
|
|
resp = MagicMock(status=200)
|
|
resp.json = AsyncMock(return_value={"messageId": "msg1"})
|
|
adapter._http_session.post = MagicMock(return_value=_AsyncCM(resp))
|
|
|
|
long_msg = "a " * 3000
|
|
|
|
await adapter.send("chat1", long_msg)
|
|
|
|
for call in adapter._http_session.post.call_args_list:
|
|
payload = call.kwargs.get("json") or call[1].get("json")
|
|
final_text = adapter.DEFAULT_REPLY_PREFIX + payload["message"]
|
|
assert len(final_text) <= adapter.MAX_MESSAGE_LENGTH
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# bridge event metadata
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestBridgeEventMetadata:
|
|
"""WhatsApp bridge metadata is preserved for downstream consumers."""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_quoted_reply_metadata_is_preserved_in_raw_message(self):
|
|
adapter = _make_adapter()
|
|
data = {
|
|
"messageId": "incoming-msg",
|
|
"chatId": "[email protected]",
|
|
"senderId": "[email protected]",
|
|
"senderName": "Tester",
|
|
"chatName": "Tester",
|
|
"isGroup": False,
|
|
"body": "approved",
|
|
"hasMedia": False,
|
|
"mediaUrls": [],
|
|
"quotedMessageId": "outbound-msg",
|
|
"quotedParticipant": "[email protected]",
|
|
"quotedRemoteJid": "[email protected]",
|
|
"hasQuotedMessage": True,
|
|
}
|
|
|
|
event = await adapter._build_message_event(data)
|
|
|
|
assert event is not None
|
|
assert event.raw_message["quotedMessageId"] == "outbound-msg"
|
|
assert event.raw_message["quotedParticipant"] == "[email protected]"
|
|
assert event.raw_message["quotedRemoteJid"] == "[email protected]"
|
|
assert event.raw_message["hasQuotedMessage"] is True
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reply_to_uncaptioned_image_attaches_quoted_media(self, tmp_path, monkeypatch):
|
|
# contextInfo.quotedMessage only ever carries a thumbnail-sized stub
|
|
# for media (or nothing for an uncaptioned attachment). The bridge
|
|
# resolves the quoted message's already-downloaded media via its own
|
|
# cache (createQuotedMediaCache) and hands back the real cached path
|
|
# in quotedMediaUrls. The adapter must fold that into this event's
|
|
# own media_urls/media_types so the existing vision pipeline picks it
|
|
# up — otherwise a reply like "save this" to an uncaptioned photo
|
|
# someone else sent looks to the agent like there is no image at all.
|
|
adapter = _make_adapter()
|
|
|
|
cache_dir = tmp_path / "cache" / "image"
|
|
cache_dir.mkdir(parents=True)
|
|
quoted_image_path = cache_dir / "img_original.jpg"
|
|
quoted_image_path.write_bytes(b"fake-jpeg-bytes")
|
|
|
|
from plugins.platforms.whatsapp import adapter as adapter_module
|
|
monkeypatch.setattr(
|
|
adapter_module, "_is_allowed_bridge_path", lambda url: True,
|
|
)
|
|
|
|
data = {
|
|
"messageId": "reply-msg",
|
|
"chatId": "[email protected]",
|
|
"senderId": "[email protected]",
|
|
"senderName": "Ananya",
|
|
"chatName": "Family",
|
|
"isGroup": True,
|
|
"body": "did you save this wedding invite?",
|
|
"hasMedia": False,
|
|
"mediaUrls": [],
|
|
"mediaType": "",
|
|
"quotedMessageId": "original-image-msg",
|
|
"quotedParticipant": "[email protected]",
|
|
"quotedRemoteJid": "[email protected]",
|
|
"hasQuotedMessage": True,
|
|
"quotedText": "",
|
|
"quotedMediaUrls": [str(quoted_image_path)],
|
|
"quotedMediaType": "image",
|
|
}
|
|
|
|
event = await adapter._build_message_event(data)
|
|
|
|
assert event is not None
|
|
assert str(quoted_image_path) in event.media_urls
|
|
idx = event.media_urls.index(str(quoted_image_path))
|
|
assert event.media_types[idx] == "image/jpeg"
|
|
|
|
@pytest.mark.asyncio
|
|
@pytest.mark.parametrize("content, inlined", [("small text", True), ("x" * (200 * 1024), False)], ids=["small", "large"])
|
|
async def test_document_marks_media_text_inlined(self, tmp_path, monkeypatch, content, inlined):
|
|
"""The per-attachment flag must track whether the text was injected, so the document
|
|
note never claims the content is inlined when the >100 KB gate skipped it."""
|
|
adapter = _make_adapter()
|
|
doc_path = tmp_path / "doc_abc_notes.txt"
|
|
doc_path.write_text(content, encoding="utf-8")
|
|
from plugins.platforms.whatsapp import adapter as adapter_module
|
|
monkeypatch.setattr(adapter_module, "_is_allowed_bridge_path", lambda url: True)
|
|
|
|
event = await adapter._build_message_event({
|
|
"messageId": "doc-msg", "chatId": "[email protected]",
|
|
"senderId": "[email protected]", "senderName": "Ananya", "isGroup": False,
|
|
"body": "", "hasMedia": True, "mediaUrls": [str(doc_path)], "mediaType": "document",
|
|
})
|
|
|
|
assert event is not None
|
|
assert ("[Content of" in (event.text or "")) is inlined
|
|
assert event.media_text_inlined == [inlined]
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_quoted_media_path_outside_cache_dir_is_rejected(self, monkeypatch):
|
|
# _is_allowed_bridge_path guards against a compromised/buggy bridge
|
|
# handing back an arbitrary absolute path; quoted-media handling must
|
|
# respect the same guard as direct media, not bypass it.
|
|
adapter = _make_adapter()
|
|
|
|
from plugins.platforms.whatsapp import adapter as adapter_module
|
|
monkeypatch.setattr(
|
|
adapter_module, "_is_allowed_bridge_path", lambda url: False,
|
|
)
|
|
|
|
data = {
|
|
"messageId": "reply-msg-2",
|
|
"chatId": "[email protected]",
|
|
"senderId": "[email protected]",
|
|
"senderName": "Ananya",
|
|
"chatName": "Family",
|
|
"isGroup": True,
|
|
"body": "did you save this?",
|
|
"hasMedia": False,
|
|
"mediaUrls": [],
|
|
"mediaType": "",
|
|
"quotedMessageId": "original-image-msg",
|
|
"quotedParticipant": "[email protected]",
|
|
"quotedRemoteJid": "[email protected]",
|
|
"hasQuotedMessage": True,
|
|
"quotedText": "",
|
|
"quotedMediaUrls": ["/etc/passwd"],
|
|
"quotedMediaType": "image",
|
|
}
|
|
|
|
event = await adapter._build_message_event(data)
|
|
|
|
assert event is not None
|
|
assert "/etc/passwd" not in event.media_urls
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_reply_to_bot_sent_image_resolves_from_outbound_index(self, tmp_path):
|
|
"""The bridge's quoted-media cache knows inbound messages only. A quote of an image WE sent
|
|
(cron chart, generated plot) must resolve from the outbound index written at send time —
|
|
otherwise "what is this?" under the bot's own image reaches the agent with no image."""
|
|
adapter = _make_adapter()
|
|
image = tmp_path / "chart.png" # a workspace path, deliberately NOT inside a cache dir
|
|
image.write_bytes(b"\x89PNG fake")
|
|
resp = MagicMock(status=200)
|
|
resp.json = AsyncMock(return_value={"messageId": "BOT_IMG"})
|
|
adapter._http_session.post = MagicMock(return_value=_AsyncCM(resp))
|
|
|
|
sent = await adapter.send_image_file("15551234567", str(image))
|
|
assert sent.success and sent.message_id == "BOT_IMG"
|
|
|
|
event = await adapter._build_message_event({
|
|
"messageId": "reply-1", "chatId": "[email protected]",
|
|
"senderId": "[email protected]", "senderName": "Alice", "isGroup": False,
|
|
"body": "what is this?", "hasMedia": False, "mediaUrls": [], "mediaType": "",
|
|
"quotedMessageId": "BOT_IMG", "quotedParticipant": "[email protected]",
|
|
"hasQuotedMessage": True, "quotedText": "", "quotedMediaUrls": [], "quotedMediaType": "",
|
|
"botIds": ["[email protected]"],
|
|
})
|
|
assert event is not None
|
|
assert event.reply_to_is_own_message is True
|
|
assert event.media_urls == [str(image)]
|
|
assert event.media_types == ["image/png"]
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# display_config tier classification
|
|
# ---------------------------------------------------------------------------
|