mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
Activation reaches plugin discovery before the application dependencies exist. Give PM its own locked Python project and runtime so it can install or repair the application without importing that dependency tree. Keep PM outside the application workspace. A shared uv workspace resolves the application graph and cannot provide this isolation. Route mutations through an isolated worker and preserve transaction callbacks, cancellation, custom package registrations, and correlated receipts. Use the same runtime builder for source installs and packaged payloads. Keep offline wheelhouse support in that builder. Nix builds the independent PM lock as a separate derivation. Refuse lazy-disabled bootstrap before installing tools or dependencies. Move first-party YAML readers and writers to ruamel. Keep the application lock's transitive PyYAML requirements for third-party packages. Verification: - Focused canonical Python suite: 177 passed, 1 host-gated skip. - Electron backend probes: 12 passed. Electron typecheck passed. - Both uv locks, scoped lint, Bash syntax, and whitespace checks passed. - Cold activation, corrupt-app repair, offline staging, and relocation ran. - Built and exercised the Nix PM runtime and standalone YAML merge script. Six broader caller test files retain the same 24 failing test IDs as an archive of HEAD. The existing real-home guard blocks those tests before they can exercise the affected paths. No full-suite pass is claimed. Native Windows signing and full Bionic package execution remain unverified.
97 lines
3.5 KiB
Python
97 lines
3.5 KiB
Python
"""Gateway STT config tests — honor stt.enabled: false from config.yaml."""
|
|
|
|
from pathlib import Path
|
|
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
import hermes_yaml as yaml
|
|
|
|
from gateway.config import GatewayConfig, Platform, load_gateway_config
|
|
from gateway.platforms.event import MessageEvent, MessageType
|
|
from gateway.session import SessionSource
|
|
|
|
|
|
def test_gateway_config_stt_disabled_from_dict_nested():
|
|
config = GatewayConfig.from_dict({"stt": {"enabled": False}})
|
|
assert config.stt_enabled is False
|
|
|
|
|
|
def test_load_gateway_config_bridges_stt_enabled_from_config_yaml(tmp_path, monkeypatch):
|
|
hermes_home = tmp_path / ".hermes"
|
|
hermes_home.mkdir()
|
|
(hermes_home / "config.yaml").write_text(
|
|
yaml.safe_dump({"stt": {"enabled": False}}),
|
|
encoding="utf-8",
|
|
)
|
|
|
|
monkeypatch.setenv("HERMES_HOME", str(hermes_home))
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
|
|
config = load_gateway_config()
|
|
|
|
assert config.stt_enabled is False
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_enrich_message_with_transcription_returns_tuple_for_empty_content_placeholder():
|
|
"""A successful transcription whose caption is the empty-content placeholder
|
|
must still return the ``(text, transcripts)`` tuple.
|
|
|
|
The Discord adapter delivers a captionless voice note as the literal
|
|
``"(The user sent a message with no text content)"`` placeholder. When STT
|
|
succeeds we strip that redundant placeholder and return just the transcript
|
|
prefix — but the method's contract (and every caller, which unpacks the
|
|
result as ``text, transcripts = ...``) requires a 2-tuple. Returning a bare
|
|
string here raised ``ValueError: too many values to unpack`` and dropped the
|
|
whole voice message on the floor.
|
|
"""
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner.config = GatewayConfig(stt_enabled=True)
|
|
runner._has_setup_skill = lambda: False
|
|
|
|
with patch(
|
|
"tools.transcription_tools.transcribe_audio",
|
|
return_value={
|
|
"success": True,
|
|
"transcript": "hello from a captionless voice note",
|
|
"provider": "local_command",
|
|
},
|
|
):
|
|
result, transcripts = await runner._enrich_message_with_transcription(
|
|
"(The user sent a message with no text content)",
|
|
["/tmp/voice.ogg"],
|
|
)
|
|
|
|
# The redundant placeholder is stripped, leaving only the transcript prefix.
|
|
assert "hello from a captionless voice note" in result
|
|
assert "(The user sent a message with no text content)" not in result
|
|
# Crucially, the transcripts are still surfaced so callers can echo them.
|
|
assert transcripts == ["hello from a captionless voice note"]
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_enrich_message_with_transcription_guards_empty_transcript():
|
|
"""success=True with an empty/whitespace transcript must not emit empty
|
|
quotes — it gets a sentinel note and is excluded from transcripts (#41603)."""
|
|
from gateway.run import GatewayRunner
|
|
|
|
runner = GatewayRunner.__new__(GatewayRunner)
|
|
runner.config = GatewayConfig(stt_enabled=True)
|
|
runner._has_setup_skill = lambda: False
|
|
|
|
with patch(
|
|
"tools.transcription_tools.transcribe_audio",
|
|
return_value={"success": True, "transcript": " \n\t", "provider": "local_command"},
|
|
):
|
|
result, transcripts = await runner._enrich_message_with_transcription(
|
|
"caption",
|
|
["/tmp/voice.ogg"],
|
|
)
|
|
|
|
assert "empty or inaudible" in result
|
|
assert '""' not in result
|
|
assert transcripts == []
|
|
|
|
|