hermes-agent/tests/gateway/test_session_stall_watchdog.py
ethernet 890bbbda1f Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts
#	apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts
#	apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts
#	apps/desktop/e2e/bot-mode-roster-localized.spec.ts
#	apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts
#	apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts
#	apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts
#	apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts
#	apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts
#	apps/desktop/e2e/bot-roster-user-sections.spec.ts
#	apps/desktop/e2e/bot-routines-pane-narrow.spec.ts
#	apps/desktop/e2e/bot-row-open-recent-session.spec.ts
#	apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts
#	apps/desktop/e2e/group-composer-auto-grow.spec.ts
#	apps/desktop/e2e/group-create-gate-remote-roster.spec.ts
#	apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts
#	apps/desktop/e2e/hosted-room-backend-continuity.spec.ts
#	apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts
#	apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts
#	apps/desktop/e2e/worktree-branch-status.spec.ts
#	apps/desktop/electron/backend-probes.test.ts
#	apps/desktop/electron/connection-apply.test.ts
#	apps/desktop/electron/desktop-electron-pin.test.ts
#	apps/desktop/electron/desktop-uninstall.test.ts
#	apps/desktop/electron/gateway-file-download-transport.test.ts
#	apps/desktop/electron/gateway-stop-before-update.test.ts
#	apps/desktop/electron/github-api-auth.test.ts
#	apps/desktop/electron/registry-primary-profile-scope.test.ts
#	apps/desktop/electron/update-api-check.test.ts
#	apps/desktop/electron/update-handoff-marker.test.ts
#	apps/desktop/electron/venv-blocker-scan.test.ts
#	apps/desktop/scripts/after-extract.test.mjs
#	apps/desktop/scripts/local-pack-publish.test.mjs
#	apps/desktop/scripts/tasks-scroll.test.mjs
#	apps/desktop/src/app/settings/model-settings.test.tsx
#	apps/desktop/src/app/updates-overlay.blockers.test.tsx
#	apps/desktop/src/components/desktop-install-overlay.test.tsx
#	apps/desktop/src/lib/update-copy.test.ts
#	scripts/ci/check_os_marker_fakes.py
#	tests-js/desktop-mac-usage-descriptions.test.ts
#	tests-js/node-engine-alignment.test.ts
#	tests/agent/lsp/test_install_and_lint_fixes.py
#	tests/agent/test_command_token_source.py
#	tests/agent/test_compression_boundary_hook.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/agent/test_custom_provider_ca_probes.py
#	tests/agent/test_endpoint_blackhole.py
#	tests/agent/test_estimator_parity.py
#	tests/agent/test_in_place_compaction.py
#	tests/agent/test_moa_loop_mode.py
#	tests/agent/test_model_metadata.py
#	tests/agent/test_skill_session_platform_gate.py
#	tests/agent/test_skill_utils.py
#	tests/agent/test_ssl_ca_guard.py
#	tests/computer_use/test_doctor.py
#	tests/cron/test_codex_execution_paths.py
#	tests/cron/test_cron_bot_chat_delivery.py
#	tests/cron/test_cron_script.py
#	tests/cron/test_media_delivery_parity.py
#	tests/cron/test_misfire_catchup.py
#	tests/cron/test_parallel_pool.py
#	tests/cron/test_recurring_eagain_redispatch.py
#	tests/gateway/test_choice_picker.py
#	tests/gateway/test_control_socket_windows_live.py
#	tests/gateway/test_dingtalk.py
#	tests/gateway/test_feishu.py
#	tests/gateway/test_feishu_onboard.py
#	tests/gateway/test_gateway_shutdown.py
#	tests/gateway/test_matrix.py
#	tests/gateway/test_model_command_custom_providers.py
#	tests/gateway/test_reasoning_command.py
#	tests/gateway/test_runtime_footer.py
#	tests/gateway/test_session.py
#	tests/gateway/test_session_hygiene.py
#	tests/gateway/test_status.py
#	tests/gateway/test_teams.py
#	tests/gateway/test_turn_lease.py
#	tests/gateway/test_whatsapp_connect.py
#	tests/hermes_cli/test_approvals_command.py
#	tests/hermes_cli/test_auth_store_lock_concurrent.py
#	tests/hermes_cli/test_backup.py
#	tests/hermes_cli/test_banner_git_state.py
#	tests/hermes_cli/test_certifi_repair.py
#	tests/hermes_cli/test_cmd_update.py
#	tests/hermes_cli/test_compat_manifest_targets.py
#	tests/hermes_cli/test_computer_use_cli.py
#	tests/hermes_cli/test_cpr_local_leak.py
#	tests/hermes_cli/test_dashboard_auth_gate.py
#	tests/hermes_cli/test_dashboard_procs_kill_grace.py
#	tests/hermes_cli/test_desktop_lifecycle_windows_live.py
#	tests/hermes_cli/test_doctor.py
#	tests/hermes_cli/test_doctor_command_install.py
#	tests/hermes_cli/test_fleet_config_migration_windows_live.py
#	tests/hermes_cli/test_gateway.py
#	tests/hermes_cli/test_gateway_platform_gating.py
#	tests/hermes_cli/test_gateway_restart_loop.py
#	tests/hermes_cli/test_gateway_task_probe.py
#	tests/hermes_cli/test_gateway_wsl.py
#	tests/hermes_cli/test_gui_command.py
#	tests/hermes_cli/test_install_cua_driver.py
#	tests/hermes_cli/test_kanban_db.py
#	tests/hermes_cli/test_lazy_command_exports.py
#	tests/hermes_cli/test_lazy_refresh_venv_repair.py
#	tests/hermes_cli/test_linux_desktop_entry.py
#	tests/hermes_cli/test_local_runtime.py
#	tests/hermes_cli/test_local_runtime_updates.py
#	tests/hermes_cli/test_managed_uv.py
#	tests/hermes_cli/test_mcp_reload_confirm_gate.py
#	tests/hermes_cli/test_nous_subscription.py
#	tests/hermes_cli/test_npm_engine.py
#	tests/hermes_cli/test_personality_none.py
#	tests/hermes_cli/test_pet_toggle.py
#	tests/hermes_cli/test_plan_reconciliation_windows_live.py
#	tests/hermes_cli/test_plugin_event_bus.py
#	tests/hermes_cli/test_plugin_manifest_v2.py
#	tests/hermes_cli/test_plugin_packs.py
#	tests/hermes_cli/test_plugins_cmd.py
#	tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py
#	tests/hermes_cli/test_process_identity.py
#	tests/hermes_cli/test_profiles.py
#	tests/hermes_cli/test_profiles_sidebar_cache.py
#	tests/hermes_cli/test_pty_bridge.py
#	tests/hermes_cli/test_resolve_turn_limit.py
#	tests/hermes_cli/test_serve_runtime_inventory.py
#	tests/hermes_cli/test_session_vacuum_config.py
#	tests/hermes_cli/test_set_config_value.py
#	tests/hermes_cli/test_signal_handler_kanban_worker.py
#	tests/hermes_cli/test_slash_confirm_windows.py
#	tests/hermes_cli/test_stale_pid_guard.py
#	tests/hermes_cli/test_startup_fast_guards.py
#	tests/hermes_cli/test_status.py
#	tests/hermes_cli/test_telegram_managed_bot.py
#	tests/hermes_cli/test_tools_config.py
#	tests/hermes_cli/test_update_apply_shallow_count.py
#	tests/hermes_cli/test_update_autostash.py
#	tests/hermes_cli/test_update_concurrent_quarantine.py
#	tests/hermes_cli/test_update_fetch_failure_classifier.py
#	tests/hermes_cli/test_update_fleet_probe_resume_token.py
#	tests/hermes_cli/test_update_handoff_backend_reap.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_update_head_moved_gate.py
#	tests/hermes_cli/test_update_host_obligation.py
#	tests/hermes_cli/test_update_import_guard.py
#	tests/hermes_cli/test_update_interrupted_recovery.py
#	tests/hermes_cli/test_update_inventory.py
#	tests/hermes_cli/test_update_launchd_unloaded_gateway.py
#	tests/hermes_cli/test_update_missing_configured_deps.py
#	tests/hermes_cli/test_update_modified_notice.py
#	tests/hermes_cli/test_update_multiplex_migration_hook.py
#	tests/hermes_cli/test_update_no_gateway_restart.py
#	tests/hermes_cli/test_update_orphan_backend_reap.py
#	tests/hermes_cli/test_update_parked_branch_guard.py
#	tests/hermes_cli/test_update_post_pull_syntax_guard.py
#	tests/hermes_cli/test_update_receipt.py
#	tests/hermes_cli/test_update_self_lock.py
#	tests/hermes_cli/test_update_shim_fail_closed.py
#	tests/hermes_cli/test_update_shim_self_lock.py
#	tests/hermes_cli/test_update_sqlite_remediation.py
#	tests/hermes_cli/test_update_stale_dashboard.py
#	tests/hermes_cli/test_update_stale_virtualenv.py
#	tests/hermes_cli/test_update_venv_health.py
#	tests/hermes_cli/test_update_venv_ownership_preflight.py
#	tests/hermes_cli/test_update_wedged_gateway.py
#	tests/hermes_cli/test_update_yes_flag.py
#	tests/hermes_cli/test_update_zip_two_phase.py
#	tests/hermes_cli/test_urllib_security.py
#	tests/hermes_cli/test_ux_messages_auth_config.py
#	tests/hermes_cli/test_ux_messages_startup.py
#	tests/hermes_cli/test_venv_holder_classifier.py
#	tests/hermes_cli/test_verify_console_scripts.py
#	tests/hermes_cli/test_verify_core_dependencies.py
#	tests/hermes_cli/test_web_server.py
#	tests/hermes_cli/test_web_server_console_ws.py
#	tests/hermes_cli/test_web_server_ws_ping.py
#	tests/hermes_cli/test_web_ui_build.py
#	tests/hermes_state/test_fts_rebuild_admission.py
#	tests/hermes_state/test_hermes_state.py
#	tests/plugins/memory/test_memory_lazy_install.py
#	tests/plugins/test_google_meet_plugin.py
#	tests/plugins/test_langfuse_plugin.py
#	tests/plugins/test_security_guidance_plugin.py
#	tests/plugins/test_transform_llm_output_hook.py
#	tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_contributor_map.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/skills/test_competitor_news_monitor_skill.py
#	tests/skills/test_document_to_action_items_skill.py
#	tests/skills/test_google_workspace_setup.py
#	tests/skills/test_google_workspace_setup_deps.py
#	tests/skills/test_grounded_citations_skill.py
#	tests/skills/test_ip_as_logo_skill.py
#	tests/skills/test_live_dashboard_skill.py
#	tests/skills/test_mcp_oauth_remote_gateway_skill.py
#	tests/skills/test_office_document_skills.py
#	tests/skills/test_openclaw_migration.py
#	tests/skills/test_product_price_monitor_skill.py
#	tests/skills/test_scrollcraft_skill.py
#	tests/skills/test_setup_wizard_generator_skill.py
#	tests/skills/test_weekly_review_planning_skill.py
#	tests/test_engines_satisfiable.py
#	tests/test_fast_safe_load.py
#	tests/test_hermes_bootstrap.py
#	tests/test_hermes_constants.py
#	tests/test_hermes_logging.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_model_tools_async_bridge.py
#	tests/test_packaging_build_guard.py
#	tests/test_packaging_metadata.py
#	tests/test_yaml_indent_consistency.py
#	tests/tools/test_approval_timeout_overflow.py
#	tests/tools/test_base_environment.py
#	tests/tools/test_bot_mode_dm.py
#	tests/tools/test_browser_chromium_check.py
#	tests/tools/test_browser_hardening.py
#	tests/tools/test_browser_homebrew_paths.py
#	tests/tools/test_browser_npx_warmup.py
#	tests/tools/test_browser_orphan_reaper.py
#	tests/tools/test_browser_real_profile.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_code_execution.py
#	tests/tools/test_code_execution_modes.py
#	tests/tools/test_code_execution_windows_env.py
#	tests/tools/test_computer_use.py
#	tests/tools/test_delegate_liveness_timeout.py
#	tests/tools/test_execute_code_approval_cluster.py
#	tests/tools/test_execution_flag_detection.py
#	tests/tools/test_fal_common.py
#	tests/tools/test_file_operations.py
#	tests/tools/test_file_tools.py
#	tests/tools/test_file_tools_cwd_resolution.py
#	tests/tools/test_file_tools_live.py
#	tests/tools/test_lazy_deps.py
#	tests/tools/test_lazy_deps_durable_target.py
#	tests/tools/test_lazy_deps_managed.py
#	tests/tools/test_local_env_blocklist.py
#	tests/tools/test_local_tempdir.py
#	tests/tools/test_macos_protected_search.py
#	tests/tools/test_mcp_npx_cached_bin.py
#	tests/tools/test_oneshot_completion_linger.py
#	tests/tools/test_process_registry.py
#	tests/tools/test_read_file_schema_gating.py
#	tests/tools/test_skill_improvements.py
#	tests/tools/test_skills_sync.py
#	tests/tools/test_termux_api_detection.py
#	tests/tools/test_tirith_security.py
#	tests/tools/test_transcription_tools.py
#	tests/tools/test_tts_streaming.py
#	tests/tools/test_wake_word.py
#	tests/tui_gateway/test_compute_host_borrowed_lease.py
#	tests/tui_gateway/test_compute_host_turn_protocol.py
#	tests/tui_gateway/test_isolated_orphan_activity.py
#	tests/tui_gateway/test_protocol.py
#	tests/tui_gateway/test_slash_worker_profile_home.py
#	tests/tui_gateway/test_subprocess_encoding.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	ui-tui/src/__tests__/terminalParity.test.ts
#	ui-tui/src/__tests__/termuxComposerLayout.test.ts
#	ui-tui/src/__tests__/textInputFastEcho.test.ts
2026-09-23 07:02:44 -04:00

548 lines
20 KiB
Python

"""Tests for gateway session stall watchdog (#72016 item 2)."""
from __future__ import annotations
import asyncio
import time
from types import SimpleNamespace
import pytest
from agent.session_activity import ActivityProvenance, build_activity_snapshot
from gateway.run import GatewayRunner, _AGENT_PENDING_SENTINEL
from gateway.session_stall import (
resolve_session_idle_seconds_from_activity,
should_clear_session_stall_notification,
should_emit_session_stall_notification,
)
class _FakeAdapter:
def __init__(self):
self._pending_messages = {}
self.sent = []
async def send(self, chat_id, content, metadata=None):
self.sent.append(
{"chat_id": chat_id, "content": content, "metadata": metadata}
)
class _FakeAgent:
"""Exposes the shared #72039 activity snapshot as the sole progress source."""
def __init__(
self,
last_activity_ts: float,
*,
description: str = "api call",
provenance: ActivityProvenance = ActivityProvenance.UNKNOWN,
):
self._last_activity_ts = last_activity_ts
self._last_activity_desc = description
self._last_activity_provenance = provenance
def get_activity_summary(self):
return build_activity_snapshot(
last_activity_at=self._last_activity_ts,
last_activity_description=self._last_activity_desc,
last_activity_provenance=self._last_activity_provenance,
)
class _AgentWithoutSummary:
"""Agent with a raw clock but no shared summary consumer API."""
def __init__(self, last_activity_ts: float):
self._last_activity_ts = last_activity_ts
def test_should_emit_requires_pending_and_idle():
assert should_emit_session_stall_notification(
timeout_seconds=300,
idle_seconds=400,
has_pending_inbound=True,
already_notified=False,
)
assert not should_emit_session_stall_notification(
timeout_seconds=300,
idle_seconds=400,
has_pending_inbound=False,
already_notified=False,
)
assert not should_emit_session_stall_notification(
timeout_seconds=300,
idle_seconds=100,
has_pending_inbound=True,
already_notified=False,
)
assert not should_emit_session_stall_notification(
timeout_seconds=0,
idle_seconds=9999,
has_pending_inbound=True,
already_notified=False,
)
assert not should_emit_session_stall_notification(
timeout_seconds=300,
idle_seconds=400,
has_pending_inbound=True,
already_notified=True,
)
def test_should_clear_when_pending_gone_or_activity_resumes():
assert should_clear_session_stall_notification(
timeout_seconds=300,
idle_seconds=400,
has_pending_inbound=False,
)
assert should_clear_session_stall_notification(
timeout_seconds=300,
idle_seconds=10,
has_pending_inbound=True,
)
assert not should_clear_session_stall_notification(
timeout_seconds=300,
idle_seconds=400,
has_pending_inbound=True,
)
def test_should_clear_holds_latch_when_idle_unknown():
assert not should_clear_session_stall_notification(
timeout_seconds=300,
idle_seconds=None,
has_pending_inbound=True,
)
def test_resolve_idle_uses_shared_activity_snapshot_only():
now = 1_000_000.0
snap = build_activity_snapshot(
last_activity_at=now - 120,
last_activity_description="tool: terminal",
last_activity_provenance=ActivityProvenance.UNKNOWN,
now=now,
)
assert resolve_session_idle_seconds_from_activity(snap, now=now) == 120.0
assert resolve_session_idle_seconds_from_activity(None, now=now) is None
assert resolve_session_idle_seconds_from_activity({}, now=now) is None
def test_resolve_idle_prefers_seconds_since_activity_field():
idle = resolve_session_idle_seconds_from_activity(
{
"seconds_since_activity": 42.5,
"last_activity_at": 1.0, # must be ignored when seconds present
},
now=999.0,
)
assert idle == 42.5
def _runner_for_stall(adapter: _FakeAdapter) -> GatewayRunner:
r = GatewayRunner.__new__(GatewayRunner)
r._running = True
r.adapters = {"fake": adapter}
r._profile_adapters = {}
r._running_agents = {}
r._running_agents_ts = {}
r._queued_events = {}
r._session_stall_notified = {}
r._thread_metadata_for_source = lambda source, *a, **k: {
"thread_id": getattr(source, "thread_id", None)
}
return r
def _pending_event(chat_id: str = "chat-1", thread_id: str | None = None):
from gateway.session import SessionSource
from gateway.config import Platform
source = SessionSource(chat_id=chat_id, thread_id=thread_id, platform=Platform.TELEGRAM)
return SimpleNamespace(text="follow-up", source=source, timestamp=time.time())
@pytest.mark.asyncio
async def test_check_session_stalls_notifies_once(monkeypatch):
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
monkeypatch.setenv("HERMES_SESSION_STALL_TIMEOUT", "60")
session_key = "agent:main:telegram:dm:1"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
sent = await runner._check_session_stalls(60)
assert sent == 1
assert len(adapter.sent) == 1
assert "/new" in adapter.sent[0]["content"]
assert runner._session_stall_notified.get(session_key) is True
# Second pass must not spam.
sent2 = await runner._check_session_stalls(60)
assert sent2 == 0
assert len(adapter.sent) == 1
@pytest.mark.asyncio
async def test_check_session_stalls_skips_fresh_activity():
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:2"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 5)
sent = await runner._check_session_stalls(60)
assert sent == 0
assert adapter.sent == []
@pytest.mark.asyncio
async def test_check_session_stalls_skips_without_pending():
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:3"
runner._running_agents[session_key] = _FakeAgent(time.time() - 999)
sent = await runner._check_session_stalls(60)
assert sent == 0
assert adapter.sent == []
@pytest.mark.asyncio
async def test_check_session_stalls_clears_latch_when_pending_drains():
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:4"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 200)
assert await runner._check_session_stalls(60) == 1
assert session_key in runner._session_stall_notified
adapter._pending_messages.clear()
assert await runner._check_session_stalls(60) == 0
assert session_key not in runner._session_stall_notified
@pytest.mark.asyncio
async def test_check_session_stalls_skips_pending_sentinel_without_activity():
"""Pending construction has no shared activity snapshot — no parallel clocks."""
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:5"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _AGENT_PENDING_SENTINEL
runner._running_agents_ts[session_key] = time.time() - 90
sent = await runner._check_session_stalls(60)
assert sent == 0
assert adapter.sent == []
@pytest.mark.asyncio
async def test_check_session_stalls_ignores_raw_clock_without_summary():
"""Do not fall back to agent._last_activity_ts outside get_activity_summary()."""
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:raw"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _AgentWithoutSummary(time.time() - 999)
runner._running_agents_ts[session_key] = time.time() - 999
sent = await runner._check_session_stalls(60)
assert sent == 0
assert adapter.sent == []
@pytest.mark.asyncio
async def test_session_stall_watcher_disabled_when_timeout_zero(monkeypatch):
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
monkeypatch.setenv("HERMES_SESSION_STALL_TIMEOUT", "0")
session_key = "agent:main:telegram:dm:6"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 999)
task = asyncio.create_task(runner._session_stall_watcher(interval=1))
await asyncio.sleep(0.05)
# Force one check path via timeout read; watcher should no-op when 0.
assert runner._session_stall_timeout_seconds() == 0.0
runner._running = False
await asyncio.wait_for(task, timeout=2)
assert adapter.sent == []
@pytest.mark.asyncio
async def test_check_session_stalls_queued_events_overflow_notifies():
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:overflow"
event = _pending_event()
runner._queued_events[session_key] = [event]
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
runner._delivery_adapter_for = lambda source: adapter
assert await runner._check_session_stalls(60) == 1
assert adapter.sent and "/new" in adapter.sent[0]["content"]
@pytest.mark.asyncio
async def test_check_session_stalls_scans_profile_adapters():
adapter = _FakeAdapter()
runner = _runner_for_stall(_FakeAdapter()) # empty primary path unused
runner.adapters = {}
runner._profile_adapters = {"coder": {"fake": adapter}}
session_key = "agent:coder:telegram:dm:1"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 1
assert len(adapter.sent) == 1
@pytest.mark.asyncio
async def test_check_session_stalls_logs_compression_provenance(caplog):
"""Stale compression stamps still stall, but provenance stays visible."""
import logging
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:compress"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(
time.time() - 120,
description="compressing context",
provenance=ActivityProvenance.AGENT_COMPRESSION,
)
with caplog.at_level(logging.WARNING):
assert await runner._check_session_stalls(60) == 1
assert any("agent.compression" in r.message for r in caplog.records)
assert any("compressing context" in r.message for r in caplog.records)
@pytest.mark.asyncio
async def test_check_session_stalls_skips_active_compression_heartbeat():
"""Fresh agent.compression heartbeats are progress, not a silent stall."""
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:compacting"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(
time.time() - 5,
description="context compression in progress",
provenance=ActivityProvenance.AGENT_COMPRESSION,
)
assert await runner._check_session_stalls(60) == 0
assert adapter.sent == []
assert session_key not in runner._session_stall_notified
@pytest.mark.asyncio
async def test_check_session_stalls_does_not_renotify_after_summary_gap():
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:gap"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 1
# Transient observation gap (no summary API).
runner._running_agents[session_key] = _AgentWithoutSummary(time.time() - 999)
assert await runner._check_session_stalls(60) == 0
assert runner._session_stall_notified.get(session_key) is True
# Stale progress returns — must not spam again in the same episode.
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 0
assert len(adapter.sent) == 1
@pytest.mark.asyncio
async def test_check_session_stalls_retries_after_send_failure():
class _FailThenOk(_FakeAdapter):
def __init__(self):
super().__init__()
self.calls = 0
async def send(self, chat_id, content, metadata=None):
self.calls += 1
if self.calls == 1:
raise RuntimeError("boom")
await super().send(chat_id, content, metadata=metadata)
adapter = _FailThenOk()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:retry"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 0
assert session_key not in runner._session_stall_notified
assert await runner._check_session_stalls(60) == 1
assert runner._session_stall_notified.get(session_key) is True
assert len(adapter.sent) == 1
@pytest.mark.asyncio
async def test_check_session_stalls_retries_after_soft_send_failure():
class _SoftFailThenOk(_FakeAdapter):
def __init__(self):
super().__init__()
self.calls = 0
async def send(self, chat_id, content, metadata=None):
from gateway.platforms.base import SendResult
self.calls += 1
if self.calls == 1:
return SendResult(success=False, error="chat not found")
await super().send(chat_id, content, metadata=metadata)
return SendResult(success=True)
adapter = _SoftFailThenOk()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:soft"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 0
assert session_key not in runner._session_stall_notified
assert await runner._check_session_stalls(60) == 1
assert runner._session_stall_notified.get(session_key) is True
assert len(adapter.sent) == 1
@pytest.mark.asyncio
async def test_check_session_stalls_renotifies_after_resume_then_restall():
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
session_key = "agent:main:telegram:dm:episode"
adapter._pending_messages[session_key] = _pending_event()
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 1
# Activity resumes (still pending) — clears latch for a new episode.
runner._running_agents[session_key] = _FakeAgent(time.time() - 5)
assert await runner._check_session_stalls(60) == 0
assert session_key not in runner._session_stall_notified
# Stall again — second episode may notify once more.
runner._running_agents[session_key] = _FakeAgent(time.time() - 120)
assert await runner._check_session_stalls(60) == 1
assert len(adapter.sent) == 2
def test_resolve_idle_rejects_nonfinite_seconds_since_activity():
now = 1_000_000.0
idle = resolve_session_idle_seconds_from_activity(
{
"seconds_since_activity": float("nan"),
"last_activity_at": now - 15,
},
now=now,
)
assert idle == 15.0
def test_resolve_idle_rejects_boolean_seconds_and_uses_timestamp():
now = 1_000_000.0
idle = resolve_session_idle_seconds_from_activity(
{
"seconds_since_activity": True,
"last_activity_ts": now - 3,
},
now=now,
)
assert idle == 3.0
class _NeverResolvingAdapter:
"""Adapter whose send() hangs forever (wedged transport)."""
def __init__(self):
self._pending_messages = {}
self.send_attempts = 0
async def send(self, chat_id, content, metadata=None):
self.send_attempts += 1
await asyncio.Event().wait() # never resolves
@pytest.mark.asyncio
async def test_check_session_stalls_bounds_wedged_send(monkeypatch):
"""Round-2 #2: a never-resolving adapter.send must not wedge the watcher.
The bounded send times out, does NOT latch (retry next tick), the pass
completes so the watcher keeps ticking, and a healthy sibling candidate
still receives its notification in the same pass.
"""
import gateway.run as gateway_run
monkeypatch.setattr(
gateway_run, "_STALL_NOTIFY_SEND_TIMEOUT_SECONDS", 0.1
)
wedged = _NeverResolvingAdapter()
healthy = _FakeAdapter()
runner = _runner_for_stall(wedged)
runner.adapters = {"wedged": wedged, "healthy": healthy}
wedged_key = "agent:main:telegram:dm:wedged"
healthy_key = "agent:main:discord:dm:healthy"
wedged._pending_messages[wedged_key] = _pending_event(chat_id="chat-w")
healthy._pending_messages[healthy_key] = _pending_event(chat_id="chat-h")
runner._running_agents[wedged_key] = _FakeAgent(time.time() - 120)
runner._running_agents[healthy_key] = _FakeAgent(time.time() - 120)
# Pass must complete despite the wedged transport (bounded by wait_for).
sent = await asyncio.wait_for(runner._check_session_stalls(60), timeout=5)
# Healthy sibling was notified in the SAME pass.
assert sent == 1
assert len(healthy.sent) == 1
assert healthy_key in runner._session_stall_notified
# Wedged session: send attempted, timed out, NOT latched.
assert wedged.send_attempts == 1
assert wedged_key not in runner._session_stall_notified
# Watcher ticks again: the wedged candidate is retried next pass.
sent2 = await asyncio.wait_for(runner._check_session_stalls(60), timeout=5)
assert sent2 == 0 # healthy already latched; wedged timed out again
assert wedged.send_attempts == 2
assert wedged_key not in runner._session_stall_notified
@pytest.mark.asyncio
@pytest.mark.parametrize("setting", [None, False, True])
async def test_stall_policy_owner_latch_and_source_log_conservation(tmp_path, monkeypatch, caplog, setting):
import hermes_yaml as yaml
owner, launch = tmp_path / "owner", tmp_path / "launch"
owner.mkdir(); launch.mkdir()
(owner / "config.yaml").write_text(yaml.safe_dump({} if setting is None else {"display": {"suppress_warning_notifications": setting}}))
(launch / "config.yaml").write_text(yaml.safe_dump({"display": {"suppress_warning_notifications": setting is not True}}))
monkeypatch.setenv("HERMES_HOME", str(launch))
for home, muted in [(owner, setting is True), (launch, setting is not True), (owner, setting is True)]:
adapter = _FakeAdapter()
runner = _runner_for_stall(adapter)
runner._resolve_profile_home_for_source = lambda source: home
key = "agent:default:telegram:dm:policy"
adapter._pending_messages[key] = _pending_event()
agent = _FakeAgent(time.time() - 120)
runner._running_agents[key] = agent
assert await runner._check_session_stalls(60) == (0 if muted else 1)
assert runner._session_stall_notified[key] is True
assert await runner._check_session_stalls(60) == 0
assert "Session stall detected" in caplog.text
agent._last_activity_ts = time.time()
assert await runner._check_session_stalls(60) == 0
assert key not in runner._session_stall_notified
agent._last_activity_ts = time.time() - 120
assert await runner._check_session_stalls(60) == (0 if muted else 1)
assert len(adapter.sent) == (0 if muted else 2)