hermes-agent/tests/gateway/test_retired_session_reset_notice.py
kshitijk4poor 0d5aae5e24 fix(gateway): warn when config still declares a retired idle/daily session_reset
Time-triggered conversation rotation was removed in 1d5d059410 and core
has read nothing under session_reset since. Nothing told users whose
config still asked for it: their gateway conversations silently stopped
resetting, and a household that never types /new pays for an
ever-growing context.

Gateway startup (for every served profile) and `hermes doctor` now
report a session_reset block whose mode is idle, daily or both, and
point at the hermes-session-reset-policy catalog plugin, which reads
the same top-level block unchanged. The notice stays quiet while that
plugin is enabled. The config key is reported, never rewritten, since
the plugin consumes it. The gateway: form the old loader also accepted
is detected too, with a hint to move it to the top level.
2026-09-28 15:54:01 +05:30

36 lines
1.7 KiB
Python

"""Gateway startup names every served profile whose config still declares a retired timed reset."""
import logging
from types import SimpleNamespace
import pytest
from gateway.run_startup import GatewayStartupMixin
from hermes_cli import session_reset_retirement
@pytest.mark.parametrize("plugin_enabled", [False, True])
def test_startup_warns_on_timed_session_reset_unless_plugin_enabled(tmp_path, monkeypatch, caplog, plugin_enabled):
home = tmp_path / "home"
home.mkdir()
(home / "config.yaml").write_text("session_reset:\n mode: idle\n idle_minutes: 60\n", encoding="utf-8")
monkeypatch.setattr("hermes_cli.profiles.profiles_to_serve", lambda multiplex: [("default", home)])
monkeypatch.setattr(session_reset_retirement, "reset_plugin_enabled", lambda: plugin_enabled)
runner = object.__new__(GatewayStartupMixin)
runner.config = SimpleNamespace(multiplex_profiles=False)
with caplog.at_level(logging.WARNING, logger="gateway.run"):
runner._start_log_retired_session_reset()
warned = [r.getMessage() for r in caplog.records if "session_reset.mode: idle" in r.getMessage()]
assert (warned == []) is plugin_enabled
if not plugin_enabled:
assert session_reset_retirement.PLUGIN_NAME in warned[0]
def test_only_timed_modes_count_as_retired_policy():
find = session_reset_retirement.retired_reset_policy
assert find({"session_reset": {"mode": "both"}}) == ("session_reset", "both")
assert find({"gateway": {"session_reset": {"mode": "Daily"}}}) == ("gateway.session_reset", "daily")
assert find({"session_reset": {"mode": "none"}}) is None
assert find({"session_reset": {"idle_minutes": 60}}) is None
assert find({}) is None