mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
Change-detectors, tautologies, source-reading tests, redundant duplicates, mock-echo tests and dead/unrunnable tests. Per-test rationale in the lane ledger (category + reason for every removal).
45 lines
1.7 KiB
Python
45 lines
1.7 KiB
Python
"""Contract: media-send overrides must accept the ``metadata`` kwarg.
|
|
|
|
``BasePlatformAdapter.send_multiple_images`` passes ``metadata=metadata``
|
|
to ``send_image`` / ``send_image_file`` / ``send_animation`` on every send.
|
|
An override whose signature stops at ``reply_to`` raises ``TypeError:
|
|
send_image() got an unexpected keyword argument 'metadata'`` at runtime —
|
|
which is exactly how image delivery broke on WhatsApp and email.
|
|
|
|
This mirrors ``test_discord_media_metadata.py`` but covers the two
|
|
adapters that previously slipped, plus a best-effort sweep over every
|
|
adapter that imports cleanly so the next slip is caught at test time.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import importlib
|
|
import inspect
|
|
|
|
import pytest
|
|
|
|
|
|
def _accepts_metadata(method) -> bool:
|
|
params = inspect.signature(method).parameters
|
|
if "metadata" in params:
|
|
return True
|
|
# A ``**kwargs`` catch-all also absorbs metadata (the convention used by
|
|
# WhatsApp's send_video / send_voice / send_document overrides).
|
|
return any(p.kind is inspect.Parameter.VAR_KEYWORD for p in params.values())
|
|
|
|
|
|
# (module, class) for the two adapters this fix targeted. These must import
|
|
# in CI, so assert directly rather than skipping.
|
|
@pytest.mark.parametrize(
|
|
"module_name, class_name",
|
|
[
|
|
("plugins.platforms.whatsapp.adapter", "WhatsAppAdapter"),
|
|
("plugins.platforms.email.adapter", "EmailAdapter"),
|
|
],
|
|
)
|
|
def test_send_image_accepts_metadata(module_name, class_name):
|
|
cls = getattr(importlib.import_module(module_name), class_name)
|
|
assert _accepts_metadata(cls.send_image), (
|
|
f"{class_name}.send_image must accept 'metadata' (or **kwargs) — "
|
|
f"send_multiple_images passes it on every send"
|
|
)
|