hermes-agent/tests/gateway/test_loop_liveness_watchdog.py
ethernet 890bbbda1f Merge remote-tracking branch 'origin/main' into ethie/pm-clean
# Conflicts:
#	apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts
#	apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts
#	apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts
#	apps/desktop/e2e/bot-mode-roster-localized.spec.ts
#	apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts
#	apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts
#	apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts
#	apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts
#	apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts
#	apps/desktop/e2e/bot-roster-user-sections.spec.ts
#	apps/desktop/e2e/bot-routines-pane-narrow.spec.ts
#	apps/desktop/e2e/bot-row-open-recent-session.spec.ts
#	apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts
#	apps/desktop/e2e/group-composer-auto-grow.spec.ts
#	apps/desktop/e2e/group-create-gate-remote-roster.spec.ts
#	apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts
#	apps/desktop/e2e/hosted-room-backend-continuity.spec.ts
#	apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts
#	apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts
#	apps/desktop/e2e/worktree-branch-status.spec.ts
#	apps/desktop/electron/backend-probes.test.ts
#	apps/desktop/electron/connection-apply.test.ts
#	apps/desktop/electron/desktop-electron-pin.test.ts
#	apps/desktop/electron/desktop-uninstall.test.ts
#	apps/desktop/electron/gateway-file-download-transport.test.ts
#	apps/desktop/electron/gateway-stop-before-update.test.ts
#	apps/desktop/electron/github-api-auth.test.ts
#	apps/desktop/electron/registry-primary-profile-scope.test.ts
#	apps/desktop/electron/update-api-check.test.ts
#	apps/desktop/electron/update-handoff-marker.test.ts
#	apps/desktop/electron/venv-blocker-scan.test.ts
#	apps/desktop/scripts/after-extract.test.mjs
#	apps/desktop/scripts/local-pack-publish.test.mjs
#	apps/desktop/scripts/tasks-scroll.test.mjs
#	apps/desktop/src/app/settings/model-settings.test.tsx
#	apps/desktop/src/app/updates-overlay.blockers.test.tsx
#	apps/desktop/src/components/desktop-install-overlay.test.tsx
#	apps/desktop/src/lib/update-copy.test.ts
#	scripts/ci/check_os_marker_fakes.py
#	tests-js/desktop-mac-usage-descriptions.test.ts
#	tests-js/node-engine-alignment.test.ts
#	tests/agent/lsp/test_install_and_lint_fixes.py
#	tests/agent/test_command_token_source.py
#	tests/agent/test_compression_boundary_hook.py
#	tests/agent/test_create_openai_client_ssl_verify.py
#	tests/agent/test_custom_provider_ca_probes.py
#	tests/agent/test_endpoint_blackhole.py
#	tests/agent/test_estimator_parity.py
#	tests/agent/test_in_place_compaction.py
#	tests/agent/test_moa_loop_mode.py
#	tests/agent/test_model_metadata.py
#	tests/agent/test_skill_session_platform_gate.py
#	tests/agent/test_skill_utils.py
#	tests/agent/test_ssl_ca_guard.py
#	tests/computer_use/test_doctor.py
#	tests/cron/test_codex_execution_paths.py
#	tests/cron/test_cron_bot_chat_delivery.py
#	tests/cron/test_cron_script.py
#	tests/cron/test_media_delivery_parity.py
#	tests/cron/test_misfire_catchup.py
#	tests/cron/test_parallel_pool.py
#	tests/cron/test_recurring_eagain_redispatch.py
#	tests/gateway/test_choice_picker.py
#	tests/gateway/test_control_socket_windows_live.py
#	tests/gateway/test_dingtalk.py
#	tests/gateway/test_feishu.py
#	tests/gateway/test_feishu_onboard.py
#	tests/gateway/test_gateway_shutdown.py
#	tests/gateway/test_matrix.py
#	tests/gateway/test_model_command_custom_providers.py
#	tests/gateway/test_reasoning_command.py
#	tests/gateway/test_runtime_footer.py
#	tests/gateway/test_session.py
#	tests/gateway/test_session_hygiene.py
#	tests/gateway/test_status.py
#	tests/gateway/test_teams.py
#	tests/gateway/test_turn_lease.py
#	tests/gateway/test_whatsapp_connect.py
#	tests/hermes_cli/test_approvals_command.py
#	tests/hermes_cli/test_auth_store_lock_concurrent.py
#	tests/hermes_cli/test_backup.py
#	tests/hermes_cli/test_banner_git_state.py
#	tests/hermes_cli/test_certifi_repair.py
#	tests/hermes_cli/test_cmd_update.py
#	tests/hermes_cli/test_compat_manifest_targets.py
#	tests/hermes_cli/test_computer_use_cli.py
#	tests/hermes_cli/test_cpr_local_leak.py
#	tests/hermes_cli/test_dashboard_auth_gate.py
#	tests/hermes_cli/test_dashboard_procs_kill_grace.py
#	tests/hermes_cli/test_desktop_lifecycle_windows_live.py
#	tests/hermes_cli/test_doctor.py
#	tests/hermes_cli/test_doctor_command_install.py
#	tests/hermes_cli/test_fleet_config_migration_windows_live.py
#	tests/hermes_cli/test_gateway.py
#	tests/hermes_cli/test_gateway_platform_gating.py
#	tests/hermes_cli/test_gateway_restart_loop.py
#	tests/hermes_cli/test_gateway_task_probe.py
#	tests/hermes_cli/test_gateway_wsl.py
#	tests/hermes_cli/test_gui_command.py
#	tests/hermes_cli/test_install_cua_driver.py
#	tests/hermes_cli/test_kanban_db.py
#	tests/hermes_cli/test_lazy_command_exports.py
#	tests/hermes_cli/test_lazy_refresh_venv_repair.py
#	tests/hermes_cli/test_linux_desktop_entry.py
#	tests/hermes_cli/test_local_runtime.py
#	tests/hermes_cli/test_local_runtime_updates.py
#	tests/hermes_cli/test_managed_uv.py
#	tests/hermes_cli/test_mcp_reload_confirm_gate.py
#	tests/hermes_cli/test_nous_subscription.py
#	tests/hermes_cli/test_npm_engine.py
#	tests/hermes_cli/test_personality_none.py
#	tests/hermes_cli/test_pet_toggle.py
#	tests/hermes_cli/test_plan_reconciliation_windows_live.py
#	tests/hermes_cli/test_plugin_event_bus.py
#	tests/hermes_cli/test_plugin_manifest_v2.py
#	tests/hermes_cli/test_plugin_packs.py
#	tests/hermes_cli/test_plugins_cmd.py
#	tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py
#	tests/hermes_cli/test_process_identity.py
#	tests/hermes_cli/test_profiles.py
#	tests/hermes_cli/test_profiles_sidebar_cache.py
#	tests/hermes_cli/test_pty_bridge.py
#	tests/hermes_cli/test_resolve_turn_limit.py
#	tests/hermes_cli/test_serve_runtime_inventory.py
#	tests/hermes_cli/test_session_vacuum_config.py
#	tests/hermes_cli/test_set_config_value.py
#	tests/hermes_cli/test_signal_handler_kanban_worker.py
#	tests/hermes_cli/test_slash_confirm_windows.py
#	tests/hermes_cli/test_stale_pid_guard.py
#	tests/hermes_cli/test_startup_fast_guards.py
#	tests/hermes_cli/test_status.py
#	tests/hermes_cli/test_telegram_managed_bot.py
#	tests/hermes_cli/test_tools_config.py
#	tests/hermes_cli/test_update_apply_shallow_count.py
#	tests/hermes_cli/test_update_autostash.py
#	tests/hermes_cli/test_update_concurrent_quarantine.py
#	tests/hermes_cli/test_update_fetch_failure_classifier.py
#	tests/hermes_cli/test_update_fleet_probe_resume_token.py
#	tests/hermes_cli/test_update_handoff_backend_reap.py
#	tests/hermes_cli/test_update_handoff_desktop_rebuild.py
#	tests/hermes_cli/test_update_head_moved_gate.py
#	tests/hermes_cli/test_update_host_obligation.py
#	tests/hermes_cli/test_update_import_guard.py
#	tests/hermes_cli/test_update_interrupted_recovery.py
#	tests/hermes_cli/test_update_inventory.py
#	tests/hermes_cli/test_update_launchd_unloaded_gateway.py
#	tests/hermes_cli/test_update_missing_configured_deps.py
#	tests/hermes_cli/test_update_modified_notice.py
#	tests/hermes_cli/test_update_multiplex_migration_hook.py
#	tests/hermes_cli/test_update_no_gateway_restart.py
#	tests/hermes_cli/test_update_orphan_backend_reap.py
#	tests/hermes_cli/test_update_parked_branch_guard.py
#	tests/hermes_cli/test_update_post_pull_syntax_guard.py
#	tests/hermes_cli/test_update_receipt.py
#	tests/hermes_cli/test_update_self_lock.py
#	tests/hermes_cli/test_update_shim_fail_closed.py
#	tests/hermes_cli/test_update_shim_self_lock.py
#	tests/hermes_cli/test_update_sqlite_remediation.py
#	tests/hermes_cli/test_update_stale_dashboard.py
#	tests/hermes_cli/test_update_stale_virtualenv.py
#	tests/hermes_cli/test_update_venv_health.py
#	tests/hermes_cli/test_update_venv_ownership_preflight.py
#	tests/hermes_cli/test_update_wedged_gateway.py
#	tests/hermes_cli/test_update_yes_flag.py
#	tests/hermes_cli/test_update_zip_two_phase.py
#	tests/hermes_cli/test_urllib_security.py
#	tests/hermes_cli/test_ux_messages_auth_config.py
#	tests/hermes_cli/test_ux_messages_startup.py
#	tests/hermes_cli/test_venv_holder_classifier.py
#	tests/hermes_cli/test_verify_console_scripts.py
#	tests/hermes_cli/test_verify_core_dependencies.py
#	tests/hermes_cli/test_web_server.py
#	tests/hermes_cli/test_web_server_console_ws.py
#	tests/hermes_cli/test_web_server_ws_ping.py
#	tests/hermes_cli/test_web_ui_build.py
#	tests/hermes_state/test_fts_rebuild_admission.py
#	tests/hermes_state/test_hermes_state.py
#	tests/plugins/memory/test_memory_lazy_install.py
#	tests/plugins/test_google_meet_plugin.py
#	tests/plugins/test_langfuse_plugin.py
#	tests/plugins/test_security_guidance_plugin.py
#	tests/plugins/test_transform_llm_output_hook.py
#	tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py
#	tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py
#	tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py
#	tests/scripts/install/test_install_clone_throttle_fallback.py
#	tests/scripts/install/test_install_lockfile_churn.py
#	tests/scripts/install/test_install_no_initial_commit.py
#	tests/scripts/install/test_install_sh_browser_install.py
#	tests/scripts/install/test_install_sh_node_prerelease.py
#	tests/scripts/install/test_install_sh_symlink_stomp.py
#	tests/scripts/install/test_install_sh_uv_lock_config.py
#	tests/scripts/install/test_install_unmerged_index.py
#	tests/scripts/test_contributor_map.py
#	tests/scripts/test_run_tests_parallel.py
#	tests/skills/test_competitor_news_monitor_skill.py
#	tests/skills/test_document_to_action_items_skill.py
#	tests/skills/test_google_workspace_setup.py
#	tests/skills/test_google_workspace_setup_deps.py
#	tests/skills/test_grounded_citations_skill.py
#	tests/skills/test_ip_as_logo_skill.py
#	tests/skills/test_live_dashboard_skill.py
#	tests/skills/test_mcp_oauth_remote_gateway_skill.py
#	tests/skills/test_office_document_skills.py
#	tests/skills/test_openclaw_migration.py
#	tests/skills/test_product_price_monitor_skill.py
#	tests/skills/test_scrollcraft_skill.py
#	tests/skills/test_setup_wizard_generator_skill.py
#	tests/skills/test_weekly_review_planning_skill.py
#	tests/test_engines_satisfiable.py
#	tests/test_fast_safe_load.py
#	tests/test_hermes_bootstrap.py
#	tests/test_hermes_constants.py
#	tests/test_hermes_logging.py
#	tests/test_managed_runtime_resolution.py
#	tests/test_model_tools_async_bridge.py
#	tests/test_packaging_build_guard.py
#	tests/test_packaging_metadata.py
#	tests/test_yaml_indent_consistency.py
#	tests/tools/test_approval_timeout_overflow.py
#	tests/tools/test_base_environment.py
#	tests/tools/test_bot_mode_dm.py
#	tests/tools/test_browser_chromium_check.py
#	tests/tools/test_browser_hardening.py
#	tests/tools/test_browser_homebrew_paths.py
#	tests/tools/test_browser_npx_warmup.py
#	tests/tools/test_browser_orphan_reaper.py
#	tests/tools/test_browser_real_profile.py
#	tests/tools/test_browser_use_cli.py
#	tests/tools/test_clipboard.py
#	tests/tools/test_code_execution.py
#	tests/tools/test_code_execution_modes.py
#	tests/tools/test_code_execution_windows_env.py
#	tests/tools/test_computer_use.py
#	tests/tools/test_delegate_liveness_timeout.py
#	tests/tools/test_execute_code_approval_cluster.py
#	tests/tools/test_execution_flag_detection.py
#	tests/tools/test_fal_common.py
#	tests/tools/test_file_operations.py
#	tests/tools/test_file_tools.py
#	tests/tools/test_file_tools_cwd_resolution.py
#	tests/tools/test_file_tools_live.py
#	tests/tools/test_lazy_deps.py
#	tests/tools/test_lazy_deps_durable_target.py
#	tests/tools/test_lazy_deps_managed.py
#	tests/tools/test_local_env_blocklist.py
#	tests/tools/test_local_tempdir.py
#	tests/tools/test_macos_protected_search.py
#	tests/tools/test_mcp_npx_cached_bin.py
#	tests/tools/test_oneshot_completion_linger.py
#	tests/tools/test_process_registry.py
#	tests/tools/test_read_file_schema_gating.py
#	tests/tools/test_skill_improvements.py
#	tests/tools/test_skills_sync.py
#	tests/tools/test_termux_api_detection.py
#	tests/tools/test_tirith_security.py
#	tests/tools/test_transcription_tools.py
#	tests/tools/test_tts_streaming.py
#	tests/tools/test_wake_word.py
#	tests/tui_gateway/test_compute_host_borrowed_lease.py
#	tests/tui_gateway/test_compute_host_turn_protocol.py
#	tests/tui_gateway/test_isolated_orphan_activity.py
#	tests/tui_gateway/test_protocol.py
#	tests/tui_gateway/test_slash_worker_profile_home.py
#	tests/tui_gateway/test_subprocess_encoding.py
#	tests/tui_gateway/test_tui_gateway_server.py
#	ui-tui/src/__tests__/terminalParity.test.ts
#	ui-tui/src/__tests__/termuxComposerLayout.test.ts
#	ui-tui/src/__tests__/textInputFastEcho.test.ts
2026-09-23 07:02:44 -04:00

338 lines
12 KiB
Python

"""Gateway event-loop freeze backstops for issue #69089."""
from __future__ import annotations
import asyncio
import pathlib
import threading
import time
from unittest.mock import MagicMock, patch
from gateway.shutdown_watchdog import (
loop_heartbeat_forever,
start_loop_liveness_watchdog,
)
def test_loop_liveness_watchdog_stop_during_dump_disarms_hard_exit():
loop = MagicMock(spec=asyncio.AbstractEventLoop)
handle_ready = threading.Event()
handle_ref = {}
exit_codes = []
def stop_during_dump(*_args, **_kwargs) -> None:
assert handle_ready.wait(timeout=2.0)
handle_ref["handle"].stop()
with (
patch("gateway.shutdown_watchdog.logger.critical") as critical,
patch(
"gateway.shutdown_watchdog.faulthandler.dump_traceback",
side_effect=stop_during_dump,
) as dump,
patch("gateway.shutdown_watchdog.os._exit", side_effect=exit_codes.append),
):
handle = start_loop_liveness_watchdog(
loop, probe_interval=0.01, probe_timeout=0.01, max_strikes=1
)
assert handle is not None
handle_ref["handle"] = handle
handle_ready.set()
handle.join(timeout=2.0)
assert not handle.is_alive()
critical.assert_called_once()
dump.assert_called_once_with(all_threads=True)
assert exit_codes == []
def test_loop_liveness_watchdog_stop_during_final_miss_disarms_hard_exit():
loop = MagicMock(spec=asyncio.AbstractEventLoop)
probe_scheduled = threading.Event()
release_probe = threading.Event()
probe_event_ref = {}
handle_ref = {}
exit_codes = []
class FinalStrikeLimit:
def __gt__(self, _strikes: int) -> bool:
# If strike evaluation is reached, keep recheck #2 from masking a
# missing post-probe recheck #1 in this boundary test.
handle_ref["handle"]._stop_event.clear()
return False
def hold_scheduled_probe(callback) -> None:
probe_event_ref["event"] = callback.__self__
probe_scheduled.set()
assert release_probe.wait(timeout=2.0)
loop.call_soon_threadsafe.side_effect = hold_scheduled_probe
with (
patch("gateway.shutdown_watchdog.logger.critical") as critical,
patch("gateway.shutdown_watchdog.faulthandler.dump_traceback") as dump,
patch("gateway.shutdown_watchdog.os._exit", side_effect=exit_codes.append),
):
handle = start_loop_liveness_watchdog(
loop,
probe_interval=0.01,
probe_timeout=0.01,
max_strikes=FinalStrikeLimit(),
)
assert handle is not None
handle_ref["handle"] = handle
assert probe_scheduled.wait(timeout=2.0), "watchdog did not schedule a probe"
def stop_during_miss() -> bool:
handle.stop()
return False
probe_event_ref["event"].is_set = stop_during_miss
release_probe.set()
handle.join(timeout=1.0)
assert not handle.is_alive()
assert exit_codes == []
critical.assert_not_called()
dump.assert_not_called()
def test_loop_liveness_watchdog_stop_after_first_recheck_skips_final_actions():
loop = MagicMock(spec=asyncio.AbstractEventLoop)
probe_scheduled = threading.Event()
release_probe = threading.Event()
def hold_scheduled_probe(callback) -> None:
probe_scheduled.set()
assert release_probe.wait(timeout=2.0)
loop.call_soon_threadsafe.side_effect = hold_scheduled_probe
with (
patch("gateway.shutdown_watchdog.logger.critical") as critical,
patch("gateway.shutdown_watchdog.faulthandler.dump_traceback") as dump,
patch("gateway.shutdown_watchdog.os._exit") as hard_exit,
):
handle = start_loop_liveness_watchdog(
loop, probe_interval=0.01, probe_timeout=0.01, max_strikes=1
)
assert handle is not None
assert probe_scheduled.wait(timeout=2.0), "watchdog did not schedule a probe"
original_is_set = handle._stop_event.is_set
is_set_calls = 0
def stop_on_final_recheck() -> bool:
nonlocal is_set_calls
is_set_calls += 1
# With the forced immediate timeout: _wait_for_probe is call 1,
# recheck #1 is call 2, and recheck #2 is call 3.
if is_set_calls == 3:
handle.stop()
return original_is_set()
handle._stop_event.is_set = stop_on_final_recheck
with patch(
"gateway.shutdown_watchdog.time.monotonic", side_effect=[0.0, 1.0]
):
release_probe.set()
handle.join(timeout=1.0)
assert is_set_calls == 3
assert not handle.is_alive()
critical.assert_not_called()
dump.assert_not_called()
hard_exit.assert_not_called()
def test_gateway_config_loop_watchdog_round_trip():
"""loop_watchdog is a config.yaml knob: default on, nested-gateway form honored."""
from gateway.config import GatewayConfig
assert GatewayConfig.from_dict({}).loop_watchdog is True
assert GatewayConfig.from_dict({"loop_watchdog": False}).loop_watchdog is False
assert (
GatewayConfig.from_dict(
{"gateway": {"loop_watchdog": "off"}}
).loop_watchdog
is False
)
config = GatewayConfig.from_dict({"loop_watchdog": False})
assert config.to_dict()["loop_watchdog"] is False
def test_gateway_config_loop_watchdog_tuning_round_trip():
"""Watchdog tolerance knobs parse, serialize, and clamp malformed values."""
from gateway.config import GatewayConfig
# Defaults
default = GatewayConfig.from_dict({})
assert default.loop_watchdog is True
assert default.loop_watchdog_probe_interval_s == 30.0
assert default.loop_watchdog_probe_timeout_s == 10.0
assert default.loop_watchdog_max_strikes == 3
# Explicit values round-trip
cfg = GatewayConfig.from_dict(
{
"loop_watchdog_probe_interval_s": 45,
"loop_watchdog_probe_timeout_s": 15,
"loop_watchdog_max_strikes": 12,
}
)
assert cfg.loop_watchdog_probe_interval_s == 45.0
assert cfg.loop_watchdog_probe_timeout_s == 15.0
assert cfg.loop_watchdog_max_strikes == 12
d = cfg.to_dict()
assert d["loop_watchdog_probe_interval_s"] == 45.0
assert d["loop_watchdog_probe_timeout_s"] == 15.0
assert d["loop_watchdog_max_strikes"] == 12
# Nested gateway.* form honored
nested = GatewayConfig.from_dict(
{
"gateway": {
"loop_watchdog_probe_interval_s": 60,
"loop_watchdog_probe_timeout_s": 20,
"loop_watchdog_max_strikes": 20,
}
}
)
assert nested.loop_watchdog_probe_interval_s == 60.0
assert nested.loop_watchdog_probe_timeout_s == 20.0
assert nested.loop_watchdog_max_strikes == 20
# Malformed / degenerate values fall back to safe defaults
clamped = GatewayConfig.from_dict(
{
"loop_watchdog_probe_interval_s": 0,
"loop_watchdog_probe_timeout_s": -5,
"loop_watchdog_max_strikes": 0,
}
)
assert clamped.loop_watchdog_probe_interval_s == 30.0
assert clamped.loop_watchdog_probe_timeout_s == 10.0
assert clamped.loop_watchdog_max_strikes == 3
def test_gateway_config_loop_watchdog_nonfinite_values_degrade():
"""NaN/Inf tuning values fall back to defaults instead of reaching the
watchdog's Event.wait loop (or aborting config load via int(inf))."""
from gateway.config import GatewayConfig
cfg = GatewayConfig.from_dict(
{
"loop_watchdog_probe_interval_s": float("inf"),
"loop_watchdog_probe_timeout_s": float("nan"),
"loop_watchdog_max_strikes": float("inf"), # int() would raise
}
)
assert cfg.loop_watchdog_probe_interval_s == 30.0
assert cfg.loop_watchdog_probe_timeout_s == 10.0
assert cfg.loop_watchdog_max_strikes == 3
# Oversized-but-finite values also clamp to defaults.
big = GatewayConfig.from_dict(
{
"loop_watchdog_probe_interval_s": 86400,
"loop_watchdog_probe_timeout_s": 7200,
"loop_watchdog_max_strikes": 10**9,
}
)
assert big.loop_watchdog_probe_interval_s == 30.0
assert big.loop_watchdog_probe_timeout_s == 10.0
assert big.loop_watchdog_max_strikes == 3
def test_load_gateway_config_bridges_loop_watchdog_keys(tmp_path, monkeypatch):
"""The real startup loader must honor gateway.loop_watchdog* from
config.yaml — from_dict's nested fallback never sees the yaml gateway
section because load_gateway_config builds gw_data flat."""
from gateway.config import load_gateway_config
(tmp_path / "config.yaml").write_text(
"gateway:\n"
" loop_watchdog: false\n"
" loop_watchdog_probe_interval_s: 45\n"
" loop_watchdog_probe_timeout_s: 15\n"
" loop_watchdog_max_strikes: 12\n",
encoding="utf-8",
)
monkeypatch.setattr("gateway.config.get_hermes_home", lambda: tmp_path)
cfg = load_gateway_config()
assert cfg.loop_watchdog is False
assert cfg.loop_watchdog_probe_interval_s == 45.0
assert cfg.loop_watchdog_probe_timeout_s == 15.0
assert cfg.loop_watchdog_max_strikes == 12
def test_loop_liveness_watchdog_marks_runtime_degraded_before_restart():
"""The terminal watchdog observation must be visible before ``os._exit``."""
from gateway.status import read_runtime_status, write_runtime_status
write_runtime_status(gateway_state="running", exit_reason=None)
loop = MagicMock(spec=asyncio.AbstractEventLoop)
fired = threading.Event()
exit_codes = []
def fake_exit(code: int) -> None:
exit_codes.append(code)
fired.set()
with (
patch("gateway.shutdown_watchdog.faulthandler.dump_traceback"),
patch("gateway.shutdown_watchdog.os._exit", side_effect=fake_exit),
):
handle = start_loop_liveness_watchdog(
loop, probe_interval=0.01, probe_timeout=0.01, max_strikes=2
)
assert handle is not None
assert fired.wait(timeout=2.0), "watchdog did not reach its restart exit"
handle.stop()
handle.join(timeout=1.0)
record = read_runtime_status()
assert exit_codes == [75]
assert record["gateway_state"] == "degraded"
assert record["exit_reason"] == "loop_liveness_watchdog"
assert record["restart_requested"] is True
def test_heartbeat_write_does_not_block_the_loop_it_monitors():
"""The heartbeat write must not freeze the loop the watchdog is watching.
``write_loop_heartbeat`` ends in ``atomic_json_write`` -> ``os.fsync``, and on
a stalling filesystem that fsync blocks whichever thread runs it. Run inline,
that thread was the gateway loop — so the loop-liveness watchdog would time
out its probe (10s, 3 strikes, a ~90-120s budget) and kill the loop for being
unresponsive at the moment it was blocked inside the watchdog's own write. A
WSL2 VHDX under io pressure was measured stalling a trivial stat-and-fsync
probe at p99 31s, max 112s — longer than the whole budget.
Bounded by a fixed sleep rather than an Event handshake on purpose: if the
write ever goes back on-loop this fails on the tick count instead of hanging.
"""
block_s = 0.30
def slow_write(**_kwargs):
time.sleep(block_s)
return pathlib.Path("/dev/null")
async def scenario() -> int:
ticks = 0
async def ticker() -> None:
nonlocal ticks
deadline = time.monotonic() + block_s
while time.monotonic() < deadline:
await asyncio.sleep(0.02)
ticks += 1
with patch(
"gateway.shutdown_watchdog.write_loop_heartbeat", slow_write
):
# should_continue False -> exactly one write, then return.
hb = asyncio.create_task(
loop_heartbeat_forever(interval_s=60.0, should_continue=lambda: False)
)
await ticker()
await asyncio.wait_for(hb, timeout=5.0)
return ticks
ticks = asyncio.run(scenario())
# Off-loop, the ticker gets roughly block_s / 0.02 ticks. Inline it gets at
# most one, because the loop cannot run anything while fsync blocks it.
assert ticks >= 5, (
"the loop made only %d tick(s) while the heartbeat was writing — "
"the write is blocking the loop again" % ticks
)