mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
Platform adapters download and cache an attachment BEFORE the gateway routes the event to a multiplexed profile, so the bytes land under the launch home while the routed turn's sandbox mounts (get_cache_directory_mounts) and vision's _media_cache_roots resolve profiles/<p>/cache/<kind>: the agent is handed a mounted, empty directory and asks for a re-send that can never work. - run_inbound.py::rehome_inbound_media: at the shared preprocessing choke point (_prepare_inbound_message_text, already inside the routed scope for every adapter and media kind) move each launch-home cache file into the active profile's matching cache dir and repoint media_urls (and any adapter-baked note). No-op when the active home is the launch home; idempotent. - platforms/base.py::CachedMedia.path is now the HOST path like every other cache_*_from_bytes primitive; context_note() translates at render time, so media_urls holds one coordinate system that the routed turn can re-home and translate alike. Diagnosis and approach credit: @JoaoMarcos44 (#101369); slimmed to the seam. Row L4-adjacent (routed turn preprocessing) / T2, T3.
84 lines
4.5 KiB
Python
84 lines
4.5 KiB
Python
"""Inbound attachments on a multiplexed gateway live in the ROUTED profile's cache (#101134).
|
|
|
|
Adapters cache an attachment before the event is routed, so the bytes land under the launch home
|
|
while the routed profile's sandbox mounts point at ``profiles/<p>/cache/<kind>`` — a mounted, empty
|
|
directory. Real temp homes A (launch) and B (routed), real ``_profile_runtime_scope``, multiplex on.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
import hermes_yaml as yaml
|
|
|
|
from agent import secret_scope as ss
|
|
from gateway.platforms.base import cache_media_bytes
|
|
from gateway.platforms.event import MessageEvent, MessageType
|
|
from gateway.run import _profile_runtime_scope
|
|
from gateway.run_inbound import GatewayInboundMixin, rehome_inbound_media
|
|
from tools.credential_files import from_agent_visible_cache_path, get_cache_directory_mounts
|
|
|
|
|
|
@pytest.fixture
|
|
def two_homes(tmp_path, monkeypatch):
|
|
"""Launch home A (HERMES_HOME, local backend) and routed profile B (docker backend)."""
|
|
a = tmp_path / ".hermes"
|
|
b = a / "profiles" / "b"
|
|
b.mkdir(parents=True)
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(a))
|
|
for name, home in (("a", a), ("b", b)):
|
|
(home / "config.yaml").write_text(
|
|
yaml.safe_dump({"terminal": {"backend": "local" if name == "a" else "docker"}}), encoding="utf-8")
|
|
ss.set_multiplex_active(True)
|
|
yield a, b
|
|
ss.set_multiplex_active(False)
|
|
|
|
|
|
def _adapter_cached(home: Path, kind: str, name: str) -> str:
|
|
"""What an adapter leaves behind: a file under ``<home>/cache/<kind>`` (host path)."""
|
|
path = home / "cache" / kind / name
|
|
path.parent.mkdir(parents=True, exist_ok=True)
|
|
path.write_bytes(b"%PDF-1.4 x" if kind == "documents" else b"\xff\xd8\xff\xe0 jpeg")
|
|
return str(path)
|
|
|
|
|
|
def test_routed_turn_rehomes_adapter_cached_attachments_a_b_a(two_homes):
|
|
a, b = two_homes
|
|
doc, img = _adapter_cached(a, "documents", "doc_0123456789ab_report.pdf"), _adapter_cached(a, "images", "img_1.jpg")
|
|
event = MessageEvent(text=f"[document 'report.pdf' saved at: {doc}]", message_type=MessageType.DOCUMENT,
|
|
source=None, media_urls=[doc, img], media_types=["application/pdf", "image/jpeg"])
|
|
|
|
with _profile_runtime_scope(b): # routed turn: B's mounts, B's cache roots
|
|
rehome_inbound_media(event)
|
|
note = GatewayInboundMixin._prepend_inbound_document_notes(event, "")
|
|
assert "/root/.hermes/cache/documents/doc_0123456789ab_report.pdf" in note # sandbox form
|
|
# The sandbox path names a file B's container actually mounts.
|
|
host = Path(from_agent_visible_cache_path("/root/.hermes/cache/documents/doc_0123456789ab_report.pdf"))
|
|
assert host.is_file() and host == b / "cache" / "documents" / "doc_0123456789ab_report.pdf"
|
|
assert {Path(m["host_path"]) for m in get_cache_directory_mounts()} >= {host.parent, (b / "cache" / "images")}
|
|
assert "/root/.hermes/cache/documents/doc_0123456789ab_report.pdf" in event.text # baked note repointed
|
|
assert event.media_urls == [str(b / "cache" / "documents" / "doc_0123456789ab_report.pdf"),
|
|
str(b / "cache" / "images" / "img_1.jpg")]
|
|
assert not Path(doc).exists() and not Path(img).exists() # moved, not copied: A holds nothing of B's
|
|
assert (b / "cache" / "images" / "img_1.jpg").is_file()
|
|
|
|
# A→B→A: a launch-profile turn keeps its own files where they are (no-op, no bleed into B).
|
|
doc_a = _adapter_cached(a, "documents", "doc_aaaaaaaaaaaa_own.pdf")
|
|
own = MessageEvent(text="", message_type=MessageType.DOCUMENT, source=None,
|
|
media_urls=[doc_a], media_types=["application/pdf"])
|
|
with _profile_runtime_scope(a):
|
|
rehome_inbound_media(own)
|
|
assert own.media_urls == [doc_a] and Path(doc_a).is_file()
|
|
assert not (b / "cache" / "documents" / "doc_aaaaaaaaaaaa_own.pdf").exists()
|
|
|
|
|
|
def test_cache_media_bytes_returns_host_path_and_translates_in_note(two_homes):
|
|
"""``media_urls`` holds ONE coordinate system (host paths, like ``cache_image_from_bytes``); the
|
|
sandbox translation happens at render time under the scope that owns the turn."""
|
|
_, b = two_homes
|
|
with _profile_runtime_scope(b): # docker backend
|
|
cached = cache_media_bytes(b"%PDF-1.4 x", filename="report.pdf", mime_type="application/pdf")
|
|
assert Path(cached.path).is_file() and Path(cached.path).parent == b / "cache" / "documents"
|
|
assert cached.context_note().startswith("[document 'report.pdf' saved at: /root/.hermes/cache/documents/doc_")
|