mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
Strict OpenAI clients reject the named hermes.tool.progress SSE frames. Setting tool_progress_events: false under platforms.api_server (loaded into PlatformConfig.extra by from_dict) now drops them; default stays on. Reimplements the intent of #42640 against the adapter config actually read in production. Overlaps #49069 (erikerosev). Co-authored-by: liuhao1024 <[email protected]>
48 lines
1.9 KiB
Python
48 lines
1.9 KiB
Python
"""``platforms.api_server.tool_progress_events: false`` drops the custom
|
|
``hermes.tool.progress`` SSE frames from streaming Chat Completions (#12020)."""
|
|
|
|
import asyncio
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
|
|
def _stream_body(platform_cfg):
|
|
from aiohttp import web
|
|
from gateway.config import PlatformConfig
|
|
from gateway.platforms.api_server import APIServerAdapter, ThreadSafeAsyncQueue
|
|
|
|
# from_dict is the production loader: a top-level platform key lands in ``extra``.
|
|
adapter = APIServerAdapter(PlatformConfig.from_dict(platform_cfg))
|
|
written = []
|
|
|
|
async def fake_agent():
|
|
return {"final_response": "done", "completed": True}, {
|
|
"input_tokens": 1, "output_tokens": 1, "total_tokens": 2}
|
|
|
|
async def run():
|
|
stream_q = ThreadSafeAsyncQueue()
|
|
stream_q.put_nowait(("__tool_progress__", {"tool": "terminal", "toolCallId": "c1", "status": "running"}))
|
|
stream_q.put_nowait("done")
|
|
stream_q.put_nowait(None)
|
|
agent_task = asyncio.ensure_future(fake_agent())
|
|
resp = AsyncMock(spec=web.StreamResponse)
|
|
resp.write = AsyncMock(side_effect=lambda data: written.append(data))
|
|
resp.prepare = AsyncMock()
|
|
req = MagicMock()
|
|
req.headers = {}
|
|
with patch("gateway.platforms.api_server.web.StreamResponse", return_value=resp):
|
|
await adapter._write_sse_chat_completion(req, "cmpl-1", "m", 1, stream_q, agent_task)
|
|
|
|
asyncio.run(run())
|
|
return b"".join(written).decode()
|
|
|
|
|
|
def test_tool_progress_frames_emitted_by_default():
|
|
body = _stream_body({"enabled": True, "token": "k"})
|
|
assert "event: hermes.tool.progress" in body
|
|
assert '"content": "done"' in body
|
|
|
|
|
|
def test_tool_progress_events_false_suppresses_frames_but_keeps_content():
|
|
body = _stream_body({"enabled": True, "token": "k", "tool_progress_events": False})
|
|
assert "hermes.tool.progress" not in body
|
|
assert '"content": "done"' in body
|