mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 21:32:52 +00:00
`_read_script_for_scanning` returned a lifecycle-shaped sentinel ("hermes gateway
restart") when the job's OWN script was oversized, a device, or a SQLite database
open in this process, so `check_gateway_lifecycle` raised the misattributed
"cron job contains a gateway lifecycle command" error. It now returns
`(text, refusal)` via `_unreadable_reason` and the caller raises the existing
named "could not scan ... <reason>" refusal, matching the referenced-script walk
(#113944 atom 4).
Also adds encoding="utf-8" to the PR's own test file where the Windows footgun
scanner flagged bare write_text()/open() calls.
119 lines
5.4 KiB
Python
119 lines
5.4 KiB
Python
"""The referenced-script walk sees the same inert-heredoc-masked view as the direct scan (#110422).
|
|
|
|
``_direct_lifecycle_scan`` masks provably-inert heredoc bodies (quoted delimiter, allowlisted
|
|
data consumer such as ``python3 - <<'PY'``), but ``_contains_unsafe_gateway_action`` walked
|
|
referenced scripts and ``sh -c`` payloads on the raw command, so a >1 MiB data path mentioned
|
|
inside the Python body failed closed as an oversized "script".
|
|
"""
|
|
|
|
import pytest
|
|
|
|
from cron.lifecycle_guard import contains_gateway_lifecycle_command_or_referenced_script as guard
|
|
|
|
|
|
def _big_file(tmp_path):
|
|
path = tmp_path / "big_blob.bin"
|
|
path.write_bytes(b"\0" * (2 * 1024 * 1024))
|
|
return path
|
|
|
|
|
|
def test_inert_heredoc_body_path_not_walked_as_script(tmp_path):
|
|
big = _big_file(tmp_path)
|
|
command = f"python3 - <<'PY'\nfrom pathlib import Path\nprint(Path('{big}').stat().st_size)\nPY"
|
|
assert guard(command, cwd=str(tmp_path)) is False
|
|
|
|
|
|
def test_prefixed_inert_heredoc_body_path_not_walked_as_script(tmp_path):
|
|
big = _big_file(tmp_path)
|
|
command = (
|
|
f"cd {tmp_path} && python3 - <<'PY'\n"
|
|
f"from pathlib import Path\nprint(Path('{big}').stat().st_size)\nPY"
|
|
)
|
|
assert guard(command, cwd=str(tmp_path)) is False
|
|
|
|
|
|
def test_allowlisted_name_function_heredoc_stays_visible(tmp_path):
|
|
command = "python3() { bash; }; python3 <<'PY'\nhermes gateway restart\nPY"
|
|
assert guard(command, cwd=str(tmp_path)) is True
|
|
|
|
|
|
def test_unquoted_heredoc_body_path_still_walked(tmp_path):
|
|
"""An expansion-capable body is not provably inert: the walk still sees it and fails closed."""
|
|
big = _big_file(tmp_path)
|
|
assert guard(f"cat > /tmp/x <<EOF\n{big}\nEOF", cwd=str(tmp_path)) is True
|
|
|
|
|
|
def test_inert_heredoc_body_script_path_still_read(tmp_path):
|
|
"""Masking hides the body from the *executed* view only: a lifecycle script named inside a
|
|
Python body is still handed to ``os.system`` at runtime, so its contents must still be read."""
|
|
script = tmp_path / "restart.sh"
|
|
script.write_text("#!/bin/sh\nhermes gateway restart\n", encoding="utf-8")
|
|
command = f"python3 - <<'PY'\nimport os\nos.system('{script}')\nPY"
|
|
assert guard(command, cwd=str(tmp_path)) is True
|
|
|
|
|
|
def test_mentioned_data_file_that_cannot_be_scanned_is_not_a_verdict(tmp_path, monkeypatch):
|
|
"""A file only MENTIONED in an inert body may exhaust the text budget (one >64 KiB line), pull
|
|
in 64+ remote-read misses (a markdown table of paths) or be a live SQLite database: each is
|
|
"nothing to scan", never a block (#113944). The same file *executed* still fails closed."""
|
|
import cron.lifecycle_guard as lifecycle_guard
|
|
from hermes_cli.sqlite_safe_read import connect_tracked
|
|
|
|
minified = tmp_path / "minified.json"
|
|
minified.write_text("[" + "1," * 40000 + "1]", encoding="utf-8")
|
|
notes = tmp_path / "notes.md"
|
|
notes.write_text("\n".join(f"| /opt/frag{i}/tool-{i}.md | note |" for i in range(70)), encoding="utf-8")
|
|
db = tmp_path / "state.db"
|
|
conn = connect_tracked(db)
|
|
monkeypatch.setattr(lifecycle_guard, "_MAX_LIFECYCLE_SCAN_REMOTE_READS", 8)
|
|
remote_misses: list[str] = []
|
|
|
|
def remote(path: str):
|
|
remote_misses.append(path)
|
|
return None
|
|
|
|
try:
|
|
for data in (minified, notes, db):
|
|
command = f"cd {tmp_path} && python3 - <<'PY'\nt = open('{data}', encoding='utf-8').read()\nPY"
|
|
assert guard(command, cwd=str(tmp_path), read_remote_script=remote) is False, data.name
|
|
assert remote_misses # the notes table was walked and its misses were bounded, not fatal
|
|
unsafe, refusal = lifecycle_guard.scan_gateway_lifecycle(f"bash {minified}")
|
|
assert unsafe is True and "budget" in refusal
|
|
unsafe, refusal = lifecycle_guard.scan_gateway_lifecycle(f"bash {db}")
|
|
assert unsafe is True and "SQLite" in refusal
|
|
finally:
|
|
conn.close()
|
|
|
|
|
|
def test_mentioned_script_with_lifecycle_command_still_blocks(tmp_path):
|
|
"""The lenient path only covers "could not scan": a mentioned script whose text IS a lifecycle
|
|
command is still a positive verdict, and the refusal reason stays empty (it is not a scan failure)."""
|
|
import cron.lifecycle_guard as lifecycle_guard
|
|
|
|
script = tmp_path / "restart.sh"
|
|
script.write_text("#!/bin/sh\nhermes gateway restart\n", encoding="utf-8")
|
|
command = f"cd {tmp_path} && python3 - <<'PY'\nimport os\nos.system('{script}')\nPY"
|
|
assert lifecycle_guard.scan_gateway_lifecycle(command, cwd=str(tmp_path)) == (True, None)
|
|
|
|
|
|
@pytest.mark.parametrize("shape", ["oversized", "sqlite"])
|
|
def test_unscannable_own_cron_script_raises_named_refusal(tmp_path, shape):
|
|
"""A cron job whose OWN script is oversized or a live SQLite database fails closed with the
|
|
named "could not scan" refusal, never the misattributed "contains a gateway lifecycle command"."""
|
|
from cron.lifecycle_guard import GatewayLifecycleBlocked, check_gateway_lifecycle
|
|
from hermes_cli.sqlite_safe_read import connect_tracked
|
|
|
|
if shape == "oversized":
|
|
script, conn = _big_file(tmp_path), None
|
|
else:
|
|
script = tmp_path / "state.db"
|
|
conn = connect_tracked(script)
|
|
try:
|
|
with pytest.raises(GatewayLifecycleBlocked) as excinfo:
|
|
check_gateway_lifecycle("run it", str(script))
|
|
finally:
|
|
if conn is not None:
|
|
conn.close()
|
|
message = str(excinfo.value)
|
|
assert "could not scan" in message and str(script) in message
|
|
assert "contains a gateway lifecycle command" not in message
|