mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 21:32:52 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
395 lines
15 KiB
Python
395 lines
15 KiB
Python
"""Cron sessions must not inherit a kanban worker's dispatcher identity.
|
|
|
|
A cron job can be fired *in-process* from a kanban worker: the worker is a
|
|
normal ``hermes chat -q`` CLI agent (its default toolset includes ``cronjob``)
|
|
running with ``HERMES_KANBAN_TASK`` legitimately set in its own environment,
|
|
and ``cronjob(action="run")`` calls ``run_one_job()`` -> ``run_job()`` in that
|
|
same process.
|
|
|
|
Without isolation the cron ``AIAgent`` is misidentified as that worker: the
|
|
kanban toolset is force-added, the kanban-worker protocol is injected into its
|
|
system prompt, and ``kanban_complete`` defaults ``task_id`` to
|
|
``$HERMES_KANBAN_TASK`` — letting an unrelated cron job close the worker's task
|
|
and overwrite real results.
|
|
|
|
The isolation is a **ContextVar**, deliberately not an ``os.environ`` clear:
|
|
``os.environ`` is process-global and shared with
|
|
|
|
* the worker's own claim heartbeat (``run_agent._touch_activity`` ->
|
|
``heartbeat_current_worker_from_env``), which would starve and let the
|
|
dispatcher reclaim a task whose worker is still alive;
|
|
* the gateway's kanban watchers, which do their own board save/restore;
|
|
* concurrent cron jobs on the parallel pool, which take a *shared* read lock
|
|
and can interleave one another's snapshot/restore.
|
|
|
|
So these tests assert both that the identity is hidden AND that the environment
|
|
is left completely untouched.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import os
|
|
import threading
|
|
|
|
import pytest
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def _clear_kanban_detect_cache():
|
|
"""`_detect_environment` memoizes per process; kanban is context-dependent."""
|
|
import agent.skill_utils as su
|
|
|
|
su._ENV_DETECT_CACHE.pop("kanban", None)
|
|
yield
|
|
su._ENV_DETECT_CACHE.pop("kanban", None)
|
|
|
|
|
|
@pytest.fixture()
|
|
def worker_env(monkeypatch):
|
|
"""Simulate running inside a dispatcher-spawned kanban worker."""
|
|
monkeypatch.setenv("HERMES_KANBAN_TASK", "t_worker_real_task")
|
|
monkeypatch.setenv("HERMES_KANBAN_WORKSPACE", "/tmp/ws")
|
|
monkeypatch.setenv("HERMES_KANBAN_RUN_ID", "42")
|
|
monkeypatch.setenv("HERMES_KANBAN_CLAIM_LOCK", "lock-abc")
|
|
monkeypatch.setenv("HERMES_KANBAN_BOARD", "team-alpha")
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# The predicate itself
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestDispatcherOwnedPredicate:
|
|
|
|
def test_false_inside_non_dispatcher_context(self):
|
|
from agent.delegation_context import (
|
|
is_dispatcher_owned_worker_context,
|
|
non_dispatcher_owned_context,
|
|
)
|
|
|
|
with non_dispatcher_owned_context():
|
|
assert is_dispatcher_owned_worker_context() is False
|
|
assert is_dispatcher_owned_worker_context() is True
|
|
|
|
def test_token_form_restores(self):
|
|
from agent.delegation_context import (
|
|
enter_non_dispatcher_owned_context,
|
|
exit_non_dispatcher_owned_context,
|
|
is_dispatcher_owned_worker_context,
|
|
)
|
|
|
|
token = enter_non_dispatcher_owned_context()
|
|
assert is_dispatcher_owned_worker_context() is False
|
|
exit_non_dispatcher_owned_context(token)
|
|
assert is_dispatcher_owned_worker_context() is True
|
|
|
|
def test_nesting_restores_outer_value(self):
|
|
from agent.delegation_context import (
|
|
is_dispatcher_owned_worker_context,
|
|
non_dispatcher_owned_context,
|
|
)
|
|
|
|
with non_dispatcher_owned_context():
|
|
with non_dispatcher_owned_context():
|
|
assert is_dispatcher_owned_worker_context() is False
|
|
assert is_dispatcher_owned_worker_context() is False
|
|
assert is_dispatcher_owned_worker_context() is True
|
|
|
|
def test_delegated_child_still_not_dispatcher_owned(self, monkeypatch):
|
|
"""The pre-existing delegate_task flag keeps its meaning."""
|
|
import agent.delegation_context as dc
|
|
|
|
token = dc._DELEGATED_CHILD_CONTEXT.set(True)
|
|
try:
|
|
assert dc.is_dispatcher_owned_worker_context() is False
|
|
finally:
|
|
dc._DELEGATED_CHILD_CONTEXT.reset(token)
|
|
|
|
def test_thread_isolation(self, worker_env):
|
|
"""A ContextVar set in one thread must not leak into a sibling thread.
|
|
|
|
This is the property an os.environ clear cannot provide, and the reason
|
|
concurrent cron jobs can't corrupt each other.
|
|
"""
|
|
from agent.delegation_context import (
|
|
is_dispatcher_owned_worker_context,
|
|
non_dispatcher_owned_context,
|
|
)
|
|
|
|
seen = {}
|
|
release = threading.Event()
|
|
|
|
def sibling():
|
|
seen["sibling"] = is_dispatcher_owned_worker_context()
|
|
release.set()
|
|
|
|
def job():
|
|
with non_dispatcher_owned_context():
|
|
seen["job"] = is_dispatcher_owned_worker_context()
|
|
t = threading.Thread(target=sibling)
|
|
t.start()
|
|
release.wait(5)
|
|
t.join(5)
|
|
|
|
t = threading.Thread(target=job)
|
|
t.start()
|
|
t.join(5)
|
|
|
|
assert seen["job"] is False, "job thread must be marked non-dispatcher"
|
|
assert seen["sibling"] is True, "sibling thread must be unaffected"
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# The gates that consume it
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestKanbanGatesRespectContext:
|
|
def test_task_tools_hidden_from_cron_agent(self, worker_env):
|
|
from agent.delegation_context import non_dispatcher_owned_context
|
|
from tools import kanban_tools
|
|
|
|
assert kanban_tools._check_kanban_mode() is True
|
|
with non_dispatcher_owned_context():
|
|
assert kanban_tools._check_kanban_mode() is False
|
|
|
|
def test_complete_does_not_default_to_worker_task(self, worker_env):
|
|
"""The damage path: kanban_complete must not inherit the task id."""
|
|
from agent.delegation_context import non_dispatcher_owned_context
|
|
from tools import kanban_tools
|
|
|
|
assert kanban_tools._default_task_id(None) == "t_worker_real_task"
|
|
with non_dispatcher_owned_context():
|
|
assert kanban_tools._default_task_id(None) is None
|
|
|
|
def test_explicit_task_id_still_honoured(self, worker_env):
|
|
"""Only the implicit default is suppressed, not an explicit argument."""
|
|
from agent.delegation_context import non_dispatcher_owned_context
|
|
from tools import kanban_tools
|
|
|
|
with non_dispatcher_owned_context():
|
|
assert kanban_tools._default_task_id("t_explicit") == "t_explicit"
|
|
|
|
|
|
def test_kanban_env_verdict_is_not_memoized(self, worker_env):
|
|
"""`kanban` must bypass _ENV_DETECT_CACHE: caching it process-wide would
|
|
freeze whichever context asked first and leak it to the others."""
|
|
from agent.delegation_context import non_dispatcher_owned_context
|
|
import agent.skill_utils as su
|
|
|
|
su._ENV_DETECT_CACHE.pop("kanban", None)
|
|
assert su._detect_environment("kanban") is True
|
|
with non_dispatcher_owned_context():
|
|
# No manual cache clear here — the production code must not have
|
|
# cached the previous True.
|
|
assert su._detect_environment("kanban") is False
|
|
assert su._detect_environment("kanban") is True
|
|
|
|
def test_toolset_force_add_suppressed(self, worker_env):
|
|
from agent.delegation_context import non_dispatcher_owned_context
|
|
import model_tools
|
|
|
|
assert model_tools._is_dispatcher_owned_worker() is True
|
|
with non_dispatcher_owned_context():
|
|
assert model_tools._is_dispatcher_owned_worker() is False
|
|
|
|
|
|
# ---------------------------------------------------------------------------
|
|
# run_job wiring
|
|
# ---------------------------------------------------------------------------
|
|
|
|
class TestRunJobKanbanIsolation:
|
|
@staticmethod
|
|
def _install_stubs(monkeypatch, observed: dict, agent_cls=None):
|
|
import sys
|
|
|
|
import cron.scheduler as sched
|
|
from cron import scheduler_delivery as sched_delivery
|
|
from agent.delegation_context import is_dispatcher_owned_worker_context
|
|
|
|
class FakeAgent:
|
|
def __init__(self, **kwargs):
|
|
observed["dispatcher_owned_during_init"] = (
|
|
is_dispatcher_owned_worker_context()
|
|
)
|
|
observed["kanban_env_during_init"] = {
|
|
k: v for k, v in os.environ.items()
|
|
if k.startswith("HERMES_KANBAN_")
|
|
}
|
|
|
|
def run_conversation(self, *_a, **_kw):
|
|
observed["dispatcher_owned_during_run"] = (
|
|
is_dispatcher_owned_worker_context()
|
|
)
|
|
return {"final_response": "done", "messages": []}
|
|
|
|
def get_activity_summary(self):
|
|
return {"seconds_since_activity": 0.0}
|
|
|
|
fake_mod = type(sys)("run_agent")
|
|
fake_mod.AIAgent = agent_cls or FakeAgent
|
|
monkeypatch.setitem(sys.modules, "run_agent", fake_mod)
|
|
|
|
from hermes_cli import runtime_provider as _rtp
|
|
|
|
monkeypatch.setattr(
|
|
_rtp, "resolve_runtime_provider",
|
|
lambda **_kw: {
|
|
"provider": "test", "api_key": "k",
|
|
"base_url": "http://test.local",
|
|
"api_mode": "chat_completions",
|
|
},
|
|
)
|
|
monkeypatch.setattr(
|
|
sched, "_build_job_prompt", lambda job, prerun_script=None, **kw: "hi"
|
|
)
|
|
monkeypatch.setattr(sched_delivery, "_resolve_origin", lambda job: None)
|
|
monkeypatch.setattr(sched, "_resolve_delivery_target", lambda job: None)
|
|
monkeypatch.setattr(
|
|
sched, "_resolve_cron_enabled_toolsets", lambda job, cfg: None
|
|
)
|
|
monkeypatch.setenv("HERMES_CRON_TIMEOUT", "0")
|
|
|
|
import dotenv
|
|
|
|
monkeypatch.setattr(dotenv, "load_dotenv", lambda *_a, **_kw: True)
|
|
|
|
@staticmethod
|
|
def _job(job_id="kanban-iso"):
|
|
return {
|
|
"id": job_id, "name": "kanban-iso-job",
|
|
"workdir": None, "schedule_display": "manual",
|
|
}
|
|
|
|
def test_agent_runs_as_non_dispatcher(self, monkeypatch, worker_env):
|
|
import cron.scheduler as sched
|
|
|
|
observed: dict = {}
|
|
self._install_stubs(monkeypatch, observed)
|
|
|
|
success, *_ = sched.run_job(self._job())
|
|
assert success is True
|
|
assert observed["dispatcher_owned_during_init"] is False
|
|
assert observed["dispatcher_owned_during_run"] is False
|
|
|
|
def test_environment_is_left_untouched(self, monkeypatch, worker_env):
|
|
"""The whole point of the ContextVar: os.environ must not be mutated, so
|
|
the worker's claim heartbeat and the gateway watchers keep working."""
|
|
import cron.scheduler as sched
|
|
|
|
before = {
|
|
k: v for k, v in os.environ.items() if k.startswith("HERMES_KANBAN_")
|
|
}
|
|
assert before, "fixture should have populated kanban env"
|
|
|
|
observed: dict = {}
|
|
self._install_stubs(monkeypatch, observed)
|
|
|
|
success, *_ = sched.run_job(self._job())
|
|
assert success is True
|
|
|
|
# Untouched DURING the job (the heartbeat thread reads it concurrently)...
|
|
assert observed["kanban_env_during_init"] == before
|
|
# ...and after.
|
|
after = {
|
|
k: v for k, v in os.environ.items() if k.startswith("HERMES_KANBAN_")
|
|
}
|
|
assert after == before
|
|
|
|
|
|
def test_context_reset_even_when_job_raises(self, monkeypatch, worker_env):
|
|
import cron.scheduler as sched
|
|
from agent.delegation_context import is_dispatcher_owned_worker_context
|
|
|
|
class ExplodingAgent:
|
|
def __init__(self, **kwargs):
|
|
pass
|
|
|
|
def run_conversation(self, *_a, **_kw):
|
|
raise RuntimeError("boom")
|
|
|
|
def get_activity_summary(self):
|
|
return {"seconds_since_activity": 0.0}
|
|
|
|
observed: dict = {}
|
|
self._install_stubs(monkeypatch, observed, agent_cls=ExplodingAgent)
|
|
|
|
success, *_ = sched.run_job(self._job("kanban-iso-fail"))
|
|
assert success is False
|
|
assert is_dispatcher_owned_worker_context() is True
|
|
# And the env survived the failure too.
|
|
assert os.environ.get("HERMES_KANBAN_BOARD") == "team-alpha"
|
|
|
|
def test_concurrent_jobs_do_not_corrupt_worker_identity(
|
|
self, monkeypatch, worker_env
|
|
):
|
|
"""Two workdir-less jobs run concurrently on the parallel pool and take a
|
|
SHARED read lock, so they interleave. With an os.environ snapshot/clear/
|
|
restore this permanently destroyed the worker's identity; a ContextVar is
|
|
per-thread and cannot."""
|
|
import cron.scheduler as sched
|
|
|
|
before = {
|
|
k: v for k, v in os.environ.items() if k.startswith("HERMES_KANBAN_")
|
|
}
|
|
observed: dict = {}
|
|
self._install_stubs(monkeypatch, observed)
|
|
|
|
results = {}
|
|
|
|
def run(name):
|
|
ok, *_ = sched.run_job(self._job(f"kanban-iso-{name}"))
|
|
results[name] = ok
|
|
|
|
threads = [threading.Thread(target=run, args=(n,)) for n in ("a", "b")]
|
|
for t in threads:
|
|
t.start()
|
|
for t in threads:
|
|
t.join(60)
|
|
|
|
assert results == {"a": True, "b": True}
|
|
after = {
|
|
k: v for k, v in os.environ.items() if k.startswith("HERMES_KANBAN_")
|
|
}
|
|
assert after == before, "worker identity must survive concurrent cron jobs"
|
|
|
|
|
|
@pytest.mark.platforms("linux")
|
|
def test_dispatcher_grants_only_the_assigned_worker_scope(tmp_path, monkeypatch):
|
|
import json
|
|
from pathlib import Path
|
|
import sys
|
|
from hermes_cli import kanban_db as kb
|
|
from hermes_cli.kanban_db_connect import connect
|
|
from hermes_cli.kanban_db_dispatch import _default_spawn
|
|
|
|
monkeypatch.setenv("HOME", str(tmp_path))
|
|
db = tmp_path / "board.db"
|
|
monkeypatch.setenv("HERMES_KANBAN_DB", str(db))
|
|
conn = connect(db)
|
|
tid = kb.create_task(conn, title="assigned child", assignee="default")
|
|
kb.claim_task(conn, tid)
|
|
task = kb.get_task(conn, tid)
|
|
output = tmp_path / "worker-result.json"
|
|
worker = tmp_path / "fixture-worker"
|
|
root = str(Path(__file__).resolve().parents[2])
|
|
worker.write_text(
|
|
f"#!{sys.executable}\nimport sys, os, json;sys.path.insert(0, {root!r})\n"
|
|
"from tools.kanban_tools import _handle_complete, heartbeat_current_worker_from_env\n"
|
|
"beat=heartbeat_current_worker_from_env()\n"
|
|
f"result=json.loads(_handle_complete({{'summary':'assigned worker'}}));result['beat']=beat\n"
|
|
f"open({str(output)!r}, 'w').write(json.dumps(result))\n"
|
|
)
|
|
worker.chmod(0o700)
|
|
monkeypatch.setenv("HERMES_BIN", str(worker))
|
|
# Building a new worker under an existing task must replace, not inherit, its scope.
|
|
monkeypatch.setenv("HERMES_KANBAN_TASK", "prior-task")
|
|
# A dispatcher launched from an agent's shell carries the descendant fence itself; the worker it
|
|
# grants a task to must not (an inherited marker fences the worker's own heartbeat + handoff).
|
|
monkeypatch.setenv("HERMES_DELEGATED_CHILD_CONTEXT", str(tmp_path))
|
|
pid = _default_spawn(task, str(tmp_path), board="default")
|
|
assert pid is not None
|
|
os.waitpid(pid, 0) # windows-footgun: ok — Linux-only real dispatcher spawn
|
|
result = json.loads(output.read_text())
|
|
assert result["ok"] and result["beat"] is True, result
|
|
assert kb.get_task(conn, tid).status == "done"
|
|
assert os.environ["HERMES_KANBAN_TASK"] == "prior-task"
|
|
conn.close()
|