mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 21:32:52 +00:00
# Conflicts: # apps/desktop/e2e/archived-hidden-session-recoverable.spec.ts # apps/desktop/e2e/bot-chat-message-agent-friendly-name.spec.ts # apps/desktop/e2e/bot-mailbox-unreadable-ticket.spec.ts # apps/desktop/e2e/bot-mode-roster-localized.spec.ts # apps/desktop/e2e/bot-mode-row-click-mirrors-registry.spec.ts # apps/desktop/e2e/bot-mode-tab-shows-bot-name.spec.ts # apps/desktop/e2e/bot-roster-group-row-organisation.spec.ts # apps/desktop/e2e/bot-roster-ignores-infra-dirs.spec.ts # apps/desktop/e2e/bot-roster-timestamp-meta.spec.ts # apps/desktop/e2e/bot-roster-user-sections.spec.ts # apps/desktop/e2e/bot-routines-pane-narrow.spec.ts # apps/desktop/e2e/bot-row-open-recent-session.spec.ts # apps/desktop/e2e/bot-tile-ignores-ambient-composer-model.spec.ts # apps/desktop/e2e/group-composer-auto-grow.spec.ts # apps/desktop/e2e/group-create-gate-remote-roster.spec.ts # apps/desktop/e2e/group-prompt-renamed-primary-handle.spec.ts # apps/desktop/e2e/hosted-room-backend-continuity.spec.ts # apps/desktop/e2e/hosted-room-legacy-store-migration.spec.ts # apps/desktop/e2e/settings-scope-chips-bot-title.spec.ts # apps/desktop/e2e/worktree-branch-status.spec.ts # apps/desktop/electron/backend-probes.test.ts # apps/desktop/electron/connection-apply.test.ts # apps/desktop/electron/desktop-electron-pin.test.ts # apps/desktop/electron/desktop-uninstall.test.ts # apps/desktop/electron/gateway-file-download-transport.test.ts # apps/desktop/electron/gateway-stop-before-update.test.ts # apps/desktop/electron/github-api-auth.test.ts # apps/desktop/electron/registry-primary-profile-scope.test.ts # apps/desktop/electron/update-api-check.test.ts # apps/desktop/electron/update-handoff-marker.test.ts # apps/desktop/electron/venv-blocker-scan.test.ts # apps/desktop/scripts/after-extract.test.mjs # apps/desktop/scripts/local-pack-publish.test.mjs # apps/desktop/scripts/tasks-scroll.test.mjs # apps/desktop/src/app/settings/model-settings.test.tsx # apps/desktop/src/app/updates-overlay.blockers.test.tsx # apps/desktop/src/components/desktop-install-overlay.test.tsx # apps/desktop/src/lib/update-copy.test.ts # scripts/ci/check_os_marker_fakes.py # tests-js/desktop-mac-usage-descriptions.test.ts # tests-js/node-engine-alignment.test.ts # tests/agent/lsp/test_install_and_lint_fixes.py # tests/agent/test_command_token_source.py # tests/agent/test_compression_boundary_hook.py # tests/agent/test_create_openai_client_ssl_verify.py # tests/agent/test_custom_provider_ca_probes.py # tests/agent/test_endpoint_blackhole.py # tests/agent/test_estimator_parity.py # tests/agent/test_in_place_compaction.py # tests/agent/test_moa_loop_mode.py # tests/agent/test_model_metadata.py # tests/agent/test_skill_session_platform_gate.py # tests/agent/test_skill_utils.py # tests/agent/test_ssl_ca_guard.py # tests/computer_use/test_doctor.py # tests/cron/test_codex_execution_paths.py # tests/cron/test_cron_bot_chat_delivery.py # tests/cron/test_cron_script.py # tests/cron/test_media_delivery_parity.py # tests/cron/test_misfire_catchup.py # tests/cron/test_parallel_pool.py # tests/cron/test_recurring_eagain_redispatch.py # tests/gateway/test_choice_picker.py # tests/gateway/test_control_socket_windows_live.py # tests/gateway/test_dingtalk.py # tests/gateway/test_feishu.py # tests/gateway/test_feishu_onboard.py # tests/gateway/test_gateway_shutdown.py # tests/gateway/test_matrix.py # tests/gateway/test_model_command_custom_providers.py # tests/gateway/test_reasoning_command.py # tests/gateway/test_runtime_footer.py # tests/gateway/test_session.py # tests/gateway/test_session_hygiene.py # tests/gateway/test_status.py # tests/gateway/test_teams.py # tests/gateway/test_turn_lease.py # tests/gateway/test_whatsapp_connect.py # tests/hermes_cli/test_approvals_command.py # tests/hermes_cli/test_auth_store_lock_concurrent.py # tests/hermes_cli/test_backup.py # tests/hermes_cli/test_banner_git_state.py # tests/hermes_cli/test_certifi_repair.py # tests/hermes_cli/test_cmd_update.py # tests/hermes_cli/test_compat_manifest_targets.py # tests/hermes_cli/test_computer_use_cli.py # tests/hermes_cli/test_cpr_local_leak.py # tests/hermes_cli/test_dashboard_auth_gate.py # tests/hermes_cli/test_dashboard_procs_kill_grace.py # tests/hermes_cli/test_desktop_lifecycle_windows_live.py # tests/hermes_cli/test_doctor.py # tests/hermes_cli/test_doctor_command_install.py # tests/hermes_cli/test_fleet_config_migration_windows_live.py # tests/hermes_cli/test_gateway.py # tests/hermes_cli/test_gateway_platform_gating.py # tests/hermes_cli/test_gateway_restart_loop.py # tests/hermes_cli/test_gateway_task_probe.py # tests/hermes_cli/test_gateway_wsl.py # tests/hermes_cli/test_gui_command.py # tests/hermes_cli/test_install_cua_driver.py # tests/hermes_cli/test_kanban_db.py # tests/hermes_cli/test_lazy_command_exports.py # tests/hermes_cli/test_lazy_refresh_venv_repair.py # tests/hermes_cli/test_linux_desktop_entry.py # tests/hermes_cli/test_local_runtime.py # tests/hermes_cli/test_local_runtime_updates.py # tests/hermes_cli/test_managed_uv.py # tests/hermes_cli/test_mcp_reload_confirm_gate.py # tests/hermes_cli/test_nous_subscription.py # tests/hermes_cli/test_npm_engine.py # tests/hermes_cli/test_personality_none.py # tests/hermes_cli/test_pet_toggle.py # tests/hermes_cli/test_plan_reconciliation_windows_live.py # tests/hermes_cli/test_plugin_event_bus.py # tests/hermes_cli/test_plugin_manifest_v2.py # tests/hermes_cli/test_plugin_packs.py # tests/hermes_cli/test_plugins_cmd.py # tests/hermes_cli/test_plugins_cmd_enable_disable_nested.py # tests/hermes_cli/test_process_identity.py # tests/hermes_cli/test_profiles.py # tests/hermes_cli/test_profiles_sidebar_cache.py # tests/hermes_cli/test_pty_bridge.py # tests/hermes_cli/test_resolve_turn_limit.py # tests/hermes_cli/test_serve_runtime_inventory.py # tests/hermes_cli/test_session_vacuum_config.py # tests/hermes_cli/test_set_config_value.py # tests/hermes_cli/test_signal_handler_kanban_worker.py # tests/hermes_cli/test_slash_confirm_windows.py # tests/hermes_cli/test_stale_pid_guard.py # tests/hermes_cli/test_startup_fast_guards.py # tests/hermes_cli/test_status.py # tests/hermes_cli/test_telegram_managed_bot.py # tests/hermes_cli/test_tools_config.py # tests/hermes_cli/test_update_apply_shallow_count.py # tests/hermes_cli/test_update_autostash.py # tests/hermes_cli/test_update_concurrent_quarantine.py # tests/hermes_cli/test_update_fetch_failure_classifier.py # tests/hermes_cli/test_update_fleet_probe_resume_token.py # tests/hermes_cli/test_update_handoff_backend_reap.py # tests/hermes_cli/test_update_handoff_desktop_rebuild.py # tests/hermes_cli/test_update_head_moved_gate.py # tests/hermes_cli/test_update_host_obligation.py # tests/hermes_cli/test_update_import_guard.py # tests/hermes_cli/test_update_interrupted_recovery.py # tests/hermes_cli/test_update_inventory.py # tests/hermes_cli/test_update_launchd_unloaded_gateway.py # tests/hermes_cli/test_update_missing_configured_deps.py # tests/hermes_cli/test_update_modified_notice.py # tests/hermes_cli/test_update_multiplex_migration_hook.py # tests/hermes_cli/test_update_no_gateway_restart.py # tests/hermes_cli/test_update_orphan_backend_reap.py # tests/hermes_cli/test_update_parked_branch_guard.py # tests/hermes_cli/test_update_post_pull_syntax_guard.py # tests/hermes_cli/test_update_receipt.py # tests/hermes_cli/test_update_self_lock.py # tests/hermes_cli/test_update_shim_fail_closed.py # tests/hermes_cli/test_update_shim_self_lock.py # tests/hermes_cli/test_update_sqlite_remediation.py # tests/hermes_cli/test_update_stale_dashboard.py # tests/hermes_cli/test_update_stale_virtualenv.py # tests/hermes_cli/test_update_venv_health.py # tests/hermes_cli/test_update_venv_ownership_preflight.py # tests/hermes_cli/test_update_wedged_gateway.py # tests/hermes_cli/test_update_yes_flag.py # tests/hermes_cli/test_update_zip_two_phase.py # tests/hermes_cli/test_urllib_security.py # tests/hermes_cli/test_ux_messages_auth_config.py # tests/hermes_cli/test_ux_messages_startup.py # tests/hermes_cli/test_venv_holder_classifier.py # tests/hermes_cli/test_verify_console_scripts.py # tests/hermes_cli/test_verify_core_dependencies.py # tests/hermes_cli/test_web_server.py # tests/hermes_cli/test_web_server_console_ws.py # tests/hermes_cli/test_web_server_ws_ping.py # tests/hermes_cli/test_web_ui_build.py # tests/hermes_state/test_fts_rebuild_admission.py # tests/hermes_state/test_hermes_state.py # tests/plugins/memory/test_memory_lazy_install.py # tests/plugins/test_google_meet_plugin.py # tests/plugins/test_langfuse_plugin.py # tests/plugins/test_security_guidance_plugin.py # tests/plugins/test_transform_llm_output_hook.py # tests/scripts/desktop_update/test_desktop_update_windows_gateway_flag.py # tests/scripts/desktop_update/test_desktop_update_windows_python_handoff.py # tests/scripts/desktop_update/test_desktop_update_windows_timestamp.py # tests/scripts/install/test_install_clone_throttle_fallback.py # tests/scripts/install/test_install_lockfile_churn.py # tests/scripts/install/test_install_no_initial_commit.py # tests/scripts/install/test_install_sh_browser_install.py # tests/scripts/install/test_install_sh_node_prerelease.py # tests/scripts/install/test_install_sh_symlink_stomp.py # tests/scripts/install/test_install_sh_uv_lock_config.py # tests/scripts/install/test_install_unmerged_index.py # tests/scripts/test_contributor_map.py # tests/scripts/test_run_tests_parallel.py # tests/skills/test_competitor_news_monitor_skill.py # tests/skills/test_document_to_action_items_skill.py # tests/skills/test_google_workspace_setup.py # tests/skills/test_google_workspace_setup_deps.py # tests/skills/test_grounded_citations_skill.py # tests/skills/test_ip_as_logo_skill.py # tests/skills/test_live_dashboard_skill.py # tests/skills/test_mcp_oauth_remote_gateway_skill.py # tests/skills/test_office_document_skills.py # tests/skills/test_openclaw_migration.py # tests/skills/test_product_price_monitor_skill.py # tests/skills/test_scrollcraft_skill.py # tests/skills/test_setup_wizard_generator_skill.py # tests/skills/test_weekly_review_planning_skill.py # tests/test_engines_satisfiable.py # tests/test_fast_safe_load.py # tests/test_hermes_bootstrap.py # tests/test_hermes_constants.py # tests/test_hermes_logging.py # tests/test_managed_runtime_resolution.py # tests/test_model_tools_async_bridge.py # tests/test_packaging_build_guard.py # tests/test_packaging_metadata.py # tests/test_yaml_indent_consistency.py # tests/tools/test_approval_timeout_overflow.py # tests/tools/test_base_environment.py # tests/tools/test_bot_mode_dm.py # tests/tools/test_browser_chromium_check.py # tests/tools/test_browser_hardening.py # tests/tools/test_browser_homebrew_paths.py # tests/tools/test_browser_npx_warmup.py # tests/tools/test_browser_orphan_reaper.py # tests/tools/test_browser_real_profile.py # tests/tools/test_browser_use_cli.py # tests/tools/test_clipboard.py # tests/tools/test_code_execution.py # tests/tools/test_code_execution_modes.py # tests/tools/test_code_execution_windows_env.py # tests/tools/test_computer_use.py # tests/tools/test_delegate_liveness_timeout.py # tests/tools/test_execute_code_approval_cluster.py # tests/tools/test_execution_flag_detection.py # tests/tools/test_fal_common.py # tests/tools/test_file_operations.py # tests/tools/test_file_tools.py # tests/tools/test_file_tools_cwd_resolution.py # tests/tools/test_file_tools_live.py # tests/tools/test_lazy_deps.py # tests/tools/test_lazy_deps_durable_target.py # tests/tools/test_lazy_deps_managed.py # tests/tools/test_local_env_blocklist.py # tests/tools/test_local_tempdir.py # tests/tools/test_macos_protected_search.py # tests/tools/test_mcp_npx_cached_bin.py # tests/tools/test_oneshot_completion_linger.py # tests/tools/test_process_registry.py # tests/tools/test_read_file_schema_gating.py # tests/tools/test_skill_improvements.py # tests/tools/test_skills_sync.py # tests/tools/test_termux_api_detection.py # tests/tools/test_tirith_security.py # tests/tools/test_transcription_tools.py # tests/tools/test_tts_streaming.py # tests/tools/test_wake_word.py # tests/tui_gateway/test_compute_host_borrowed_lease.py # tests/tui_gateway/test_compute_host_turn_protocol.py # tests/tui_gateway/test_isolated_orphan_activity.py # tests/tui_gateway/test_protocol.py # tests/tui_gateway/test_slash_worker_profile_home.py # tests/tui_gateway/test_subprocess_encoding.py # tests/tui_gateway/test_tui_gateway_server.py # ui-tui/src/__tests__/terminalParity.test.ts # ui-tui/src/__tests__/termuxComposerLayout.test.ts # ui-tui/src/__tests__/textInputFastEcho.test.ts
199 lines
8.8 KiB
Python
199 lines
8.8 KiB
Python
"""Regression tests for #87644 — cron scheduler silently stalls after EMFILE.
|
|
|
|
Three fixes under test:
|
|
|
|
1. ``tick()`` no longer swallows a real ``OSError`` at tick-lock acquisition as
|
|
"another instance holds the lock". An EMFILE/ENFILE (fd exhaustion) on
|
|
``open(.tick.lock)`` previously made ``tick()`` return 0 — which the ticker
|
|
loop recorded as a *successful* tick and cleared the error — so the
|
|
scheduler looked perfectly healthy (heartbeat + success markers fresh)
|
|
while no job ever ran again. Now the failure propagates to the ticker
|
|
loop, which records it and backs off.
|
|
|
|
2. The ticker loop detects fd exhaustion (EMFILE/ENFILE/"Too many open
|
|
files"), attempts best-effort fd reclamation (``gc.collect()`` + raising
|
|
the soft nofile limit), and applies exponential backoff so an exhausted
|
|
process stops hammering the store every 60s. Once FDs free up, the next
|
|
tick succeeds and the backoff resets — the scheduler self-heals without a
|
|
gateway restart.
|
|
|
|
3. Genuine lock contention (EWOULDBLOCK/EAGAIN on flock) still skips the tick
|
|
silently — that behavior is preserved.
|
|
"""
|
|
import errno
|
|
import threading
|
|
import time
|
|
from unittest.mock import patch
|
|
|
|
import pytest
|
|
|
|
import cron.scheduler as scheduler_mod
|
|
|
|
try:
|
|
import fcntl
|
|
except ImportError: # pragma: no cover - non-POSIX
|
|
fcntl = None
|
|
|
|
pytestmark = pytest.mark.skipif(fcntl is None, reason="flock semantics are POSIX-only")
|
|
|
|
def _wait_until(predicate, timeout=10.0, interval=0.005):
|
|
"""Block until ``predicate()`` is truthy or ``timeout`` elapses."""
|
|
deadline = time.monotonic() + timeout
|
|
while time.monotonic() < deadline:
|
|
value = predicate()
|
|
if value:
|
|
return value
|
|
time.sleep(interval)
|
|
return predicate()
|
|
|
|
# ── Fix 1: tick() must not swallow EMFILE as "another instance holds the lock" ─
|
|
|
|
class TestTickLockEmfileNotSwallowed:
|
|
def test_lock_open_emfile_raises_instead_of_silent_skip(self, monkeypatch):
|
|
"""open(.tick.lock) raising EMFILE must propagate — not return 0 as if
|
|
another ticker held the lock (the pre-fix silent stall)."""
|
|
real_open = open
|
|
calls = []
|
|
|
|
def flaky_open(path, *args, **kwargs):
|
|
if str(path).endswith(".tick.lock"):
|
|
calls.append(("emfile", str(path)))
|
|
raise OSError(errno.EMFILE, "Too many open files")
|
|
return real_open(path, *args, **kwargs)
|
|
|
|
monkeypatch.setattr("builtins.open", flaky_open)
|
|
with pytest.raises(OSError) as excinfo:
|
|
scheduler_mod.tick(verbose=False)
|
|
assert excinfo.value.errno == errno.EMFILE
|
|
assert calls, "the lock file open must have been attempted"
|
|
|
|
def test_lock_flock_emfile_raises(self, monkeypatch):
|
|
"""flock() raising EMFILE (fd exhaustion at lock syscall) must also
|
|
propagate — only EWOULDBLOCK/EAGAIN/EACCES mean contention."""
|
|
with patch.object(fcntl, "flock", side_effect=OSError(errno.EMFILE, "Too many open files")):
|
|
with pytest.raises(OSError) as excinfo:
|
|
scheduler_mod.tick(verbose=False)
|
|
assert excinfo.value.errno == errno.EMFILE
|
|
|
|
def test_lock_contention_ewouldblock_still_skips_silently(self, monkeypatch):
|
|
"""Genuine contention (another ticker holds the lock) still returns 0
|
|
silently — the cross-process mutual-exclusion contract is preserved."""
|
|
with patch.object(fcntl, "flock", side_effect=OSError(errno.EWOULDBLOCK, "Resource temporarily unavailable")):
|
|
assert scheduler_mod.tick(verbose=False) == 0
|
|
|
|
# ── Fix 2: ticker loop survives EMFILE, reclaims fds, backs off, self-heals ──
|
|
|
|
class TestTickerEmfileBackoff:
|
|
def test_emfile_tick_records_error_and_keeps_looping(self, monkeypatch):
|
|
"""An EMFILE tick must be recorded as a FAILED tick (not success) and
|
|
the loop must keep running — the pre-fix state where the scheduler
|
|
stalled silently while the heartbeat kept reporting healthy."""
|
|
from cron.scheduler_provider import InProcessCronScheduler
|
|
|
|
beats = []
|
|
errors = []
|
|
stop = threading.Event()
|
|
prov = InProcessCronScheduler()
|
|
|
|
with patch(
|
|
"cron.scheduler.tick",
|
|
side_effect=OSError(errno.EMFILE, "Too many open files"),
|
|
), patch(
|
|
"cron.jobs.record_ticker_heartbeat",
|
|
side_effect=lambda success=False: beats.append(success),
|
|
), patch(
|
|
"cron.jobs.record_ticker_error",
|
|
side_effect=lambda msg: errors.append(msg),
|
|
), patch("cron.jobs.clear_ticker_error") as clear:
|
|
t = threading.Thread(target=prov.start, args=(stop,), kwargs={"interval": 0}, daemon=True)
|
|
t.start()
|
|
assert _wait_until(lambda: len(beats) >= 3), "ticker did not keep beating"
|
|
stop.set()
|
|
t.join(timeout=5)
|
|
|
|
assert not t.is_alive(), "ticker must survive EMFILE ticks"
|
|
assert errors, "ticker error must be persisted so `hermes cron status` can show it"
|
|
assert "Too many open files" in errors[0]
|
|
# Every post-failure beat must be success=False: liveness yes, success no.
|
|
assert beats[-1] is False
|
|
clear.assert_not_called()
|
|
|
|
def test_emfile_triggers_fd_reclamation(self, monkeypatch):
|
|
"""The ticker must attempt best-effort fd reclamation on EMFILE so the
|
|
next tick can succeed once descriptors free up."""
|
|
from cron.scheduler_provider import InProcessCronScheduler
|
|
|
|
reclaimed = []
|
|
stop = threading.Event()
|
|
prov = InProcessCronScheduler()
|
|
|
|
with patch(
|
|
"cron.scheduler.tick",
|
|
side_effect=OSError(errno.EMFILE, "Too many open files"),
|
|
), patch(
|
|
"cron.scheduler._reclaim_fds_best_effort",
|
|
side_effect=lambda: reclaimed.append(1),
|
|
), patch("cron.jobs.record_ticker_heartbeat"), patch("cron.jobs.record_ticker_error"):
|
|
t = threading.Thread(target=prov.start, args=(stop,), kwargs={"interval": 0}, daemon=True)
|
|
t.start()
|
|
assert _wait_until(lambda: len(reclaimed) >= 1), "fd reclamation never ran"
|
|
stop.set()
|
|
t.join(timeout=5)
|
|
|
|
assert len(reclaimed) >= 1
|
|
|
|
def test_ticker_recovers_after_emfile_clears(self, monkeypatch):
|
|
"""Once ticks stop raising EMFILE, the next tick succeeds, the error is
|
|
cleared and the success marker is bumped again — self-healing without a
|
|
gateway restart."""
|
|
from cron.scheduler_provider import InProcessCronScheduler
|
|
|
|
attempts = {"n": 0}
|
|
beats = []
|
|
errors = []
|
|
stop = threading.Event()
|
|
prov = InProcessCronScheduler()
|
|
|
|
def flaky_tick(*args, **kwargs):
|
|
attempts["n"] += 1
|
|
if attempts["n"] <= 2:
|
|
raise OSError(errno.EMFILE, "Too many open files")
|
|
return 0
|
|
|
|
with patch("cron.scheduler.tick", side_effect=flaky_tick), patch(
|
|
"cron.jobs.record_ticker_heartbeat",
|
|
side_effect=lambda success=False: beats.append(success),
|
|
), patch(
|
|
"cron.jobs.record_ticker_error",
|
|
side_effect=lambda msg: errors.append(msg),
|
|
), patch("cron.jobs.clear_ticker_error") as clear, patch(
|
|
"cron.scheduler._reclaim_fds_best_effort"
|
|
):
|
|
t = threading.Thread(target=prov.start, args=(stop,), kwargs={"interval": 0}, daemon=True)
|
|
t.start()
|
|
# Wait until we've seen at least one success beat AFTER the failures.
|
|
assert _wait_until(lambda: len(beats) >= 4), "ticker never recovered"
|
|
stop.set()
|
|
t.join(timeout=5)
|
|
|
|
assert not t.is_alive()
|
|
assert attempts["n"] >= 3
|
|
assert errors, "failures must be recorded"
|
|
assert True in beats, "a successful tick must bump the success marker"
|
|
clear.assert_called(), "a successful tick must clear the recorded error"
|
|
|
|
# ── Helpers ────────────────────────────────────────────────────────────────────
|
|
|
|
class TestEmfileHelpers:
|
|
def test_is_fd_exhaustion_errno(self):
|
|
assert scheduler_mod._is_fd_exhaustion(OSError(errno.EMFILE, "Too many open files"))
|
|
assert scheduler_mod._is_fd_exhaustion(OSError(errno.ENFILE, "file table overflow"))
|
|
assert not scheduler_mod._is_fd_exhaustion(OSError(errno.EACCES, "Permission denied"))
|
|
assert not scheduler_mod._is_fd_exhaustion(OSError(errno.EWOULDBLOCK, "Resource temporarily unavailable"))
|
|
|
|
def test_is_fd_exhaustion_wrapped_message(self):
|
|
"""load_jobs wraps the raw OSError in a RuntimeError whose message
|
|
carries the errno text — the ticker must classify that too."""
|
|
assert scheduler_mod._is_fd_exhaustion(
|
|
RuntimeError("Failed to read cron database: [Errno 24] Too many open files")
|
|
)
|