mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-16 19:36:54 +00:00
Change-detectors, tautologies, source-reading tests, redundant duplicates, mock-echo tests and dead/unrunnable tests. Per-test rationale in the lane ledger (category + reason for every removal).
168 lines
5.1 KiB
Python
168 lines
5.1 KiB
Python
"""Tests for AIAgent._sanitize_tool_call_arguments."""
|
|
|
|
import copy
|
|
import logging
|
|
|
|
from run_agent import AIAgent
|
|
|
|
|
|
_MISSING = object()
|
|
|
|
|
|
def _tool_call(call_id="call_1", name="read_file", arguments='{"path":"/tmp/foo"}'):
|
|
function = {"name": name}
|
|
if arguments is not _MISSING:
|
|
function["arguments"] = arguments
|
|
return {
|
|
"id": call_id,
|
|
"type": "function",
|
|
"function": function,
|
|
}
|
|
|
|
|
|
def _assistant_message(*tool_calls):
|
|
return {
|
|
"role": "assistant",
|
|
"content": "tooling",
|
|
"tool_calls": list(tool_calls),
|
|
}
|
|
|
|
|
|
def _tool_message(call_id="call_1", content="ok"):
|
|
return {
|
|
"role": "tool",
|
|
"tool_call_id": call_id,
|
|
"content": content,
|
|
}
|
|
|
|
|
|
def test_valid_arguments_unchanged():
|
|
messages = [
|
|
{"role": "user", "content": "hello"},
|
|
_assistant_message(_tool_call(arguments='{"path":"/tmp/foo"}')),
|
|
_tool_message(content="done"),
|
|
]
|
|
original = copy.deepcopy(messages)
|
|
|
|
repaired = AIAgent._sanitize_tool_call_arguments(messages)
|
|
|
|
assert repaired == 0
|
|
assert messages == original
|
|
|
|
|
|
def test_truncated_arguments_replaced_with_empty_object(caplog):
|
|
messages = [
|
|
_assistant_message(_tool_call(arguments='{"path": "/tmp/foo')),
|
|
]
|
|
|
|
with caplog.at_level(logging.WARNING, logger="run_agent"):
|
|
repaired = AIAgent._sanitize_tool_call_arguments(
|
|
messages,
|
|
logger=logging.getLogger("run_agent"),
|
|
session_id="session-123",
|
|
)
|
|
|
|
assert repaired == 1
|
|
assert messages[0]["tool_calls"][0]["function"]["arguments"] == "{}"
|
|
assert any(
|
|
"session=session-123" in record.message
|
|
and "tool_call_id=call_1" in record.message
|
|
for record in caplog.records
|
|
)
|
|
|
|
|
|
def test_marker_appended_to_existing_tool_message():
|
|
marker = AIAgent._TOOL_CALL_ARGUMENTS_CORRUPTION_MARKER
|
|
messages = [
|
|
_assistant_message(_tool_call(arguments='{"path": "/tmp/foo')),
|
|
_tool_message(content="existing tool output"),
|
|
]
|
|
|
|
repaired = AIAgent._sanitize_tool_call_arguments(messages)
|
|
|
|
assert repaired == 1
|
|
assert messages[1]["content"] == f"{marker}\nexisting tool output"
|
|
|
|
|
|
|
|
|
|
def test_multiple_corrupted_tool_calls_in_one_message():
|
|
marker = AIAgent._TOOL_CALL_ARGUMENTS_CORRUPTION_MARKER
|
|
messages = [
|
|
_assistant_message(
|
|
_tool_call(call_id="call_1", arguments='{"path": "/tmp/foo'),
|
|
_tool_call(call_id="call_2", arguments='{"path":"/tmp/bar"}'),
|
|
_tool_call(call_id="call_3", arguments='{"mode":"tail"'),
|
|
),
|
|
]
|
|
|
|
repaired = AIAgent._sanitize_tool_call_arguments(messages)
|
|
|
|
assert repaired == 2
|
|
assert messages[0]["tool_calls"][0]["function"]["arguments"] == "{}"
|
|
assert messages[0]["tool_calls"][1]["function"]["arguments"] == '{"path":"/tmp/bar"}'
|
|
assert messages[0]["tool_calls"][2]["function"]["arguments"] == "{}"
|
|
assert messages[1]["tool_call_id"] == "call_1"
|
|
assert messages[1]["content"] == marker
|
|
assert messages[2]["tool_call_id"] == "call_3"
|
|
assert messages[2]["content"] == marker
|
|
|
|
|
|
def test_empty_string_arguments_treated_as_empty_object(caplog):
|
|
messages = [
|
|
_assistant_message(_tool_call(arguments="")),
|
|
]
|
|
|
|
with caplog.at_level(logging.WARNING, logger="run_agent"):
|
|
repaired = AIAgent._sanitize_tool_call_arguments(
|
|
messages,
|
|
logger=logging.getLogger("run_agent"),
|
|
session_id="session-123",
|
|
)
|
|
|
|
assert repaired == 0
|
|
assert messages[0]["tool_calls"][0]["function"]["arguments"] == "{}"
|
|
assert caplog.records == []
|
|
|
|
|
|
def test_non_assistant_messages_ignored():
|
|
messages = [
|
|
{"role": "user", "content": "hello", "tool_calls": [_tool_call(arguments='{"bad":')]},
|
|
{"role": "tool", "tool_call_id": "call_1", "content": "ok"},
|
|
{"role": "system", "content": "sys", "tool_calls": [_tool_call(arguments='{"bad":')]},
|
|
None,
|
|
"not a dict",
|
|
]
|
|
original = copy.deepcopy(messages)
|
|
|
|
repaired = AIAgent._sanitize_tool_call_arguments(messages)
|
|
|
|
assert repaired == 0
|
|
assert messages == original
|
|
|
|
|
|
def test_corrupt_args_repair_pops_persist_marker_on_stamped_dicts():
|
|
"""A resumed session can load stamped rows whose tool_call args are corrupt;
|
|
repairing them in place must pop the marker or session.db keeps the corrupt
|
|
bytes while the live transcript holds the repaired ones (divergent resume)."""
|
|
from agent.context_compressor import _DB_PERSISTED_MARKER
|
|
|
|
stamped_call = _assistant_message(
|
|
_tool_call(call_id="call_1", arguments="{invalid json")
|
|
)
|
|
stamped_call[_DB_PERSISTED_MARKER] = True
|
|
stamped_result = _tool_message(call_id="call_1", content="ok")
|
|
stamped_result[_DB_PERSISTED_MARKER] = True
|
|
messages = [
|
|
{"role": "user", "content": "hello"},
|
|
stamped_call,
|
|
stamped_result,
|
|
]
|
|
|
|
repaired = AIAgent._sanitize_tool_call_arguments(messages)
|
|
|
|
assert repaired == 1
|
|
assert stamped_call["tool_calls"][0]["function"]["arguments"] == "{}"
|
|
assert stamped_result["content"].endswith("ok")
|
|
assert _DB_PERSISTED_MARKER not in stamped_call
|
|
assert _DB_PERSISTED_MARKER not in stamped_result
|