mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
The non-streaming 5xx unmask probe runs on the stream worker thread while StreamingWaitMonitor keeps polling last_chunk_time, which nothing refreshes during the probe. A probe longer than the stale timeout fired _kill_stale_stream every window: a false "Reconnecting..." status and a _bump_stale_streak strike toward HERMES_STREAM_STALE_GIVEUP. Suspend the stale check (timeout = inf) for the probe's duration; the probe keeps its own non-streaming watchdog. The probe also went through _adopt_final_response, which latches _disable_streaming and logs "switching to non-streaming for this session", then undid the latch in a finally. Split the pure replay into _replay_final_response and call that instead. Also: status via error_classifier._extract_status_code, monotonic probe window seeded in agent_init, docstring says "per 60s window".
104 lines
4.3 KiB
Python
104 lines
4.3 KiB
Python
"""Streaming 5xx unmasking: the non-streaming probe surfaces the provider's real error.
|
|
|
|
Regression shape (AssemblyAI LLM Gateway, 2026-09): a gateway that validates requests
|
|
only on its non-streaming path returns an opaque ``500 something went wrong`` when
|
|
streaming the SAME request. _handle_stream_error must re-issue once non-streaming on a
|
|
pre-delta 5xx so the actionable 4xx (or a successful response) reaches the user instead
|
|
of three identical opaque 500s.
|
|
|
|
Gating invariants (from cross-vendor review):
|
|
- never after partial delivery, on non-5xx, or without an HTTP status
|
|
- one probe per 60s window on the AGENT (outer retries build fresh _StreamingCall
|
|
instances, so an instance flag would re-probe every attempt)
|
|
- chat-completions wire only (adoption replays chat-completions shapes)
|
|
- probe success delivers for the turn WITHOUT latching _disable_streaming
|
|
(a transient gateway 500 must not permanently disable streaming)
|
|
- the recovered delivery opens and closes its own stream pair (consumers must never
|
|
see deltas after the failed attempt's terminal on_stream_end)
|
|
- user interrupts re-raise; never swallowed
|
|
"""
|
|
from types import SimpleNamespace
|
|
|
|
from agent import chat_completion_helpers as h
|
|
|
|
|
|
def _make_call(api_kwargs, *, deltas_sent=False, api_mode="chat_completions"):
|
|
call = h._StreamingCall.__new__(h._StreamingCall)
|
|
call.agent = SimpleNamespace(
|
|
provider="custom", model="gpt-5.6-sol", api_mode=api_mode,
|
|
_interrupt_requested=False,
|
|
_is_provider_stream_parse_error=lambda e: False,
|
|
_buffer_status=lambda text: call.buffered.append(text),
|
|
_disable_streaming=False, _stream_5xx_probe_ts=None,
|
|
_fire_stream_delta=lambda text: call.deltas.append(text),
|
|
)
|
|
call.buffered = []
|
|
call.deltas = []
|
|
call.first_delta_fired = {"done": True}
|
|
call.on_first_delta = None
|
|
call._stream_stale_timeout = 180.0
|
|
call.api_kwargs = api_kwargs
|
|
call.result = {"response": None, "error": None, "partial_tool_names": []}
|
|
call.deltas_were_sent = {"yes": deltas_sent}
|
|
call.provider_tool_in_flight = {"yes": False}
|
|
call._request_cancelled = {"value": False}
|
|
return call
|
|
|
|
|
|
class _StreamErr(Exception):
|
|
"""Stands in for the openai 5xx the stream path raises."""
|
|
|
|
def __init__(self, status):
|
|
super().__init__(f"Error code: {status} - something went wrong")
|
|
self.status_code = status
|
|
|
|
|
|
class _ProbeErr(Exception):
|
|
def __init__(self, status):
|
|
super().__init__(f"Error code: {status} - real validation message")
|
|
self.status_code = status
|
|
|
|
|
|
def _run_handle_stream_error(call, e):
|
|
return call._handle_stream_error(e, attempt=2, max_retries=2)
|
|
|
|
|
|
def test_stream_5xx_probe_success_delivers_response_without_latch(monkeypatch):
|
|
call = _make_call({"model": "m", "stream": True, "stream_options": {"x": 1}, "messages": []})
|
|
seen_kwargs = []
|
|
|
|
def fake_probe(agent, kwargs):
|
|
seen_kwargs.append((kwargs, call._stream_stale_timeout))
|
|
return SimpleNamespace(choices=[SimpleNamespace(message=SimpleNamespace(content="ok", reasoning_content=None))])
|
|
|
|
monkeypatch.setattr(h, "interruptible_api_call", fake_probe)
|
|
|
|
handled = not _run_handle_stream_error(call, _StreamErr(500))
|
|
|
|
assert handled
|
|
assert call.result["response"] is not None
|
|
assert call.result["error"] is None
|
|
probe_kwargs, stale_during_probe = seen_kwargs[0]
|
|
assert "stream" not in probe_kwargs and "stream_options" not in probe_kwargs
|
|
assert call.deltas == ["ok"]
|
|
# One-turn recovery: streaming is never latched off for the session.
|
|
assert call.agent._disable_streaming is False
|
|
# No chunks arrive during the probe: the stream monitor must not stale-kill it.
|
|
assert stale_during_probe == float("inf") and call._stream_stale_timeout == 180.0
|
|
assert call.buffered and "non-streaming retry succeeded" in call.buffered[0]
|
|
|
|
|
|
def test_stream_5xx_unmasked_by_probe_4xx(monkeypatch):
|
|
call = _make_call({"model": "m", "messages": []})
|
|
real = _ProbeErr(400)
|
|
|
|
def fake_probe(agent, kwargs):
|
|
raise real
|
|
|
|
monkeypatch.setattr(h, "interruptible_api_call", fake_probe)
|
|
|
|
handled = _run_handle_stream_error(call, _StreamErr(500))
|
|
|
|
assert not handled # loop stops, error propagates
|
|
assert call.result["error"] is real # the REAL validation error replaces the opaque 500
|
|
assert call.result["response"] is None
|