mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
106 lines
3.3 KiB
Python
106 lines
3.3 KiB
Python
"""Tests for IterationBudget thread safety.
|
|
|
|
The `used` property must acquire the lock before reading `_used` to prevent
|
|
data races with concurrent `consume()` / `refund()` calls.
|
|
"""
|
|
from concurrent.futures import ThreadPoolExecutor
|
|
|
|
|
|
|
|
def test_iteration_budget_used_is_thread_safe():
|
|
"""Iterating `used` while other threads consume/refund must not crash.
|
|
|
|
Before the fix, `used` returned `_used` directly without holding the lock,
|
|
so a concurrent `consume()` could observe a partially-updated value or
|
|
cause the C-level `list.append` to raise a ValueError ("list size changed").
|
|
"""
|
|
from agent.iteration_budget import IterationBudget
|
|
|
|
budget = IterationBudget(max_total=1000)
|
|
num_threads = 10
|
|
operations_per_thread = 200
|
|
|
|
errors = []
|
|
|
|
def worker(consume: bool):
|
|
try:
|
|
for _ in range(operations_per_thread):
|
|
if consume:
|
|
budget.consume()
|
|
else:
|
|
budget.refund()
|
|
# Also read `used` to exercise the property
|
|
_ = budget.used
|
|
except Exception as exc:
|
|
errors.append(exc)
|
|
|
|
with ThreadPoolExecutor(max_workers=num_threads * 2) as executor:
|
|
# Half the threads consume, half refund
|
|
futures = []
|
|
for i in range(num_threads):
|
|
consume = i < num_threads // 2
|
|
futures.append(executor.submit(worker, consume))
|
|
futures.append(executor.submit(worker, consume))
|
|
|
|
for f in futures:
|
|
f.result()
|
|
|
|
assert not errors, f"Thread safety violation: {errors}"
|
|
# Final value should be within expected bounds
|
|
assert 0 <= budget.used <= budget.max_total
|
|
|
|
|
|
def test_iteration_budget_consume_returns_false_when_exhausted():
|
|
"""consume() must return False once the budget is exhausted."""
|
|
from agent.iteration_budget import IterationBudget
|
|
|
|
budget = IterationBudget(max_total=3)
|
|
assert budget.consume() is True
|
|
assert budget.consume() is True
|
|
assert budget.consume() is True
|
|
assert budget.consume() is False
|
|
|
|
|
|
def test_iteration_budget_refund_restores_consume():
|
|
"""refund() after consume() must allow one more consume()."""
|
|
from agent.iteration_budget import IterationBudget
|
|
|
|
budget = IterationBudget(max_total=2)
|
|
assert budget.consume() is True
|
|
assert budget.consume() is True
|
|
assert budget.consume() is False # exhausted
|
|
budget.refund()
|
|
assert budget.consume() is True
|
|
|
|
|
|
def test_iteration_budget_used_reflects_consume_and_refund():
|
|
"""used property must accurately reflect consume() and refund() calls."""
|
|
from agent.iteration_budget import IterationBudget
|
|
|
|
budget = IterationBudget(max_total=10)
|
|
|
|
assert budget.used == 0
|
|
budget.consume()
|
|
assert budget.used == 1
|
|
budget.consume()
|
|
assert budget.used == 2
|
|
budget.refund()
|
|
assert budget.used == 1
|
|
budget.refund()
|
|
assert budget.used == 0
|
|
|
|
|
|
def test_iteration_budget_remaining():
|
|
"""remaining property must equal max_total - used."""
|
|
from agent.iteration_budget import IterationBudget
|
|
|
|
budget = IterationBudget(max_total=5)
|
|
|
|
assert budget.remaining == 5
|
|
budget.consume()
|
|
assert budget.remaining == 4
|
|
budget.consume()
|
|
budget.consume()
|
|
assert budget.remaining == 2
|
|
budget.refund()
|
|
assert budget.remaining == 3
|