mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 04:11:35 +00:00
`scripts/run_tests.sh tests/<dir>/` is how a change gets its regression
coverage run, so a test filed under the wrong directory is a test nobody
runs when that code changes. Two kinds of drift had accumulated.
Parallel directories for one source package, folded into the mirror:
tests/acp -> tests/acp_adapter (its __init__/conftest move with it)
tests/cli -> tests/hermes_cli (prompt_toolkit fixture merged into
hermes_cli/conftest.py)
tests/run_agent -> tests/agent (backoff fixture becomes
agent/conftest.py)
tests/relay -> tests/gateway/relay
tests/state -> tests/hermes_state
246 loose files at tests/ root, routed by the package they import/patch:
hermes_cli, hermes_state, agent, gateway, tools, plugins, tui_gateway, cron.
Installer and desktop-update script tests go to tests/scripts/{install,
desktop_update}/. 43 tests of root-level modules (batch_runner, utils,
hermes_constants, packaging) stay at the root.
Filenames drop their issue numbers (95 files: test_89315_x.py -> test_x.py);
the number stays in the module docstring where it has context.
Collisions: test_cli_skin_integration.py existed in both tests/ and tests/cli
with different subsets — merged into one (10 tests, all kept);
run_agent/test_pre_compress_memory_context.py -> agent/..._handoff.py;
tests/test_account_usage.py -> agent/test_account_usage_fetch.py;
tests/test_web_server.py -> hermes_cli/test_web_server_ws_ping.py.
Deleted: test_minisweagent_path.py (empty since PR #2804),
test_model_picker_scroll.py (tested a private copy of the logic, imported
nothing), test_process_loop_event_loop_warning.py (asserted asyncio behaviour,
imported nothing from Hermes).
Repo-root path arithmetic (Path(__file__).parents[N], dirname chains) is
bumped for the 202 files that changed depth and verified by evaluating every
such expression against the new location. classify_changes' desktop-updater
lane prefix, tests-os.yml's ignore glob and every in-tree path comment follow
the moves. tests/test_tests_tree_layout.py keeps the tree from drifting back.
80 lines
2.6 KiB
Python
80 lines
2.6 KiB
Python
"""Tests for ACP session-provenance derivation (issue #33617).
|
|
|
|
Exercises acp_adapter.provenance against a real SessionDB — no mocks — covering
|
|
the acceptance-criteria matrix: root session, compression-split continuation,
|
|
multi-depth chains, rotation flagging, and graceful handling of unknown ids.
|
|
"""
|
|
|
|
import time
|
|
|
|
import pytest
|
|
|
|
from acp_adapter.provenance import build_session_provenance, session_provenance_meta
|
|
from hermes_state import SessionDB
|
|
|
|
|
|
@pytest.fixture()
|
|
def db(tmp_path):
|
|
d = SessionDB(db_path=tmp_path / "state.db")
|
|
yield d
|
|
|
|
|
|
def _mk(db, sid, parent=None):
|
|
db.create_session(session_id=sid, source="acp", parent_session_id=parent)
|
|
|
|
|
|
def test_root_session_no_compression(db):
|
|
_mk(db, "root1")
|
|
prov = build_session_provenance(db, "acp-1", "root1")
|
|
assert prov["acpSessionId"] == "acp-1"
|
|
assert prov["currentHermesSessionId"] == "root1"
|
|
assert prov["rootHermesSessionId"] == "root1"
|
|
assert prov["parentHermesSessionId"] is None
|
|
assert prov["sessionKind"] == "root"
|
|
assert prov["compressionDepth"] == 0
|
|
assert "reason" not in prov # no rotation signalled
|
|
|
|
|
|
def test_compression_split_continuation(db):
|
|
# Parent ended with compression, child created afterwards.
|
|
_mk(db, "old")
|
|
db.end_session("old", "compression")
|
|
time.sleep(0.001)
|
|
_mk(db, "new", parent="old")
|
|
|
|
prov = build_session_provenance(
|
|
db, "acp-1", "new", previous_hermes_session_id="old"
|
|
)
|
|
assert prov["sessionKind"] == "continuation"
|
|
assert prov["parentHermesSessionId"] == "old"
|
|
assert prov["rootHermesSessionId"] == "old"
|
|
assert prov["compressionDepth"] == 1
|
|
assert prov["previousHermesSessionId"] == "old"
|
|
# Head rotated this turn → reason/creatorKind flagged.
|
|
assert prov["reason"] == "compression"
|
|
assert prov["creatorKind"] == "compression"
|
|
|
|
|
|
|
|
|
|
def test_non_compression_parent_is_root_not_continuation(db):
|
|
# A child with a parent that did NOT end via compression (e.g. delegate
|
|
# or branch child) must not be reported as a compression continuation.
|
|
_mk(db, "p")
|
|
_mk(db, "c", parent="p") # parent still live, no end_reason
|
|
prov = build_session_provenance(db, "acp-1", "c")
|
|
assert prov["sessionKind"] == "root"
|
|
assert prov["compressionDepth"] == 0
|
|
assert prov["rootHermesSessionId"] == "p" # lineage root still walked
|
|
|
|
|
|
|
|
|
|
|
|
|
|
def test_meta_wrapper_shape(db):
|
|
_mk(db, "root1")
|
|
meta = session_provenance_meta(db, "acp-1", "root1")
|
|
assert set(meta.keys()) == {"hermes"}
|
|
assert "sessionProvenance" in meta["hermes"]
|
|
assert meta["hermes"]["sessionProvenance"]["currentHermesSessionId"] == "root1"
|