mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 03:54:08 +00:00
`_directory_links()` walks every parent up to `/`, and `initialize_home()` skipped `_secure_dir()` whenever that list was non-empty, so any symlinked ancestor disabled home hardening and left `~/.hermes` plus its `cron`/`sessions`/`logs`/`memories` subdirectories at the mkdir default `0o755`. macOS makes that the normal case: the default temp root is `/var/folders/...` and `/var` is a symlink to `/private/var` (as are `/tmp` and `/etc`), so any home reached through those prefixes was never secured. Reported on macOS arm64 as `493 != 448` (0o755 vs 0o700) in tests/cron/test_file_permissions.py; the same numbers reproduce on Linux by aliasing a parent directory. Only links at or below the home boundary are operator-owned. The home itself, or a link inside it, still transfers permission ownership to the operator — behaviour pinned by test_initialization_preserves_external_directory_modes and unchanged here. Availability diagnosis is untouched: a link above the home whose target is missing is still refused instead of being materialized on the underlying filesystem.
90 lines
4 KiB
Python
90 lines
4 KiB
Python
"""Directory initialization and storage diagnostics for the active Hermes home."""
|
|
|
|
import os
|
|
from pathlib import Path
|
|
|
|
|
|
class HomeInitializationError(RuntimeError):
|
|
"""The home skeleton is unavailable, not an invalid YAML document."""
|
|
|
|
|
|
def _directory_links(path: Path) -> list[Path]:
|
|
return [part for part in (*reversed(path.parents), path) if part.is_symlink()]
|
|
|
|
|
|
def _operator_owned_links(links: list[Path], home: Path) -> list[Path]:
|
|
"""Keep only the links that make the operator the owner of the home's permissions.
|
|
|
|
That boundary is the home itself and anything under it. A link *above* the home
|
|
(macOS ``/tmp`` -> ``/private/tmp``, ``/var`` -> ``/private/var``, or any aliased parent
|
|
the user happens to live in) says nothing about who owns :data:`home`, and treating it as
|
|
an operator-owned link left a fresh home and its ``cron``/``sessions``/``logs``/``memories``
|
|
subdirectories at the default ``0o755`` instead of ``0o700``.
|
|
"""
|
|
return [link for link in links if link == home or home in link.parents]
|
|
|
|
|
|
def _ensure_directory(path: Path, *, create: bool, secure: bool, home: Path) -> None:
|
|
from hermes_cli.config import _secure_dir
|
|
|
|
detail = ""
|
|
try:
|
|
links = _directory_links(path)
|
|
detail = "; ".join(f"{link} -> {link.readlink()}" for link in links)
|
|
# Never materialize a missing mount's target on the underlying disk.
|
|
for link in links:
|
|
if not link.is_dir():
|
|
raise FileNotFoundError(f"Directory link is unavailable: {link}")
|
|
if create:
|
|
path.mkdir(parents=True, exist_ok=True)
|
|
elif not path.is_dir():
|
|
raise FileNotFoundError(f"Required directory does not exist: {path}")
|
|
# The operator owns permissions beyond a link, including logs/curator.
|
|
if secure and not _operator_owned_links(links, home):
|
|
_secure_dir(path)
|
|
except OSError as exc:
|
|
raise HomeInitializationError(
|
|
f"Cannot initialize Hermes directory {path}: {exc}. "
|
|
+ (f"Directory links: {detail}. " if detail else "")
|
|
+ "Check the directory/link target, mount availability and access permissions; "
|
|
"restore the mount or repair the link before retrying. "
|
|
"Hermes has not replaced the link or created its missing target."
|
|
) from exc
|
|
|
|
|
|
def initialize_home(home: Path, subdirs: tuple[str, ...], ensured: set[str]) -> None:
|
|
from hermes_cli.config import _ensure_default_soul_md, is_managed
|
|
|
|
managed = is_managed()
|
|
old_umask = os.umask(0o007) if managed else None
|
|
try:
|
|
_ensure_directory(home, create=not managed, secure=not managed, home=home)
|
|
required = ("cron", "sessions", "logs", "memories") if managed else subdirs
|
|
for subdir in required:
|
|
_ensure_directory(home / subdir, create=not managed, secure=not managed, home=home)
|
|
if managed:
|
|
_ensure_directory(home / "logs" / "curator", create=True, secure=False, home=home)
|
|
try:
|
|
_ensure_default_soul_md(home)
|
|
except OSError as exc:
|
|
raise HomeInitializationError(
|
|
f"Cannot initialize Hermes home {home}: {exc}. "
|
|
"Check storage availability and access permissions."
|
|
) from exc
|
|
finally:
|
|
if old_umask is not None:
|
|
os.umask(old_umask)
|
|
# Plugin discovery rebinds the resolved home. Do not repeat chmod through
|
|
# that spelling after the operator-owned symlink boundary has been lost.
|
|
ensured.update((str(home), str(home.resolve())))
|
|
|
|
|
|
def config_load_issue(exc: Exception):
|
|
from hermes_cli.config import ConfigIssue
|
|
|
|
if isinstance(exc, (HomeInitializationError, OSError)):
|
|
return ConfigIssue(
|
|
"error", f"Hermes storage is unavailable: {exc}",
|
|
"Check the reported path, link target, mount and permissions; keep config.yaml unchanged.",
|
|
)
|
|
return ConfigIssue("error", "Could not load config.yaml", "Run 'hermes setup' to create a valid config")
|