hermes-agent/apps/desktop/e2e
Repository files (latest commit first)
Filename Latest commit message Latest commit date
Siddharth Balyan 5eea87882a
Clarify: one question shape and one result shape on every surface (skip, cancel, timeout and undelivered are told apart) (#127760)
* refactor(desktop): split clarify-tool.tsx into a clarify/ folder

Pure moves, no behaviour change. Parsing, the question-card core
(shell, choice rows, question block), the delivery watchdog, and each
pending/settled card get their own file so the core can be reused.

* feat(clarify): one questions[] shape with per-question status and one outcome

The clarify tool now takes only questions=[{question, choices?, multi_select?}].
A wrong shape is a tool error that names the right one, so a model that
sends the old top-level question/choices corrects itself on the next call.

Every result has the same shape on every surface: each response carries
status (answered, skipped, unanswered) with user_response null unless
answered, and the result carries one outcome (submitted, cancelled,
timed_out, undelivered) plus an optional surface-written notice. The
timeout and cancel sentences that used to pose as the user's answer are
gone, and the compressor reads status instead of matching their prefixes.

The callback contract is callback(questions) -> {answers, outcome, notice?}
(None = skipped, missing qid = unanswered). tui_gateway settles a batch the
same way for the last lock, a cancel, an interrupt and the deadline, and
clarify.lock keeps a null answer as a skip. A multi-select answer that is
not a JSON array counts as one typed ("Other") answer. The tool-row preview
reads the first question.

* feat(clarify): every surface asks through the one question card

CLI: the batch panel is the only panel; Enter on an empty field skips a
question, Ctrl+C cancels and keeps the locked answers, the deadline returns
timed_out. -q and -z return undelivered with a no-user notice.

Ink TUI: the single-question prompt is gone; the card supports multi-select
(Space or a digit toggles, Enter locks, typed Other text joins the picks),
an empty submit skips, Esc cancels, and "Batch" names are dropped.

Desktop: the single-question card is deleted and its keyboard handling moved
into the one card (arrows, letters and digits, auto-advance, Enter picks then
confirms). Confirm enables at one answer; blank questions lock null; Skip and
a composer message cancel; the settled card shows No answer for unanswered
questions. The bots room card follows the same contract.

Messaging: one card per question with a "Reply skip to skip" line in every
locale; timeouts and delivery failures map to timed_out and undelivered.

* fix(clarify): cancelled for a released messaging card, labels win over the skip word

A prose reply to a messaging choice card, /new and session end released
the wait with "", which read as timed_out. They now resolve with a
CANCELLED marker and the tool gets outcome cancelled.

A typed reply that matches a choice label ("Skip") now resolves to that
choice; the skip word applies only when no choice matches.

The bots room card sends the picked labels as they are; the tool already
strips the recommendation label. Unused OUTCOMES and a new docstring and
comment are removed.

* fix(tui): re-editing a multi-select answer keeps its picks

The Ink card stored a multi-select answer as display text ("A, B"), so
revisiting the question put the whole string into Other and re-locked it
as one item. The answers map now keeps the raw JSON array, the card
restores the picks on revisit, and only the display lines format it.

Comments that earlier edits reworded are restored to their original
words, minus the phrases the change made wrong. The compute-host clarify
lock accepts None for a skipped question.

* test(clarify): align three checks with the one-answer confirm and the regenerated keys

The desktop Cmd+Enter test now expects a send with one answer (the blank
question locks null), the compressor test expects the single-answer summary
the code gives, and locales/_keys.desktop.json is regenerated for the
removed and added clarify strings.

* test(tui): the one-question card header is singular
2026-09-29 18:33:44 +05:30
..
core Clarify: one question shape and one result shape on every surface (skip, cancel, timeout and undelivered are told apart) (#127760) 2026-09-29 18:33:44 +05:30
update fix(desktop): desktop.log stamps lines in local time, like the Python logs 2026-09-28 19:02:20 +05:30
at-rest-connection-token.spec.ts test: purge low-value tests, lane js01 (202 removed) 2026-09-23 03:15:26 -07:00
batch-clarify.spec.ts Clarify: one question shape and one result shape on every surface (skip, cancel, timeout and undelivered are told apart) (#127760) 2026-09-29 18:33:44 +05:30
boot-failure.spec.ts fix: tool_calls double-encoding on import (#68856) 2026-07-21 18:53:05 +00:00
boot.spec.ts test: purge low-value tests, lane js01 (202 removed) 2026-09-23 03:15:26 -07:00
bot-screen-stale-status-reply.spec.ts Merge remote-tracking branch 'origin/main' into ethie/pm-clean 2026-09-23 07:36:31 -04:00
chat.spec.ts Merge remote-tracking branch 'origin/main' into ethie/pm-clean 2026-09-23 07:02:44 -04:00
completed-reply-refresh.spec.ts test(desktop): carry completed-reply native regression 2026-09-22 12:54:27 +05:30
correction-session-switch.spec.ts Merge upstream main (afc3d9d34c): refresh before review 2026-09-02 17:53:49 +02:00
electron-binary.ts fix(desktop): resolve the e2e Electron binary per platform and layout 2026-08-31 11:56:42 -07:00
electron-binary.unit.test.ts test: purge low-value tests, lane js01 (202 removed) 2026-09-23 03:15:26 -07:00
fix-electron-tracing.ts fix(desktop): address review — overlay a11y, e2e typecheck, nits 2026-07-20 14:37:39 -04:00
fixtures.ts docs(desktop): describe what --ignore-existing skips 2026-09-26 17:15:10 -05:00
fleet-profile-rail.spec.ts Merge remote-tracking branch 'origin/main' into ethie/pm-clean 2026-09-23 07:02:44 -04:00
group-approval-click-submits.spec.ts test(desktop-e2e): restore the group approval-click and member-failure specs 2026-09-23 16:58:39 -07:00
group-member-backend-failure.spec.ts fix(desktop): a member that fails after pre-tool text is reported, not posted as its reply 2026-09-23 16:58:39 -07:00
group-turn-integrity.spec.ts chore(evals,desktop): drop literal /tmp from eval harnesses and desktop scripts 2026-09-19 10:44:26 -07:00
hidden-history-messages.spec.ts feat(ci): require desktop chat after bundle and install builds 2026-09-13 19:57:38 -04:00
image-attachment-resume.spec.ts feat(ci): require desktop chat after bundle and install builds 2026-09-13 19:57:38 -04:00
interim-messages.spec.ts Merge upstream main (afc3d9d34c): refresh before review 2026-09-02 17:53:49 +02:00
large-session-resume.spec.ts Merge remote-tracking branch 'origin/main' into ethie/pm-clean 2026-09-23 07:02:44 -04:00
new-bot-config-on-disk.spec.ts fix(cli): inherit the launch profile's custom provider gateway with its model 2026-09-16 17:02:38 -07:00
onboarding.spec.ts test: purge low-value tests, lane js01 (202 removed) 2026-09-23 03:15:26 -07:00
peer-device-reset.spec.ts Merge remote-tracking branch 'origin/main' into ethie/pm-clean 2026-09-22 10:58:18 -04:00
profile-soul-missing.spec.ts fix(desktop): explain missing profile SOUL.md files 2026-09-27 06:54:56 -05:00
provider-setup-owner.spec.ts fix(desktop): retain provider setup connection and profile ownership 2026-09-23 22:41:26 -07:00
queue-turn-boundary.spec.ts refactor(desktop-e2e): one mock inference server in tests-js/scripts 2026-08-12 10:40:57 -04:00
real-session-builder.ts test(desktop): cover attached-image resume end to end 2026-07-24 21:20:52 -05:00
remote-oauth-recovery.spec.ts fix(desktop): validate remote OAuth through ticket minting 2026-09-11 07:14:55 -05:00
run-tmp.ts fix(desktop): test runs stop leaking temp dirs into TMPDIR 2026-09-27 23:10:22 -07:00
session-compression-and-queue-stop.spec.ts Merge upstream main (afc3d9d34c): refresh before review 2026-09-02 17:53:49 +02:00
sidebar-states.spec.ts Merge upstream main (afc3d9d34c): refresh before review 2026-09-02 17:53:49 +02:00
submit-drift.spec.ts test(desktop): cover submit drift through e2e (#69599) 2026-07-22 16:44:54 -04:00
test.ts fix: tool_calls double-encoding on import (#68856) 2026-07-21 18:53:05 +00:00
unread-dot-restart.spec.ts Merge upstream main (b81383ec21) into the install-e2e suite branch 2026-09-01 19:33:13 +02:00
visual-snapshot.ts fix(desktop): link artifacts in E2E summary + upload all screenshots 2026-07-20 11:44:41 -04:00
warm-resume-jitter.spec.ts Merge remote-tracking branch 'origin/main' into ethie/pm-clean 2026-09-23 07:02:44 -04:00
window-input.unit.test.ts fix(install-e2e): verify input readiness and tolerate transient windows 2026-09-06 12:55:05 -04:00